Skip to content

[Profiler] Try fixing crashes in etw events based profiler#8673

Merged
gleocadie merged 1 commit into
masterfrom
gleocadie/try-fixing-crashes-in-etw-events-based-profiler
Jun 4, 2026
Merged

[Profiler] Try fixing crashes in etw events based profiler#8673
gleocadie merged 1 commit into
masterfrom
gleocadie/try-fixing-crashes-in-etw-events-based-profiler

Conversation

@gleocadie

@gleocadie gleocadie commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

This crash was detected by crashtracker:

0x7FFD1B5F14A6 IpcServer::StartCallback(_TP_CALLBACK_INSTANCE*, void*) (c:\mnt\profiler\src\ProfilerEngine\Datadog.Profiler.Native.Windows\ETW\IpcServer.cpp:195)
0x7FFD36C87243 TppSimplepExecuteCallback
0x7FFD36C8BB36 TppWorkerThread
0x7EB811E7 C:\Windows\System32\cyinjct.dll!<unknown>+11e7
0x7FFD35564DE0 BaseThreadInitThunk
0x7FFD36CFEDAB RtlUserThreadStart

Reason for change

In any case, the pThis which represents the IpcServer instance is leaked so it's not destroyed at any point. The only thing remaining, the _pLogger could be nullptr (shutdown, the smart pointer was destroyed) due to a race. This crash feels like an application start quickly followed by shutdown.

One thing we can do, use std::shared_ptr instead.

Implementation details

Use std::shared_ptr to share the logger amongst components.

Test coverage

Other details

@gleocadie
gleocadie requested a review from a team as a code owner May 21, 2026 13:06
@github-actions github-actions Bot added the area:profiler Issues related to the continous-profiler label May 21, 2026
@gleocadie
gleocadie force-pushed the gleocadie/try-fixing-crashes-in-etw-events-based-profiler branch from 4d7d559 to 68ed0c4 Compare May 21, 2026 13:10
@pr-commenter

pr-commenter Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-04 08:50:30

Comparing candidate commit d8e7605 in PR branch gleocadie/try-fixing-crashes-in-etw-events-based-profiler with baseline commit e7dd8f5 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5001.359op/s; -4746.189op/s] or [-5.709%; -5.418%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-7121.610op/s; -6701.832op/s] or [-8.444%; -7.946%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+305.928ms; +313.271ms] or [+151.812%; +155.456%]
  • 🟥 throughput [-44.476op/s; -40.464op/s] or [-8.002%; -7.280%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+379.598ms; +383.339ms] or [+299.905%; +302.861%]
  • 🟩 throughput [+82.252op/s; +89.010op/s] or [+10.845%; +11.736%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+394.755ms; +398.063ms] or [+349.343%; +352.271%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-15.397ms; -11.123ms] or [-7.191%; -5.195%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-269003.272op/s; -265769.955op/s] or [-27.467%; -27.136%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.475ms; -21.618ms] or [-11.807%; -9.641%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-155316.453op/s; -139186.602op/s] or [-22.316%; -19.998%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+9924.414op/s; +12831.879op/s] or [+6.315%; +8.165%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+9510.363op/s; +12160.708op/s] or [+7.576%; +9.688%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+470112.835op/s; +489738.136op/s] or [+15.676%; +16.330%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.870ms; -14.336ms] or [-8.698%; -6.608%]
  • 🟩 throughput [+177171.985op/s; +233463.157op/s] or [+7.032%; +9.267%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+300.127ms; +300.873ms] or [+149.963%; +150.336%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.960ms; +303.172ms] or [+151.271%; +152.890%]
  • 🟩 throughput [+693.680op/s; +902.974op/s] or [+5.306%; +6.906%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.765ms; +302.190ms] or [+150.998%; +152.220%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.464ms; +297.476ms] or [+145.611%; +146.109%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+297.493ms; +299.395ms] or [+145.433%; +146.363%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.048ms; +303.058ms] or [+150.464%; +151.468%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+26.024µs; +49.745µs] or [+8.308%; +15.881%]
  • 🟥 throughput [-458.919op/s; -259.412op/s] or [-14.306%; -8.087%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.782ms; +300.495ms] or [+149.622%; +149.978%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+408.391ms; +415.738ms] or [+443.734%; +451.716%]
  • 🟩 throughput [+774.492op/s; +988.420op/s] or [+6.364%; +8.122%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+298.204ms; +354.508ms] or [+226.423%; +269.174%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+298.039ms; +345.145ms] or [+137.035%; +158.694%]
  • 🟥 throughput [-527.318op/s; -483.195op/s] or [-47.780%; -43.782%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+205.433ms; +338.713ms] or [+87.547%; +144.345%]
  • 🟥 throughput [-675.842op/s; -592.211op/s] or [-45.079%; -39.501%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+336.354ms; +345.804ms] or [+201.179%; +206.831%]
  • 🟥 throughput [-416.279op/s; -376.330op/s] or [-28.985%; -26.203%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-143.680µs; -117.438µs] or [-7.278%; -5.949%]
  • 🟩 throughput [+32.429op/s; +40.000op/s] or [+6.402%; +7.896%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.118ms; +303.677ms] or [+152.141%; +152.926%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+299.556ms; +318.332ms] or [+150.108%; +159.517%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+298.319ms; +301.451ms] or [+149.863%; +151.436%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+305.772ms; +308.556ms] or [+153.548%; +154.947%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+296.615ms; +313.969ms] or [+146.663%; +155.244%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+301.022ms; +305.335ms] or [+152.571%; +154.757%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.827ms; +302.054ms] or [+150.988%; +151.604%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+296.445ms; +309.360ms] or [+147.751%; +154.187%]
  • 🟩 throughput [+49338.656op/s; +62306.270op/s] or [+9.797%; +12.372%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.948ms; +304.085ms] or [+149.719%; +151.280%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.124ms; -12.452ms] or [-7.498%; -5.790%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+26.367µs; +73.699µs] or [+6.513%; +18.204%]
  • 🟥 throughput [-371.781op/s; -147.008op/s] or [-14.961%; -5.916%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-24.148KB; -24.126KB] or [-8.809%; -8.801%]
  • unstable execution_time [-26.163µs; +30.790µs] or [-5.171%; +6.085%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-51.114µs; +11.605µs] or [-8.858%; +2.011%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+9.207µs; +14.348µs] or [+21.763%; +33.913%]
  • 🟥 throughput [-5999.067op/s; -4032.111op/s] or [-25.254%; -16.974%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.993µs; -6.033µs] or [-21.709%; -9.360%]
  • unstable throughput [+1519.027op/s; +3257.777op/s] or [+9.320%; +19.988%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.383ms; +302.771ms] or [+152.336%; +153.037%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.798ms; +306.112ms] or [+154.632%; +155.810%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+298.951ms; +301.153ms] or [+149.662%; +150.764%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+31062.556op/s; +34789.942op/s] or [+5.879%; +6.585%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+297.868ms; +300.033ms] or [+148.460%; +149.540%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+299.085ms; +301.007ms] or [+150.186%; +151.151%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.480ms; +304.692ms] or [+153.399%; +154.520%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.201ms; +300.065ms] or [+149.243%; +149.674%]
  • 🟩 throughput [+61083804.988op/s; +61419686.828op/s] or [+44.485%; +44.730%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+282.786ms; +357.034ms] or [+351.695%; +444.035%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.580ms; +300.708ms] or [+149.424%; +149.986%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+73763.161op/s; +90429.472op/s] or [+6.887%; +8.443%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+54798.595op/s; +73759.729op/s] or [+6.343%; +8.538%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+74804.946op/s; +105781.771op/s] or [+5.790%; +8.188%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+62352.253op/s; +71831.062op/s] or [+6.193%; +7.134%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+47990.607op/s; +52926.720op/s] or [+8.714%; +9.611%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+23656.185op/s; +33525.753op/s] or [+5.295%; +7.504%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+85501.827op/s; +104383.886op/s] or [+9.553%; +11.662%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8673) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.96 ± (74.10 - 74.62) ms73.90 ± (73.95 - 74.64) ms-0.1%✅
.NET Framework 4.8 - Bailout
duration77.70 ± (77.53 - 77.90) ms77.30 ± (77.17 - 77.60) ms-0.5%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1100.73 ± (1101.31 - 1108.49) ms1110.16 ± (1106.72 - 1113.47) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.76 ± (22.70 - 22.81) ms22.47 ± (22.43 - 22.51) ms-1.3%✅
process.time_to_main_ms85.02 ± (84.76 - 85.28) ms84.28 ± (84.06 - 84.50) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.90 ± (10.89 - 10.90) MB10.91 ± (10.90 - 10.91) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.47 ± (22.43 - 22.51) ms22.36 ± (22.31 - 22.41) ms-0.5%✅
process.time_to_main_ms85.45 ± (85.19 - 85.71) ms86.00 ± (85.76 - 86.23) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.94 ± (10.94 - 10.94) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms216.17 ± (215.28 - 217.06) ms212.89 ± (211.97 - 213.81) ms-1.5%✅
process.time_to_main_ms546.05 ± (544.48 - 547.63) ms539.66 ± (538.23 - 541.10) ms-1.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.31 ± (48.28 - 48.35) MB48.31 ± (48.27 - 48.35) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.26 ± (21.22 - 21.29) ms21.63 ± (21.57 - 21.69) ms+1.8%✅⬆️
process.time_to_main_ms72.95 ± (72.77 - 73.13) ms76.22 ± (75.96 - 76.47) ms+4.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.61) MB10.63 ± (10.63 - 10.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.41 ± (21.35 - 21.46) ms21.24 ± (21.20 - 21.28) ms-0.8%✅
process.time_to_main_ms75.85 ± (75.56 - 76.15) ms75.48 ± (75.26 - 75.70) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.72 ± (10.72 - 10.72) MB10.75 ± (10.75 - 10.75) MB+0.3%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms368.64 ± (366.37 - 370.92) ms367.29 ± (365.19 - 369.38) ms-0.4%✅
process.time_to_main_ms546.67 ± (545.45 - 547.89) ms549.13 ± (547.83 - 550.44) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.72 ± (49.69 - 49.74) MB49.81 ± (49.79 - 49.83) MB+0.2%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.31 ± (19.27 - 19.35) ms19.28 ± (19.24 - 19.32) ms-0.1%✅
process.time_to_main_ms72.21 ± (72.04 - 72.39) ms72.68 ± (72.48 - 72.88) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.67 ± (7.67 - 7.68) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.24 ± (19.19 - 19.29) ms19.58 ± (19.53 - 19.63) ms+1.8%✅⬆️
process.time_to_main_ms72.87 ± (72.71 - 73.02) ms75.40 ± (75.15 - 75.64) ms+3.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.72 ± (7.72 - 7.73) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms293.90 ± (291.77 - 296.04) ms295.12 ± (293.08 - 297.15) ms+0.4%✅⬆️
process.time_to_main_ms497.02 ± (495.91 - 498.13) ms497.85 ± (496.67 - 499.04) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.88 ± (36.85 - 36.91) MB36.90 ± (36.87 - 36.92) MB+0.0%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration198.99 ± (198.52 - 199.53) ms197.91 ± (197.54 - 198.49) ms-0.5%✅
.NET Framework 4.8 - Bailout
duration203.69 ± (203.26 - 204.18) ms201.49 ± (201.40 - 202.38) ms-1.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1198.41 ± (1197.95 - 1204.10) ms1195.14 ± (1195.29 - 1202.54) ms-0.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms193.88 ± (193.43 - 194.34) ms192.46 ± (191.98 - 192.94) ms-0.7%✅
process.time_to_main_ms84.64 ± (84.35 - 84.93) ms84.20 ± (83.92 - 84.49) ms-0.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.05 ± (16.03 - 16.08) MB16.06 ± (16.03 - 16.08) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.3%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms193.81 ± (193.39 - 194.22) ms191.55 ± (191.09 - 192.01) ms-1.2%✅
process.time_to_main_ms86.05 ± (85.82 - 86.27) ms84.91 ± (84.66 - 85.16) ms-1.3%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.10 - 16.15) MB16.13 ± (16.10 - 16.15) MB+0.0%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.0%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms387.73 ± (386.53 - 388.94) ms381.77 ± (380.73 - 382.81) ms-1.5%✅
process.time_to_main_ms537.35 ± (536.03 - 538.67) ms530.71 ± (529.55 - 531.86) ms-1.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.55 ± (57.35 - 57.76) MB57.09 ± (57.01 - 57.17) MB-0.8%✅
runtime.dotnet.threads.count30 ± (30 - 30)29 ± (29 - 30)-0.4%✅
.NET 6 - Baseline
process.internal_duration_ms197.95 ± (197.44 - 198.46) ms196.05 ± (195.62 - 196.49) ms-1.0%✅
process.time_to_main_ms73.47 ± (73.20 - 73.74) ms72.01 ± (71.75 - 72.26) ms-2.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.36 ± (16.33 - 16.39) MB16.39 ± (16.35 - 16.42) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.8%✅
.NET 6 - Bailout
process.internal_duration_ms196.94 ± (196.64 - 197.25) ms194.79 ± (194.43 - 195.15) ms-1.1%✅
process.time_to_main_ms74.18 ± (74.03 - 74.33) ms72.72 ± (72.52 - 72.92) ms-2.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.41 ± (16.38 - 16.44) MB16.44 ± (16.39 - 16.50) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-1.8%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms585.51 ± (583.00 - 588.02) ms585.85 ± (583.02 - 588.68) ms+0.1%✅⬆️
process.time_to_main_ms543.58 ± (542.62 - 544.54) ms536.31 ± (535.21 - 537.41) ms-1.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.18 ± (61.09 - 61.27) MB61.22 ± (61.13 - 61.31) MB+0.1%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.5%✅
.NET 8 - Baseline
process.internal_duration_ms194.85 ± (194.41 - 195.30) ms191.00 ± (190.54 - 191.46) ms-2.0%✅
process.time_to_main_ms71.95 ± (71.70 - 72.21) ms70.37 ± (70.15 - 70.59) ms-2.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.67 ± (11.65 - 11.70) MB11.75 ± (11.73 - 11.77) MB+0.7%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms193.47 ± (193.02 - 193.93) ms190.43 ± (190.01 - 190.86) ms-1.6%✅
process.time_to_main_ms72.69 ± (72.49 - 72.89) ms71.43 ± (71.22 - 71.64) ms-1.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.75 ± (11.73 - 11.78) MB11.75 ± (11.73 - 11.78) MB+0.0%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.3%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms513.60 ± (510.91 - 516.29) ms507.82 ± (505.22 - 510.42) ms-1.1%✅
process.time_to_main_ms492.23 ± (491.41 - 493.05) ms488.39 ± (487.56 - 489.22) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.61 ± (50.57 - 50.64) MB50.61 ± (50.58 - 50.65) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.7%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (74ms)  : 69, 80
    master - mean (74ms)  : 71, 78

    section Bailout
    This PR (8673) - mean (77ms)  : 74, 80
    master - mean (78ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (1,110ms)  : 1061, 1159
    master - mean (1,105ms)  : 1051, 1158
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (114ms)  : 110, 118
    master - mean (115ms)  : 109, 121

    section Bailout
    This PR (8673) - mean (115ms)  : 110, 120
    master - mean (115ms)  : 112, 118

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (789ms)  : 767, 810
    master - mean (798ms)  : 772, 824
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (104ms)  : 99, 110
    master - mean (101ms)  : 96, 105

    section Bailout
    This PR (8673) - mean (103ms)  : 99, 108
    master - mean (104ms)  : 98, 109

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (947ms)  : 905, 990
    master - mean (944ms)  : 904, 985
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (100ms)  : 96, 103
    master - mean (99ms)  : 95, 103

    section Bailout
    This PR (8673) - mean (103ms)  : 98, 108
    master - mean (100ms)  : 98, 102

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (825ms)  : 795, 854
    master - mean (821ms)  : 780, 862
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (198ms)  : 192, 204
    master - mean (199ms)  : 192, 206

    section Bailout
    This PR (8673) - mean (202ms)  : 197, 207
    master - mean (204ms)  : 199, 208

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (1,199ms)  : 1144, 1254
    master - mean (1,201ms)  : 1156, 1246
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (286ms)  : 279, 292
    master - mean (288ms)  : 281, 294

    section Bailout
    This PR (8673) - mean (285ms)  : 279, 291
    master - mean (289ms)  : 283, 294

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (954ms)  : 935, 973
    master - mean (965ms)  : 947, 982
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (277ms)  : 270, 283
    master - mean (281ms)  : 275, 287

    section Bailout
    This PR (8673) - mean (275ms)  : 271, 280
    master - mean (280ms)  : 276, 283

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (1,152ms)  : 1112, 1191
    master - mean (1,166ms)  : 1122, 1210
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8673) - mean (271ms)  : 264, 279
    master - mean (277ms)  : 271, 283

    section Bailout
    This PR (8673) - mean (272ms)  : 267, 277
    master - mean (277ms)  : 271, 282

    section CallTarget+Inlining+NGEN
    This PR (8673) - mean (1,028ms)  : 991, 1064
    master - mean (1,038ms)  : 1004, 1072
Loading

chrisnas
chrisnas approved these changes May 21, 2026
View reviewed changes

@chrisnas chrisnas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleocadie
gleocadie force-pushed the gleocadie/try-fixing-crashes-in-etw-events-based-profiler branch from 68ed0c4 to d8e7605 Compare June 4, 2026 07:57
@gleocadie
gleocadie merged commit 7cb3bc8 into master Jun 4, 2026
147 checks passed
@gleocadie
gleocadie deleted the gleocadie/try-fixing-crashes-in-etw-events-based-profiler branch June 4, 2026 12:43
@github-actions github-actions Bot added this to the vNext-v3 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisnas chrisnas chrisnas approved these changes

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler identified-by:crashtracking

Projects

None yet

Milestone

3.46.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gleocadie @chrisnas