Skip to content

Update vendored OpenTelemetry.Exporter.OpenTelemetryProtocol#8655

Merged
andrewlock merged 9 commits into
masterfrom
andrew/update-otel-vendoring
Jun 4, 2026
Merged

Update vendored OpenTelemetry.Exporter.OpenTelemetryProtocol#8655
andrewlock merged 9 commits into
masterfrom
andrew/update-otel-vendoring

Conversation

@andrewlock

@andrewlock andrewlock commented May 18, 2026

Copy link
Copy Markdown
Member

Summary of changes

  • Switch OpenTelemetry.Exporter.OpenTelemetryProtocol vendoring to be "include" instead of "exclude"
  • Vendored required shared types
  • Update to latest release

Reason for change

  • We want to keep our dependencies up to date
  • We can now specify "include" as well as "exclude" during vendoring, which makes the definition more terse

Implementation details

Each commit is self contained, so may be easier to understand

  • Convert vendoring to use "include" instead of "exclude"
  • Update the code, and confirm no changes (actually minor warning updates due to changes in the vendoring process)
  • Update the code to the latest
  • Need to vendor new "helpers" too
  • Final update

Test coverage

Covered by existing tests

Other details

May conflict with other work @zacharycmontoya is doing - this PR is easily re-runnable later, so his definitely takes precedence!

@andrewlock
andrewlock requested review from a team as code owners May 18, 2026 13:44
@andrewlock andrewlock added dependencies Pull requests that update a dependency file area:vendors Code from other vendors area:opentelemetry OpenTelemetry support labels May 18, 2026
@pr-commenter

pr-commenter Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-04 13:32:31

Comparing candidate commit 8440d3c in PR branch andrew/update-otel-vendoring with baseline commit 02a4461 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5493.562op/s; -5200.412op/s] or [-6.271%; -5.937%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • 🟩 throughput [+11565.331op/s; +13822.995op/s] or [+5.393%; +6.446%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6682.518op/s; -6214.680op/s] or [-7.923%; -7.369%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-6772.657op/s; -5651.623op/s] or [-6.886%; -5.746%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+312.218ms; +318.496ms] or [+154.934%; +158.049%]
  • 🟥 throughput [-44.190op/s; -39.879op/s] or [-7.951%; -7.175%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+380.657ms; +382.221ms] or [+300.742%; +301.978%]
  • 🟩 throughput [+90.615op/s; +93.267op/s] or [+11.947%; +12.297%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+390.105ms; +391.586ms] or [+345.228%; +346.539%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-15.500ms; -11.287ms] or [-7.239%; -5.271%]
  • 🟩 throughput [+7055.425op/s; +9865.524op/s] or [+5.150%; +7.201%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-271713.652op/s; -266858.357op/s] or [-27.743%; -27.248%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-26.994ms; -22.145ms] or [-12.038%; -9.876%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-156766.946op/s; -140760.373op/s] or [-22.524%; -20.225%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+8456.540op/s; +11540.082op/s] or [+5.381%; +7.343%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+8858.029op/s; +11486.185op/s] or [+7.057%; +9.150%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+380836.270op/s; +442970.432op/s] or [+12.699%; +14.771%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.182ms; -14.845ms] or [-8.842%; -6.843%]
  • 🟩 throughput [+154235.199op/s; +213130.997op/s] or [+6.122%; +8.460%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.439ms; +300.394ms] or [+149.620%; +150.097%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.747ms; +302.955ms] or [+151.163%; +152.781%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.468ms; +303.525ms] or [+151.352%; +152.892%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.192ms; +298.420ms] or [+145.969%; +146.572%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+299.100ms; +303.273ms] or [+146.219%; +148.259%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+299.158ms; +301.554ms] or [+149.519%; +150.716%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+21.832µs; +45.518µs] or [+6.970%; +14.531%]
  • 🟥 throughput [-424.347op/s; -225.067op/s] or [-13.228%; -7.016%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.091ms; +300.776ms] or [+149.776%; +150.118%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+410.113ms; +420.602ms] or [+445.605%; +457.002%]
  • 🟩 throughput [+750.322op/s; +985.005op/s] or [+6.166%; +8.094%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+249.130ms; +312.910ms] or [+189.162%; +237.590%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+302.606ms; +356.973ms] or [+139.135%; +164.133%]
  • 🟥 throughput [-520.550op/s; -477.524op/s] or [-47.167%; -43.268%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+141.494ms; +286.967ms] or [+60.299%; +122.293%]
  • 🟥 throughput [-671.757op/s; -588.313op/s] or [-44.806%; -39.241%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+329.568ms; +338.039ms] or [+197.120%; +202.186%]
  • 🟥 throughput [-406.795op/s; -368.894op/s] or [-28.325%; -25.686%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟩 execution_time [-361.640µs; -146.408µs] or [-12.581%; -5.093%]
  • unstable throughput [+23.084op/s; +67.600op/s] or [+6.636%; +19.431%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-176.896µs; -143.338µs] or [-8.961%; -7.261%]
  • 🟩 throughput [+40.315op/s; +50.280op/s] or [+7.959%; +9.926%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+303.595ms; +305.838ms] or [+152.885%; +154.014%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+300.440ms; +302.997ms] or [+150.551%; +151.832%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.356ms; +304.493ms] or [+151.389%; +152.964%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.111ms; +305.896ms] or [+152.212%; +153.611%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.755ms; +300.244ms] or [+147.721%; +148.457%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+304.623ms; +308.556ms] or [+154.396%; +156.390%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.618ms; +302.519ms] or [+150.883%; +151.837%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+299.884ms; +302.625ms] or [+149.465%; +150.831%]
  • 🟩 throughput [+40995.805op/s; +48961.296op/s] or [+8.140%; +9.722%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+298.221ms; +301.505ms] or [+148.362%; +149.996%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-17.553ms; -13.855ms] or [-8.162%; -6.443%]
  • 🟩 throughput [+19651.342op/s; +26705.024op/s] or [+5.391%; +7.326%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+13.171µs; +58.456µs] or [+3.253%; +14.439%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.854KB; -19.832KB] or [-7.242%; -7.234%]
  • unstable execution_time [-39.996µs; +14.495µs] or [-7.905%; +2.865%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-18.309KB; -18.289KB] or [-6.675%; -6.667%]
  • unstable execution_time [-40.931µs; +22.110µs] or [-7.093%; +3.831%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+5.630µs; +9.745µs] or [+13.308%; +23.033%]
  • 🟥 throughput [-4535.719op/s; -2756.296op/s] or [-19.094%; -11.603%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.667µs; -5.943µs] or [-21.204%; -9.220%]
  • unstable throughput [+1426.054op/s; +3118.579op/s] or [+8.749%; +19.134%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.038ms; +303.416ms] or [+152.667%; +153.363%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+298.947ms; +301.361ms] or [+152.163%; +153.392%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+298.672ms; +301.670ms] or [+149.522%; +151.023%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+36337.544op/s; +38410.354op/s] or [+6.878%; +7.270%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.885ms; +304.072ms] or [+150.463%; +151.553%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+300.451ms; +303.679ms] or [+150.872%; +152.493%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.875ms; +305.138ms] or [+153.599%; +154.747%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.491ms; +300.886ms] or [+149.387%; +150.083%]
  • 🟩 throughput [+61084440.399op/s; +61420025.541op/s] or [+44.485%; +44.730%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+341.888ms; +398.505ms] or [+425.198%; +495.612%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.067ms; +300.265ms] or [+149.168%; +149.765%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+93943.504op/s; +102097.246op/s] or [+8.771%; +9.532%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+43753.622op/s; +63783.547op/s] or [+5.064%; +7.383%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+73142.023op/s; +82102.465op/s] or [+7.264%; +8.154%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+40891.472op/s; +47401.009op/s] or [+7.425%; +8.607%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+90943.959op/s; +108258.596op/s] or [+10.161%; +12.095%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@andrewlock andrewlock mentioned this pull request May 19, 2026
Merged
link04
link04 approved these changes Jun 3, 2026
View reviewed changes

@link04 link04 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! I found it so dirty when I added this and had to exclude so much.

May need to build to fix the trimming file.

@bouwkast

bouwkast commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

zacharycmontoya
zacharycmontoya approved these changes Jun 3, 2026
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the trimming file change for System.Net.Http.HttpCompletionOption

@andrewlock
andrewlock force-pushed the andrew/update-otel-vendoring branch from 8877b15 to 161db71 Compare June 4, 2026 06:33
@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8655) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.12 ± (75.00 - 75.50) ms74.26 ± (74.29 - 74.91) ms-1.1%✅
.NET Framework 4.8 - Bailout
duration78.26 ± (78.19 - 78.55) ms78.70 ± (78.64 - 79.22) ms+0.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1085.90 ± (1087.15 - 1092.70) ms1105.48 ± (1106.76 - 1115.99) ms+1.8%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.55 ± (22.49 - 22.60) ms22.89 ± (22.82 - 22.95) ms+1.5%✅⬆️
process.time_to_main_ms85.57 ± (85.29 - 85.85) ms87.27 ± (86.99 - 87.55) ms+2.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.92 ± (10.92 - 10.92) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.32 ± (22.28 - 22.36) ms22.50 ± (22.45 - 22.54) ms+0.8%✅⬆️
process.time_to_main_ms84.88 ± (84.66 - 85.10) ms85.84 ± (85.63 - 86.04) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.97 ± (10.97 - 10.97) MB10.94 ± (10.93 - 10.94) MB-0.3%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.32 ± (211.21 - 213.43) ms212.00 ± (210.93 - 213.08) ms-0.1%✅
process.time_to_main_ms535.07 ± (533.82 - 536.32) ms540.42 ± (538.92 - 541.92) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.39 ± (48.36 - 48.43) MB48.31 ± (48.27 - 48.34) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.68 ± (21.63 - 21.73) ms21.21 ± (21.17 - 21.25) ms-2.2%✅
process.time_to_main_ms75.95 ± (75.71 - 76.20) ms73.42 ± (73.23 - 73.61) ms-3.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.63) MB10.65 ± (10.64 - 10.65) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.32 ± (21.28 - 21.36) ms21.35 ± (21.30 - 21.40) ms+0.2%✅⬆️
process.time_to_main_ms74.67 ± (74.49 - 74.84) ms75.51 ± (75.24 - 75.78) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.74 - 10.75) MB10.75 ± (10.75 - 10.75) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms368.02 ± (366.09 - 369.95) ms371.54 ± (369.50 - 373.59) ms+1.0%✅⬆️
process.time_to_main_ms543.63 ± (542.41 - 544.84) ms548.30 ± (547.23 - 549.37) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.83 ± (49.81 - 49.85) MB49.82 ± (49.80 - 49.85) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.29 ± (19.25 - 19.32) ms19.31 ± (19.26 - 19.36) ms+0.1%✅⬆️
process.time_to_main_ms71.61 ± (71.45 - 71.76) ms72.34 ± (72.10 - 72.59) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.70) MB7.68 ± (7.67 - 7.68) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.54 ± (19.50 - 19.59) ms19.30 ± (19.25 - 19.35) ms-1.3%✅
process.time_to_main_ms75.60 ± (75.34 - 75.86) ms73.01 ± (72.82 - 73.19) ms-3.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.73 - 7.74) MB7.72 ± (7.71 - 7.72) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms296.70 ± (294.70 - 298.70) ms293.29 ± (291.26 - 295.32) ms-1.2%✅
process.time_to_main_ms495.14 ± (493.96 - 496.31) ms495.63 ± (494.61 - 496.66) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.84 ± (36.81 - 36.88) MB36.87 ± (36.84 - 36.90) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration199.50 ± (198.85 - 199.80) ms199.03 ± (198.79 - 199.79) ms-0.2%✅
.NET Framework 4.8 - Bailout
duration201.94 ± (201.57 - 202.37) ms201.96 ± (201.92 - 202.87) ms+0.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1195.52 ± (1194.15 - 1200.11) ms1194.69 ± (1193.80 - 1199.69) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms194.89 ± (194.39 - 195.39) ms192.78 ± (192.37 - 193.20) ms-1.1%✅
process.time_to_main_ms85.24 ± (84.97 - 85.51) ms83.88 ± (83.60 - 84.17) ms-1.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.02 ± (16.00 - 16.05) MB16.08 ± (16.06 - 16.11) MB+0.4%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms194.24 ± (193.74 - 194.74) ms192.33 ± (191.96 - 192.69) ms-1.0%✅
process.time_to_main_ms86.05 ± (85.80 - 86.31) ms84.81 ± (84.53 - 85.09) ms-1.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.15 ± (16.12 - 16.18) MB+0.4%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)-0.1%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms387.79 ± (386.62 - 388.96) ms387.01 ± (385.55 - 388.46) ms-0.2%✅
process.time_to_main_ms540.61 ± (539.16 - 542.06) ms533.33 ± (532.09 - 534.56) ms-1.3%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.33 ± (57.16 - 57.50) MB57.76 ± (57.51 - 58.01) MB+0.8%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms198.94 ± (198.47 - 199.42) ms195.55 ± (195.04 - 196.06) ms-1.7%✅
process.time_to_main_ms73.36 ± (73.09 - 73.64) ms71.99 ± (71.72 - 72.26) ms-1.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.33 ± (16.31 - 16.35) MB16.44 ± (16.42 - 16.46) MB+0.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.4%✅
.NET 6 - Bailout
process.internal_duration_ms196.33 ± (195.84 - 196.82) ms195.52 ± (195.11 - 195.92) ms-0.4%✅
process.time_to_main_ms73.64 ± (73.39 - 73.89) ms72.67 ± (72.48 - 72.85) ms-1.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.37 ± (16.35 - 16.39) MB16.47 ± (16.44 - 16.49) MB+0.6%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.1%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms585.73 ± (583.52 - 587.94) ms584.85 ± (582.44 - 587.26) ms-0.2%✅
process.time_to_main_ms545.54 ± (544.43 - 546.66) ms539.88 ± (538.91 - 540.86) ms-1.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.00 ± (60.92 - 61.08) MB61.05 ± (60.97 - 61.12) MB+0.1%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms195.19 ± (194.74 - 195.64) ms193.59 ± (193.10 - 194.08) ms-0.8%✅
process.time_to_main_ms71.64 ± (71.38 - 71.89) ms71.17 ± (70.93 - 71.41) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.68 ± (11.66 - 11.71) MB11.73 ± (11.70 - 11.76) MB+0.4%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.2%✅
.NET 8 - Bailout
process.internal_duration_ms194.92 ± (194.46 - 195.39) ms193.49 ± (193.09 - 193.89) ms-0.7%✅
process.time_to_main_ms72.82 ± (72.62 - 73.02) ms72.24 ± (72.06 - 72.42) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.69 - 11.74) MB11.75 ± (11.72 - 11.77) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms515.43 ± (512.87 - 517.99) ms511.13 ± (508.49 - 513.76) ms-0.8%✅
process.time_to_main_ms493.29 ± (492.51 - 494.06) ms490.38 ± (489.47 - 491.30) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.63 ± (50.60 - 50.66) MB50.62 ± (50.58 - 50.65) MB-0.0%✅
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 29)-0.4%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (75ms)  : 70, 79
    master - mean (75ms)  : 72, 79

    section Bailout
    This PR (8655) - mean (79ms)  : 74, 83
    master - mean (78ms)  : 76, 81

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (1,111ms)  : 1043, 1180
    master - mean (1,090ms)  : 1049, 1131
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (117ms)  : 112, 122
    master - mean (115ms)  : 110, 121

    section Bailout
    This PR (8655) - mean (115ms)  : 113, 118
    master - mean (114ms)  : 111, 117

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (789ms)  : 765, 812
    master - mean (786ms)  : 767, 806
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (101ms)  : 97, 105
    master - mean (104ms)  : 99, 109

    section Bailout
    This PR (8655) - mean (104ms)  : 99, 108
    master - mean (102ms)  : 100, 104

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (952ms)  : 917, 987
    master - mean (938ms)  : 902, 975
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (99ms)  : 95, 103
    master - mean (99ms)  : 96, 101

    section Bailout
    This PR (8655) - mean (100ms)  : 97, 103
    master - mean (103ms)  : 99, 108

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (818ms)  : 784, 852
    master - mean (821ms)  : 779, 862
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (199ms)  : 192, 207
    master - mean (199ms)  : 193, 205

    section Bailout
    This PR (8655) - mean (202ms)  : 197, 208
    master - mean (202ms)  : 198, 206

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (1,197ms)  : 1154, 1239
    master - mean (1,197ms)  : 1154, 1240
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (286ms)  : 279, 292
    master - mean (289ms)  : 281, 297

    section Bailout
    This PR (8655) - mean (286ms)  : 281, 291
    master - mean (289ms)  : 282, 297

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (958ms)  : 939, 978
    master - mean (968ms)  : 946, 989
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (276ms)  : 269, 283
    master - mean (281ms)  : 273, 289

    section Bailout
    This PR (8655) - mean (277ms)  : 272, 281
    master - mean (279ms)  : 271, 286

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (1,154ms)  : 1113, 1195
    master - mean (1,159ms)  : 1126, 1193
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8655) - mean (274ms)  : 268, 281
    master - mean (277ms)  : 272, 282

    section Bailout
    This PR (8655) - mean (276ms)  : 271, 280
    master - mean (278ms)  : 272, 283

    section CallTarget+Inlining+NGEN
    This PR (8655) - mean (1,034ms)  : 995, 1074
    master - mean (1,042ms)  : 997, 1087
Loading

@andrewlock
andrewlock force-pushed the andrew/update-otel-vendoring branch from 161db71 to 8440d3c Compare June 4, 2026 12:44
zacharycmontoya
zacharycmontoya approved these changes Jun 4, 2026
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@andrewlock
andrewlock merged commit 09ed0c4 into master Jun 4, 2026
138 checks passed
@andrewlock
andrewlock deleted the andrew/update-otel-vendoring branch June 4, 2026 15:27
@github-actions github-actions Bot added this to the vNext-v3 milestone Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@link04 link04 link04 approved these changes

Assignees

No one assigned

Labels

area:opentelemetry OpenTelemetry support area:vendors Code from other vendors dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

3.46.0

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlock @bouwkast @zacharycmontoya @link04