Skip to content

[Debugger] Preserve EMITTING diagnostics across probe change#8654

Merged
dudikeleti merged 2 commits into
masterfrom
dudik/2026-021/guarantee-emitting-diagnostic
May 18, 2026
Merged

[Debugger] Preserve EMITTING diagnostics across probe change#8654
dudikeleti merged 2 commits into
masterfrom
dudik/2026-021/guarantee-emitting-diagnostic

Conversation

@dudikeleti

@dudikeleti dudikeleti commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Guarantees debugger EMITTING probe diagnostics are emitted at least once when a probe is removed or updated before the next delayed status poll.
  • Emits explicit, non-default probe statuses immediately from ProbeStatusPoller instead of waiting for the native polling cycle.
  • Reworks DiagnosticsSink queue ownership so stale queued statuses are invalidated by generation, and one-shot EMITTING statuses survive probe removal.
  • Keeps default/fetchable probe statuses on the existing native polling path, while clearing old diagnostics when a probe is updated back to a default status.
  • Adds focused debugger sink and poller tests for removal, replacement, repeated updates, full queues, queue recreation, and generation cleanup.

Reason for change

  • A probe could move through EMITTING and then be removed or replaced before diagnostics were uploaded, causing the backend to miss the fact that instrumentation actually emitted.
  • Immediate explicit-status emission reduces reliance on the delayed native poll for statuses already known by managed code.
  • The sink needed stronger ownership rules to avoid both lost priority diagnostics and stale re-emission after probe replacement.

Implementation details

  • Uses a single lock to protect diagnostics, generations, queue state, and per-message ownership flags; this makes the generation and one-shot removal invariants explicit and easier to reason about.
  • Replaces concurrent containers with a coarse lock; this is acceptable because the diagnostics sink runs off the hot path, and correctness of queued status ownership is more important than fine-grained concurrency here.
  • Introduces per-probe generations so queued messages are only returned if they still match the current diagnostic generation at dequeue time.
  • Treats removed EMITTING diagnostics as one-shot messages: they are preserved until returned once, then both the diagnostic and generation entries are removed.
  • Forces queue recreation for priority EMITTING messages when needed, preferring to rebuild/drop stale queue entries rather than lose a not-yet-returned EMITTING status.
  • Keeps normal statuses bounded by queue capacity and interval-based re-emission, avoiding indefinite retention of overflowed removed EMITTING diagnostics.
  • ProbeStatusPoller now emits known explicit statuses during add/update, but still schedules native polling for default/fetchable statuses.

Test coverage

  • Added unit coverage in ProbeStatusSinkTests for preserved EMITTING diagnostics, stale status invalidation, queue pressure, queue recreation, default-status updates, and poller immediate emission.

@dudikeleti
dudikeleti requested review from a team as code owners May 18, 2026 13:07
@dudikeleti
dudikeleti requested a review from Copilot May 18, 2026 13:08
Copilot AI reviewed May 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves debugger probe diagnostic delivery by ensuring EMITTING statuses are not lost when probes are removed/updated before the next native status poll, and by tightening ownership/invalidating stale queued diagnostics via per-probe generations.

Changes:

  • Reworked DiagnosticsSink to use a single lock + per-probe generations, preserving one-shot removed EMITTING diagnostics while preventing stale re-emission after probe replacement.
  • Updated ProbeStatusPoller to immediately emit explicit (non-default) statuses on add/update, while keeping default/fetchable statuses on the native polling path.
  • Added focused unit tests covering preserved EMITTING behavior across removal/replacement, queue pressure/recreation, and generation cleanup.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tracer/test/Datadog.Trace.Tests/Debugger/ProbeStatusSinkTests.cs Adds coverage for removed/updated probe diagnostics (especially EMITTING), queue pressure, and poller immediate emission behavior.
tracer/src/Datadog.Trace/Debugger/Sink/DiagnosticsSink.cs Reworks diagnostic storage/queueing with generation-based invalidation and one-shot EMITTING preservation.
tracer/src/Datadog.Trace/Debugger/ProbeStatuses/ProbeStatusPoller.cs Emits explicit statuses immediately during add/update and resets diagnostics on updates/removals.
tracer/src/Datadog.Trace/Debugger/Sink/Models/TimedMessage.cs Removes the standalone TimedMessage model (now internal to DiagnosticsSink).
tracer/missing-nullability-files.csv Removes the deleted TimedMessage.cs entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tracer/src/Datadog.Trace/Debugger/Sink/DiagnosticsSink.cs Outdated
dudikeleti added 2 commits May 18, 2026 15:25
@dudikeleti
[Debugger] Preserve EMITTING diagnostics across probe removal
2a2d5dc 
Guarantee that a probe reaching EMITTING is reported at least once even when it is removed, replaced, or queued under pressure before diagnostics are uploaded.

Rework DiagnosticsSink ownership around locked generation tracking and one-shot EMITTING removal, and emit explicit poller statuses immediately while keeping default statuses on the native polling path.
@dudikeleti
Fix diagnostics sink queue invariants
f8ac8ba
@dudikeleti
dudikeleti force-pushed the dudik/2026-021/guarantee-emitting-diagnostic branch from 519ab8d to f8ac8ba Compare May 18, 2026 13:25
@dudikeleti
dudikeleti enabled auto-merge (squash) May 18, 2026 13:28
@dudikeleti
dudikeleti removed the request for review from andreimatei May 18, 2026 13:29
@tylfin

tylfin commented May 18, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 18, 2026

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@dudikeleti
dudikeleti removed the request for review from P403n1x87 May 18, 2026 13:53
@pr-commenter

pr-commenter Bot commented May 18, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-18 14:24:43

Comparing candidate commit f8ac8ba in PR branch dudik/2026-021/guarantee-emitting-diagnostic with baseline commit 8dc4176 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472

Found 1 performance improvements and 5 performance regressions! Performance is the same for 47 metrics, 19 unstable metrics, 89 known flaky benchmarks, 37 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan net6.0

  • 🟥 allocated_mem [+95 bytes; +96 bytes] or [+6.738%; +6.746%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan net6.0

  • 🟥 execution_time [+6.325ms; +9.614ms] or [+5.143%; +7.817%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_GetCurrentSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_SetActive net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+7.889%; +7.898%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-79152.921op/s; -69634.647op/s] or [-53.770%; -47.304%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟩 execution_time [-100.231ms; -97.973ms] or [-50.055%; -48.928%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [-25.494ms; -8.795ms] or [-18.234%; -6.290%]
  • unstable throughput [+11267.713op/s; +30261.016op/s] or [+6.572%; +17.650%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-57.610ms; -27.865ms] or [-43.257%; -20.922%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-6.122ms; +15.930ms] or [-4.336%; +11.282%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [+19.257ms; +39.727ms] or [+15.221%; +31.401%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [-17789.481µs; +17292.817µs] or [-16.019%; +15.572%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-29.562ms; -9.039ms] or [-18.273%; -5.587%]
  • unstable throughput [-2484.426op/s; +12019.409op/s] or [-1.943%; +9.400%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-42.568ms; -2.533ms] or [-31.584%; -1.879%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [+6.051ms; +46.038ms] or [+4.318%; +32.855%]
  • unstable throughput [-31780.209op/s; +260.950op/s] or [-18.168%; +0.149%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [-16.452ms; +18.850ms] or [-15.020%; +17.210%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [+6.760ms; +23.882ms] or [+5.519%; +19.497%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-22.582ms; +11.997ms] or [-19.670%; +10.450%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • unstable execution_time [-57.447ms; -22.512ms] or [-31.699%; -12.422%]
  • unstable throughput [+21898.057op/s; +47890.264op/s] or [+16.715%; +36.555%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [+6.016ms; +32.314ms] or [+6.751%; +36.261%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [+2.313ms; +38.408ms] or [+1.598%; +26.543%]
  • unstable throughput [-20092.381op/s; +3688.196op/s] or [-14.430%; +2.649%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • unstable execution_time [-32.344ms; -5.738ms] or [-20.524%; -3.641%]
  • unstable throughput [-2178.506op/s; +17874.025op/s] or [-1.430%; +11.731%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • unstable execution_time [-3.435ms; +44.828ms] or [-2.626%; +34.264%]
  • unstable throughput [-17235.404op/s; +14187.721op/s] or [-14.799%; +12.182%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1

  • unstable execution_time [+31.054ms; +62.979ms] or [+36.706%; +74.440%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-7.252ms; +10.091ms] or [-4.769%; +6.636%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [+2.288ms; +41.188ms] or [+2.049%; +36.880%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-8.741%; -8.734%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [-19.532ms; +17.491ms] or [-17.841%; +15.978%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [-23.875ms; -6.623ms] or [-17.173%; -4.763%]
  • unstable throughput [+23482.618op/s; +49479.662op/s] or [+14.479%; +30.509%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-45.346ms; -6.004ms] or [-33.541%; -4.441%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6695.946op/s; -5796.925op/s] or [-7.939%; -6.873%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • unstable execution_time [-68.660ms; -34.399ms] or [-34.255%; -17.161%]
  • unstable throughput [-44886.068op/s; -29656.441op/s] or [-37.729%; -24.927%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-89.501ms; -66.798ms] or [-45.016%; -33.597%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+315.711ms; +332.053ms] or [+156.667%; +164.776%]
  • 🟥 throughput [-55.530op/s; -43.027op/s] or [-9.991%; -7.741%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+99.086ms; +101.153ms] or [+78.284%; +79.917%]
  • 🟩 throughput [+84.879op/s; +92.578op/s] or [+11.191%; +12.206%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+85.306ms; +86.535ms] or [+75.493%; +76.580%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • unstable execution_time [-49.021ms; -27.280ms] or [-22.894%; -12.741%]
  • unstable throughput [-34002.392op/s; -19070.581op/s] or [-24.820%; -13.920%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]
  • 🟩 execution_time [-31.977ms; -14.523ms] or [-15.227%; -6.916%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-267442.859op/s; -263831.331op/s] or [-27.307%; -26.938%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • unstable execution_time [-85.083ms; -52.787ms] or [-37.943%; -23.541%]
  • unstable throughput [-294793.113op/s; -166539.215op/s] or [-31.493%; -17.792%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟩 execution_time [-79.462ms; -60.500ms] or [-39.664%; -30.199%]
  • 🟥 throughput [-126968.106op/s; -109532.101op/s] or [-18.243%; -15.738%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 execution_time [-43.958ms; -25.334ms] or [-22.179%; -12.783%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • unstable execution_time [-48.754ms; -28.736ms] or [-24.856%; -14.651%]
  • 🟩 throughput [+10302.096op/s; +13097.714op/s] or [+8.207%; +10.434%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-73.477ms; -71.282ms] or [-36.329%; -35.243%]
  • 🟩 throughput [+237070.865op/s; +272991.572op/s] or [+7.905%; +9.103%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.754ms; -15.322ms] or [-9.106%; -7.063%]
  • 🟩 throughput [+161739.470op/s; +216770.176op/s] or [+6.420%; +8.604%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.124ms; +314.898ms] or [+150.462%; +157.344%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • unstable execution_time [+207.783ms; +256.293ms] or [+104.786%; +129.249%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+304.060ms; +310.616ms] or [+153.162%; +156.464%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.303ms; +311.064ms] or [+146.023%; +152.783%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+242.584ms; +259.698ms] or [+118.591%; +126.957%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+303.147ms; +309.082ms] or [+151.512%; +154.479%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+22.002µs; +45.720µs] or [+7.024%; +14.596%]
  • 🟥 throughput [-425.906op/s; -226.369op/s] or [-13.277%; -7.057%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.258ms; +301.061ms] or [+149.860%; +150.260%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+353.663ms; +379.894ms] or [+384.269%; +412.770%]
  • 🟥 throughput [-7069.401op/s; -6800.493op/s] or [-58.090%; -55.881%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+214.078ms; +275.688ms] or [+162.547%; +209.327%]
  • 🟥 throughput [-1274.404op/s; -1026.829op/s] or [-12.337%; -9.940%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+296.565ms; +312.024ms] or [+136.358%; +143.466%]
  • 🟥 throughput [-681.917op/s; -664.614op/s] or [-61.788%; -60.221%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-53.947ms; +79.912ms] or [-22.990%; +34.055%]
  • 🟥 throughput [-698.631op/s; -607.045op/s] or [-46.599%; -40.490%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+345.397ms; +353.750ms] or [+206.588%; +211.584%]
  • 🟥 throughput [-740.800op/s; -706.448op/s] or [-51.581%; -49.189%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟩 throughput [+18.058op/s; +19.376op/s] or [+5.191%; +5.570%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-182.506µs; -168.615µs] or [-9.245%; -8.541%]
  • 🟩 throughput [+47.450op/s; +51.644op/s] or [+9.367%; +10.195%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-231.291µs; -197.405µs] or [-5.865%; -5.006%]
  • 🟩 throughput [+13.445op/s; +15.846op/s] or [+5.302%; +6.248%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+305.883ms; +318.546ms] or [+154.037%; +160.414%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+255.791ms; +275.161ms] or [+128.177%; +137.884%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+302.037ms; +309.033ms] or [+151.731%; +155.245%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+301.917ms; +313.164ms] or [+151.613%; +157.261%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+203.654ms; +228.443ms] or [+100.698%; +112.955%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+304.537ms; +313.286ms] or [+154.353%; +158.787%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+304.197ms; +316.834ms] or [+152.679%; +159.022%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+302.637ms; +310.402ms] or [+150.837%; +154.707%]
  • 🟩 throughput [+40153.507op/s; +50530.790op/s] or [+7.973%; +10.034%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+298.598ms; +304.361ms] or [+148.550%; +151.417%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • unstable execution_time [-75.961ms; -46.305ms] or [-35.322%; -21.532%]
  • unstable throughput [-132176.736op/s; -77854.160op/s] or [-36.260%; -21.358%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • unstable execution_time [-89.890ms; -67.421ms] or [-45.090%; -33.819%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-26.417KB; -26.395KB] or [-9.636%; -9.628%]
  • unstable execution_time [-80.988µs; -29.481µs] or [-16.007%; -5.827%]
  • 🟩 throughput [+135.467op/s; +317.976op/s] or [+6.760%; +15.867%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 throughput [+98.290op/s; +252.518op/s] or [+5.615%; +14.427%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+5.796µs; +10.974µs] or [+13.701%; +25.940%]
  • 🟥 throughput [-4743.337op/s; -2774.788op/s] or [-19.968%; -11.681%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-10.415µs; -0.235µs] or [-16.158%; -0.365%]
  • unstable throughput [+251.767op/s; +2234.412op/s] or [+1.545%; +13.709%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+305.418ms; +319.546ms] or [+154.375%; +161.516%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • unstable execution_time [+281.590ms; +301.461ms] or [+143.328%; +153.443%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.667ms; +309.018ms] or [+151.522%; +154.702%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-35.896ms; -9.617ms] or [-17.942%; -4.807%]
  • 🟥 throughput [-253926.278op/s; -201239.063op/s] or [-48.063%; -38.090%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-53.048ms; -23.557ms] or [-26.890%; -11.941%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.142ms; +315.928ms] or [+151.089%; +157.462%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+226.285ms; +281.257ms] or [+113.629%; +141.234%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+305.976ms; +311.404ms] or [+155.171%; +157.924%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.309ms; +301.071ms] or [+149.796%; +150.176%]
  • 🟩 throughput [+64680234.146op/s; +64996207.166op/s] or [+47.104%; +47.334%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+372.752ms; +384.095ms] or [+463.583%; +477.690%]
  • 🟥 throughput [-7330.725op/s; -7125.587op/s] or [-56.670%; -55.084%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+301.955ms; +304.678ms] or [+150.608%; +151.966%]
  • 🟥 throughput [-30488856.644op/s; -29123545.639op/s] or [-13.505%; -12.900%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • unstable execution_time [-51.164ms; -15.665ms] or [-25.059%; -7.672%]
  • unstable throughput [-257052.018op/s; -81898.797op/s] or [-24.000%; -7.647%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • unstable execution_time [-87.257ms; -64.845ms] or [-44.153%; -32.812%]
  • 🟩 throughput [+46042.476op/s; +67588.663op/s] or [+5.329%; +7.823%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-80.778ms; -59.913ms] or [-42.086%; -31.215%]
  • unstable throughput [-104890.412op/s; +42217.469op/s] or [-8.119%; +3.268%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-33.595ms; -10.533ms] or [-16.506%; -5.175%]
  • 🟩 throughput [+84944.957op/s; +97221.158op/s] or [+8.436%; +9.656%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • unstable execution_time [-71.678ms; -44.220ms] or [-35.796%; -22.083%]
  • unstable throughput [-49428.455op/s; +14960.950op/s] or [-8.975%; +2.717%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-99.102ms; -94.976ms] or [-49.793%; -47.720%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-100.400ms; -77.398ms] or [-50.218%; -38.713%]
  • unstable throughput [-95535.785op/s; +19044.044op/s] or [-10.674%; +2.128%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-29.725ms; -6.924ms] or [-15.097%; -3.516%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

@andrewlock andrewlock mentioned this pull request May 18, 2026
Merged
@dudikeleti
dudikeleti merged commit e6ef71a into master May 18, 2026
136 of 139 checks passed
@dudikeleti
dudikeleti deleted the dudik/2026-021/guarantee-emitting-diagnostic branch May 18, 2026 16:18
@github-actions github-actions Bot added this to the vNext-v3 milestone May 18, 2026
andrewlock added a commit that referenced this pull request May 29, 2026
@andrewlock
Add some more owners to the nullability file (#8656)
7c711e3 
## Summary of changes

Adds some more owners to the nullability file

## Reason for change

There's no reason this has to only be owned by apm-dotnet IMO

## Implementation details

- Add more teams as owners of the nullability files csv
- Add the full path

## Test coverage

Meh

## Other details

PRs like #8654 require an APM review even though they only touch
Debugger code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@jpbempel jpbempel jpbempel approved these changes
@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes
@tylfin tylfin Awaiting requested review from tylfin

Assignees

No one assigned

Labels

area:debugger

Projects

None yet

Milestone

3.45.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dudikeleti @tylfin @jpbempel @NachoEchevarria