[Profiler] Add Flaky attribute#8648
Merged
Merged
Conversation
github-actions
Bot
added
the
area:profiler
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8648) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (72ms) : 69, 75
master - mean (72ms) : 70, 74
section Bailout
This PR (8648) - mean (79ms) : 75, 84
master - mean (78ms) : 74, 82
section CallTarget+Inlining+NGEN
This PR (8648) - mean (1,119ms) : 1037, 1202
master - mean (1,109ms) : 1061, 1157
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (116ms) : 110, 121
master - mean (114ms) : 110, 119
section Bailout
This PR (8648) - mean (117ms) : 112, 123
master - mean (118ms) : 113, 123
section CallTarget+Inlining+NGEN
This PR (8648) - mean (790ms) : 758, 821
master - mean (792ms) : 763, 822
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (105ms) : 95, 115
master - mean (104ms) : 98, 110
section Bailout
This PR (8648) - mean (102ms) : 98, 106
master - mean (105ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (8648) - mean (945ms) : 913, 976
master - mean (949ms) : 916, 983
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (101ms) : 94, 108
master - mean (99ms) : 96, 103
section Bailout
This PR (8648) - mean (104ms) : 99, 108
master - mean (104ms) : 99, 108
section CallTarget+Inlining+NGEN
This PR (8648) - mean (822ms) : 775, 868
master - mean (821ms) : 779, 863
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (199ms) : 193, 206
master - mean (200ms) : 194, 207
section Bailout
This PR (8648) - mean (203ms) : 198, 208
master - mean (204ms) : 199, 209
section CallTarget+Inlining+NGEN
This PR (8648) - mean (1,200ms) : 1157, 1243
master - mean (1,203ms) : 1164, 1243
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (285ms) : 274, 296
master - mean (288ms) : 282, 294
section Bailout
This PR (8648) - mean (288ms) : 281, 295
master - mean (291ms) : 283, 298
section CallTarget+Inlining+NGEN
This PR (8648) - mean (964ms) : 945, 983
master - mean (969ms) : 947, 992
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (279ms) : 270, 289
master - mean (282ms) : 275, 289
section Bailout
This PR (8648) - mean (280ms) : 270, 290
master - mean (281ms) : 275, 288
section CallTarget+Inlining+NGEN
This PR (8648) - mean (1,159ms) : 1121, 1198
master - mean (1,161ms) : 1131, 1192
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8648) - mean (280ms) : 272, 288
master - mean (279ms) : 271, 287
section Bailout
This PR (8648) - mean (280ms) : 274, 286
master - mean (279ms) : 274, 284
section CallTarget+Inlining+NGEN
This PR (8648) - mean (1,042ms) : 1006, 1078
master - mean (1,041ms) : 1000, 1083
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-20 08:19:53 Comparing candidate commit 2b41806 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 3 performance improvements and 5 performance regressions! Performance is the same for 45 metrics, 19 unstable metrics, 84 known flaky benchmarks, 42 flaky benchmarks without significant changes.
|
gleocadie
force-pushed
the
gleocadie/add-flaky-attribute
branch
from
May 20, 2026 07:04
653364c to
bd2f341
Compare
chrisnas
approved these changes
May 20, 2026
chrisnas
left a comment
chrisnas
left a comment
Contributor
There was a problem hiding this comment.
Just a comment to change + test to add (just in case)
…ribute.cs Co-authored-by: chrisnas <[email protected]>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add
Flakyattribute to restart flaky tests.Reason for change
Exceptions integration tests on aarch64 are flaky (stack comparison). This is caused by truncated stacks and the current state of the ManagedCodeCache.
Implementation details
Add
FlakyAttributeand add it on Exceptions integration tests.Test coverage
Other details