Load native loader in profiler via absolute path on Windows#8646
Merged
Conversation
andrewlock
added
type:reliability
area:profiler
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8646) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (73ms) : 71, 75
master - mean (74ms) : 70, 79
section Bailout
This PR (8646) - mean (77ms) : 74, 79
master - mean (78ms) : 74, 81
section CallTarget+Inlining+NGEN
This PR (8646) - mean (1,107ms) : 1052, 1162
master - mean (1,100ms) : 1043, 1157
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (113ms) : 110, 116
master - mean (115ms) : 110, 119
section Bailout
This PR (8646) - mean (118ms) : 110, 125
master - mean (115ms) : 111, 118
section CallTarget+Inlining+NGEN
This PR (8646) - mean (786ms) : 759, 813
master - mean (787ms) : 758, 816
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (104ms) : 97, 110
master - mean (104ms) : 98, 109
section Bailout
This PR (8646) - mean (102ms) : 98, 106
master - mean (103ms) : 99, 106
section CallTarget+Inlining+NGEN
This PR (8646) - mean (946ms) : 901, 992
master - mean (945ms) : 904, 986
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (102ms) : 96, 108
master - mean (98ms) : 95, 102
section Bailout
This PR (8646) - mean (103ms) : 98, 108
master - mean (101ms) : 97, 105
section CallTarget+Inlining+NGEN
This PR (8646) - mean (823ms) : 786, 861
master - mean (819ms) : 774, 865
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (198ms) : 193, 203
master - mean (199ms) : 195, 204
section Bailout
This PR (8646) - mean (202ms) : 195, 209
master - mean (202ms) : 197, 206
section CallTarget+Inlining+NGEN
This PR (8646) - mean (1,200ms) : 1150, 1250
master - mean (1,204ms) : 1154, 1253
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (289ms) : 282, 295
master - mean (289ms) : 278, 299
section Bailout
This PR (8646) - mean (289ms) : 283, 295
master - mean (290ms) : 281, 298
section CallTarget+Inlining+NGEN
This PR (8646) - mean (962ms) : 943, 981
master - mean (965ms) : 948, 982
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (278ms) : 272, 284
master - mean (281ms) : 273, 289
section Bailout
This PR (8646) - mean (277ms) : 271, 282
master - mean (281ms) : 274, 289
section CallTarget+Inlining+NGEN
This PR (8646) - mean (1,155ms) : 1114, 1196
master - mean (1,170ms) : 1132, 1208
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8646) - mean (277ms) : 270, 284
master - mean (278ms) : 271, 285
section Bailout
This PR (8646) - mean (277ms) : 270, 283
master - mean (279ms) : 271, 286
section CallTarget+Inlining+NGEN
This PR (8646) - mean (1,038ms) : 999, 1077
master - mean (1,039ms) : 993, 1084
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-15 09:59:03 Comparing candidate commit 50260a7 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 3 performance improvements and 2 performance regressions! Performance is the same for 47 metrics, 20 unstable metrics, 85 known flaky benchmarks, 41 flaky benchmarks without significant changes.
|
gleocadie
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates the fallback path when loading the native loader (runtime ID store) to use an absolute path
Reason for change
By default, we load the native loader using an env var set by the loader itself. This is the default approach, but there's also a fallback in case this is not set for some reason.
On Windows only, we were using just the filename to load the library, which can be ambiguous depending on dll search paths. This changes the Windows lookup to use an absolute path like we do on Linux
Implementation details
Remove the
#ifdeffor Windows, and construct the full path in both cases.Test coverage
Should be covered by existing tests
Other details
Note that the old comment of "the native loader is in the parent directory" has been incorrect since #3060 (v2.14.0, back in 2022 😅)