Skip to content

Serialize RuntimeIdTests and HttpHeaderHelperTests to remove telemetry header flake#8638

Merged
NachoEchevarria merged 3 commits into
masterfrom
nacho/fixFlakyTelemtryAgentTest
May 29, 2026
Merged

Serialize RuntimeIdTests and HttpHeaderHelperTests to remove telemetry header flake#8638
NachoEchevarria merged 3 commits into
masterfrom
nacho/fixFlakyTelemtryAgentTest

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Add [Collection(nameof(EnvironmentVariablesTestCollection))] to RuntimeIdTests so they cannot run in parallel.

Reason for change

HttpHeaderHelperTests.TelemetryAgentHttpHeaderHelper_WritesExpectedHeaders flaked in build 201656: expected included DD-Root-Session-ID: inherited-root-session-id, actual did not.

RuntimeIdTests transiently sets RuntimeId._rootSessionId = "inherited-root-session-id" before restoring it in finally. xUnit runs test classes in parallel, and the log confirms RuntimeIdTests (6ms) ran inside HttpHeaderHelperTests's 146ms window. The race:

  1. helper.DefaultHeaders read fresh during the mutation window → expected includes the root header.
  2. helper.WriteLeadingHeaders populated the once-per-process cache TelemetryHttpHeaderNames._httpSerializedDefaultAgentHeaders after RuntimeIdTests restored state → actual lacks it.

Implementation details

  • RuntimeIdTests.cs — gains [Collection(...)]. It already mutates _DD_ROOT_DOTNET_SESSION_ID, so it belongs here anyway.

Production code is unchanged: the lazy cache and static field are fine because _rootSessionId is set once at startup in real runs.

Test coverage

No new tests — existing coverage is preserved, just no longer racing.

Other details

@NachoEchevarria NachoEchevarria changed the title Fix fix(tests): serialize RuntimeIdTests and HttpHeaderHelperTests to remove telemetry header flake May 14, 2026
@github-actions github-actions Bot added the area:tests unit tests, integration tests label May 14, 2026
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 14, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8638) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.76 ± (72.95 - 73.39) ms74.18 ± (74.23 - 74.76) ms+1.9%✅⬆️
.NET Framework 4.8 - Bailout
duration79.27 ± (79.12 - 79.65) ms76.91 ± (76.77 - 77.17) ms-3.0%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1107.49 ± (1108.19 - 1116.57) ms1105.93 ± (1103.53 - 1110.42) ms-0.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms22.85 ± (22.79 - 22.91) ms22.67 ± (22.62 - 22.72) ms-0.8%
process.time_to_main_ms86.84 ± (86.52 - 87.16) ms85.49 ± (85.20 - 85.78) ms-1.6%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.93) MB10.92 ± (10.92 - 10.92) MB-0.1%
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.47 ± (22.42 - 22.51) ms22.42 ± (22.38 - 22.46) ms-0.2%
process.time_to_main_ms86.71 ± (86.47 - 86.94) ms86.13 ± (85.90 - 86.37) ms-0.7%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.97 ± (10.97 - 10.97) MB10.96 ± (10.96 - 10.96) MB-0.1%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.42 ± (212.58 - 214.26) ms214.50 ± (213.65 - 215.34) ms+0.5%✅⬆️
process.time_to_main_ms541.49 ± (539.99 - 542.99) ms544.36 ± (543.08 - 545.65) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.59 ± (48.56 - 48.62) MB48.59 ± (48.56 - 48.62) MB-0.0%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.29 ± (21.24 - 21.34) ms21.65 ± (21.60 - 21.71) ms+1.7%✅⬆️
process.time_to_main_ms73.88 ± (73.62 - 74.13) ms76.07 ± (75.78 - 76.36) ms+3.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.64) MB10.64 ± (10.64 - 10.65) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.41 ± (21.36 - 21.47) ms21.24 ± (21.19 - 21.28) ms-0.8%
process.time_to_main_ms76.44 ± (76.18 - 76.70) ms75.39 ± (75.17 - 75.62) ms-1.4%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.74 ± (10.74 - 10.74) MB10.76 ± (10.76 - 10.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms370.09 ± (367.63 - 372.56) ms367.19 ± (365.09 - 369.29) ms-0.8%
process.time_to_main_ms548.37 ± (546.95 - 549.79) ms550.02 ± (548.59 - 551.45) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed50.07 ± (50.04 - 50.10) MB50.03 ± (50.01 - 50.05) MB-0.1%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%
.NET 8 - Baseline
process.internal_duration_ms19.24 ± (19.20 - 19.27) ms19.40 ± (19.36 - 19.44) ms+0.9%✅⬆️
process.time_to_main_ms71.88 ± (71.73 - 72.03) ms72.88 ± (72.69 - 73.07) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.68) MB7.69 ± (7.68 - 7.69) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.59 ± (19.54 - 19.64) ms19.94 ± (19.87 - 20.02) ms+1.8%✅⬆️
process.time_to_main_ms75.16 ± (74.89 - 75.44) ms77.68 ± (77.37 - 77.98) ms+3.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.74 ± (7.74 - 7.75) MB7.72 ± (7.72 - 7.73) MB-0.2%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms294.32 ± (292.35 - 296.28) ms292.79 ± (290.79 - 294.80) ms-0.5%
process.time_to_main_ms498.91 ± (497.96 - 499.85) ms499.44 ± (498.28 - 500.59) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.95 ± (36.92 - 36.98) MB36.96 ± (36.93 - 36.98) MB+0.0%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.6%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration199.94 ± (199.87 - 200.68) ms196.64 ± (196.13 - 197.06) ms-1.6%
.NET Framework 4.8 - Bailout
duration202.91 ± (202.78 - 203.77) ms200.42 ± (200.06 - 200.89) ms-1.2%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1196.74 ± (1196.53 - 1202.41) ms1183.60 ± (1184.53 - 1190.34) ms-1.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms193.85 ± (193.33 - 194.37) ms191.78 ± (191.37 - 192.20) ms-1.1%
process.time_to_main_ms83.38 ± (83.07 - 83.69) ms83.01 ± (82.76 - 83.26) ms-0.4%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.05 ± (16.03 - 16.07) MB16.07 ± (16.05 - 16.10) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.1%
.NET Core 3.1 - Bailout
process.internal_duration_ms193.99 ± (193.45 - 194.52) ms190.69 ± (190.18 - 191.20) ms-1.7%
process.time_to_main_ms85.07 ± (84.69 - 85.45) ms83.98 ± (83.73 - 84.24) ms-1.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.20 ± (16.17 - 16.22) MB16.15 ± (16.12 - 16.18) MB-0.3%
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.0%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms388.15 ± (386.60 - 389.70) ms384.28 ± (383.11 - 385.45) ms-1.0%
process.time_to_main_ms536.10 ± (534.70 - 537.49) ms534.83 ± (533.75 - 535.91) ms-0.2%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed57.92 ± (57.71 - 58.14) MB57.28 ± (57.17 - 57.40) MB-1.1%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.5%
.NET 6 - Baseline
process.internal_duration_ms198.89 ± (198.37 - 199.41) ms195.68 ± (195.25 - 196.10) ms-1.6%
process.time_to_main_ms72.60 ± (72.36 - 72.83) ms71.47 ± (71.23 - 71.70) ms-1.6%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.31 ± (16.29 - 16.33) MB16.31 ± (16.25 - 16.37) MB+0.0%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.8%
.NET 6 - Bailout
process.internal_duration_ms198.16 ± (197.68 - 198.64) ms194.39 ± (194.03 - 194.74) ms-1.9%
process.time_to_main_ms73.43 ± (73.20 - 73.67) ms72.53 ± (72.34 - 72.71) ms-1.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.37 ± (16.35 - 16.39) MB16.44 ± (16.40 - 16.47) MB+0.4%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-1.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms583.21 ± (580.53 - 585.88) ms584.10 ± (581.65 - 586.56) ms+0.2%✅⬆️
process.time_to_main_ms547.43 ± (546.29 - 548.58) ms538.13 ± (537.21 - 539.05) ms-1.7%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed61.06 ± (60.98 - 61.14) MB61.06 ± (60.98 - 61.14) MB-0.0%
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.0%
.NET 8 - Baseline
process.internal_duration_ms197.62 ± (197.14 - 198.10) ms193.64 ± (193.19 - 194.09) ms-2.0%
process.time_to_main_ms72.12 ± (71.88 - 72.36) ms71.25 ± (70.98 - 71.52) ms-1.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.74) MB11.66 ± (11.64 - 11.68) MB-0.5%
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.8%
.NET 8 - Bailout
process.internal_duration_ms195.87 ± (195.24 - 196.49) ms192.57 ± (192.05 - 193.08) ms-1.7%
process.time_to_main_ms72.94 ± (72.71 - 73.17) ms71.83 ± (71.63 - 72.04) ms-1.5%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.81 ± (11.79 - 11.83) MB11.74 ± (11.71 - 11.76) MB-0.6%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.5%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms511.65 ± (508.87 - 514.43) ms511.07 ± (508.58 - 513.55) ms-0.1%
process.time_to_main_ms497.18 ± (496.13 - 498.22) ms490.27 ± (489.50 - 491.05) ms-1.4%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed50.70 ± (50.65 - 50.74) MB50.61 ± (50.57 - 50.65) MB-0.2%
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.8%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (74ms)  : 71, 78
    master - mean (73ms)  : 70, 77

    section Bailout
    This PR (8638) - mean (77ms)  : 74, 80
    master - mean (79ms)  : 75, 83

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (1,107ms)  : 1057, 1157
    master - mean (1,112ms)  : 1053, 1172

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (115ms)  : 110, 120
    master - mean (117ms)  : 111, 123

    section Bailout
    This PR (8638) - mean (115ms)  : 112, 119
    master - mean (116ms)  : 112, 121

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (797ms)  : 770, 823
    master - mean (794ms)  : 764, 824

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (104ms)  : 98, 111
    master - mean (102ms)  : 97, 106

    section Bailout
    This PR (8638) - mean (103ms)  : 99, 107
    master - mean (104ms)  : 99, 110

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (947ms)  : 914, 979
    master - mean (948ms)  : 896, 1000

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (100ms)  : 97, 103
    master - mean (99ms)  : 96, 102

    section Bailout
    This PR (8638) - mean (106ms)  : 102, 110
    master - mean (103ms)  : 98, 108

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (822ms)  : 788, 856
    master - mean (823ms)  : 786, 860

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (197ms)  : 192, 201
    master - mean (200ms)  : 195, 205

    section Bailout
    This PR (8638) - mean (200ms)  : 196, 205
    master - mean (203ms)  : 197, 210

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (1,187ms)  : 1146, 1229
    master - mean (1,199ms)  : 1157, 1242

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (283ms)  : 277, 289
    master - mean (286ms)  : 273, 300

    section Bailout
    This PR (8638) - mean (283ms)  : 276, 291
    master - mean (288ms)  : 281, 295

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (957ms)  : 928, 986
    master - mean (966ms)  : 937, 995

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (276ms)  : 271, 281
    master - mean (281ms)  : 270, 291

    section Bailout
    This PR (8638) - mean (275ms)  : 271, 279
    master - mean (280ms)  : 270, 290

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (1,153ms)  : 1115, 1191
    master - mean (1,161ms)  : 1117, 1205

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8638) - mean (275ms)  : 269, 281
    master - mean (280ms)  : 270, 290

    section Bailout
    This PR (8638) - mean (274ms)  : 268, 280
    master - mean (279ms)  : 269, 290

    section CallTarget+Inlining+NGEN
    This PR (8638) - mean (1,034ms)  : 985, 1082
    master - mean (1,042ms)  : 999, 1085

Loading

@pr-commenter

pr-commenter Bot commented May 14, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-22 11:36:33

Comparing candidate commit 910ea94 in PR branch nacho/fixFlakyTelemtryAgentTest with baseline commit 3125784 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

Found 6 performance improvements and 9 performance regressions! Performance is the same for 45 metrics, 12 unstable metrics, 93 known flaky benchmarks, 33 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartActiveSpan net6.0

  • 🟥 throughput [-132862.738op/s; -112504.256op/s] or [-47.933%; -40.589%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • 🟥 throughput [-112279.116op/s; -95369.062op/s] or [-41.432%; -35.192%]
  • 🟩 execution_time [-72.802ms; -55.226ms] or [-36.087%; -27.375%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan netcoreapp3.1

  • 🟩 execution_time [-111.721ms; -110.281ms] or [-55.801%; -55.082%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_GetCurrentSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • 🟥 throughput [-105025.965op/s; -99457.558op/s] or [-38.090%; -36.070%]
  • 🟩 execution_time [-70.428ms; -52.618ms] or [-35.054%; -26.190%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_SetActive net6.0

  • 🟥 throughput [-132440.571op/s; -112368.892op/s] or [-52.416%; -44.472%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_SetActive netcoreapp3.1

  • 🟩 execution_time [-108.146ms; -106.642ms] or [-54.367%; -53.611%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-5420.475op/s; -4682.301op/s] or [-6.188%; -5.345%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-73966.672op/s; -66424.732op/s] or [-50.247%; -45.123%]
  • 🟩 execution_time [-32.223ms; -16.230ms] or [-15.990%; -8.054%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-55045.664op/s; -39738.543op/s] or [-27.600%; -19.925%]
  • 🟩 execution_time [-74.475ms; -56.055ms] or [-37.664%; -28.349%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [-57.498ms; -36.591ms] or [-28.671%; -18.246%]
  • 🟥 throughput [-144743.393op/s; -124028.289op/s] or [-48.830%; -41.842%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-98.955ms; -74.058ms] or [-49.758%; -37.238%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • 🟩 execution_time [-70.675ms; -53.655ms] or [-35.157%; -26.691%]
  • 🟥 throughput [-112992.270op/s; -97642.790op/s] or [-43.488%; -37.581%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [-99.340ms; -74.323ms] or [-49.701%; -37.185%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • 🟩 execution_time [-77.130ms; -74.615ms] or [-38.284%; -37.036%]
  • 🟥 throughput [-100275.584op/s; -97391.735op/s] or [-35.089%; -34.080%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [-99.915ms; -75.229ms] or [-49.961%; -37.617%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • 🟩 execution_time [-63.446ms; -48.741ms] or [-31.719%; -24.368%]
  • 🟥 throughput [-99860.803op/s; -88538.802op/s] or [-43.314%; -38.403%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-96.727ms; -72.050ms] or [-48.628%; -36.222%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟩 execution_time [-77.426ms; -75.377ms] or [-38.742%; -37.716%]
  • 🟥 throughput [-105458.698op/s; -100587.726op/s] or [-35.579%; -33.935%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • 🟩 execution_time [-111.708ms; -110.424ms] or [-55.789%; -55.148%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • 🟩 execution_time [-67.941ms; -58.351ms] or [-33.798%; -29.028%]
  • 🟥 throughput [-136090.092op/s; -120613.277op/s] or [-45.321%; -40.167%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-99.089ms; -74.198ms] or [-49.675%; -37.196%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472

  • 🟥 throughput [-12390.476op/s; -11524.735op/s] or [-6.410%; -5.962%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • unstable execution_time [-60.776ms; -38.292ms] or [-30.110%; -18.971%]
  • 🟥 throughput [-109378.525op/s; -91457.496op/s] or [-40.168%; -33.587%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-100.366ms; -76.269ms] or [-49.893%; -37.914%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-58.497ms; -35.900ms] or [-29.249%; -17.950%]
  • 🟥 throughput [-112053.513op/s; -98141.047op/s] or [-44.866%; -39.295%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • 🟩 execution_time [-112.679ms; -110.824ms] or [-56.222%; -55.296%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-59.370ms; -24.459ms] or [-29.602%; -12.195%]
  • 🟥 throughput [-116761.981op/s; -94966.611op/s] or [-43.753%; -35.586%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • 🟩 execution_time [-112.542ms; -110.402ms] or [-56.371%; -55.299%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • unstable execution_time [-95.798ms; -72.193ms] or [-47.835%; -36.048%]
  • unstable throughput [-50107.338op/s; -32613.774op/s] or [-28.926%; -18.827%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1

  • unstable execution_time [-100.864ms; -76.311ms] or [-50.291%; -38.049%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+7.434%; +7.442%]
  • 🟩 execution_time [-54.111ms; -41.897ms] or [-27.108%; -20.989%]
  • 🟥 throughput [-104440.975op/s; -96165.260op/s] or [-47.396%; -43.641%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-98.569ms; -74.935ms] or [-49.106%; -37.332%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [-54.561ms; -34.531ms] or [-27.323%; -17.292%]
  • 🟥 throughput [-137559.280op/s; -121040.160op/s] or [-52.111%; -45.853%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • 🟩 execution_time [-114.499ms; -112.695ms] or [-56.704%; -55.810%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [-43.228ms; -19.838ms] or [-21.527%; -9.879%]
  • 🟥 throughput [-126694.901op/s; -109827.825op/s] or [-44.467%; -38.547%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-101.701ms; -77.081ms] or [-50.725%; -38.445%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-9966.453op/s; -9241.253op/s] or [-11.817%; -10.957%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • unstable execution_time [-76.311ms; -55.732ms] or [-38.072%; -27.805%]
  • unstable throughput [-40828.862op/s; -28451.886op/s] or [-34.318%; -23.915%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-53.371ms; -23.564ms] or [-26.844%; -11.852%]
  • 🟥 throughput [-6661.779op/s; -4922.543op/s] or [-6.774%; -5.005%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+317.477ms; +333.776ms] or [+157.543%; +165.632%]
  • 🟥 throughput [-57.293op/s; -44.609op/s] or [-10.308%; -8.026%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+98.002ms; +100.798ms] or [+77.427%; +79.637%]
  • 🟩 throughput [+86.732op/s; +96.436op/s] or [+11.435%; +12.715%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+83.960ms; +85.365ms] or [+74.301%; +75.545%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • unstable execution_time [-61.937ms; -40.035ms] or [-28.927%; -18.698%]
  • unstable throughput [-23199.832op/s; -8651.344op/s] or [-16.935%; -6.315%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-271739.905op/s; -267212.782op/s] or [-27.746%; -27.284%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • unstable execution_time [-73.549ms; -47.921ms] or [-32.800%; -21.371%]
  • unstable throughput [-340898.491op/s; -223396.301op/s] or [-36.419%; -23.866%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟩 execution_time [-89.593ms; -85.071ms] or [-44.721%; -42.464%]
  • 🟥 throughput [-132156.749op/s; -115910.606op/s] or [-18.988%; -16.654%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 throughput [-48890.109op/s; -45023.005op/s] or [-31.108%; -28.647%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 execution_time [-62.447ms; -46.380ms] or [-31.838%; -23.646%]
  • 🟩 throughput [+9626.282op/s; +12342.333op/s] or [+7.669%; +9.832%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • unstable execution_time [-41.078ms; -20.455ms] or [-20.310%; -10.113%]
  • unstable throughput [-601748.951op/s; -254845.722op/s] or [-20.065%; -8.498%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • unstable execution_time [-83.470ms; -58.246ms] or [-38.476%; -26.849%]
  • 🟩 throughput [+162721.466op/s; +216931.202op/s] or [+6.459%; +8.611%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.489ms; +315.358ms] or [+150.644%; +157.574%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • unstable execution_time [+151.998ms; +189.243ms] or [+76.653%; +95.436%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • unstable execution_time [+251.503ms; +290.326ms] or [+126.688%; +146.244%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.596ms; +311.118ms] or [+146.167%; +152.809%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+235.339ms; +243.662ms] or [+115.048%; +119.117%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+263.745ms; +279.227ms] or [+131.819%; +139.558%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+22.615µs; +46.330µs] or [+7.220%; +14.791%]
  • 🟥 throughput [-430.971op/s; -231.481op/s] or [-13.435%; -7.216%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.411ms; +301.485ms] or [+149.936%; +150.472%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+365.759ms; +377.762ms] or [+397.412%; +410.454%]
  • 🟥 throughput [-6862.616op/s; -6704.320op/s] or [-56.391%; -55.090%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+289.698ms; +341.018ms] or [+219.965%; +258.932%]
  • 🟥 throughput [-1270.351op/s; -1052.744op/s] or [-12.298%; -10.191%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+302.548ms; +317.081ms] or [+139.109%; +145.791%]
  • 🟥 throughput [-686.277op/s; -669.546op/s] or [-62.183%; -60.667%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-50.295ms; +83.635ms] or [-21.434%; +35.642%]
  • 🟥 throughput [-710.781op/s; -618.341op/s] or [-47.409%; -41.244%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+337.659ms; +346.276ms] or [+201.959%; +207.113%]
  • 🟥 throughput [-723.861op/s; -689.782op/s] or [-50.401%; -48.029%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-197.260µs; -184.526µs] or [-9.992%; -9.347%]
  • 🟩 throughput [+52.333op/s; +56.296op/s] or [+10.331%; +11.113%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-233.591µs; -219.449µs] or [-5.924%; -5.565%]
  • 🟩 throughput [+14.960op/s; +15.973op/s] or [+5.899%; +6.299%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+304.822ms; +316.556ms] or [+153.503%; +159.411%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+268.172ms; +283.110ms] or [+134.381%; +141.867%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+299.939ms; +306.976ms] or [+150.677%; +154.212%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+304.620ms; +317.352ms] or [+152.970%; +159.364%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+218.382ms; +239.555ms] or [+107.980%; +118.449%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+303.142ms; +310.162ms] or [+153.646%; +157.204%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+303.305ms; +317.571ms] or [+152.232%; +159.392%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • unstable execution_time [+212.814ms; +281.005ms] or [+106.068%; +140.055%]
  • 🟩 throughput [+36039.377op/s; +47833.411op/s] or [+7.156%; +9.498%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+302.732ms; +309.554ms] or [+150.607%; +154.000%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-205787.295op/s; -189780.695op/s] or [-56.453%; -52.062%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • unstable execution_time [-72.265ms; -44.268ms] or [-36.249%; -22.205%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-24.535KB; -24.512KB] or [-8.950%; -8.941%]
  • unstable execution_time [-66.478µs; -11.740µs] or [-13.139%; -2.320%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 execution_time [-88.225µs; -32.576µs] or [-15.289%; -5.645%]
  • 🟩 throughput [+117.820op/s; +269.344op/s] or [+6.731%; +15.388%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472

  • 🟥 allocated_mem [+8.190KB; +8.196KB] or [+16.663%; +16.675%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+4.019µs; +9.796µs] or [+9.500%; +23.154%]
  • 🟥 throughput [-4085.601op/s; -1944.672op/s] or [-17.199%; -8.186%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-11.588µs; -0.966µs] or [-17.979%; -1.499%]
  • unstable throughput [+591.076op/s; +2659.295op/s] or [+3.626%; +16.316%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.608ms; +317.397ms] or [+153.461%; +160.430%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.712ms; +310.945ms] or [+154.588%; +158.270%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+301.867ms; +307.209ms] or [+151.122%; +153.796%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-61.567ms; -31.941ms] or [-30.774%; -15.965%]
  • unstable throughput [-206566.288op/s; -128981.882op/s] or [-39.099%; -24.414%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-53.785ms; -23.645ms] or [-27.263%; -11.985%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.464ms; +315.442ms] or [+150.252%; +157.219%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+266.128ms; +296.684ms] or [+133.637%; +148.981%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+307.501ms; +313.355ms] or [+155.945%; +158.914%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.668ms; +301.375ms] or [+149.975%; +150.327%]
  • 🟩 throughput [+59772970.645op/s; +60043745.654op/s] or [+43.530%; +43.728%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+375.905ms; +388.333ms] or [+467.504%; +482.961%]
  • 🟥 throughput [-7367.577op/s; -7160.630op/s] or [-56.955%; -55.355%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+301.271ms; +303.665ms] or [+150.267%; +151.461%]
  • 🟥 throughput [-30360184.414op/s; -29053990.117op/s] or [-13.448%; -12.869%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 execution_time [-102.536ms; -101.085ms] or [-50.221%; -49.510%]
  • 🟩 throughput [+78023.191op/s; +90928.637op/s] or [+7.285%; +8.490%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • unstable execution_time [-87.097ms; -65.055ms] or [-44.071%; -32.918%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-65.631ms; -41.022ms] or [-34.194%; -21.373%]
  • unstable throughput [-242907.145op/s; -65266.739op/s] or [-18.801%; -5.052%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-92.094ms; -69.890ms] or [-45.247%; -34.338%]
  • 🟩 throughput [+72528.473op/s; +80476.737op/s] or [+7.203%; +7.993%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • unstable execution_time [-71.029ms; -42.889ms] or [-35.472%; -21.419%]
  • unstable throughput [-43617.277op/s; +23610.751op/s] or [-7.920%; +4.287%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • unstable execution_time [-70.135ms; -43.362ms] or [-35.238%; -21.787%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-81.614ms; -52.476ms] or [-40.821%; -26.247%]
  • unstable throughput [-94082.422op/s; +25197.754op/s] or [-10.511%; +2.815%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-33.316ms; -9.777ms] or [-16.921%; -4.966%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

@NachoEchevarria NachoEchevarria changed the title fix(tests): serialize RuntimeIdTests and HttpHeaderHelperTests to remove telemetry header flake Serialize RuntimeIdTests and HttpHeaderHelperTests to remove telemetry header flake May 18, 2026
@NachoEchevarria
NachoEchevarria marked this pull request as ready for review May 22, 2026 08:51
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner May 22, 2026 08:51
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 22, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/apm-reliability/dd-trace-dotnet | check-big-regressions   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Execution of Regression Check failed with exit code 5.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 910ea94 | Docs | Datadog PR Page | Give us feedback!

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we only need it on RuntimeIdTests though. And I'd rather we instead re-wrote RuntimeId to not be inherently flaky 😭

Comment thread tracer/test/Datadog.Trace.Tests/Util/RuntimeIdTests.cs Outdated
Comment thread tracer/test/Datadog.Trace.Tests/HttpOverStreams/HttpHeaderHelperTests.cs Outdated
@NachoEchevarria

Copy link
Copy Markdown
Collaborator Author

Thanks, I think we only need it on RuntimeIdTests though. And I'd rather we instead re-wrote RuntimeId to not be inherently flaky 😭

Sure! I will take it as a pending task that could be addressed in a subsequent PR.

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NachoEchevarria
NachoEchevarria merged commit fcebc68 into master May 29, 2026
136 of 138 checks passed
@NachoEchevarria
NachoEchevarria deleted the nacho/fixFlakyTelemtryAgentTest branch May 29, 2026 14:57
@github-actions github-actions Bot added this to the vNext-v3 milestone May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tests unit tests, integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants