Use ArtifactsOutput in more places in the tracer build#8636
Merged
Conversation
andrewlock
added
the
area:builds
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 154f7620e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8636) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (73ms) : 70, 76
master - mean (73ms) : 70, 75
section Bailout
This PR (8636) - mean (79ms) : 75, 82
master - mean (79ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8636) - mean (1,107ms) : 1056, 1158
master - mean (1,111ms) : 1049, 1173
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (115ms) : 109, 121
master - mean (116ms) : 110, 122
section Bailout
This PR (8636) - mean (117ms) : 113, 122
master - mean (117ms) : 112, 122
section CallTarget+Inlining+NGEN
This PR (8636) - mean (796ms) : 771, 820
master - mean (788ms) : 761, 814
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (104ms) : 99, 109
master - mean (102ms) : 97, 107
section Bailout
This PR (8636) - mean (102ms) : 99, 104
master - mean (106ms) : 99, 113
section CallTarget+Inlining+NGEN
This PR (8636) - mean (945ms) : 909, 981
master - mean (948ms) : 909, 986
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (101ms) : 96, 106
master - mean (100ms) : 95, 104
section Bailout
This PR (8636) - mean (104ms) : 99, 108
master - mean (102ms) : 97, 107
section CallTarget+Inlining+NGEN
This PR (8636) - mean (822ms) : 785, 858
master - mean (824ms) : 787, 861
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (197ms) : 192, 201
master - mean (196ms) : 191, 201
section Bailout
This PR (8636) - mean (200ms) : 195, 204
master - mean (200ms) : 195, 206
section CallTarget+Inlining+NGEN
This PR (8636) - mean (1,189ms) : 1149, 1228
master - mean (1,192ms) : 1156, 1229
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (283ms) : 276, 290
master - mean (286ms) : 280, 291
section Bailout
This PR (8636) - mean (283ms) : 277, 290
master - mean (286ms) : 279, 292
section CallTarget+Inlining+NGEN
This PR (8636) - mean (954ms) : 928, 981
master - mean (954ms) : 928, 981
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (273ms) : 264, 282
master - mean (275ms) : 268, 283
section Bailout
This PR (8636) - mean (273ms) : 265, 281
master - mean (275ms) : 268, 283
section CallTarget+Inlining+NGEN
This PR (8636) - mean (1,155ms) : 1125, 1185
master - mean (1,150ms) : 1111, 1189
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8636) - mean (274ms) : 265, 283
master - mean (275ms) : 268, 282
section Bailout
This PR (8636) - mean (275ms) : 271, 279
master - mean (275ms) : 269, 281
section CallTarget+Inlining+NGEN
This PR (8636) - mean (1,036ms) : 991, 1082
master - mean (1,034ms) : 994, 1073
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This comment has been minimized.
This comment has been minimized.
andrewlock
force-pushed
the
andrew/artifacts-output
branch
from
May 20, 2026 10:49
cfc8e0e to
1a01b26
Compare
andrewlock
changed the title
UseArtifactsOutput in more places in the tracer buildArtifactsOutput in more places in the tracer build
andrewlock
force-pushed
the
andrew/artifacts-output
branch
2 times, most recently
from
May 22, 2026 15:20
0071aa7 to
ae4148d
Compare
This was referenced May 22, 2026
BenchmarksBenchmark execution time: 2026-05-28 10:44:24 Comparing candidate commit 303ef9e in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
andrewlock
force-pushed
the
andrew/artifacts-output
branch
2 times, most recently
from
May 26, 2026 11:26
7578ab7 to
7317090
Compare
zacharycmontoya
approved these changes
May 27, 2026
andrewlock
force-pushed
the
andrew/artifacts-output
branch
from
May 28, 2026 09:54
7317090 to
303ef9e
Compare
andrewlock
enabled auto-merge (squash)
May 28, 2026 10:48
andrewlock
added a commit
that referenced
this pull request
Jun 1, 2026
## Summary of changes Follows on from #8636, moves more build outputs into the artifacts folder ## Reason for change Today, build outputs end up scattered throughput the repository, because of how the defaults work for .NET, and how we're using a very "bespoke" way of building (i.e. we're not just doing `dotnet build`). That makes it tricky to track where things are built to in CI particularly, and will hamper any attempts to modify CI (e.g. to move to GitLab). ## Implementation details Had 🤖 look for everything that wasn't going to the `artifacts/` folder, and move it, so that we can more easily include/exclude it from artifacts. Took a _relatively_ conservative approach in places (e.g. to the profiler assets) Final results look like this: ``` artifacts/ ├─📂 bin/ ├─📂 obj/ ├─📂 publish/ ├─📂 package/ ├─📂 build_data/ ├─📂 monitoring-home/ ├─📂 native-bin/ ├─📂 native-obj/ ├─📂 native-symbols/ ├─📂 ProfilerResources/ ├─📂 profiler-build/ ├─📂 output/ ├─📂 deps/ └─📂 vcpkg/ ``` The important thing is that we can exclude most of these when doing the "upload working directory" step ## Test coverage This is the test - if the build still passes I think we're ok. ## Other details Stacked on - #8610 - #8636 --------- Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
andrewlock
added a commit
that referenced
this pull request
Jun 1, 2026
## Summary of changes Update all the launchsettings.json to point to the new output path in #8680 ## Reason for change We moved the default output folder in #8680, but there were already enough changes in that PR, so I didn't want to clutter it up with these simple changes. ## Implementation details 🤖 converted `shared\bin` to `artifacts` ## Test coverage N/A - it's only for local testing (personally I would probably remove all of these files completely, but some people like them) ## Other details Stacked on - #8610 - #8636 - #8680 --------- Co-authored-by: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Set
UseArtifactsOutputfor alltracer/librariesReason for change
UseArtifactsOutputputs all the build output nested in a top-level directory. We are already using this for samples and in some places. This PR extends it to use in more of the tracer build.The advantage of this approach is it neatly scopes the output of a stage in the
artifacts/bin,artifacts/objorartifacts/packagesfolder (for example). This is convenient in general (I use artifact layout in personal projects wherever possible), but it's particularly useful in CI, especially if/when we need to migrate the build to gitlab.Implementation details
Get the 🤖 to make the change. As long as CI keeps working, we can still build locally, and the artifacts look the same, ultimately, we're good 👍
Test coverage
This is the test. Also had the agent do some analysis of the artifacts to make sure it's ok, and tested locally.
Other details
Stacked on:
Datadog.Trace.Build.g.slnto reduce size of artifacts copied between stages #8610Will add more to the stack (e.g. profiling assets later)
Requires: