Skip to content

Small improvements to ObjectExtensions class#863

Merged
zacharycmontoya merged 5 commits into
masterfrom
zach/tests/managed-profiler-reflection-tests
Aug 28, 2020
Merged

Small improvements to ObjectExtensions class#863
zacharycmontoya merged 5 commits into
masterfrom
zach/tests/managed-profiler-reflection-tests

Conversation

@zacharycmontoya

Copy link
Copy Markdown
Contributor
  • Add unit tests to make sure the CallMethod overloads work with different specified return types
  • Add fix to include the return type in CallMethod cache keys
  • Remove unused CreatePropertyDelegate

@DataDog/apm-dotnet

…rn types is specified, the second call will fail to match the cached version and return a default value. Instead, use the return type in the cache key to map the two different invocations to different delegates.
@zacharycmontoya zacharycmontoya added area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:tests unit tests, integration tests labels Aug 17, 2020
@zacharycmontoya
zacharycmontoya requested a review from a team as a code owner August 17, 2020 23:15
@zacharycmontoya zacharycmontoya self-assigned this Aug 17, 2020
}

[Fact]
public void CallMethod_OneTypeArg_WithDifferentReturnType_ShouldNotAffectResult()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zacharycmontoya
zacharycmontoya merged commit 0ead03c into master Aug 28, 2020
@zacharycmontoya
zacharycmontoya deleted the zach/tests/managed-profiler-reflection-tests branch August 28, 2020 02:18
@zacharycmontoya zacharycmontoya added this to the 1.19.2 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) area:tests unit tests, integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants