Tag gitlab include refs as migration touchpoints#8624
Merged
Conversation
NachoEchevarria
changed the title
include: refs + finish DDOCTOSTS_SCOPE
NachoEchevarria
changed the title
include: refs + finish DDOCTOSTS_SCOPE
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8624) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (73ms) : 71, 75
master - mean (73ms) : 70, 77
section Bailout
This PR (8624) - mean (80ms) : 76, 84
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (8624) - mean (1,113ms) : 1062, 1164
master - mean (1,112ms) : 1053, 1172
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (117ms) : 111, 123
master - mean (117ms) : 111, 123
section Bailout
This PR (8624) - mean (118ms) : 111, 125
master - mean (116ms) : 112, 121
section CallTarget+Inlining+NGEN
This PR (8624) - mean (792ms) : 769, 815
master - mean (794ms) : 764, 824
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (105ms) : 100, 109
master - mean (102ms) : 97, 106
section Bailout
This PR (8624) - mean (102ms) : 99, 105
master - mean (104ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8624) - mean (945ms) : 911, 979
master - mean (948ms) : 896, 1000
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (101ms) : 95, 107
master - mean (99ms) : 96, 102
section Bailout
This PR (8624) - mean (104ms) : 99, 109
master - mean (103ms) : 98, 108
section CallTarget+Inlining+NGEN
This PR (8624) - mean (821ms) : 788, 854
master - mean (823ms) : 786, 860
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (198ms) : 193, 203
master - mean (200ms) : 195, 205
section Bailout
This PR (8624) - mean (201ms) : 197, 205
master - mean (203ms) : 197, 210
section CallTarget+Inlining+NGEN
This PR (8624) - mean (1,183ms) : 1147, 1219
master - mean (1,199ms) : 1157, 1242
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (283ms) : 275, 291
master - mean (286ms) : 273, 300
section Bailout
This PR (8624) - mean (283ms) : 277, 289
master - mean (288ms) : 281, 295
section CallTarget+Inlining+NGEN
This PR (8624) - mean (950ms) : 932, 969
master - mean (966ms) : 937, 995
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (275ms) : 268, 281
master - mean (281ms) : 270, 291
section Bailout
This PR (8624) - mean (276ms) : 270, 281
master - mean (280ms) : 270, 290
section CallTarget+Inlining+NGEN
This PR (8624) - mean (1,150ms) : 1104, 1195
master - mean (1,161ms) : 1117, 1205
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8624) - mean (275ms) : 270, 281
master - mean (280ms) : 270, 290
section Bailout
This PR (8624) - mean (274ms) : 270, 277
master - mean (279ms) : 269, 290
section CallTarget+Inlining+NGEN
This PR (8624) - mean (1,027ms) : 979, 1075
master - mean (1,042ms) : 999, 1085
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-13 10:54:20 Comparing candidate commit 59c92d7 in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 4 performance improvements and 3 performance regressions! Performance is the same for 48 metrics, 17 unstable metrics, 86 known flaky benchmarks, 40 flaky benchmarks without significant changes.
|
NachoEchevarria
marked this pull request as ready for review
May 22, 2026 08:53
Contributor
|
andrewlock
approved these changes
May 26, 2026
zacharycmontoya
approved these changes
May 27, 2026
NachoEchevarria
added
the
area:builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Follow-up to #8426.
DDOCTOSTS_SCOPEinmacrobenchmarks.yml.include: project: 'DataDog/...'lines asMIGRATION TOUCHPOINTs. These can't be parameterized — GitLab evaluatesinclude:before top-levelvariables:is in scope (docs) — so the comments make them greppable at cutover.Reason for change
GitHub org / GitLab group split mitigation.
Implementation details
.gitlab-ci.yml:14and.gitlab/benchmarks/macrobenchmarks.yml:1— touchpoint comments..gitlab/benchmarks/macrobenchmarks.yml:577—DDOCTOSTS_SCOPE→"${GITHUB_ORG_INTERNAL}/benchmarking-platform".Test coverage
No behavior change:
GITHUB_ORG_INTERNALdefaults toDataDog.Other details
Non-URL mitigations (runners, registry,
id_tokens, schedules/secrets recreation) need infra coordination and are out of scope.