Skip to content

Fix WAF Encoder child miscount bug#8617

Merged
andrewlock merged 4 commits into
masterfrom
andrew/fix-waf-encoder-mismatch
May 26, 2026
Merged

Fix WAF Encoder child miscount bug#8617
andrewlock merged 4 commits into
masterfrom
andrew/fix-waf-encoder-mismatch

Conversation

@andrewlock

@andrewlock andrewlock commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

Fixes a miscount issue with the WAF encoder

Reason for change

#5587 refactored the WAF encoder code, but there's a bug. ProcessKeyValuePairs calculates childrenCount once, calls EnumerateIDictionaryItems, and then sets NbEntries using the unmodified childrenCount. EnumerateIDictionaryItems skips empty keys, and decrements childrenCount, but it's working on a local copy of the value, so ProcessKeyValuePairs doesn't see the change, meaning it sends too high a value in ddWafObjectMap.NbEntries

Implementation details

Pass childrenCount by ref, so that decrementing it correctly decrements the "global" value.

Test coverage

Added some unit tests that demonstrate the issue. These caused errors in the LegacyEncoder paths which similarly were addressed. The change in the snapshots is due to now skipping empty keys

Other details

This was 🤖 identified - I find this code pretty hard to follow, so please do sense check that the change actually makes sense 😅

@andrewlock
andrewlock requested a review from a team as a code owner May 12, 2026 16:58
@pr-commenter

pr-commenter Bot commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-13 14:21:31

Comparing candidate commit a421430 in PR branch andrew/fix-waf-encoder-mismatch with baseline commit 5a188d7 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472

Found 6 performance improvements and 2 performance regressions! Performance is the same for 48 metrics, 16 unstable metrics, 89 known flaky benchmarks, 37 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]
  • 🟩 throughput [+13811.180op/s; +28894.992op/s] or [+8.736%; +18.278%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-63755.992op/s; -58058.362op/s] or [-43.311%; -39.440%]
  • 🟩 execution_time [-52.716ms; -41.526ms] or [-26.160%; -20.607%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟩 execution_time [-99.235ms; -97.144ms] or [-49.557%; -48.513%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-39911.101op/s; -35279.043op/s] or [-20.012%; -17.689%]
  • 🟩 execution_time [-85.624ms; -81.513ms] or [-43.303%; -41.223%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-94.625ms; -90.863ms] or [-48.156%; -46.242%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [+42.383ms; +75.567ms] or [+30.502%; +54.383%]
  • unstable throughput [-45324.664op/s; -16306.269op/s] or [-26.002%; -9.355%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [+6.348ms; +31.393ms] or [+6.826%; +33.757%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-1.812ms; +15.340ms] or [-1.375%; +11.638%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [-15.046ms; +19.673ms] or [-13.662%; +17.864%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-25.893ms; -6.806ms] or [-18.153%; -4.772%]
  • unstable throughput [+475.318op/s; +17899.358op/s] or [+0.277%; +10.427%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [+10.621ms; +34.878ms] or [+11.769%; +38.650%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [+26.505ms; +65.547ms] or [+19.210%; +47.506%]
  • unstable throughput [-36336.168op/s; -15860.181op/s] or [-25.626%; -11.185%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-34.991ms; -9.901ms] or [-30.443%; -8.614%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [-11.954ms; +40.877ms] or [-6.495%; +22.208%]
  • unstable throughput [-32250.235op/s; +4279.842op/s] or [-21.815%; +2.895%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [+27.198ms; +58.027ms] or [+29.857%; +63.700%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [+14.655ms; +41.379ms] or [+10.416%; +29.409%]
  • unstable throughput [-36308.254op/s; -15994.117op/s] or [-19.271%; -8.489%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [+8.675ms; +33.249ms] or [+9.462%; +36.266%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]
  • unstable execution_time [-77.791ms; -37.771ms] or [-39.310%; -19.087%]
  • unstable throughput [+26876.198op/s; +55865.056op/s] or [+21.222%; +44.112%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [+7.900ms; +31.781ms] or [+8.434%; +33.933%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+8.332%; +8.340%]
  • unstable execution_time [-28.142ms; -2.057ms] or [-18.127%; -1.325%]
  • unstable throughput [-4868.899op/s; +12688.545op/s] or [-3.445%; +8.979%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [-33.325ms; -9.426ms] or [-29.803%; -8.430%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [+9.787ms; +47.954ms] or [+7.200%; +35.278%]
  • unstable throughput [-29176.563op/s; -1248.350op/s] or [-18.159%; -0.777%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [-37.557ms; -12.917ms] or [-33.130%; -11.394%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-5.210%; -5.202%]
  • unstable execution_time [-42.889ms; -12.271ms] or [-27.299%; -7.811%]
  • unstable throughput [+12890.388op/s; +34895.078op/s] or [+13.738%; +37.190%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [+4.343ms; +18.523ms] or [+3.111%; +13.267%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-23.289ms; +19.323ms] or [-17.012%; +14.115%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+9.570%; +9.578%]
  • unstable execution_time [+2.382ms; +20.617ms] or [+1.890%; +16.360%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [+8.245ms; +34.043ms] or [+9.206%; +38.011%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • 🟥 allocated_mem [+95 bytes; +96 bytes] or [+6.738%; +6.746%]
  • unstable execution_time [-25.993ms; -8.479ms] or [-18.319%; -5.976%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-60.636ms; -30.677ms] or [-44.771%; -22.650%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-8710.971op/s; -8037.760op/s] or [-10.329%; -9.530%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟩 execution_time [-78.132ms; -64.162ms] or [-38.980%; -32.011%]
  • 🟥 throughput [-35993.129op/s; -25973.068op/s] or [-30.254%; -21.831%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-72.696ms; -44.181ms] or [-36.564%; -22.222%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+317.077ms; +333.038ms] or [+157.345%; +165.265%]
  • 🟥 throughput [-56.797op/s; -44.062op/s] or [-10.219%; -7.928%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+109.355ms; +156.448ms] or [+86.397%; +123.604%]
  • unstable throughput [-12.419op/s; +68.437op/s] or [-1.637%; +9.023%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+85.638ms; +87.184ms] or [+75.787%; +77.155%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • unstable execution_time [-60.331ms; -33.854ms] or [-28.177%; -15.811%]
  • unstable throughput [-26417.791op/s; -9564.283op/s] or [-19.283%; -6.981%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]
  • 🟩 execution_time [-63.487ms; -42.932ms] or [-30.232%; -20.444%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-279490.726op/s; -265278.423op/s] or [-28.537%; -27.086%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • unstable execution_time [-87.753ms; -55.485ms] or [-39.134%; -24.744%]
  • unstable throughput [-271713.907op/s; -141855.002op/s] or [-29.028%; -15.155%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • unstable execution_time [-61.769ms; -37.842ms] or [-30.832%; -18.889%]
  • 🟥 throughput [-130496.814op/s; -113986.497op/s] or [-18.750%; -16.378%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 throughput [-35088.603op/s; -20284.158op/s] or [-22.326%; -12.906%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • unstable execution_time [-35.029ms; -15.135ms] or [-17.859%; -7.716%]
  • 🟩 throughput [+11152.258op/s; +13855.610op/s] or [+8.884%; +11.038%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-55.069ms; -37.769ms] or [-27.228%; -18.674%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.191ms; -13.774ms] or [-8.386%; -6.349%]
  • 🟩 throughput [+147618.053op/s; +202490.735op/s] or [+5.859%; +8.037%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.462ms; +315.247ms] or [+150.630%; +157.518%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • unstable execution_time [+146.030ms; +185.901ms] or [+73.643%; +93.750%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • unstable execution_time [+252.674ms; +291.095ms] or [+127.277%; +146.631%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+299.878ms; +313.648ms] or [+147.288%; +154.051%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+254.895ms; +274.250ms] or [+124.609%; +134.071%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+290.834ms; +303.360ms] or [+145.358%; +151.619%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+19.525µs; +43.281µs] or [+6.233%; +13.817%]
  • 🟥 throughput [-405.377op/s; -205.503op/s] or [-12.637%; -6.406%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.074ms; +301.119ms] or [+149.768%; +150.289%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+357.542ms; +377.791ms] or [+388.484%; +410.485%]
  • 🟥 throughput [-7012.204op/s; -6789.251op/s] or [-57.620%; -55.788%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+206.360ms; +289.206ms] or [+156.687%; +219.591%]
  • 🟥 throughput [-1163.471op/s; -929.883op/s] or [-11.263%; -9.002%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+296.686ms; +313.337ms] or [+136.413%; +144.069%]
  • 🟥 throughput [-682.573op/s; -664.843op/s] or [-61.848%; -60.241%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-47.606ms; +86.377ms] or [-20.288%; +36.810%]
  • 🟥 throughput [-719.517op/s; -626.459op/s] or [-47.992%; -41.785%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+339.152ms; +347.086ms] or [+202.852%; +207.598%]
  • 🟥 throughput [-731.773op/s; -697.546op/s] or [-50.952%; -48.569%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-60.784µs; -54.115µs] or [-5.637%; -5.019%]
  • 🟩 throughput [+49.210op/s; +55.298op/s] or [+5.306%; +5.962%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-186.458µs; -165.379µs] or [-9.445%; -8.377%]
  • 🟩 throughput [+46.537op/s; +53.059op/s] or [+9.187%; +10.474%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+304.505ms; +317.162ms] or [+153.343%; +159.717%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • unstable execution_time [+162.172ms; +207.055ms] or [+81.265%; +103.756%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+300.876ms; +306.994ms] or [+151.147%; +154.221%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.594ms; +314.658ms] or [+152.455%; +158.011%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+214.521ms; +238.381ms] or [+106.071%; +117.869%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+305.199ms; +312.090ms] or [+154.688%; +158.181%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+305.177ms; +315.994ms] or [+153.171%; +158.600%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • unstable execution_time [+209.043ms; +277.395ms] or [+104.189%; +138.256%]
  • 🟩 throughput [+41009.854op/s; +51752.526op/s] or [+8.143%; +10.276%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+301.011ms; +306.861ms] or [+149.750%; +152.661%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • unstable execution_time [-64.057ms; -25.581ms] or [-29.787%; -11.895%]
  • unstable throughput [-140689.947op/s; -81230.174op/s] or [-38.595%; -22.284%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-100.967ms; -96.373ms] or [-50.647%; -48.342%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-23.614KB; -23.592KB] or [-8.614%; -8.606%]
  • unstable execution_time [-75.687µs; -20.542µs] or [-14.959%; -4.060%]
  • 🟩 throughput [+103.211op/s; +302.823op/s] or [+5.150%; +15.111%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+3.258µs; +8.077µs] or [+7.701%; +19.091%]
  • 🟥 throughput [-3643.679op/s; -1684.829op/s] or [-15.339%; -7.093%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.911µs; -4.683µs] or [-21.582%; -7.266%]
  • unstable throughput [+1409.117op/s; +3376.360op/s] or [+8.645%; +20.715%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+305.435ms; +319.620ms] or [+154.384%; +161.553%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+304.049ms; +310.453ms] or [+154.760%; +158.020%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.620ms; +306.517ms] or [+150.497%; +153.450%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-91.246ms; -65.963ms] or [-45.609%; -32.971%]
  • unstable throughput [-117118.016op/s; -55217.782op/s] or [-22.168%; -10.452%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-56.666ms; -25.774ms] or [-28.724%; -13.065%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.042ms; +314.267ms] or [+149.544%; +156.634%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+262.722ms; +293.100ms] or [+131.926%; +147.181%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.475ms; +307.141ms] or [+152.382%; +155.762%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.382ms; +301.002ms] or [+149.832%; +150.141%]
  • 🟩 throughput [+59857945.448op/s; +60139473.071op/s] or [+43.592%; +43.797%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+375.295ms; +386.685ms] or [+466.746%; +480.911%]
  • 🟥 throughput [-7428.214op/s; -7232.190op/s] or [-57.424%; -55.908%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+302.601ms; +304.858ms] or [+150.930%; +152.056%]
  • 🟥 throughput [-30201149.507op/s; -29034074.969op/s] or [-13.377%; -12.860%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • unstable execution_time [-56.317ms; -29.083ms] or [-27.583%; -14.244%]
  • unstable throughput [-217461.705op/s; -68324.160op/s] or [-20.304%; -6.379%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • unstable execution_time [-92.058ms; -68.451ms] or [-46.582%; -34.636%]
  • 🟩 throughput [+50581.063op/s; +71126.928op/s] or [+5.855%; +8.233%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-65.922ms; -41.204ms] or [-34.346%; -21.467%]
  • unstable throughput [-248196.631op/s; -69808.710op/s] or [-19.211%; -5.403%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-57.486ms; -29.922ms] or [-28.244%; -14.701%]
  • 🟩 throughput [+63743.056op/s; +85157.682op/s] or [+6.331%; +8.458%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-99.329ms; -97.409ms] or [-49.604%; -48.646%]
  • 🟩 throughput [+39371.581op/s; +45537.489op/s] or [+7.149%; +8.269%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • unstable execution_time [-90.964ms; -68.882ms] or [-45.704%; -34.609%]
  • 🟩 throughput [+23074.674op/s; +32828.052op/s] or [+5.165%; +7.348%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-100.515ms; -76.518ms] or [-50.275%; -38.273%]
  • unstable throughput [-97891.321op/s; +16444.269op/s] or [-10.937%; +1.837%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-72.283ms; -44.675ms] or [-36.712%; -22.690%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 12, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8617) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.49 ± (73.49 - 73.98) ms74.49 ± (74.41 - 75.00) ms+1.4%✅⬆️
.NET Framework 4.8 - Bailout
duration77.40 ± (77.43 - 77.82) ms78.18 ± (78.13 - 78.65) ms+1.0%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1096.73 ± (1096.06 - 1104.64) ms1095.05 ± (1093.99 - 1101.52) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.60 ± (22.56 - 22.64) ms22.74 ± (22.68 - 22.81) ms+0.6%✅⬆️
process.time_to_main_ms84.92 ± (84.73 - 85.11) ms86.33 ± (86.03 - 86.62) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.91 - 10.92) MB10.92 ± (10.91 - 10.92) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.51 ± (22.46 - 22.55) ms22.46 ± (22.41 - 22.50) ms-0.2%✅
process.time_to_main_ms87.04 ± (86.80 - 87.29) ms86.32 ± (86.11 - 86.54) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.96) MB10.96 ± (10.95 - 10.96) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.76 ± (211.93 - 213.59) ms214.57 ± (213.84 - 215.30) ms+0.8%✅⬆️
process.time_to_main_ms538.15 ± (536.75 - 539.56) ms540.85 ± (539.44 - 542.27) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.45 ± (48.42 - 48.48) MB48.29 ± (48.26 - 48.32) MB-0.3%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.78 ± (21.71 - 21.86) ms21.18 ± (21.14 - 21.21) ms-2.8%✅
process.time_to_main_ms77.16 ± (76.85 - 77.47) ms73.45 ± (73.26 - 73.64) ms-4.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.59 ± (10.59 - 10.59) MB10.61 ± (10.61 - 10.62) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.17 ± (21.12 - 21.21) ms21.05 ± (21.02 - 21.08) ms-0.5%✅
process.time_to_main_ms75.11 ± (74.88 - 75.35) ms74.23 ± (74.05 - 74.41) ms-1.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.72 ± (10.72 - 10.72) MB10.73 ± (10.73 - 10.73) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms378.22 ± (376.40 - 380.04) ms378.51 ± (376.30 - 380.73) ms+0.1%✅⬆️
process.time_to_main_ms536.60 ± (535.32 - 537.88) ms538.35 ± (537.04 - 539.65) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.77 ± (49.74 - 49.79) MB49.90 ± (49.88 - 49.93) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.62 ± (19.57 - 19.67) ms19.85 ± (19.79 - 19.92) ms+1.2%✅⬆️
process.time_to_main_ms73.89 ± (73.61 - 74.17) ms75.45 ± (75.16 - 75.74) ms+2.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.66) MB7.65 ± (7.65 - 7.66) MB-0.0%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.96 ± (19.89 - 20.02) ms19.55 ± (19.51 - 19.60) ms-2.0%✅
process.time_to_main_ms77.36 ± (77.06 - 77.67) ms74.98 ± (74.80 - 75.17) ms-3.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.70 ± (7.70 - 7.71) MB7.70 ± (7.69 - 7.70) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms299.33 ± (296.98 - 301.68) ms296.85 ± (294.37 - 299.32) ms-0.8%✅
process.time_to_main_ms496.00 ± (494.90 - 497.10) ms499.24 ± (498.00 - 500.48) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.88 ± (36.85 - 36.91) MB36.88 ± (36.85 - 36.91) MB-0.0%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.1%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration191.95 ± (191.79 - 192.44) ms190.03 ± (190.00 - 190.75) ms-1.0%✅
.NET Framework 4.8 - Bailout
duration195.02 ± (194.99 - 195.43) ms193.15 ± (193.12 - 193.41) ms-1.0%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1162.89 ± (1163.67 - 1168.78) ms1160.26 ± (1161.72 - 1167.65) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms185.06 ± (184.78 - 185.34) ms184.17 ± (183.90 - 184.44) ms-0.5%✅
process.time_to_main_ms80.58 ± (80.43 - 80.73) ms80.12 ± (79.93 - 80.31) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.17 ± (16.14 - 16.20) MB16.16 ± (16.10 - 16.21) MB-0.1%✅
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 20)-0.4%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms185.22 ± (184.79 - 185.65) ms183.07 ± (182.86 - 183.28) ms-1.2%✅
process.time_to_main_ms82.50 ± (82.29 - 82.71) ms80.96 ± (80.84 - 81.07) ms-1.9%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.14 - 16.18) MB16.00 ± (15.88 - 16.12) MB-1.0%✅
runtime.dotnet.threads.count21 ± (20 - 21)20 ± (20 - 20)-2.8%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms379.81 ± (378.60 - 381.03) ms374.97 ± (373.88 - 376.07) ms-1.3%✅
process.time_to_main_ms520.17 ± (519.08 - 521.26) ms515.90 ± (515.00 - 516.79) ms-0.8%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.03 ± (56.97 - 57.09) MB57.06 ± (57.00 - 57.12) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms190.29 ± (189.88 - 190.70) ms188.46 ± (188.16 - 188.76) ms-1.0%✅
process.time_to_main_ms70.48 ± (70.25 - 70.71) ms69.79 ± (69.64 - 69.94) ms-1.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.93 ± (15.77 - 16.09) MB15.91 ± (15.73 - 16.08) MB-0.1%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (17 - 18)-2.9%✅
.NET 6 - Bailout
process.internal_duration_ms194.42 ± (193.96 - 194.88) ms187.60 ± (187.38 - 187.81) ms-3.5%✅
process.time_to_main_ms73.15 ± (72.96 - 73.34) ms70.37 ± (70.29 - 70.46) ms-3.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.37 ± (16.34 - 16.39) MB16.00 ± (15.82 - 16.18) MB-2.2%✅
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-6.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms583.90 ± (580.16 - 587.64) ms580.25 ± (576.03 - 584.47) ms-0.6%✅
process.time_to_main_ms515.02 ± (514.07 - 515.98) ms512.80 ± (511.92 - 513.68) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.05 ± (60.97 - 61.14) MB61.15 ± (61.06 - 61.23) MB+0.2%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms189.17 ± (188.75 - 189.60) ms185.63 ± (185.42 - 185.84) ms-1.9%✅
process.time_to_main_ms70.18 ± (70.01 - 70.34) ms68.78 ± (68.66 - 68.90) ms-2.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.74) MB11.69 ± (11.60 - 11.78) MB-0.2%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (17 - 18)-3.4%✅
.NET 8 - Bailout
process.internal_duration_ms191.05 ± (190.40 - 191.69) ms184.82 ± (184.65 - 184.99) ms-3.3%✅
process.time_to_main_ms72.27 ± (72.04 - 72.50) ms69.75 ± (69.68 - 69.81) ms-3.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.77 ± (11.75 - 11.78) MB11.59 ± (11.50 - 11.69) MB-1.5%✅
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (18 - 19)-3.8%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms511.44 ± (508.81 - 514.07) ms510.36 ± (507.93 - 512.78) ms-0.2%✅
process.time_to_main_ms478.03 ± (477.07 - 478.99) ms477.53 ± (476.60 - 478.46) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.62 ± (50.59 - 50.66) MB50.58 ± (50.55 - 50.62) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.5%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (75ms)  : 70, 79
    master - mean (74ms)  : 70, 77

    section Bailout
    This PR (8617) - mean (78ms)  : 74, 82
    master - mean (78ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (1,098ms)  : 1041, 1155
    master - mean (1,100ms)  : 1038, 1163
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (116ms)  : 110, 122
    master - mean (114ms)  : 111, 118

    section Bailout
    This PR (8617) - mean (115ms)  : 113, 118
    master - mean (117ms)  : 114, 119

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (792ms)  : 764, 821
    master - mean (787ms)  : 764, 810
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (101ms)  : 97, 105
    master - mean (106ms)  : 100, 112

    section Bailout
    This PR (8617) - mean (102ms)  : 98, 106
    master - mean (103ms)  : 98, 107

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (946ms)  : 913, 979
    master - mean (944ms)  : 906, 982
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (103ms)  : 98, 109
    master - mean (101ms)  : 96, 107

    section Bailout
    This PR (8617) - mean (102ms)  : 100, 105
    master - mean (106ms)  : 100, 111

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (828ms)  : 785, 871
    master - mean (828ms)  : 790, 866
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (190ms)  : 187, 194
    master - mean (192ms)  : 189, 195

    section Bailout
    This PR (8617) - mean (193ms)  : 192, 195
    master - mean (195ms)  : 193, 197

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (1,165ms)  : 1122, 1207
    master - mean (1,166ms)  : 1130, 1202
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (272ms)  : 267, 277
    master - mean (274ms)  : 271, 277

    section Bailout
    This PR (8617) - mean (272ms)  : 269, 275
    master - mean (276ms)  : 267, 285

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (927ms)  : 910, 945
    master - mean (939ms)  : 910, 967
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (266ms)  : 262, 270
    master - mean (269ms)  : 263, 275

    section Bailout
    This PR (8617) - mean (266ms)  : 263, 269
    master - mean (276ms)  : 268, 284

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (1,124ms)  : 1060, 1188
    master - mean (1,129ms)  : 1074, 1183
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8617) - mean (264ms)  : 261, 267
    master - mean (270ms)  : 259, 280

    section Bailout
    This PR (8617) - mean (264ms)  : 262, 266
    master - mean (274ms)  : 258, 290

    section CallTarget+Inlining+NGEN
    This PR (8617) - mean (1,021ms)  : 982, 1060
    master - mean (1,025ms)  : 978, 1072
Loading

@github-actions

github-actions Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

10 occurrences of :

-      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-2e4a7b5a-,
+      _dd.appsec.fp.http.endpoint: http-get-9ce5b35c-8e35c2cd-,

@andrewlock
andrewlock merged commit ee77554 into master May 26, 2026
136 checks passed
@andrewlock
andrewlock deleted the andrew/fix-waf-encoder-mismatch branch May 26, 2026 07:43
@github-actions github-actions Bot added this to the vNext-v3 milestone May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes
@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:asm identified-by:ai type:bug

Projects

None yet

Milestone

3.45.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @e-n-0 @NachoEchevarria