Skip to content

Ensure we wrap the process path in quotes before running it#8613

Merged
andrewlock merged 1 commit into
masterfrom
andrew/telemetry-path-hardening
May 20, 2026
Merged

Ensure we wrap the process path in quotes before running it#8613
andrewlock merged 1 commit into
masterfrom
andrew/telemetry-path-hardening

Conversation

@andrewlock

Copy link
Copy Markdown
Member

Summary of changes

Wrap the telemetry handler path in quotes before executing

Reason for change

If the telemetry path contains a space, we'd try to run the wrong path. Wrapping the value in quotes first ensures it's treated as a single argument.

Implementation details

Manually wrap with ". This is only called in a single place, in which we read from an env var. The simple fix is to check if it starts with a quote, and if not, wrap it. There's edge cases here, but this should be a "good enough" fix.

Test coverage

Covered by existing tests, they should be unchanged.

Other details

Added a comment to a similar path that's not affected, because it use fs::path instead, which automatically does the quoting.

@andrewlock
andrewlock requested review from a team as code owners May 12, 2026 14:30
@andrewlock
andrewlock force-pushed the andrew/telemetry-path-hardening branch from 13a0d9e to 9bd1e8c Compare May 12, 2026 14:30
@andrewlock andrewlock added area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) identified-by:ai labels May 12, 2026
@pr-commenter

pr-commenter Bot commented May 12, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-12 15:27:47

Comparing candidate commit 9bd1e8c in PR branch andrew/telemetry-path-hardening with baseline commit e052471 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1

Found 4 performance improvements and 2 performance regressions! Performance is the same for 48 metrics, 18 unstable metrics, 90 known flaky benchmarks, 36 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartActiveSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_GetCurrentSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_SetActive net6.0

  • 🟥 throughput [-35478.976op/s; -20904.965op/s] or [-22.383%; -13.188%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-74246.827op/s; -66827.559op/s] or [-50.437%; -45.397%]
  • 🟩 execution_time [-32.105ms; -16.765ms] or [-15.932%; -8.320%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [-11.963ms; +28.853ms] or [-7.295%; +17.594%]
  • unstable throughput [-14215.282op/s; +18257.408op/s] or [-9.081%; +11.663%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [+27.688ms; +57.383ms] or [+30.398%; +63.000%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-42.220ms; -23.044ms] or [-27.413%; -14.962%]
  • unstable throughput [+19312.162op/s; +35897.621op/s] or [+14.041%; +26.100%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [-36.170ms; -10.574ms] or [-32.606%; -9.532%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-7.020ms; +19.005ms] or [-5.267%; +14.259%]
  • unstable throughput [-17808.560op/s; +7099.600op/s] or [-10.041%; +4.003%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [+47.716ms; +83.204ms] or [+42.818%; +74.664%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [+20.107ms; +50.492ms] or [+13.200%; +33.147%]
  • unstable throughput [-30086.637op/s; -12396.472op/s] or [-23.455%; -9.664%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [+10.220ms; +34.607ms] or [+11.154%; +37.771%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [-13.236ms; +15.697ms] or [-8.636%; +10.242%]
  • unstable throughput [-15035.589op/s; +14314.987op/s] or [-9.231%; +8.788%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [-35.131ms; -10.483ms] or [-31.479%; -9.393%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [-51.894ms; -14.204ms] or [-30.565%; -8.366%]
  • unstable throughput [+13416.647op/s; +36371.318op/s] or [+7.853%; +21.289%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-40.711ms; -2.201ms] or [-30.203%; -1.633%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • unstable execution_time [-22.308ms; +11.846ms] or [-14.926%; +7.926%]
  • unstable throughput [-17952.405op/s; +14023.607op/s] or [-9.839%; +7.686%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-65.844ms; -26.536ms] or [-41.939%; -16.902%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-7.698%; -7.691%]
  • unstable execution_time [+7.484ms; +46.966ms] or [+5.376%; +33.733%]
  • unstable throughput [-13766.241op/s; +10653.970op/s] or [-9.630%; +7.453%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [-16.420ms; +18.736ms] or [-15.049%; +17.172%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-57.560ms; -23.479ms] or [-35.069%; -14.305%]
  • unstable throughput [+5436.774op/s; +27491.130op/s] or [+3.486%; +17.629%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-5.210%; -5.202%]
  • unstable execution_time [-66.482ms; -27.154ms] or [-38.725%; -15.817%]
  • unstable throughput [+19781.095op/s; +43681.425op/s] or [+21.907%; +48.377%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1

  • unstable execution_time [+9.472ms; +35.381ms] or [+10.671%; +39.860%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-31.294ms; -1.475ms] or [-18.701%; -0.881%]
  • unstable throughput [-1408.785op/s; +14317.478op/s] or [-1.242%; +12.621%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-8.741%; -8.734%]
  • unstable execution_time [+14.960ms; +32.877ms] or [+12.111%; +26.615%]
  • unstable throughput [-29767.728op/s; -13671.954op/s] or [-19.007%; -8.730%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [-19.308ms; +16.720ms] or [-17.518%; +15.170%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • unstable execution_time [-12138.792µs; +12598.764µs] or [-8.736%; +9.067%]
  • unstable throughput [+4114.987op/s; +21099.298op/s] or [+2.504%; +12.840%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-59.495ms; -29.090ms] or [-45.002%; -22.004%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-9075.899op/s; -8301.848op/s] or [-10.761%; -9.844%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • unstable execution_time [-44.330ms; -22.939ms] or [-22.116%; -11.444%]
  • 🟥 throughput [-56756.558op/s; -45335.724op/s] or [-47.706%; -38.106%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟩 execution_time [-99.277ms; -97.042ms] or [-49.933%; -48.809%]
  • 🟥 throughput [-6446.182op/s; -5241.708op/s] or [-6.554%; -5.330%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+305.592ms; +320.356ms] or [+151.646%; +158.972%]
  • 🟥 throughput [-57.384op/s; -44.684op/s] or [-10.324%; -8.040%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+120.684ms; +180.657ms] or [+95.348%; +142.730%]
  • unstable throughput [-46.904op/s; +54.111op/s] or [-6.184%; +7.134%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+82.575ms; +83.301ms] or [+73.076%; +73.718%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • unstable execution_time [-49.915ms; -27.723ms] or [-23.312%; -12.947%]
  • unstable throughput [-31769.645op/s; -17161.839op/s] or [-23.190%; -12.527%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]
  • 🟩 execution_time [-63.290ms; -42.514ms] or [-30.138%; -20.245%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-284611.793op/s; -266830.213op/s] or [-29.060%; -27.245%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • unstable execution_time [-89.836ms; -65.108ms] or [-40.063%; -29.035%]
  • unstable throughput [-255451.387op/s; -145100.741op/s] or [-27.290%; -15.501%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • unstable execution_time [-64.953ms; -41.275ms] or [-32.422%; -20.603%]
  • 🟥 throughput [-129183.453op/s; -112804.312op/s] or [-18.561%; -16.208%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 execution_time [-55.727ms; -41.764ms] or [-28.117%; -21.072%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • unstable execution_time [-50.205ms; -29.997ms] or [-25.596%; -15.293%]
  • 🟩 throughput [+10937.887op/s; +13696.615op/s] or [+8.713%; +10.911%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-71.765ms; -54.397ms] or [-35.483%; -26.895%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • unstable execution_time [-81.968ms; -57.339ms] or [-37.784%; -26.431%]
  • 🟩 throughput [+176545.595op/s; +236112.715op/s] or [+7.008%; +9.372%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.433ms; +315.252ms] or [+150.616%; +157.521%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+130.602ms; +137.016ms] or [+65.863%; +69.098%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+301.859ms; +308.415ms] or [+152.053%; +155.355%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.453ms; +311.045ms] or [+146.097%; +152.773%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • unstable execution_time [+248.401ms; +270.217ms] or [+121.434%; +132.099%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+260.532ms; +273.021ms] or [+130.213%; +136.456%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+20.888µs; +44.545µs] or [+6.669%; +14.221%]
  • 🟥 throughput [-416.352op/s; -217.300op/s] or [-12.979%; -6.774%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.255ms; +301.118ms] or [+149.858%; +150.289%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+366.290ms; +380.052ms] or [+397.989%; +412.942%]
  • 🟥 throughput [-6975.896op/s; -6787.420op/s] or [-57.322%; -55.773%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+253.309ms; +319.135ms] or [+192.335%; +242.316%]
  • 🟥 throughput [-1232.815op/s; -991.882op/s] or [-11.934%; -9.602%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+298.039ms; +312.807ms] or [+137.035%; +143.826%]
  • 🟥 throughput [-682.732op/s; -665.875op/s] or [-61.862%; -60.335%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-49.503ms; +84.499ms] or [-21.096%; +36.010%]
  • 🟥 throughput [-713.282op/s; -619.646op/s] or [-47.576%; -41.331%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+335.029ms; +342.583ms] or [+200.386%; +204.904%]
  • 🟥 throughput [-725.605op/s; -691.503op/s] or [-50.523%; -48.148%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟥 execution_time [+92.669µs; +104.904µs] or [+6.366%; +7.207%]
  • 🟥 throughput [-46.123op/s; -40.996op/s] or [-6.714%; -5.968%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 throughput [+47.486op/s; +57.933op/s] or [+5.120%; +6.246%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-216.874µs; -193.380µs] or [-10.986%; -9.796%]
  • 🟩 throughput [+55.412op/s; +62.676op/s] or [+10.939%; +12.373%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+306.448ms; +318.851ms] or [+154.322%; +160.567%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+262.283ms; +275.219ms] or [+131.430%; +137.913%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.045ms; +307.860ms] or [+151.232%; +154.656%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+304.905ms; +317.759ms] or [+153.113%; +159.568%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+225.521ms; +248.148ms] or [+111.510%; +122.698%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+300.164ms; +306.599ms] or [+152.136%; +155.398%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+305.578ms; +319.242ms] or [+153.373%; +160.231%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+304.898ms; +311.554ms] or [+151.964%; +155.281%]
  • 🟩 throughput [+39771.101op/s; +49323.539op/s] or [+7.897%; +9.794%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.483ms; +307.102ms] or [+149.488%; +152.781%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • unstable execution_time [-87.429ms; -60.247ms] or [-40.655%; -28.015%]
  • unstable throughput [-109173.714op/s; -62719.494op/s] or [-29.949%; -17.206%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • unstable execution_time [-28.516ms; -6.162ms] or [-14.304%; -3.091%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-26.171KB; -26.149KB] or [-9.547%; -9.538%]
  • unstable execution_time [-101.359µs; -48.307µs] or [-20.033%; -9.548%]
  • 🟩 throughput [+237.318op/s; +431.624op/s] or [+11.842%; +21.538%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 execution_time [-84.919µs; -29.906µs] or [-14.716%; -5.183%]
  • 🟩 throughput [+106.407op/s; +255.953op/s] or [+6.079%; +14.623%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+1.960µs; +6.847µs] or [+4.632%; +16.184%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.073µs; -4.849µs] or [-21.833%; -7.524%]
  • unstable throughput [+1465.298op/s; +3429.494op/s] or [+8.990%; +21.041%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.763ms; +314.254ms] or [+152.528%; +158.841%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.846ms; +308.969ms] or [+154.148%; +157.264%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.873ms; +308.200ms] or [+151.625%; +154.292%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-98.769ms; -74.786ms] or [-49.370%; -37.381%]
  • unstable throughput [-105210.792op/s; -41826.064op/s] or [-19.914%; -7.917%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-75.348ms; -46.116ms] or [-38.194%; -23.376%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+299.907ms; +312.642ms] or [+149.476%; +155.824%]
  • 🟥 throughput [-14612.660op/s; -10315.215op/s] or [-9.649%; -6.811%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+199.331ms; +240.162ms] or [+100.095%; +120.598%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+307.525ms; +314.349ms] or [+155.957%; +159.418%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.308ms; +301.187ms] or [+149.795%; +150.233%]
  • 🟩 throughput [+65010409.041op/s; +65331012.520op/s] or [+47.345%; +47.578%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+373.471ms; +395.642ms] or [+464.478%; +492.051%]
  • 🟥 throughput [-7522.145op/s; -7251.958op/s] or [-58.150%; -56.061%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+296.970ms; +299.274ms] or [+148.122%; +149.271%]
  • 🟥 throughput [-18068321.546op/s; -16804647.844op/s] or [-8.003%; -7.443%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • unstable execution_time [-89.809ms; -67.122ms] or [-43.987%; -32.875%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • unstable execution_time [-88.614ms; -67.132ms] or [-44.839%; -33.969%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-54.449ms; -18.230ms] or [-28.368%; -9.498%]
  • unstable throughput [-345110.871op/s; -139767.377op/s] or [-26.712%; -10.818%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-57.108ms; -29.028ms] or [-28.058%; -14.262%]
  • 🟩 throughput [+76903.429op/s; +88131.404op/s] or [+7.638%; +8.753%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • unstable execution_time [-85.647ms; -65.544ms] or [-42.772%; -32.732%]
  • unstable throughput [-67850.870op/s; -10562.716op/s] or [-12.320%; -1.918%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • unstable execution_time [-51.989ms; -25.071ms] or [-26.121%; -12.597%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-57.977ms; -30.133ms] or [-28.999%; -15.072%]
  • unstable throughput [-324586.224op/s; -191787.670op/s] or [-36.264%; -21.427%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-73.958ms; -46.062ms] or [-37.562%; -23.394%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

@dd-trace-dotnet-ci-bot

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8613) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.74 ± (72.72 - 73.09) ms74.79 ± (74.63 - 75.16) ms+2.8%✅⬆️
.NET Framework 4.8 - Bailout
duration79.44 ± (79.28 - 79.83) ms78.22 ± (78.17 - 78.63) ms-1.5%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1100.19 ± (1095.94 - 1103.81) ms1093.19 ± (1093.39 - 1101.03) ms-0.6%
.NET Core 3.1 - Baseline
process.internal_duration_ms22.82 ± (22.77 - 22.88) ms22.80 ± (22.74 - 22.86) ms-0.1%
process.time_to_main_ms86.81 ± (86.47 - 87.16) ms87.76 ± (87.47 - 88.06) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.84 ± (10.84 - 10.85) MB10.93 ± (10.92 - 10.93) MB+0.8%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.62 ± (22.58 - 22.67) ms22.38 ± (22.34 - 22.41) ms-1.1%
process.time_to_main_ms87.65 ± (87.41 - 87.90) ms86.29 ± (86.07 - 86.51) ms-1.6%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.96 ± (10.96 - 10.96) MB+0.2%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.35 ± (212.38 - 214.31) ms212.38 ± (211.44 - 213.32) ms-0.5%
process.time_to_main_ms539.09 ± (537.67 - 540.51) ms538.45 ± (537.08 - 539.82) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.30 ± (48.26 - 48.33) MB48.36 ± (48.33 - 48.40) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.15 ± (21.11 - 21.19) ms21.45 ± (21.39 - 21.52) ms+1.4%✅⬆️
process.time_to_main_ms73.90 ± (73.70 - 74.10) ms74.73 ± (74.42 - 75.03) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.63) MB10.63 ± (10.62 - 10.63) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms21.25 ± (21.19 - 21.30) ms21.42 ± (21.36 - 21.47) ms+0.8%✅⬆️
process.time_to_main_ms76.08 ± (75.76 - 76.41) ms77.19 ± (76.91 - 77.48) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.74 ± (10.74 - 10.74) MB10.74 ± (10.74 - 10.74) MB-0.0%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms381.33 ± (379.41 - 383.25) ms380.69 ± (378.56 - 382.81) ms-0.2%
process.time_to_main_ms538.67 ± (537.27 - 540.08) ms539.20 ± (537.86 - 540.54) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed49.76 ± (49.74 - 49.79) MB49.92 ± (49.90 - 49.95) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 29)28 ± (28 - 28)-0.1%
.NET 8 - Baseline
process.internal_duration_ms19.50 ± (19.46 - 19.54) ms19.53 ± (19.48 - 19.57) ms+0.1%✅⬆️
process.time_to_main_ms73.17 ± (72.99 - 73.35) ms72.97 ± (72.78 - 73.17) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.66 ± (7.66 - 7.67) MB7.66 ± (7.65 - 7.66) MB-0.0%
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.86 ± (19.81 - 19.92) ms19.80 ± (19.74 - 19.86) ms-0.3%
process.time_to_main_ms76.88 ± (76.60 - 77.16) ms75.95 ± (75.67 - 76.24) ms-1.2%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.71 ± (7.71 - 7.72) MB-0.1%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms292.93 ± (290.61 - 295.26) ms294.37 ± (292.21 - 296.52) ms+0.5%✅⬆️
process.time_to_main_ms500.62 ± (499.51 - 501.73) ms500.23 ± (499.06 - 501.40) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.98 ± (36.96 - 37.01) MB36.94 ± (36.91 - 36.97) MB-0.1%
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.82 ± (193.93 - 194.83) ms203.39 ± (203.33 - 204.19) ms+4.9%✅⬆️
.NET Framework 4.8 - Bailout
duration197.94 ± (197.81 - 198.31) ms206.21 ± (206.12 - 206.81) ms+4.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1218.83 ± (1215.93 - 1225.21) ms1221.92 ± (1222.24 - 1230.67) ms+0.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms200.18 ± (199.73 - 200.62) ms201.94 ± (201.56 - 202.33) ms+0.9%✅⬆️
process.time_to_main_ms88.13 ± (87.91 - 88.36) ms88.80 ± (88.53 - 89.06) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.01 ± (15.99 - 16.03) MB15.94 ± (15.91 - 15.96) MB-0.5%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms194.07 ± (193.71 - 194.43) ms199.98 ± (199.60 - 200.36) ms+3.0%✅⬆️
process.time_to_main_ms86.37 ± (86.16 - 86.58) ms88.93 ± (88.71 - 89.15) ms+3.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.13 ± (16.10 - 16.15) MB15.99 ± (15.97 - 16.02) MB-0.8%
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)-0.2%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms384.92 ± (383.59 - 386.25) ms378.70 ± (377.50 - 379.90) ms-1.6%
process.time_to_main_ms529.66 ± (528.41 - 530.91) ms521.49 ± (520.17 - 522.81) ms-1.5%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed57.28 ± (57.12 - 57.44) MB57.19 ± (57.11 - 57.28) MB-0.1%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms197.22 ± (196.66 - 197.78) ms191.07 ± (190.71 - 191.42) ms-3.1%
process.time_to_main_ms72.63 ± (72.41 - 72.85) ms70.26 ± (70.08 - 70.45) ms-3.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.31 ± (16.29 - 16.34) MB16.25 ± (16.11 - 16.38) MB-0.4%
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (18 - 19)-4.0%
.NET 6 - Bailout
process.internal_duration_ms200.40 ± (199.94 - 200.86) ms187.68 ± (187.51 - 187.84) ms-6.3%
process.time_to_main_ms75.49 ± (75.24 - 75.74) ms70.55 ± (70.45 - 70.65) ms-6.5%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.33 ± (16.30 - 16.35) MB15.99 ± (15.82 - 16.16) MB-2.1%
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-5.8%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms596.61 ± (593.98 - 599.25) ms586.71 ± (582.74 - 590.69) ms-1.7%
process.time_to_main_ms542.32 ± (541.25 - 543.39) ms514.92 ± (514.20 - 515.65) ms-5.1%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed61.40 ± (61.30 - 61.50) MB61.37 ± (61.27 - 61.47) MB-0.0%
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.4%
.NET 8 - Baseline
process.internal_duration_ms200.67 ± (200.39 - 200.96) ms186.42 ± (186.22 - 186.63) ms-7.1%
process.time_to_main_ms74.63 ± (74.41 - 74.84) ms69.18 ± (69.01 - 69.35) ms-7.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.67 ± (11.65 - 11.69) MB11.68 ± (11.59 - 11.76) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (17 - 18)-6.3%
.NET 8 - Bailout
process.internal_duration_ms199.88 ± (199.56 - 200.20) ms186.17 ± (185.98 - 186.37) ms-6.9%
process.time_to_main_ms75.75 ± (75.61 - 75.89) ms70.27 ± (70.19 - 70.36) ms-7.2%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.74) MB11.84 ± (11.81 - 11.87) MB+1.0%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-2.5%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms517.08 ± (513.79 - 520.37) ms512.37 ± (509.83 - 514.91) ms-0.9%
process.time_to_main_ms501.82 ± (501.01 - 502.63) ms474.21 ± (473.47 - 474.95) ms-5.5%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed50.62 ± (50.58 - 50.66) MB50.57 ± (50.54 - 50.61) MB-0.1%
runtime.dotnet.threads.count30 ± (30 - 30)29 ± (29 - 29)-2.2%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (75ms)  : 71, 79
    master - mean (73ms)  : 70, 76

    section Bailout
    This PR (8613) - mean (78ms)  : 75, 82
    master - mean (80ms)  : 75, 84

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (1,097ms)  : 1041, 1153
    master - mean (1,100ms)  : 1042, 1158

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (118ms)  : 111, 124
    master - mean (117ms)  : 110, 123

    section Bailout
    This PR (8613) - mean (116ms)  : 111, 120
    master - mean (117ms)  : 113, 122

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (788ms)  : 759, 817
    master - mean (792ms)  : 759, 825

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (103ms)  : 97, 109
    master - mean (102ms)  : 98, 105

    section Bailout
    This PR (8613) - mean (105ms)  : 100, 111
    master - mean (104ms)  : 98, 110

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (948ms)  : 914, 982
    master - mean (947ms)  : 911, 982

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (100ms)  : 96, 104
    master - mean (101ms)  : 97, 104

    section Bailout
    This PR (8613) - mean (104ms)  : 98, 110
    master - mean (105ms)  : 99, 111

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (830ms)  : 784, 875
    master - mean (826ms)  : 783, 870

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (204ms)  : 199, 209
    master - mean (194ms)  : 190, 199

    section Bailout
    This PR (8613) - mean (206ms)  : 203, 210
    master - mean (198ms)  : 196, 200

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (1,226ms)  : 1164, 1288
    master - mean (1,221ms)  : 1154, 1287

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (300ms)  : 295, 305
    master - mean (298ms)  : 290, 306

    section Bailout
    This PR (8613) - mean (298ms)  : 293, 304
    master - mean (290ms)  : 284, 296

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (941ms)  : 899, 983
    master - mean (958ms)  : 941, 976

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (270ms)  : 264, 275
    master - mean (278ms)  : 267, 290

    section Bailout
    This PR (8613) - mean (266ms)  : 263, 269
    master - mean (285ms)  : 276, 293

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (1,127ms)  : 1063, 1191
    master - mean (1,166ms)  : 1128, 1204

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8613) - mean (265ms)  : 261, 270
    master - mean (286ms)  : 282, 290

    section Bailout
    This PR (8613) - mean (266ms)  : 263, 268
    master - mean (286ms)  : 282, 290

    section CallTarget+Inlining+NGEN
    This PR (8613) - mean (1,015ms)  : 954, 1075
    master - mean (1,052ms)  : 999, 1104

Loading

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock
andrewlock merged commit 9bb9da8 into master May 20, 2026
148 checks passed
@andrewlock
andrewlock deleted the andrew/telemetry-path-hardening branch May 20, 2026 10:39
@github-actions github-actions Bot added this to the vNext-v3 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:native-library Automatic instrumentation native C++ code (Datadog.Trace.ClrProfiler.Native) area:shared-components identified-by:ai

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants