Exclude OpenTelemetry.Api from benchmark PR comments#8606
Conversation
00241e2 to
62c6554
Compare
OpenTelemetry.Api benchmarks only run on master, not on PRs, causing noisy "scenarios present only in baseline" warnings in PR comments.
62c6554 to
4e6327b
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8606) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (74ms) : 70, 79
master - mean (74ms) : 69, 78
section Bailout
This PR (8606) - mean (77ms) : 75, 80
master - mean (79ms) : 76, 83
section CallTarget+Inlining+NGEN
This PR (8606) - mean (1,097ms) : 1049, 1145
master - mean (1,100ms) : 1050, 1150
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (115ms) : 107, 122
master - mean (117ms) : 111, 122
section Bailout
This PR (8606) - mean (114ms) : 112, 117
master - mean (116ms) : 111, 121
section CallTarget+Inlining+NGEN
This PR (8606) - mean (791ms) : 764, 818
master - mean (788ms) : 764, 811
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (101ms) : 98, 104
master - mean (101ms) : 96, 105
section Bailout
This PR (8606) - mean (102ms) : 100, 104
master - mean (104ms) : 100, 109
section CallTarget+Inlining+NGEN
This PR (8606) - mean (942ms) : 909, 975
master - mean (941ms) : 895, 987
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (102ms) : 96, 109
master - mean (100ms) : 96, 104
section Bailout
This PR (8606) - mean (101ms) : 99, 104
master - mean (100ms) : 98, 103
section CallTarget+Inlining+NGEN
This PR (8606) - mean (828ms) : 794, 861
master - mean (826ms) : 783, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (190ms) : 188, 193
master - mean (190ms) : 187, 194
section Bailout
This PR (8606) - mean (194ms) : 192, 195
master - mean (194ms) : 192, 195
section CallTarget+Inlining+NGEN
This PR (8606) - mean (1,161ms) : 1123, 1198
master - mean (1,161ms) : 1116, 1206
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (272ms) : 268, 276
master - mean (271ms) : 268, 275
section Bailout
This PR (8606) - mean (272ms) : 270, 275
master - mean (272ms) : 270, 275
section CallTarget+Inlining+NGEN
This PR (8606) - mean (929ms) : 908, 950
master - mean (926ms) : 902, 951
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (267ms) : 264, 270
master - mean (266ms) : 263, 269
section Bailout
This PR (8606) - mean (267ms) : 264, 270
master - mean (266ms) : 263, 269
section CallTarget+Inlining+NGEN
This PR (8606) - mean (1,123ms) : 1051, 1195
master - mean (1,117ms) : 1045, 1190
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8606) - mean (264ms) : 260, 269
master - mean (264ms) : 261, 267
section Bailout
This PR (8606) - mean (264ms) : 261, 266
master - mean (264ms) : 261, 266
section CallTarget+Inlining+NGEN
This PR (8606) - mean (1,014ms) : 969, 1059
master - mean (1,012ms) : 972, 1053
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-12 10:05:00 Comparing candidate commit 4e6327b in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 2 performance improvements and 5 performance regressions! Performance is the same for 47 metrics, 18 unstable metrics, 94 known flaky benchmarks, 32 flaky benchmarks without significant changes.
|
Summary of changes
Exclude
OpenTelemetry.Apibenchmark results from PR comment comparison.Reason for change
As a follow up to enabling OTel microbenchmarks, the PR comment has become very noisy, as it's expecting all the benchmarks, even though we don't run them on PRs.
#8593 (comment)
Implementation details
Filter out
candidate.OpenTelemetry.Api.*files when globbing for candidate results inpost-pr-comment.sh. These benchmarks only run on master (Nuke doesn't buildBenchmarks.OpenTelemetry.Apion PRs), so including them causes "scenarios present only in baseline" warnings.Test coverage
CI pipeline on this branch.
Other details