Skip to content

[Debugger] Report retryable line probe resolution errors#8603

Merged
dudikeleti merged 8 commits into
masterfrom
dudik/di/report-line-probe-errors
May 22, 2026
Merged

[Debugger] Report retryable line probe resolution errors#8603
dudikeleti merged 8 commits into
masterfrom
dudik/di/report-line-probe-errors

Conversation

@dudikeleti

@dudikeleti dudikeleti commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

  • Report retryable line-probe source path mismatches as backend ERROR statuses with actionable fallback diagnostics.
  • Keep retryable line probes in the unbound retry set so later assembly loads can still bind them.
  • Stop retrying terminal resolver errors while continuing to retry non-terminal unbound results.
  • Deduplicate repeated retryable line-probe error reports by stable error key instead of full rendered message/details.
  • Avoid replaying explicitly pushed probe error statuses during status polling.
  • Add focused resolver, DynamicInstrumentation, and probe status poller coverage for the new status transitions.

Reason for change

  • Some line-probe resolution failures were only visible locally in logs, leaving users without backend feedback about why a probe did not bind.
  • Repeated retry attempts could resend equivalent error statuses when only diagnostic counts changed, creating noisy backend updates.

Implementation details

  • Adds LineProbeResolveResult.ReportError to separate retryability from backend status reporting.
  • Adds line-probe resolve error key/details payloads so DynamicInstrumentation can deduplicate by failure category while still rendering detailed messages.
  • DynamicInstrumentation reports Unbound + ReportError as ERROR, keeps those probes retryable, and only reports again when the stable error key changes.
  • Terminal Error results are reported as ERROR and removed from retry tracking.
  • Source-file mismatch messages include fallback diagnostics when available; detailed diagnostic collection remains gated by diagnostic level.
  • ProbeStatusPoller drops explicit status updates after they are sent so poll cycles do not replay them.

Test coverage

  • Added LineProbeResolverTest coverage for source-file mismatch error keys/details.
  • Added DynamicInstrumentationTests coverage for retryable line-probe errors, deduplication when only diagnostic counts change, and reporting again when the stable error key changes.
  • Added ProbeStatusSinkTests coverage to ensure explicit error statuses are not replayed on poll.

@pr-commenter

pr-commenter Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-20 21:22:38

Comparing candidate commit 9244350 in PR branch dudik/di/report-line-probe-errors with baseline commit 17a15a6 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

Found 2 performance improvements and 3 performance regressions! Performance is the same for 47 metrics, 20 unstable metrics, 84 known flaky benchmarks, 42 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan net6.0

  • 🟥 allocated_mem [+95 bytes; +96 bytes] or [+6.518%; +6.526%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_GetCurrentSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-79300.974op/s; -70609.185op/s] or [-53.870%; -47.966%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-71011.702op/s; -51660.723op/s] or [-35.605%; -25.903%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [-10.983ms; +3.405ms] or [-8.002%; +2.481%]
  • unstable throughput [-37486.418op/s; -1570.334op/s] or [-19.421%; -0.814%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-21248.125µs; +22442.829µs] or [-16.051%; +16.954%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-70.874ms; -36.006ms] or [-37.928%; -19.269%]
  • unstable throughput [+36257.175op/s; +72024.121op/s] or [+30.654%; +60.893%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-31.126ms; -5.495ms] or [-20.597%; -3.636%]
  • unstable throughput [+8505.440op/s; +33927.494op/s] or [+5.456%; +21.764%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [-59.287ms; -28.937ms] or [-44.411%; -21.676%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-10.283ms; +5.715ms] or [-7.072%; +3.930%]
  • 🟥 throughput [-12062.863op/s; -8373.044op/s] or [-8.502%; -5.901%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [-35.872ms; -12.152ms] or [-30.900%; -10.468%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [-22.492ms; -5.729ms] or [-16.027%; -4.083%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [-36.687ms; -11.521ms] or [-32.127%; -10.089%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [+16.541ms; +60.380ms] or [+11.871%; +43.331%]
  • unstable throughput [-48987.818op/s; -20652.867op/s] or [-26.531%; -11.185%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [-32.963ms; -8.008ms] or [-30.026%; -7.294%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • unstable execution_time [-40.687ms; -16.785ms] or [-24.154%; -9.964%]
  • unstable throughput [+15861.202op/s; +38020.631op/s] or [+11.554%; +27.696%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-8.845ms; +22.766ms] or [-8.583%; +22.090%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-7.698%; -7.691%]
  • unstable execution_time [-1.232ms; +47.569ms] or [-0.724%; +27.964%]
  • unstable throughput [-21055.338op/s; +7042.311op/s] or [-17.591%; +5.883%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [+9.868ms; +34.952ms] or [+11.151%; +39.497%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]
  • unstable execution_time [-18.789ms; +9.303ms] or [-12.397%; +6.138%]
  • 🟥 throughput [-28577.305op/s; -15673.966op/s] or [-16.751%; -9.188%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-5.210%; -5.202%]
  • unstable execution_time [-69.992ms; -48.784ms] or [-42.591%; -29.685%]
  • unstable throughput [+43723.049op/s; +57442.520op/s] or [+50.155%; +65.892%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [+1.690ms; +23.747ms] or [+1.104%; +15.504%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-8.741%; -8.734%]
  • unstable execution_time [-16.509ms; +22.482ms] or [-10.782%; +14.682%]
  • unstable throughput [-10120.633op/s; +12570.141op/s] or [-7.024%; +8.724%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [-27.752ms; -9.942ms] or [-19.332%; -6.926%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6652.258op/s; -6042.658op/s] or [-7.888%; -7.165%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • unstable execution_time [-88.073ms; -50.269ms] or [-43.940%; -25.079%]
  • unstable throughput [-31268.374op/s; -15924.546op/s] or [-26.282%; -13.385%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-90.941ms; -68.046ms] or [-45.740%; -34.225%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+317.364ms; +332.632ms] or [+157.487%; +165.064%]
  • 🟥 throughput [-56.844op/s; -44.009op/s] or [-10.227%; -7.918%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+98.592ms; +99.883ms] or [+77.893%; +78.913%]
  • 🟩 throughput [+89.524op/s; +94.277op/s] or [+11.803%; +12.430%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+82.005ms; +83.487ms] or [+72.572%; +73.882%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • 🟩 execution_time [-40.264ms; -23.719ms] or [-18.805%; -11.078%]
  • 🟥 throughput [-34567.119op/s; -22728.823op/s] or [-25.232%; -16.591%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]
  • 🟩 execution_time [-83.997ms; -79.523ms] or [-39.999%; -37.868%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-271705.547op/s; -266311.560op/s] or [-27.742%; -27.192%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • unstable execution_time [-75.581ms; -49.419ms] or [-33.706%; -22.039%]
  • unstable throughput [-333081.943op/s; -216560.310op/s] or [-35.584%; -23.135%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟩 execution_time [-76.327ms; -56.583ms] or [-38.099%; -28.244%]
  • 🟥 throughput [-131223.009op/s; -114723.737op/s] or [-18.854%; -16.484%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • unstable execution_time [-27.959ms; -6.438ms] or [-14.107%; -3.248%]
  • unstable throughput [-24053.137op/s; -7275.536op/s] or [-15.305%; -4.629%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 execution_time [-34.666ms; -15.199ms] or [-17.674%; -7.749%]
  • 🟩 throughput [+10225.237op/s; +12879.855op/s] or [+8.146%; +10.260%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-73.469ms; -56.640ms] or [-36.325%; -28.004%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • unstable execution_time [-66.024ms; -40.449ms] or [-30.435%; -18.646%]
  • 🟩 throughput [+180819.005op/s; +237176.899op/s] or [+7.177%; +9.414%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.237ms; +315.241ms] or [+150.518%; +157.515%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • unstable execution_time [+144.799ms; +183.285ms] or [+73.023%; +92.431%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • unstable execution_time [+212.026ms; +258.571ms] or [+106.802%; +130.248%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.861ms; +311.589ms] or [+146.298%; +153.040%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+254.726ms; +274.431ms] or [+124.526%; +134.159%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+276.785ms; +289.000ms] or [+138.337%; +144.442%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+21.222µs; +45.019µs] or [+6.775%; +14.372%]
  • 🟥 throughput [-419.773op/s; -219.637op/s] or [-13.086%; -6.847%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+300.910ms; +302.130ms] or [+150.185%; +150.794%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+358.333ms; +378.154ms] or [+389.344%; +410.879%]
  • 🟥 throughput [-7117.831op/s; -6893.216op/s] or [-58.488%; -56.643%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+276.168ms; +337.646ms] or [+209.691%; +256.371%]
  • 🟥 throughput [-1768.308op/s; -1556.336op/s] or [-17.118%; -15.066%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+299.152ms; +315.603ms] or [+137.547%; +145.111%]
  • 🟥 throughput [-684.450op/s; -666.934op/s] or [-62.018%; -60.431%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-49.204ms; +84.603ms] or [-20.969%; +36.054%]
  • 🟥 throughput [-702.341op/s; -610.689op/s] or [-46.846%; -40.733%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+339.271ms; +347.561ms] or [+202.924%; +207.882%]
  • 🟥 throughput [-725.954op/s; -691.876op/s] or [-50.547%; -48.174%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-175.238µs; -144.523µs] or [-8.877%; -7.321%]
  • 🟩 throughput [+40.525op/s; +49.747op/s] or [+8.000%; +9.821%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-247.202µs; -239.674µs] or [-6.269%; -6.078%]
  • 🟩 throughput [+16.422op/s; +16.953op/s] or [+6.476%; +6.685%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+303.543ms; +316.820ms] or [+152.859%; +159.544%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • unstable execution_time [+173.300ms; +219.025ms] or [+86.841%; +109.754%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+302.113ms; +307.799ms] or [+151.769%; +154.625%]
  • 🟩 throughput [+31565.147op/s; +44115.672op/s] or [+6.649%; +9.293%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.952ms; +318.214ms] or [+152.635%; +159.796%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+212.621ms; +237.905ms] or [+105.132%; +117.633%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+301.639ms; +308.965ms] or [+152.884%; +156.597%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+303.018ms; +316.380ms] or [+152.088%; +158.794%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • unstable execution_time [+157.670ms; +235.173ms] or [+78.584%; +117.212%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+297.660ms; +304.568ms] or [+148.083%; +151.520%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • unstable execution_time [-70.915ms; -44.084ms] or [-32.976%; -20.499%]
  • unstable throughput [-137566.734op/s; -91439.748op/s] or [-37.738%; -25.084%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • unstable execution_time [-53.065ms; -24.827ms] or [-26.618%; -12.453%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-24.989KB; -24.966KB] or [-9.115%; -9.107%]
  • unstable execution_time [-92.135µs; -38.738µs] or [-18.210%; -7.656%]
  • 🟩 throughput [+188.654op/s; +378.666op/s] or [+9.414%; +18.896%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-16.746KB; -16.729KB] or [-6.105%; -6.098%]
  • 🟩 execution_time [-98.921µs; -44.872µs] or [-17.142%; -7.776%]
  • 🟩 throughput [+161.127op/s; +308.626op/s] or [+9.205%; +17.632%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.847µs; -5.027µs] or [-21.483%; -7.799%]
  • unstable throughput [+1409.258op/s; +3321.406op/s] or [+8.646%; +20.378%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+304.186ms; +318.212ms] or [+153.753%; +160.842%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+283.353ms; +301.982ms] or [+144.226%; +153.708%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+300.075ms; +306.685ms] or [+150.224%; +153.534%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-75.000ms; -47.039ms] or [-37.489%; -23.512%]
  • unstable throughput [-173423.487op/s; -105454.756op/s] or [-32.825%; -19.960%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-77.449ms; -48.108ms] or [-39.259%; -24.386%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.435ms; +313.290ms] or [+149.740%; +156.147%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+171.672ms; +243.467ms] or [+86.205%; +122.257%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+304.401ms; +310.695ms] or [+154.372%; +157.565%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.189ms; +301.048ms] or [+149.736%; +150.164%]
  • 🟩 throughput [+60056916.889op/s; +60342273.506op/s] or [+43.737%; +43.945%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+369.297ms; +380.308ms] or [+459.287%; +472.981%]
  • 🟥 throughput [-7475.035op/s; -7277.083op/s] or [-57.786%; -56.255%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+302.488ms; +304.458ms] or [+150.874%; +151.857%]
  • 🟥 throughput [-29989456.557op/s; -28837818.302op/s] or [-13.283%; -12.773%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • unstable execution_time [-49.621ms; -15.718ms] or [-24.303%; -7.699%]
  • unstable throughput [-361820.812op/s; -198019.409op/s] or [-33.782%; -18.488%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 execution_time [-102.165ms; -98.025ms] or [-51.696%; -49.602%]
  • 🟩 throughput [+51938.260op/s; +71650.271op/s] or [+6.012%; +8.293%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • unstable execution_time [-15.831ms; +12.527ms] or [-8.248%; +6.527%]
  • unstable throughput [-557459.702op/s; -396208.968op/s] or [-43.148%; -30.667%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-55.597ms; -28.374ms] or [-27.316%; -13.940%]
  • 🟩 throughput [+84014.306op/s; +94871.851op/s] or [+8.344%; +9.422%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • unstable execution_time [-38.811ms; -15.185ms] or [-19.382%; -7.583%]
  • unstable throughput [-203565.140op/s; -134463.098op/s] or [-36.964%; -24.416%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • unstable execution_time [-74.023ms; -46.676ms] or [-37.192%; -23.452%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-99.661ms; -75.099ms] or [-49.848%; -37.563%]
  • unstable throughput [-85181.729op/s; +33839.521op/s] or [-9.517%; +3.781%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-52.897ms; -24.912ms] or [-26.865%; -12.652%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

@dudikeleti
dudikeleti force-pushed the dudik/di/report-line-probe-errors branch from aa90bcb to 3b4bc30 Compare May 19, 2026 16:23
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8603) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.27 ± (73.31 - 73.76) ms74.50 ± (74.27 - 74.85) ms+1.7%✅⬆️
.NET Framework 4.8 - Bailout
duration76.27 ± (76.14 - 76.49) ms77.68 ± (77.65 - 78.08) ms+1.9%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1106.25 ± (1105.55 - 1112.72) ms1107.67 ± (1105.13 - 1111.58) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.61 ± (22.57 - 22.64) ms22.60 ± (22.54 - 22.66) ms-0.0%✅
process.time_to_main_ms85.27 ± (85.06 - 85.48) ms85.36 ± (85.06 - 85.66) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.92) MB10.92 ± (10.91 - 10.92) MB-0.0%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.54 ± (22.49 - 22.58) ms22.10 ± (22.07 - 22.13) ms-1.9%✅
process.time_to_main_ms87.16 ± (86.86 - 87.47) ms85.36 ± (85.16 - 85.55) ms-2.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.94) MB10.95 ± (10.95 - 10.96) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.93 ± (212.94 - 214.93) ms212.68 ± (211.75 - 213.62) ms-0.6%✅
process.time_to_main_ms543.68 ± (542.21 - 545.14) ms540.28 ± (538.67 - 541.90) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.40 ± (48.36 - 48.43) MB48.47 ± (48.43 - 48.51) MB+0.2%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.13 ± (21.10 - 21.16) ms21.09 ± (21.06 - 21.12) ms-0.2%✅
process.time_to_main_ms73.42 ± (73.27 - 73.56) ms73.55 ± (73.40 - 73.69) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.63) MB10.63 ± (10.63 - 10.63) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.36 ± (21.30 - 21.41) ms20.99 ± (20.95 - 21.03) ms-1.7%✅
process.time_to_main_ms76.65 ± (76.37 - 76.93) ms74.36 ± (74.20 - 74.52) ms-3.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.74 - 10.75) MB10.74 ± (10.73 - 10.74) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms368.03 ± (365.67 - 370.38) ms367.37 ± (365.21 - 369.53) ms-0.2%✅
process.time_to_main_ms550.97 ± (549.56 - 552.38) ms551.94 ± (550.58 - 553.29) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.00 ± (49.98 - 50.02) MB50.02 ± (50.00 - 50.05) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.38 ± (19.34 - 19.43) ms19.79 ± (19.73 - 19.85) ms+2.1%✅⬆️
process.time_to_main_ms72.74 ± (72.53 - 72.96) ms75.23 ± (74.94 - 75.53) ms+3.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.68 - 7.69) MB7.67 ± (7.66 - 7.67) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.24 ± (19.19 - 19.29) ms19.38 ± (19.34 - 19.42) ms+0.7%✅⬆️
process.time_to_main_ms72.84 ± (72.67 - 73.02) ms74.02 ± (73.84 - 74.20) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.74) MB7.71 ± (7.70 - 7.71) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms295.15 ± (293.03 - 297.27) ms294.99 ± (292.77 - 297.22) ms-0.1%✅
process.time_to_main_ms498.28 ± (497.04 - 499.53) ms498.60 ± (497.46 - 499.73) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.92 ± (36.89 - 36.95) MB36.95 ± (36.93 - 36.98) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.5%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration200.27 ± (199.98 - 200.87) ms200.91 ± (200.52 - 201.43) ms+0.3%✅⬆️
.NET Framework 4.8 - Bailout
duration204.10 ± (203.26 - 204.32) ms204.87 ± (204.42 - 205.24) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1202.78 ± (1201.25 - 1207.66) ms1200.24 ± (1201.03 - 1207.24) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms194.99 ± (194.51 - 195.46) ms196.37 ± (195.92 - 196.81) ms+0.7%✅⬆️
process.time_to_main_ms83.91 ± (83.62 - 84.19) ms85.16 ± (84.84 - 85.49) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.11 - 16.15) MB16.02 ± (16.00 - 16.05) MB-0.6%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.1%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms194.74 ± (194.32 - 195.16) ms195.73 ± (195.25 - 196.21) ms+0.5%✅⬆️
process.time_to_main_ms85.42 ± (85.19 - 85.65) ms86.35 ± (86.04 - 86.66) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.15 - 16.18) MB16.04 ± (16.01 - 16.07) MB-0.8%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.1%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms390.28 ± (389.03 - 391.52) ms389.95 ± (388.73 - 391.16) ms-0.1%✅
process.time_to_main_ms537.43 ± (536.52 - 538.33) ms540.58 ± (539.17 - 542.00) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.13 ± (57.91 - 58.34) MB57.97 ± (57.74 - 58.20) MB-0.3%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms199.67 ± (199.32 - 200.02) ms201.07 ± (200.62 - 201.52) ms+0.7%✅⬆️
process.time_to_main_ms73.39 ± (73.14 - 73.64) ms73.86 ± (73.61 - 74.12) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.33 ± (16.30 - 16.35) MB16.31 ± (16.29 - 16.33) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.8%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms199.08 ± (198.67 - 199.50) ms199.17 ± (198.70 - 199.65) ms+0.0%✅⬆️
process.time_to_main_ms74.19 ± (73.92 - 74.45) ms73.89 ± (73.66 - 74.12) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.40 ± (16.37 - 16.43) MB16.39 ± (16.37 - 16.41) MB-0.1%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.5%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms587.83 ± (585.60 - 590.06) ms587.40 ± (583.91 - 590.90) ms-0.1%✅
process.time_to_main_ms546.01 ± (545.09 - 546.94) ms547.24 ± (545.81 - 548.66) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.09 ± (61.00 - 61.18) MB61.08 ± (60.96 - 61.20) MB-0.0%✅
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms197.75 ± (197.21 - 198.30) ms196.61 ± (196.07 - 197.15) ms-0.6%✅
process.time_to_main_ms72.49 ± (72.25 - 72.73) ms72.06 ± (71.81 - 72.30) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.67 ± (11.65 - 11.69) MB11.66 ± (11.64 - 11.67) MB-0.1%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.3%✅
.NET 8 - Bailout
process.internal_duration_ms197.30 ± (196.82 - 197.78) ms197.46 ± (197.02 - 197.90) ms+0.1%✅⬆️
process.time_to_main_ms73.48 ± (73.26 - 73.69) ms73.48 ± (73.23 - 73.72) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.71 ± (11.69 - 11.73) MB11.73 ± (11.71 - 11.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms515.14 ± (512.81 - 517.46) ms515.16 ± (512.74 - 517.59) ms+0.0%✅⬆️
process.time_to_main_ms493.90 ± (492.92 - 494.88) ms495.06 ± (494.22 - 495.90) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.63 ± (50.59 - 50.67) MB50.57 ± (50.53 - 50.61) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.5%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (75ms)  : 70, 79
    master - mean (74ms)  : 70, 77

    section Bailout
    This PR (8603) - mean (78ms)  : 75, 81
    master - mean (76ms)  : 75, 78

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (1,108ms)  : 1062, 1154
    master - mean (1,109ms)  : 1058, 1161
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (115ms)  : 108, 123
    master - mean (115ms)  : 111, 119

    section Bailout
    This PR (8603) - mean (114ms)  : 112, 117
    master - mean (117ms)  : 110, 123

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (791ms)  : 765, 816
    master - mean (796ms)  : 766, 825
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (101ms)  : 98, 104
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (8603) - mean (102ms)  : 99, 105
    master - mean (105ms)  : 99, 111

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (948ms)  : 911, 986
    master - mean (949ms)  : 910, 988
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (103ms)  : 98, 108
    master - mean (100ms)  : 96, 104

    section Bailout
    This PR (8603) - mean (101ms)  : 97, 105
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (825ms)  : 792, 857
    master - mean (824ms)  : 784, 863
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (201ms)  : 196, 206
    master - mean (200ms)  : 195, 206

    section Bailout
    This PR (8603) - mean (205ms)  : 201, 209
    master - mean (204ms)  : 198, 210

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (1,204ms)  : 1162, 1246
    master - mean (1,204ms)  : 1157, 1251
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (291ms)  : 283, 299
    master - mean (288ms)  : 279, 297

    section Bailout
    This PR (8603) - mean (291ms)  : 284, 298
    master - mean (289ms)  : 280, 297

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (968ms)  : 950, 986
    master - mean (968ms)  : 949, 988
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (284ms)  : 273, 295
    master - mean (281ms)  : 277, 286

    section Bailout
    This PR (8603) - mean (282ms)  : 274, 290
    master - mean (281ms)  : 275, 288

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (1,162ms)  : 1118, 1206
    master - mean (1,163ms)  : 1127, 1199
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8603) - mean (280ms)  : 273, 286
    master - mean (281ms)  : 274, 287

    section Bailout
    This PR (8603) - mean (281ms)  : 275, 287
    master - mean (281ms)  : 274, 287

    section CallTarget+Inlining+NGEN
    This PR (8603) - mean (1,041ms)  : 995, 1087
    master - mean (1,041ms)  : 1001, 1080
Loading

@datadog-official

datadog-official Bot commented May 19, 2026 •
edited by datadog-prod-us1-6 Bot
Loading

Copy link
Copy Markdown
Contributor

Pipelines

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/apm-reliability/dd-trace-dotnet | check-big-regressions   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. FileNotFoundError: No such file or directory: '/go/src/github.com/DataDog/apm-reliability/dd-trace-dotnet/artifacts/candidate*.converted.json'

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9244350 | Docs | Datadog PR Page | Give us feedback!

@dudikeleti
dudikeleti force-pushed the dudik/di/report-line-probe-errors branch from 3b4bc30 to e8b4868 Compare May 20, 2026 09:26
@dudikeleti
dudikeleti requested a review from Copilot May 20, 2026 09:30
@dudikeleti
dudikeleti marked this pull request as ready for review May 20, 2026 09:30
@dudikeleti
dudikeleti requested a review from a team as a code owner May 20, 2026 09:30
Copilot AI reviewed May 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Dynamic Instrumentation line-probe resolution feedback by reporting certain retryable “unbound” resolution failures as backend ERROR statuses (with stable error keys for deduplication), while still keeping those probes retryable so they can bind later when additional assemblies load. It also adjusts probe-status polling to avoid replaying explicitly pushed statuses, and adds test coverage for the new status transitions/deduplication behavior.

Changes:

  • Add retryable error reporting metadata to LineProbeResolveResult (stable error key/details + ReportError flag) and enhance source-path mismatch diagnostics.
  • Update DynamicInstrumentation to (a) report retryable mismatch failures as ERROR while keeping probes in the retry set, (b) stop retrying terminal resolver errors, and (c) deduplicate repeated retryable error reports by stable error key.
  • Update ProbeStatusPoller behavior to avoid replaying explicitly pushed statuses during poll cycles; add/extend unit and integration tests for these transitions.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tracer/test/Datadog.Trace.Tests/Debugger/ProbeStatusSinkTests.cs Adds coverage to ensure explicit ERROR statuses aren’t replayed during polling.
tracer/test/Datadog.Trace.Tests/Debugger/DynamicInstrumentationTests.cs Adds unit tests for retryable line-probe error reporting, deduplication, and retry/terminal behavior.
tracer/test/Datadog.Trace.Debugger.IntegrationTests/LineProbeResolverTest.cs Updates/extends integration assertions for retryable mismatch errors and stable key/details payloads.
tracer/src/Datadog.Trace/Debugger/ProbeStatuses/ProbeStatusPoller.cs Stops poll cycles from re-emitting explicit statuses by only polling fetchable (default) probes.
tracer/src/Datadog.Trace/Debugger/Models/LineProbeResolveResult.cs Extends resolve result with stable error key/details and a ReportError signal.
tracer/src/Datadog.Trace/Debugger/LineProbeResolver.cs Produces stable mismatch error keys/details and builds richer mismatch diagnostics messages.
tracer/src/Datadog.Trace/Debugger/DynamicInstrumentation.cs Reports retryable mismatch failures as ERROR (deduped), keeps retry set for non-terminal unbound, stops retrying terminal errors, and adds an injectable native instrumentation delegate for testing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tracer/src/Datadog.Trace/Debugger/DynamicInstrumentation.cs Outdated
Comment thread tracer/test/Datadog.Trace.Tests/Debugger/DynamicInstrumentationTests.cs Outdated
Comment thread tracer/src/Datadog.Trace/Debugger/DynamicInstrumentation.cs Outdated
@dudikeleti
dudikeleti requested a review from Copilot May 20, 2026 10:19
Copilot AI reviewed May 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dudikeleti
dudikeleti force-pushed the dudik/di/report-line-probe-errors branch from 31d4d67 to a1b0c67 Compare May 20, 2026 14:43
@dudikeleti
dudikeleti requested a review from tylfin May 20, 2026 14:44
@dudikeleti
dudikeleti force-pushed the dudik/di/report-line-probe-errors branch from a1b0c67 to 09ae91f Compare May 20, 2026 16:41
@dudikeleti
dudikeleti requested a review from Copilot May 20, 2026 16:42
Copilot AI reviewed May 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dudikeleti
dudikeleti requested a review from andreimatei May 20, 2026 20:23
@dudikeleti
dudikeleti enabled auto-merge (squash) May 20, 2026 20:50
@dudikeleti
dudikeleti requested a review from jpbempel May 22, 2026 09:25
@dudikeleti
dudikeleti requested a review from P403n1x87 May 22, 2026 09:25
@dudikeleti
dudikeleti merged commit 3125784 into master May 22, 2026
141 checks passed
@dudikeleti
dudikeleti deleted the dudik/di/report-line-probe-errors branch May 22, 2026 09:28
@github-actions github-actions Bot added this to the vNext-v3 milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@P403n1x87 P403n1x87 P403n1x87 approved these changes

Assignees

No one assigned

Labels

area:debugger

Projects

None yet

Milestone

3.45.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dudikeleti @P403n1x87