Decrease warnings part 4#8599
Conversation
BenchmarksBenchmark execution time: 2026-05-12 12:16:59 Comparing candidate commit 0f9685f in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 2 performance improvements and 4 performance regressions! Performance is the same for 49 metrics, 17 unstable metrics, 92 known flaky benchmarks, 34 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8599) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (73ms) : 70, 76
master - mean (73ms) : 69, 77
section Bailout
This PR (8599) - mean (78ms) : 75, 82
master - mean (78ms) : 75, 81
section CallTarget+Inlining+NGEN
This PR (8599) - mean (1,097ms) : 1049, 1146
master - mean (1,098ms) : 1055, 1142
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (114ms) : 109, 120
master - mean (113ms) : 109, 118
section Bailout
This PR (8599) - mean (117ms) : 113, 122
master - mean (118ms) : 112, 124
section CallTarget+Inlining+NGEN
This PR (8599) - mean (785ms) : 756, 814
master - mean (784ms) : 758, 810
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (102ms) : 96, 107
master - mean (105ms) : 99, 111
section Bailout
This PR (8599) - mean (104ms) : 99, 109
master - mean (103ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8599) - mean (942ms) : 896, 988
master - mean (945ms) : 903, 987
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (101ms) : 97, 106
master - mean (101ms) : 97, 105
section Bailout
This PR (8599) - mean (104ms) : 99, 108
master - mean (104ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8599) - mean (825ms) : 783, 866
master - mean (824ms) : 779, 869
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (193ms) : 190, 197
master - mean (190ms) : 187, 193
section Bailout
This PR (8599) - mean (198ms) : 195, 201
master - mean (193ms) : 192, 195
section CallTarget+Inlining+NGEN
This PR (8599) - mean (1,170ms) : 1131, 1210
master - mean (1,160ms) : 1122, 1199
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (278ms) : 272, 283
master - mean (277ms) : 270, 283
section Bailout
This PR (8599) - mean (278ms) : 274, 281
master - mean (279ms) : 274, 285
section CallTarget+Inlining+NGEN
This PR (8599) - mean (936ms) : 914, 959
master - mean (941ms) : 920, 961
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (271ms) : 267, 274
master - mean (273ms) : 266, 280
section Bailout
This PR (8599) - mean (271ms) : 268, 274
master - mean (274ms) : 268, 280
section CallTarget+Inlining+NGEN
This PR (8599) - mean (1,134ms) : 1076, 1191
master - mean (1,152ms) : 1101, 1202
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8599) - mean (279ms) : 270, 289
master - mean (283ms) : 276, 290
section Bailout
This PR (8599) - mean (274ms) : 268, 280
master - mean (279ms) : 271, 288
section CallTarget+Inlining+NGEN
This PR (8599) - mean (1,029ms) : 991, 1067
master - mean (1,044ms) : 994, 1094
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Part 4 of the warning-reduction series. 7 warning sources fixed across profiler demos and tracer test-applications.
Reason for change
Continuing the cleanup of CI build warnings; this batch surfaced after parts 1-3 merged.
Implementation details
Samples.BuggyBits/CompanyInformationController.cs— reorderedContact(public) aboveGetGitHubPageViaThread(private) to satisfy SA1202; added whitespace around=inIndex(bool shortLived = false)default value to satisfy SA1003.Samples.BuggyBits/Program.cs— movedCreateHostBuilder(public) up aboveGetOpenPortso all public members come before any private ones (SA1202).Samples.Computer01/AppDomainCrash.cs— moved the// just swallowcomment from inline-on-catchinto the catch block body (SA1108).Samples.ExceptionGenerator/GenericExceptionsScenario.cs— wrapped theException(SerializationInfo, StreamingContext)ctor and theSystem.Runtime.Serializationusing directive in#if !NET8_0_OR_GREATER. The ctor is the classic pre-net8 Exception subclass pattern; preserved on older TFMs, removed on net8+ where it's obsolete.Samples.LifetimeManager.TerminationSignals/Program.cs— added!toAssembly.GetType(name, throwOnError: true). WiththrowOnError: truethe BCL throwsTypeLoadExceptionrather than returning null, so the value is guaranteed non-null at runtime even though the BCL annotation is conservative.Samples.Debugger.AspNetCore5.csproj— scoped<NoWarn>NETSDK1206</NoWarn>toIsTargetFrameworkCompatible('net8.0'). The deprecatedalpine-*RIDs come from a transitive package (SQLitePCLRaw.lib.e_sqlite3); the suppression only activates on net8+ where the warning fires, leaving older TFMs untouched.Test coverage
No behavioral changes. CI verifies the warning count drops without breaking compilation.
Other details