Skip sending errors to instrumentation telemetry for performance counter initialization#8598
Conversation
BenchmarksBenchmark execution time: 2026-05-11 11:58:04 Comparing candidate commit 2559d5a in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 3 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 18 unstable metrics, 86 known flaky benchmarks, 40 flaky benchmarks without significant changes.
|
|
FYI I changed your link to error tracking to be the exact issue URL so it wired up the issue to this PR |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8598) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (73ms) : 70, 76
master - mean (75ms) : 71, 80
section Bailout
This PR (8598) - mean (77ms) : 75, 79
master - mean (78ms) : 75, 82
section CallTarget+Inlining+NGEN
This PR (8598) - mean (1,129ms) : 1074, 1184
master - mean (1,125ms) : 1071, 1179
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (114ms) : 110, 118
master - mean (115ms) : 108, 123
section Bailout
This PR (8598) - mean (119ms) : 113, 125
master - mean (115ms) : 112, 118
section CallTarget+Inlining+NGEN
This PR (8598) - mean (810ms) : 787, 832
master - mean (808ms) : 783, 834
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (104ms) : 97, 111
master - mean (103ms) : 98, 109
section Bailout
This PR (8598) - mean (103ms) : 98, 108
master - mean (104ms) : 99, 109
section CallTarget+Inlining+NGEN
This PR (8598) - mean (951ms) : 911, 991
master - mean (946ms) : 910, 981
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (104ms) : 97, 111
master - mean (100ms) : 96, 104
section Bailout
This PR (8598) - mean (103ms) : 98, 108
master - mean (104ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8598) - mean (832ms) : 779, 886
master - mean (835ms) : 778, 892
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (194ms) : 190, 197
master - mean (195ms) : 191, 198
section Bailout
This PR (8598) - mean (197ms) : 195, 200
master - mean (199ms) : 196, 201
section CallTarget+Inlining+NGEN
This PR (8598) - mean (1,236ms) : 1159, 1312
master - mean (1,212ms) : 1173, 1251
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (286ms) : 277, 294
master - mean (277ms) : 269, 284
section Bailout
This PR (8598) - mean (283ms) : 273, 292
master - mean (278ms) : 274, 282
section CallTarget+Inlining+NGEN
This PR (8598) - mean (959ms) : 938, 980
master - mean (964ms) : 938, 990
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (271ms) : 268, 275
master - mean (276ms) : 263, 290
section Bailout
This PR (8598) - mean (272ms) : 268, 275
master - mean (273ms) : 268, 278
section CallTarget+Inlining+NGEN
This PR (8598) - mean (1,148ms) : 1103, 1192
master - mean (1,144ms) : 1097, 1191
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8598) - mean (270ms) : 266, 274
master - mean (277ms) : 266, 287
section Bailout
This PR (8598) - mean (269ms) : 266, 272
master - mean (275ms) : 264, 287
section CallTarget+Inlining+NGEN
This PR (8598) - mean (1,028ms) : 989, 1066
master - mean (1,023ms) : 980, 1067
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Skip sending errors to instrumentation telemetry for performance counter initialization
Reason for change
We were already skipping logging these errors inside
InitializePerformanceCounters, but after logging, these known failure paths callthrow, which then gets caught and re-logged with a more generic error. There's little value in sending this to telemetry, because this is an app-level permissions issue that we can't resolve directly.Implementation details
Error->ErrorSkipTelemetryTest coverage
meh
Other details
Error Tracking