Skip to content

[ASM Test] Add IIS CI coverage for WebApi null-action ASM test#8597

Merged
dudikeleti merged 1 commit into
masterfrom
dudik/tests/aspnetwebapi-null-action-iis
May 11, 2026
Merged

[ASM Test] Add IIS CI coverage for WebApi null-action ASM test#8597
dudikeleti merged 1 commit into
masterfrom
dudik/tests/aspnetwebapi-null-action-iis

Conversation

@dudikeleti

@dudikeleti dudikeleti commented May 11, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Adds the missing RunOnWindows=True and LoadFromGAC=True traits to AspNetWebApi.TestNullAction.
  • Ensures the null-action WebApi ASM test is included by the Windows IIS AppSec CI filter.
  • Updates the affected null-action snapshots for the current ASP.NET component: aspnet tag output.

Reason for change

  • AspNetWebApi.TestNullAction was not exercised by the IIS AppSec CI jobs, so snapshot changes could be missed by PR CI.
  • Covering this test in IIS CI keeps local focused runs and CI validation aligned.

Implementation details

  • The trait additions match the neighboring IIS WebApi ASM tests in AspNetWebApi.cs.
  • Snapshot updates cover classic/integrated IIS modes with security enabled and disabled.
  • No shared IIS harness workaround changes are included.

Test coverage

  • AspNetWebApi.TestNullAction

@dudikeleti
dudikeleti requested a review from a team as a code owner May 11, 2026 10:19
@dudikeleti dudikeleti changed the title [Tests] Add IIS CI coverage for WebApi null-action ASM test [ASM Test] Add IIS CI coverage for WebApi null-action ASM test May 11, 2026
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

16 occurrences of :

+      component: aspnet,

@github-actions github-actions Bot added the area:tests unit tests, integration tests label May 11, 2026
@pr-commenter

pr-commenter Bot commented May 11, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-11 11:18:41

Comparing candidate commit 76bdfa9 in PR branch dudik/tests/aspnetwebapi-null-action-iis with baseline commit 76f0db1 in branch master.

Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥
Check Gitlab CI job log to find if any benchmark has crashed.

Scenarios present only in baseline:

  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • Benchmarks.OpenTelemetry.Api.Trace.ActivityBenchmark.StartSpan net472

Found 3 performance improvements and 5 performance regressions! Performance is the same for 50 metrics, 14 unstable metrics, 87 known flaky benchmarks, 39 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartActiveSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartRootSpan net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TracerBenchmark.StartSpan_GetCurrentSpan net6.0

  • 🟥 allocated_mem [+143 bytes; +144 bytes] or [+10.108%; +10.117%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 throughput [-324411.097op/s; -297695.552op/s] or [-61.553%; -56.484%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net6.0

  • 🟥 throughput [-69982.610op/s; -63214.676op/s] or [-47.540%; -42.943%]
  • 🟩 execution_time [-30.511ms; -15.593ms] or [-15.141%; -7.738%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-39059.789op/s; -34122.450op/s] or [-19.585%; -17.109%]
  • 🟩 execution_time [-81.721ms; -77.196ms] or [-41.328%; -39.040%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0

  • unstable execution_time [+20.671ms; +55.379ms] or [+15.958%; +42.752%]
  • unstable throughput [-65958.222op/s; -33754.331op/s] or [-31.844%; -16.297%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1

  • unstable execution_time [-36.627ms; -11.942ms] or [-31.982%; -10.428%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0

  • unstable execution_time [-18.476ms; +22.305ms] or [-11.937%; +14.411%]
  • unstable throughput [-24727.477op/s; -1110.216op/s] or [-16.088%; -0.722%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1

  • unstable execution_time [+12.721ms; +37.921ms] or [+14.772%; +44.035%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [+11.174ms; +40.087ms] or [+8.649%; +31.026%]
  • unstable throughput [-36134.133op/s; -12673.871op/s] or [-19.675%; -6.901%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [-36.922ms; -12.579ms] or [-32.612%; -11.110%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-51.278ms; -23.590ms] or [-29.181%; -13.424%]
  • unstable throughput [+14183.094op/s; +29340.030op/s] or [+12.021%; +24.867%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [+30.092ms; +60.412ms] or [+33.534%; +67.320%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0

  • unstable execution_time [+11.686ms; +28.954ms] or [+9.704%; +24.042%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0

  • unstable execution_time [-22.770ms; -4.604ms] or [-16.582%; -3.353%]
  • unstable throughput [-1222.484op/s; +17473.848op/s] or [-0.672%; +9.609%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0

  • unstable execution_time [-31.737ms; -14.022ms] or [-21.672%; -9.575%]
  • 🟩 throughput [+13128.155op/s; +28862.729op/s] or [+8.195%; +18.018%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-7.698%; -7.691%]
  • unstable execution_time [-10.702ms; +14.245ms] or [-7.747%; +10.311%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0

  • unstable execution_time [-11.736ms; +34.063ms] or [-6.892%; +20.005%]
  • unstable throughput [-12888.136op/s; +32078.285op/s] or [-9.340%; +23.247%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1

  • unstable execution_time [+8.873ms; +34.151ms] or [+9.932%; +38.227%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-5.210%; -5.202%]
  • unstable execution_time [-75.870ms; -37.218ms] or [-47.340%; -23.222%]
  • unstable throughput [+24151.754op/s; +48038.125op/s] or [+23.603%; +46.947%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1

  • unstable execution_time [-18344.939µs; +17162.095µs] or [-16.365%; +15.310%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0

  • unstable execution_time [-37.644ms; -7.257ms] or [-21.594%; -4.163%]
  • unstable throughput [+14007.182op/s; +27829.063op/s] or [+13.028%; +25.883%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1

  • unstable execution_time [+9.385ms; +33.986ms] or [+10.209%; +36.970%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0

  • 🟩 allocated_mem [-96 bytes; -95 bytes] or [-5.829%; -5.822%]
  • unstable execution_time [-23.644ms; -4.146ms] or [-16.962%; -2.974%]
  • unstable throughput [+25325.381op/s; +49238.844op/s] or [+17.622%; +34.261%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1

  • unstable execution_time [+11.749ms; +37.470ms] or [+13.842%; +44.144%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0

  • 🟩 allocated_mem [-144 bytes; -143 bytes] or [-9.188%; -9.180%]
  • unstable execution_time [+10.202ms; +44.299ms] or [+8.243%; +35.793%]
  • unstable throughput [-27495.414op/s; -4346.567op/s] or [-15.217%; -2.406%]

scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1

  • unstable execution_time [+29.038ms; +59.066ms] or [+32.184%; +65.466%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-9559.938op/s; -8606.379op/s] or [-11.335%; -10.205%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • unstable execution_time [-50.119ms; -27.847ms] or [-25.004%; -13.893%]
  • 🟥 throughput [-53633.461op/s; -42818.371op/s] or [-45.081%; -35.991%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • unstable execution_time [-70.684ms; -42.932ms] or [-35.552%; -21.593%]
  • 🟥 throughput [-6798.965op/s; -5371.439op/s] or [-6.913%; -5.462%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+310.609ms; +326.631ms] or [+154.135%; +162.086%]
  • 🟥 throughput [-56.749op/s; -43.874op/s] or [-10.210%; -7.894%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+99.584ms; +101.196ms] or [+78.678%; +79.951%]
  • 🟩 throughput [+84.642op/s; +90.616op/s] or [+11.160%; +11.947%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+84.516ms; +86.344ms] or [+74.793%; +76.411%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+9.299%; +9.310%]
  • 🟩 execution_time [-74.530ms; -53.510ms] or [-34.808%; -24.991%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]
  • 🟩 execution_time [-47.740ms; -27.712ms] or [-22.733%; -13.196%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-269612.819op/s; -264360.566op/s] or [-27.529%; -26.993%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+439 bytes; +440 bytes] or [+35.945%; +35.954%]
  • 🟩 execution_time [-55.232ms; -33.330ms] or [-24.631%; -14.864%]
  • unstable throughput [-399253.150op/s; -298110.832op/s] or [-42.653%; -31.848%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-139966.620op/s; -123584.347op/s] or [-20.111%; -17.757%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 execution_time [-35.634ms; -20.468ms] or [-17.979%; -10.327%]
  • 🟥 throughput [-25968.585op/s; -13299.447op/s] or [-16.523%; -8.462%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • unstable execution_time [-50.048ms; -30.068ms] or [-25.516%; -15.330%]
  • 🟩 throughput [+10201.722op/s; +12858.915op/s] or [+8.127%; +10.244%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-68.195ms; -51.825ms] or [-33.717%; -25.623%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-100.332ms; -79.032ms] or [-46.250%; -36.431%]
  • 🟩 throughput [+155954.648op/s; +223554.019op/s] or [+6.190%; +8.873%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+301.220ms; +315.036ms] or [+150.509%; +157.413%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • unstable execution_time [+152.211ms; +190.452ms] or [+76.760%; +96.046%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+302.037ms; +309.020ms] or [+152.142%; +155.660%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.741ms; +311.440ms] or [+146.239%; +152.967%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+235.281ms; +243.809ms] or [+115.020%; +119.189%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+258.624ms; +271.315ms] or [+129.260%; +135.603%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+18.426µs; +42.084µs] or [+5.882%; +13.435%]
  • 🟥 throughput [-395.646op/s; -196.526op/s] or [-12.333%; -6.126%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.865ms; +301.090ms] or [+149.664%; +150.275%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+355.378ms; +367.834ms] or [+386.133%; +399.667%]
  • 🟥 throughput [-6764.193op/s; -6595.904op/s] or [-55.582%; -54.199%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+293.582ms; +338.735ms] or [+222.914%; +257.198%]
  • 🟥 throughput [-1264.636op/s; -1037.913op/s] or [-12.242%; -10.048%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+295.398ms; +310.706ms] or [+135.821%; +142.860%]
  • 🟥 throughput [-680.856op/s; -663.676op/s] or [-61.692%; -60.135%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [-48.895ms; +85.204ms] or [-20.837%; +36.310%]
  • 🟥 throughput [-715.046op/s; -620.635op/s] or [-47.694%; -41.397%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.305KB; +2.308KB] or [+5.442%; +5.450%]
  • 🟥 execution_time [+337.677ms; +346.781ms] or [+201.970%; +207.415%]
  • 🟥 throughput [-724.210op/s; -690.094op/s] or [-50.426%; -48.050%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-198.389µs; -188.936µs] or [-10.050%; -9.571%]
  • 🟩 throughput [+53.675op/s; +56.618op/s] or [+10.596%; +11.177%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-217.179µs; -202.621µs] or [-5.507%; -5.138%]
  • 🟩 throughput [+13.750op/s; +14.788op/s] or [+5.422%; +5.831%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+307.031ms; +320.949ms] or [+154.615%; +161.624%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • unstable execution_time [+181.635ms; +238.891ms] or [+91.018%; +119.709%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.842ms; +309.516ms] or [+151.633%; +155.488%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.831ms; +316.931ms] or [+152.574%; +159.152%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • unstable execution_time [+231.249ms; +259.478ms] or [+114.342%; +128.300%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+304.387ms; +311.011ms] or [+154.277%; +157.634%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+304.210ms; +318.353ms] or [+152.686%; +159.784%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+304.898ms; +313.289ms] or [+151.964%; +156.146%]
  • 🟩 throughput [+34744.697op/s; +44834.262op/s] or [+6.899%; +8.903%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+302.608ms; +308.249ms] or [+150.545%; +153.351%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • unstable execution_time [-52.732ms; -27.043ms] or [-24.521%; -12.575%]
  • unstable throughput [-161355.542op/s; -113150.890op/s] or [-44.264%; -31.040%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-100.232ms; -96.154ms] or [-50.278%; -48.232%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-25.355KB; -25.332KB] or [-9.249%; -9.241%]
  • unstable execution_time [-63.160µs; -5.825µs] or [-12.483%; -1.151%]
  • unstable throughput [+41.209op/s; +251.474op/s] or [+2.056%; +12.549%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 throughput [+93.985op/s; +247.742op/s] or [+5.369%; +14.154%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+3.060µs; +7.422µs] or [+7.234%; +17.544%]
  • 🟥 throughput [-3492.293op/s; -1589.591op/s] or [-14.701%; -6.692%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.078µs; -5.076µs] or [-21.842%; -7.875%]
  • unstable throughput [+1475.719op/s; +3415.181op/s] or [+9.054%; +20.953%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.507ms; +315.188ms] or [+152.904%; +159.314%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+304.528ms; +311.769ms] or [+155.004%; +158.689%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.861ms; +309.339ms] or [+151.619%; +154.862%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • unstable execution_time [-61.116ms; -32.364ms] or [-30.549%; -16.177%]
  • unstable throughput [-206416.672op/s; -132976.015op/s] or [-39.070%; -25.170%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • unstable execution_time [-56.643ms; -26.263ms] or [-28.712%; -13.313%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.406ms; +316.268ms] or [+150.722%; +157.631%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • unstable execution_time [+177.163ms; +247.384ms] or [+88.963%; +124.224%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+305.785ms; +312.277ms] or [+155.075%; +158.367%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.076ms; +300.963ms] or [+149.680%; +150.122%]
  • 🟩 throughput [+60032858.069op/s; +60341948.904op/s] or [+43.720%; +43.945%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+374.405ms; +391.683ms] or [+465.639%; +487.128%]
  • 🟥 throughput [-7456.303op/s; -7220.894op/s] or [-57.641%; -55.821%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+301.566ms; +303.941ms] or [+150.414%; +151.599%]
  • 🟥 throughput [-29628081.449op/s; -28456698.072op/s] or [-13.123%; -12.604%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • unstable execution_time [-75.933ms; -50.118ms] or [-37.191%; -24.547%]
  • unstable throughput [-202264.796op/s; -49852.991op/s] or [-18.885%; -4.655%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 execution_time [-97.351ms; -92.935ms] or [-49.260%; -47.026%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 execution_time [-89.995ms; -85.850ms] or [-46.888%; -44.728%]
  • 🟩 throughput [+74767.737op/s; +105919.898op/s] or [+5.787%; +8.198%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • unstable execution_time [-55.207ms; -28.237ms] or [-27.124%; -13.873%]
  • 🟩 throughput [+75352.077op/s; +89205.802op/s] or [+7.484%; +8.860%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • unstable execution_time [-89.370ms; -69.324ms] or [-44.631%; -34.620%]
  • unstable throughput [-37297.038op/s; +23540.513op/s] or [-6.772%; +4.275%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • unstable execution_time [-51.608ms; -24.658ms] or [-25.930%; -12.389%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • unstable execution_time [-99.802ms; -77.038ms] or [-49.919%; -38.533%]
  • unstable throughput [-89771.581op/s; +27692.660op/s] or [-10.030%; +3.094%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • unstable execution_time [-30.740ms; -7.311ms] or [-15.612%; -3.713%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

NachoEchevarria
NachoEchevarria reviewed May 11, 2026
View reviewed changes
Comment thread tracer/test/Datadog.Trace.Security.IntegrationTests/AspNetWebApi.cs
}

[SkippableFact]
[Trait("RunOnWindows", "True")]

@NachoEchevarria NachoEchevarria May 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other tests in this file have [Trait("Category", "EndToEnd")], probably it's worth adding it for consistency even though I am not sure if it's used

@dudikeleti
dudikeleti merged commit bbdbeb4 into master May 11, 2026
137 checks passed
@dudikeleti
dudikeleti deleted the dudik/tests/aspnetwebapi-null-action-iis branch May 11, 2026 16:06
@github-actions github-actions Bot added this to the vNext-v3 milestone May 11, 2026
@dudikeleti dudikeleti mentioned this pull request May 11, 2026
Merged
dudikeleti added a commit that referenced this pull request May 12, 2026
@dudikeleti @cursoragent
[ASM Test] Mark WebApi null-action test as end-to-end (#8604)
4f292f0 
## Summary of changes
- Mark the WebApi null-action ASM IIS test with the EndToEnd category
trait.

## Reason for change
- Keeps the test metadata consistent with the neighboring WebApi IIS
tests added by #8597.

## Implementation details
- Adds only the missing `[Trait("Category", "EndToEnd")]` attribute to
`TestNullAction`.

## Test coverage
- metadata-only test attribute change.

Co-authored-by: Cursor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.44.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dudikeleti @NachoEchevarria