Skip to content

Configure the benchmarks project for micro-benchmarks#859

Merged
kevingosse merged 2 commits into
masterfrom
kevin/microbenchmarks
Aug 14, 2020
Merged

Configure the benchmarks project for micro-benchmarks#859
kevingosse merged 2 commits into
masterfrom
kevin/microbenchmarks

Conversation

@kevingosse

Copy link
Copy Markdown
Contributor
  • Added the project to the minimal solution
  • Added a microbenchmarks folder and a gitignore file to ignore the contents of that folder

@kevingosse
kevingosse requested a review from a team as a code owner August 13, 2020 12:46
@tonyredondo

Copy link
Copy Markdown
Member

Is that the same Benchmark project from the complete solution that wasn't added to the Minimal solution?

@kevingosse

Copy link
Copy Markdown
Contributor Author

Is that the same Benchmark project from the complete solution that wasn't added to the Minimal solution?

Yup. I thought about it for a while but saw no obvious reason why this couldn't be used for micro-benchmarks as well.

@kevingosse

Copy link
Copy Markdown
Contributor Author

I don't know if there are any rules about what should and shouldn't go in the Minimal solution. I don't mind creating a benchmark solution, if needed.

@tonyredondo

Copy link
Copy Markdown
Member

Is that the same Benchmark project from the complete solution that wasn't added to the Minimal solution?

Yup. I thought about it for a while but saw no obvious reason why this couldn't be used for micro-benchmarks as well.

Cool, seems fine by me

- Added to the minimal solution
- Added a microbenchmarks folder with gitignore file
Otherwise, VS modifies the csproj when the first class is added to the folder
@kevingosse
kevingosse force-pushed the kevin/microbenchmarks branch from bd10e2e to b58aa6a Compare August 13, 2020 15:13
@kevingosse
kevingosse merged commit 5618720 into master Aug 14, 2020
@kevingosse
kevingosse deleted the kevin/microbenchmarks branch August 14, 2020 15:01
@zacharycmontoya zacharycmontoya added the area:benchmarks Benchmarks, throughput tests, Crank, Bombardier, etc label Aug 31, 2020
@zacharycmontoya zacharycmontoya added this to the 1.19.2 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:benchmarks Benchmarks, throughput tests, Crank, Bombardier, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants