Skip to content

[CI Visibility] propagate tests skipping enabled tag#8582

Merged
anmarchenko merged 2 commits into
masterfrom
anmarchenko/tests_skipped_tag_propagation
May 26, 2026
Merged

[CI Visibility] propagate tests skipping enabled tag#8582
anmarchenko merged 2 commits into
masterfrom
anmarchenko/tests_skipped_tag_propagation

Conversation

@anmarchenko

@anmarchenko anmarchenko commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary of changes

  • Propagate test.itr.tests_skipping.enabled to CI Visibility test suite and test spans.
  • Add the typed tag property on session tags so module, suite, and test tags can inherit the same value.
  • Update EVP assertions and snapshots for MSTest, NUnit, xUnit v2, and xUnit v3.

JIRA: SDTEST-3761

Reason for change

test.itr.tests_skipping.enabled was only emitted on session and module spans. Suite and test spans should carry the same session-level tests-skipping enabled value so all CI Visibility span levels expose consistent ITR metadata.

Implementation details

  • Seed the new typed tag from TestOptimization.SkippableFeature in session and module tag construction.
  • Copy the tag from module to suite tags and from suite to test tags.
  • Keep the existing late module/session SetTag behavior unchanged.
  • Regenerate the minimal CI Visibility tag-list output for TestSessionSpanTags.
  • Scrub local repo.name and repo.owner resource attributes from Verify snapshots to keep the EVP snapshots stable across developer environments.

Other details

N/A

@anmarchenko
anmarchenko requested review from a team as code owners May 7, 2026 12:29
@github-actions

github-actions Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

542 occurrences of :

+      test.itr.tests_skipping.enabled: false,

2599 occurrences of :

+      test.itr.tests_skipping.enabled: true,

@pr-commenter

pr-commenter Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-26 07:47:00

Comparing candidate commit 1acfba8 in PR branch anmarchenko/tests_skipped_tag_propagation with baseline commit 35f65d0 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 70 metrics, 1 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync net472

  • 🟥 throughput [-7060.228op/s; -6678.968op/s] or [-8.060%; -7.625%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-6127.024op/s; -5569.567op/s] or [-7.265%; -6.604%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+302.915ms; +308.872ms] or [+150.317%; +153.273%]
  • 🟥 throughput [-47.094op/s; -42.915op/s] or [-8.473%; -7.721%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+380.261ms; +382.559ms] or [+300.430%; +302.245%]
  • 🟩 throughput [+94.385op/s; +102.241op/s] or [+12.444%; +13.480%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+392.213ms; +395.450ms] or [+347.094%; +349.958%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.528%; +27.540%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.976%; +9.987%]
  • 🟩 execution_time [-15.150ms; -10.927ms] or [-7.076%; -5.103%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.500%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.743%; +105.758%]
  • 🟥 throughput [-275072.913op/s; -261167.606op/s] or [-28.086%; -26.666%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.557%; +38.566%]
  • 🟩 execution_time [-25.962ms; -21.088ms] or [-11.578%; -9.405%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.288%; +105.304%]
  • 🟥 throughput [-155015.524op/s; -139162.034op/s] or [-22.273%; -19.995%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+6673.597op/s; +9320.350op/s] or [+5.316%; +7.425%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+477240.090op/s; +493726.743op/s] or [+15.913%; +16.463%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.687ms; -14.351ms] or [-8.614%; -6.615%]
  • 🟩 throughput [+176569.851op/s; +229876.057op/s] or [+7.009%; +9.124%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.290ms; +300.384ms] or [+149.545%; +150.092%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.646ms; +303.811ms] or [+151.112%; +153.212%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.746ms; +302.225ms] or [+150.989%; +152.238%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.429ms; +298.886ms] or [+146.085%; +146.801%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+294.790ms; +297.444ms] or [+144.112%; +145.409%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.650ms; +304.450ms] or [+150.764%; +152.164%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+23.239µs; +46.922µs] or [+7.419%; +14.980%]
  • 🟥 throughput [-435.986op/s; -236.723op/s] or [-13.591%; -7.379%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.243ms; +299.949ms] or [+149.353%; +149.705%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+412.236ms; +418.081ms] or [+447.912%; +454.262%]
  • 🟩 throughput [+810.750op/s; +1017.151op/s] or [+6.662%; +8.358%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+267.129ms; +320.787ms] or [+202.829%; +243.570%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+269.467ms; +330.111ms] or [+123.898%; +151.782%]
  • 🟥 throughput [-581.642op/s; -529.860op/s] or [-52.702%; -48.010%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+208.052ms; +341.328ms] or [+88.663%; +145.460%]
  • 🟥 throughput [-680.309op/s; -596.580op/s] or [-45.377%; -39.792%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+334.250ms; +341.697ms] or [+199.920%; +204.374%]
  • 🟥 throughput [-416.041op/s; -377.358op/s] or [-28.968%; -26.275%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • unstable throughput [+9.605op/s; +113.187op/s] or [+1.793%; +21.127%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-169.080µs; -139.329µs] or [-8.565%; -7.058%]
  • 🟩 throughput [+38.878op/s; +47.900op/s] or [+7.675%; +9.456%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+304.579ms; +305.950ms] or [+153.380%; +154.071%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+303.026ms; +308.901ms] or [+151.847%; +154.791%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+298.760ms; +302.309ms] or [+150.084%; +151.867%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.585ms; +306.307ms] or [+152.450%; +153.817%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+297.005ms; +299.105ms] or [+146.856%; +147.894%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.218ms; +305.837ms] or [+153.177%; +155.011%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.554ms; +303.547ms] or [+150.851%; +152.353%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+299.218ms; +314.188ms] or [+149.133%; +156.594%]
  • 🟩 throughput [+36194.178op/s; +49451.087op/s] or [+7.187%; +9.819%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+301.703ms; +304.454ms] or [+150.095%; +151.463%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.783ms; -13.111ms] or [-7.804%; -6.097%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+5.454µs; +48.101µs] or [+1.347%; +11.881%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.529KB; -19.508KB] or [-7.124%; -7.116%]
  • unstable execution_time [-26525.345ns; +25992.104ns] or [-5.243%; +5.137%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • unstable execution_time [-82.039µs; -22.202µs] or [-14.217%; -3.847%]
  • 🟩 throughput [+88.320op/s; +257.805op/s] or [+5.046%; +14.729%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+9.939µs; +15.452µs] or [+23.492%; +36.524%]
  • 🟥 throughput [-6284.350op/s; -4264.869op/s] or [-26.455%; -17.954%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-12.421µs; -3.773µs] or [-19.271%; -5.854%]
  • unstable throughput [+946.932op/s; +2756.102op/s] or [+5.810%; +16.910%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.880ms; +303.523ms] or [+152.587%; +153.417%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.199ms; +304.784ms] or [+153.818%; +155.134%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.197ms; +303.115ms] or [+149.785%; +151.746%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+36813.717op/s; +40025.846op/s] or [+6.968%; +7.576%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+298.894ms; +300.910ms] or [+148.972%; +149.976%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.653ms; +303.427ms] or [+151.476%; +152.366%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+303.474ms; +305.753ms] or [+153.902%; +155.058%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.103ms; +301.095ms] or [+149.693%; +150.188%]
  • 🟩 throughput [+61076145.667op/s; +61427450.009op/s] or [+44.479%; +44.735%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+423.571ms; +427.510ms] or [+526.786%; +531.684%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.773ms; +300.783ms] or [+149.520%; +150.024%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+89305.775op/s; +98645.411op/s] or [+8.338%; +9.210%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+55865.274op/s; +75265.269op/s] or [+6.466%; +8.712%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+73056.876op/s; +104708.405op/s] or [+5.655%; +8.105%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+84521.080op/s; +91743.749op/s] or [+8.394%; +9.112%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+40343.369op/s; +48219.994op/s] or [+7.326%; +8.756%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+27482.075op/s; +37121.315op/s] or [+6.151%; +8.309%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+58296.447op/s; +103132.912op/s] or [+6.513%; +11.523%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.ActivityBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_AddEvent_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_GetContext_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_RecordException_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetAttributes_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_SetStatus_Sampled netcoreapp3.1
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net472
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled net6.0
  • scenario:Benchmarks.OpenTelemetry.InstrumentedApi.Trace.TelemetrySpanBenchmark.StartSpan_UpdateName_Sampled netcoreapp3.1
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8582) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.37 ± (72.36 - 72.71) ms74.17 ± (74.23 - 74.78) ms+2.5%✅⬆️
.NET Framework 4.8 - Bailout
duration78.71 ± (78.69 - 79.17) ms77.49 ± (77.35 - 77.70) ms-1.5%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1104.12 ± (1106.74 - 1114.93) ms1098.92 ± (1097.76 - 1104.16) ms-0.5%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.82 ± (22.76 - 22.89) ms22.49 ± (22.43 - 22.54) ms-1.5%✅
process.time_to_main_ms86.60 ± (86.18 - 87.01) ms85.57 ± (85.29 - 85.85) ms-1.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.91) MB10.93 ± (10.93 - 10.93) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.71 ± (22.66 - 22.76) ms22.15 ± (22.11 - 22.19) ms-2.5%✅
process.time_to_main_ms87.36 ± (87.10 - 87.61) ms85.19 ± (84.99 - 85.40) ms-2.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.96) MB10.95 ± (10.95 - 10.96) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.48 ± (211.61 - 213.34) ms213.77 ± (212.83 - 214.72) ms+0.6%✅⬆️
process.time_to_main_ms539.14 ± (537.84 - 540.45) ms542.76 ± (541.62 - 543.91) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.61 ± (48.57 - 48.64) MB48.60 ± (48.57 - 48.64) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.3%✅
.NET 6 - Baseline
process.internal_duration_ms21.30 ± (21.25 - 21.34) ms21.47 ± (21.42 - 21.52) ms+0.8%✅⬆️
process.time_to_main_ms73.88 ± (73.69 - 74.08) ms75.82 ± (75.56 - 76.09) ms+2.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.64) MB10.65 ± (10.64 - 10.65) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.63 ± (21.52 - 21.73) ms21.22 ± (21.17 - 21.27) ms-1.9%✅
process.time_to_main_ms77.62 ± (77.25 - 77.99) ms75.70 ± (75.47 - 75.93) ms-2.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.74 - 10.75) MB10.76 ± (10.76 - 10.76) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms370.84 ± (368.90 - 372.78) ms366.89 ± (364.82 - 368.97) ms-1.1%✅
process.time_to_main_ms549.26 ± (548.10 - 550.43) ms549.15 ± (548.15 - 550.15) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.05 ± (50.03 - 50.07) MB50.08 ± (50.06 - 50.11) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.30 ± (19.27 - 19.33) ms19.27 ± (19.24 - 19.30) ms-0.2%✅
process.time_to_main_ms72.31 ± (72.12 - 72.50) ms72.62 ± (72.45 - 72.79) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.70 ± (7.69 - 7.70) MB7.69 ± (7.69 - 7.70) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.39 ± (19.35 - 19.44) ms19.58 ± (19.53 - 19.63) ms+0.9%✅⬆️
process.time_to_main_ms74.66 ± (74.40 - 74.91) ms75.88 ± (75.64 - 76.12) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.74 ± (7.73 - 7.74) MB7.73 ± (7.72 - 7.73) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms295.91 ± (293.86 - 297.96) ms294.95 ± (292.56 - 297.34) ms-0.3%✅
process.time_to_main_ms495.11 ± (494.01 - 496.21) ms497.77 ± (496.71 - 498.84) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.96 ± (36.94 - 36.99) MB36.94 ± (36.91 - 36.97) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.5%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration195.83 ± (195.70 - 196.58) ms198.29 ± (198.03 - 198.70) ms+1.3%✅⬆️
.NET Framework 4.8 - Bailout
duration200.28 ± (199.97 - 201.03) ms201.44 ± (201.05 - 201.73) ms+0.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1188.87 ± (1189.62 - 1194.96) ms1194.99 ± (1195.64 - 1201.85) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms193.17 ± (192.72 - 193.62) ms193.86 ± (193.44 - 194.29) ms+0.4%✅⬆️
process.time_to_main_ms83.85 ± (83.48 - 84.21) ms83.85 ± (83.54 - 84.17) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.20 ± (16.17 - 16.23) MB16.11 ± (16.08 - 16.13) MB-0.6%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms192.38 ± (191.91 - 192.86) ms192.65 ± (192.26 - 193.04) ms+0.1%✅⬆️
process.time_to_main_ms84.57 ± (84.26 - 84.89) ms84.55 ± (84.31 - 84.78) ms-0.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.21 ± (16.18 - 16.25) MB16.14 ± (16.11 - 16.16) MB-0.5%✅
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.5%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms383.42 ± (382.06 - 384.78) ms384.21 ± (382.86 - 385.56) ms+0.2%✅⬆️
process.time_to_main_ms532.88 ± (531.64 - 534.11) ms534.75 ± (533.47 - 536.04) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed57.25 ± (57.15 - 57.35) MB57.39 ± (57.25 - 57.52) MB+0.2%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms195.54 ± (195.07 - 196.02) ms196.07 ± (195.63 - 196.52) ms+0.3%✅⬆️
process.time_to_main_ms71.31 ± (71.11 - 71.52) ms71.94 ± (71.70 - 72.17) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.37 ± (16.34 - 16.40) MB16.41 ± (16.38 - 16.44) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.3%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms194.84 ± (194.35 - 195.32) ms195.63 ± (195.18 - 196.08) ms+0.4%✅⬆️
process.time_to_main_ms72.14 ± (71.97 - 72.32) ms72.79 ± (72.60 - 72.99) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.46 ± (16.43 - 16.49) MB16.42 ± (16.40 - 16.45) MB-0.2%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.1%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms584.35 ± (581.64 - 587.06) ms583.04 ± (580.01 - 586.08) ms-0.2%✅
process.time_to_main_ms536.24 ± (535.28 - 537.21) ms541.21 ± (540.23 - 542.20) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.12 ± (61.04 - 61.20) MB61.15 ± (61.07 - 61.23) MB+0.1%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms193.45 ± (192.87 - 194.02) ms193.93 ± (193.59 - 194.28) ms+0.3%✅⬆️
process.time_to_main_ms71.18 ± (70.95 - 71.42) ms71.45 ± (71.24 - 71.67) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.74 ± (11.72 - 11.76) MB11.71 ± (11.69 - 11.74) MB-0.2%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.6%✅
.NET 8 - Bailout
process.internal_duration_ms192.69 ± (192.29 - 193.10) ms193.18 ± (192.86 - 193.50) ms+0.3%✅⬆️
process.time_to_main_ms72.16 ± (71.93 - 72.38) ms72.35 ± (72.19 - 72.51) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.79 ± (11.76 - 11.81) MB11.73 ± (11.71 - 11.75) MB-0.5%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms511.81 ± (509.20 - 514.43) ms512.21 ± (509.51 - 514.91) ms+0.1%✅⬆️
process.time_to_main_ms489.47 ± (488.58 - 490.36) ms488.32 ± (487.50 - 489.14) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.69 ± (50.65 - 50.73) MB50.61 ± (50.57 - 50.64) MB-0.2%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (75ms)  : 70, 79
    master - mean (73ms)  : 70, 75

    section Bailout
    This PR (8582) - mean (78ms)  : 75, 80
    master - mean (79ms)  : 75, 82

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (1,101ms)  : 1055, 1147
    master - mean (1,111ms)  : 1049, 1173
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (115ms)  : 110, 120
    master - mean (116ms)  : 110, 122

    section Bailout
    This PR (8582) - mean (114ms)  : 111, 117
    master - mean (117ms)  : 112, 122

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (793ms)  : 765, 821
    master - mean (788ms)  : 761, 814
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (104ms)  : 98, 110
    master - mean (102ms)  : 97, 107

    section Bailout
    This PR (8582) - mean (104ms)  : 99, 108
    master - mean (106ms)  : 99, 113

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (947ms)  : 912, 982
    master - mean (948ms)  : 909, 986
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (100ms)  : 96, 104
    master - mean (100ms)  : 95, 104

    section Bailout
    This PR (8582) - mean (103ms)  : 98, 109
    master - mean (102ms)  : 97, 107

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (825ms)  : 785, 864
    master - mean (824ms)  : 787, 861
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (198ms)  : 195, 202
    master - mean (196ms)  : 191, 201

    section Bailout
    This PR (8582) - mean (201ms)  : 198, 205
    master - mean (200ms)  : 195, 206

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (1,199ms)  : 1154, 1243
    master - mean (1,192ms)  : 1156, 1229
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (286ms)  : 280, 292
    master - mean (286ms)  : 280, 291

    section Bailout
    This PR (8582) - mean (286ms)  : 281, 292
    master - mean (286ms)  : 279, 292

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (958ms)  : 938, 979
    master - mean (954ms)  : 928, 981
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (276ms)  : 269, 282
    master - mean (275ms)  : 268, 283

    section Bailout
    This PR (8582) - mean (277ms)  : 272, 282
    master - mean (275ms)  : 268, 283

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (1,153ms)  : 1108, 1199
    master - mean (1,150ms)  : 1111, 1189
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8582) - mean (275ms)  : 270, 280
    master - mean (275ms)  : 268, 282

    section Bailout
    This PR (8582) - mean (275ms)  : 270, 281
    master - mean (275ms)  : 269, 281

    section CallTarget+Inlining+NGEN
    This PR (8582) - mean (1,034ms)  : 982, 1086
    master - mean (1,034ms)  : 994, 1073
Loading

@anmarchenko
anmarchenko marked this pull request as draft May 7, 2026 14:31
@anmarchenko
anmarchenko marked this pull request as ready for review May 7, 2026 14:37
@anmarchenko

anmarchenko commented May 8, 2026

Copy link
Copy Markdown
Member Author

E2E Test Report: SUCCESS

Tested by: Shepherd Agent (autonomous QA for Datadog Test Optimization)

Test Environment

  • Method: Local testing with peasy-net + mockdog
  • Revision tested: aeb37b26e3688d29b6d557d2ddfc9620d490a4e8
  • PR branch: anmarchenko/tests_skipped_tag_propagation

Results

Check Result
TIA enabled: test.itr.tests_skipping.enabled=true on session span ✅
TIA enabled: tag propagated to module span ✅
TIA enabled: tag propagated to all 21 suite spans ✅
TIA enabled: tag propagated to all 319 test spans ✅
TIA disabled: test.itr.tests_skipping.enabled=false on session/module/suite/test spans ✅

Notes

  • While running the PR validation, I hit a Shepherd-side issue in crook's .NET build selection logic for Azure DevOps artifacts. I fixed that in Shepherd and reran the validation.
  • After the fix, crook selected the expected artifact-producing build and the PR branch validated cleanly.

Verification

  • Verified directly from fresh mockdog span data produced by the local run.
  • Confirmed the expected tag values at session, module, suite, and test span levels for both the enabled and disabled scenarios.

Test Methodology

  1. Ran peasy-net against the PR branch dependency with the itr-enabled scenario.
  2. Queried the resulting span data to confirm tag propagation on session/module/suite/test spans.
  3. Re-ran the same PR branch with the default scenario to confirm the disabled case stays false.

This E2E test was performed by Shepherd - autonomous QA agent for Datadog Test Optimization.

@anmarchenko
anmarchenko force-pushed the anmarchenko/tests_skipped_tag_propagation branch from aeb37b2 to aba37d5 Compare May 8, 2026 13:18
@anmarchenko
anmarchenko requested a review from tonyredondo May 12, 2026 06:56
tonyredondo
tonyredondo reviewed May 13, 2026
View reviewed changes
Comment thread tracer/test/Datadog.Trace.TestHelpers.SharedSource/VerifyHelper.cs Outdated
Comment on lines +256 to +257
&& kvp.Key != "repo.name"
&& kvp.Key != "repo.owner")

@tonyredondo tonyredondo May 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this doesn't have anything to do with the PR right?

@anmarchenko anmarchenko May 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I think this was part of trying to make tests pass, will check again

@anmarchenko anmarchenko May 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonyredondo the unrelated changes are removed

@anmarchenko ChatGPT Codex Connector

anmarchenko commented May 19, 2026

Copy link
Copy Markdown
Member Author

@tonyredondo this is ready for another pass.

@anmarchenko

anmarchenko commented May 22, 2026

Copy link
Copy Markdown
Member Author

@tonyredondo CI is green now; only approval is missing. Could you take another pass?

@anmarchenko
anmarchenko force-pushed the anmarchenko/tests_skipped_tag_propagation branch from 2be2016 to 1acfba8 Compare May 26, 2026 06:54
tonyredondo
tonyredondo approved these changes May 26, 2026
View reviewed changes

@tonyredondo tonyredondo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmarchenko
anmarchenko merged commit 169fbf4 into master May 26, 2026
136 checks passed
@anmarchenko
anmarchenko deleted the anmarchenko/tests_skipped_tag_propagation branch May 26, 2026 09:01
@github-actions github-actions Bot added this to the vNext-v3 milestone May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:ci-visibility

Projects

None yet

Milestone

3.45.0

Development

Successfully merging this pull request may close these issues.

2 participants

@anmarchenko @tonyredondo