Skip to content

[Profiler] Add guard-rails when creating a profile#8579

Merged
gleocadie merged 3 commits into
masterfrom
gleocadie/fix-potential-issue-in-profile-creation
May 7, 2026
Merged

[Profiler] Add guard-rails when creating a profile#8579
gleocadie merged 3 commits into
masterfrom
gleocadie/fix-potential-issue-in-profile-creation

Conversation

@gleocadie

@gleocadie gleocadie commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

Add guards to prevent crashing if failed at creating a FFI profile

Reason for change

This is to make the code safer.

Implementation details

  • Make public the static Profile::Create factory method and private the ctor
  • Check if value types and ffi calls succeed to return nullptr or a valid Profile instance

Test coverage

  • Added unit tests for failing case.

Other details

@gleocadie
gleocadie requested a review from a team as a code owner May 7, 2026 11:07
@github-actions github-actions Bot added the area:profiler Issues related to the continous-profiler label May 7, 2026
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 7, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8579) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.77 ± (74.78 - 75.47) ms72.52 ± (72.39 - 72.75) ms-3.0%✅
.NET Framework 4.8 - Bailout
duration79.43 ± (78.92 - 79.46) ms77.66 ± (77.56 - 77.92) ms-2.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1125.90 ± (1125.54 - 1132.96) ms1135.03 ± (1132.91 - 1141.66) ms+0.8%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.69 ± (22.62 - 22.75) ms22.67 ± (22.61 - 22.72) ms-0.1%✅
process.time_to_main_ms87.16 ± (86.80 - 87.51) ms86.06 ± (85.78 - 86.34) ms-1.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.93 ± (10.92 - 10.93) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.40 ± (22.36 - 22.44) ms22.83 ± (22.77 - 22.88) ms+1.9%✅⬆️
process.time_to_main_ms85.56 ± (85.35 - 85.76) ms89.39 ± (89.10 - 89.68) ms+4.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.96 ± (10.95 - 10.96) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms204.40 ± (203.79 - 205.00) ms205.54 ± (205.01 - 206.07) ms+0.6%✅⬆️
process.time_to_main_ms566.93 ± (565.53 - 568.34) ms569.53 ± (568.12 - 570.95) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.80 ± (49.77 - 49.83) MB49.81 ± (49.78 - 49.83) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.8%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.53 ± (21.47 - 21.59) ms21.10 ± (21.06 - 21.14) ms-2.0%✅
process.time_to_main_ms75.75 ± (75.46 - 76.03) ms73.30 ± (73.13 - 73.47) ms-3.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.62 - 10.63) MB10.64 ± (10.64 - 10.64) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.10 ± (21.06 - 21.13) ms21.48 ± (21.43 - 21.54) ms+1.8%✅⬆️
process.time_to_main_ms74.75 ± (74.58 - 74.93) ms77.14 ± (76.86 - 77.43) ms+3.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.74 ± (10.74 - 10.74) MB10.75 ± (10.75 - 10.75) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms353.37 ± (351.28 - 355.46) ms355.99 ± (353.63 - 358.35) ms+0.7%✅⬆️
process.time_to_main_ms563.86 ± (562.44 - 565.28) ms562.68 ± (561.17 - 564.18) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.97 ± (50.94 - 50.99) MB51.17 ± (51.15 - 51.19) MB+0.4%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.83 ± (19.77 - 19.89) ms19.43 ± (19.39 - 19.46) ms-2.0%✅
process.time_to_main_ms75.12 ± (74.84 - 75.40) ms73.58 ± (73.41 - 73.75) ms-2.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.68 - 7.69) MB7.67 ± (7.66 - 7.67) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.71 ± (19.65 - 19.77) ms19.44 ± (19.39 - 19.48) ms-1.4%✅
process.time_to_main_ms76.07 ± (75.79 - 76.34) ms74.40 ± (74.23 - 74.56) ms-2.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.72 - 7.73) MB7.72 ± (7.71 - 7.72) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms280.42 ± (278.17 - 282.67) ms280.65 ± (277.70 - 283.60) ms+0.1%✅⬆️
process.time_to_main_ms521.49 ± (520.14 - 522.84) ms523.28 ± (521.99 - 524.57) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.86 ± (37.83 - 37.90) MB37.88 ± (37.85 - 37.91) MB+0.0%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration202.64 ± (203.29 - 204.97) ms203.12 ± (203.35 - 204.58) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration207.02 ± (207.21 - 208.46) ms209.72 ± (209.67 - 211.36) ms+1.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1264.58 ± (1263.27 - 1269.26) ms1261.97 ± (1261.28 - 1269.31) ms-0.2%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms200.22 ± (199.53 - 200.92) ms199.68 ± (199.02 - 200.33) ms-0.3%✅
process.time_to_main_ms87.05 ± (86.71 - 87.39) ms87.20 ± (86.82 - 87.58) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.96 ± (15.94 - 15.97) MB15.98 ± (15.96 - 16.00) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-1.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms200.40 ± (199.56 - 201.25) ms199.29 ± (198.70 - 199.87) ms-0.6%✅
process.time_to_main_ms88.64 ± (88.27 - 89.02) ms88.51 ± (88.18 - 88.83) ms-0.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.98 ± (15.96 - 15.99) MB16.07 ± (16.06 - 16.09) MB+0.6%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.4%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms386.01 ± (384.62 - 387.41) ms384.88 ± (383.40 - 386.35) ms-0.3%✅
process.time_to_main_ms583.59 ± (581.82 - 585.36) ms577.11 ± (575.58 - 578.64) ms-1.1%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.59 ± (58.42 - 58.75) MB58.51 ± (58.40 - 58.62) MB-0.1%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms204.83 ± (204.19 - 205.46) ms205.60 ± (204.99 - 206.20) ms+0.4%✅⬆️
process.time_to_main_ms75.41 ± (75.12 - 75.71) ms76.60 ± (76.30 - 76.90) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.24 ± (16.22 - 16.26) MB16.29 ± (16.27 - 16.31) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-1.0%✅
.NET 6 - Bailout
process.internal_duration_ms205.14 ± (204.46 - 205.82) ms206.38 ± (205.82 - 206.94) ms+0.6%✅⬆️
process.time_to_main_ms76.82 ± (76.51 - 77.12) ms78.13 ± (77.81 - 78.45) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.29 ± (16.27 - 16.31) MB16.32 ± (16.30 - 16.34) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 21)+0.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms567.35 ± (564.70 - 569.99) ms567.72 ± (565.19 - 570.25) ms+0.1%✅⬆️
process.time_to_main_ms570.70 ± (569.50 - 571.90) ms576.70 ± (575.41 - 577.98) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.94 ± (61.90 - 61.97) MB62.04 ± (62.01 - 62.08) MB+0.2%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms202.87 ± (202.26 - 203.49) ms203.66 ± (203.15 - 204.16) ms+0.4%✅⬆️
process.time_to_main_ms74.81 ± (74.54 - 75.07) ms75.29 ± (75.06 - 75.52) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.64 ± (11.63 - 11.66) MB11.63 ± (11.61 - 11.64) MB-0.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.0%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms202.43 ± (201.72 - 203.14) ms203.39 ± (202.80 - 203.97) ms+0.5%✅⬆️
process.time_to_main_ms75.69 ± (75.44 - 75.95) ms76.59 ± (76.32 - 76.87) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.63 ± (11.62 - 11.65) MB11.71 ± (11.70 - 11.72) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.6%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms495.65 ± (491.23 - 500.07) ms509.73 ± (502.97 - 516.49) ms+2.8%✅⬆️
process.time_to_main_ms531.02 ± (529.46 - 532.59) ms539.23 ± (537.71 - 540.75) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.66 ± (51.61 - 51.70) MB51.62 ± (51.56 - 51.68) MB-0.1%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.4%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (73ms)  : 70, 75
    master - mean (75ms)  : 70, 80

    section Bailout
    This PR (8579) - mean (78ms)  : 76, 80
    master - mean (79ms)  : 75, 83

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (1,137ms)  : 1072, 1202
    master - mean (1,129ms)  : 1075, 1183
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (116ms)  : 110, 122
    master - mean (117ms)  : 110, 124

    section Bailout
    This PR (8579) - mean (120ms)  : 114, 125
    master - mean (115ms)  : 112, 118

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (812ms)  : 785, 838
    master - mean (808ms)  : 777, 839
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (101ms)  : 97, 104
    master - mean (104ms)  : 99, 109

    section Bailout
    This PR (8579) - mean (105ms)  : 99, 111
    master - mean (102ms)  : 98, 106

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (956ms)  : 910, 1003
    master - mean (951ms)  : 910, 991
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (101ms)  : 97, 105
    master - mean (103ms)  : 97, 109

    section Bailout
    This PR (8579) - mean (102ms)  : 99, 104
    master - mean (104ms)  : 99, 109

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (838ms)  : 778, 898
    master - mean (834ms)  : 791, 876
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (204ms)  : 195, 213
    master - mean (204ms)  : 192, 217

    section Bailout
    This PR (8579) - mean (211ms)  : 197, 224
    master - mean (208ms)  : 199, 217

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (1,265ms)  : 1205, 1325
    master - mean (1,266ms)  : 1223, 1309
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (297ms)  : 283, 311
    master - mean (298ms)  : 282, 315

    section Bailout
    This PR (8579) - mean (298ms)  : 283, 312
    master - mean (299ms)  : 283, 315

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (1,003ms)  : 980, 1027
    master - mean (1,010ms)  : 987, 1033
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (292ms)  : 280, 304
    master - mean (290ms)  : 276, 304

    section Bailout
    This PR (8579) - mean (294ms)  : 282, 306
    master - mean (292ms)  : 277, 307

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (1,175ms)  : 1139, 1211
    master - mean (1,171ms)  : 1132, 1210
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8579) - mean (290ms)  : 279, 302
    master - mean (289ms)  : 274, 305

    section Bailout
    This PR (8579) - mean (291ms)  : 278, 304
    master - mean (289ms)  : 274, 305

    section CallTarget+Inlining+NGEN
    This PR (8579) - mean (1,086ms)  : 982, 1191
    master - mean (1,065ms)  : 988, 1141
Loading

@pr-commenter

pr-commenter Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-07 15:19:01

Comparing candidate commit a667c15 in PR branch gleocadie/fix-potential-issue-in-profile-creation with baseline commit 6d9882f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 60 known flaky benchmarks, 27 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-9237.387op/s; -8754.208op/s] or [-10.953%; -10.380%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-6505.356op/s; -5351.992op/s] or [-6.615%; -5.442%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+324.528ms; +326.146ms] or [+161.042%; +161.845%]
  • 🟥 throughput [-41.331op/s; -37.709op/s] or [-7.436%; -6.785%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+380.546ms; +382.590ms] or [+300.655%; +302.270%]
  • 🟩 throughput [+92.855op/s; +96.951op/s] or [+12.243%; +12.783%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+390.590ms; +392.633ms] or [+345.657%; +347.466%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-16.013ms; -11.843ms] or [-7.479%; -5.531%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • 🟥 throughput [-259051.784op/s; -255666.329op/s] or [-26.450%; -26.105%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.373ms; -21.496ms] or [-11.761%; -9.586%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • 🟥 throughput [-137769.197op/s; -121762.158op/s] or [-19.795%; -17.495%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+10985.690op/s; +13924.631op/s] or [+6.990%; +8.860%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+11317.041op/s; +13968.815op/s] or [+9.015%; +11.128%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+445750.355op/s; +463197.937op/s] or [+14.863%; +15.445%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.185ms; -13.827ms] or [-8.383%; -6.374%]
  • 🟩 throughput [+200668.787op/s; +254068.682op/s] or [+7.965%; +10.085%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.181ms; +299.832ms] or [+149.491%; +149.816%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+300.810ms; +304.313ms] or [+151.699%; +153.466%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.513ms; +302.130ms] or [+150.871%; +152.189%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.472ms; +297.208ms] or [+145.615%; +145.977%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+297.197ms; +299.641ms] or [+145.289%; +146.483%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+300.178ms; +301.217ms] or [+150.028%; +150.548%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+23.090µs; +46.695µs] or [+7.371%; +14.907%]
  • 🟥 throughput [-434.068op/s; -235.450op/s] or [-13.531%; -7.340%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.842ms; +300.540ms] or [+149.652%; +150.000%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+365.205ms; +401.197ms] or [+396.811%; +435.917%]
  • 🟩 throughput [+1169.910op/s; +1299.873op/s] or [+9.613%; +10.681%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+293.978ms; +329.095ms] or [+223.215%; +249.879%]
  • 🟩 throughput [+705.385op/s; +902.325op/s] or [+6.829%; +8.735%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 allocated_mem [+2.825KB; +2.830KB] or [+5.019%; +5.028%]
  • unstable execution_time [+308.016ms; +361.110ms] or [+141.623%; +166.035%]
  • 🟥 throughput [-542.023op/s; -503.393op/s] or [-49.113%; -45.612%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+206.689ms; +339.906ms] or [+88.082%; +144.854%]
  • 🟥 throughput [-678.124op/s; -594.352op/s] or [-45.231%; -39.643%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 allocated_mem [+2.149KB; +2.152KB] or [+5.075%; +5.082%]
  • 🟥 execution_time [+329.619ms; +340.056ms] or [+197.150%; +203.393%]
  • 🟥 throughput [-410.502op/s; -374.894op/s] or [-28.583%; -26.103%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • unstable throughput [-0.451op/s; +53.186op/s] or [-0.084%; +9.928%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 throughput [+27.423op/s; +37.866op/s] or [+5.414%; +7.475%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+300.869ms; +302.753ms] or [+151.512%; +152.461%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+305.108ms; +307.486ms] or [+152.890%; +154.082%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+301.397ms; +304.381ms] or [+151.409%; +152.908%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+302.897ms; +304.526ms] or [+152.105%; +152.923%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.822ms; +300.785ms] or [+147.754%; +148.725%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+305.464ms; +309.212ms] or [+154.822%; +156.722%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+304.228ms; +306.020ms] or [+152.695%; +153.595%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+300.148ms; +302.535ms] or [+149.596%; +150.786%]
  • 🟩 throughput [+53324.311op/s; +58689.574op/s] or [+10.588%; +11.654%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.753ms; +303.253ms] or [+149.622%; +150.866%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.317ms; -12.662ms] or [-7.587%; -5.888%]
  • 🟩 throughput [+18432.631op/s; +25065.175op/s] or [+5.057%; +6.876%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-18.323KB; -18.301KB] or [-6.684%; -6.676%]
  • unstable execution_time [-28.230µs; +23.697µs] or [-5.580%; +4.684%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-16.520KB; -16.504KB] or [-6.022%; -6.016%]
  • unstable execution_time [+7.953µs; +116.290µs] or [+1.378%; +20.152%]
  • unstable throughput [-152.410op/s; +44.700op/s] or [-8.707%; +2.554%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+6.968µs; +11.090µs] or [+16.471%; +26.214%]
  • 🟥 throughput [-4951.148op/s; -3162.015op/s] or [-20.843%; -13.311%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.266µs; -5.880µs] or [-20.582%; -9.123%]
  • 🟩 throughput [+1516.864op/s; +3083.271op/s] or [+9.306%; +18.917%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.132ms; +304.069ms] or [+153.220%; +153.694%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.479ms; +304.731ms] or [+153.961%; +155.107%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.267ms; +301.554ms] or [+149.820%; +150.965%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+36744.402op/s; +40497.521op/s] or [+6.955%; +7.665%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+299.910ms; +301.594ms] or [+149.478%; +150.317%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+300.809ms; +302.539ms] or [+151.052%; +151.921%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.747ms; +304.862ms] or [+153.534%; +154.606%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.203ms; +300.830ms] or [+149.743%; +150.056%]
  • 🟩 throughput [+66057757.439op/s; +66311390.677op/s] or [+48.107%; +48.292%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+372.506ms; +409.261ms] or [+463.277%; +508.989%]
  • 🟩 throughput [+1007.967op/s; +1168.897op/s] or [+7.792%; +9.036%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+300.088ms; +301.050ms] or [+149.677%; +150.157%]
  • 🟩 throughput [+18292984.708op/s; +19243510.495op/s] or [+8.103%; +8.524%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+86284.073op/s; +95141.884op/s] or [+8.056%; +8.883%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+74896.232op/s; +105731.469op/s] or [+5.797%; +8.184%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+67657.924op/s; +75817.914op/s] or [+6.720%; +7.530%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+48507.689op/s; +54637.467op/s] or [+8.808%; +9.921%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+23238.033op/s; +32889.311op/s] or [+5.201%; +7.362%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+79693.891op/s; +96790.818op/s] or [+8.904%; +10.814%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

chrisnas
chrisnas approved these changes May 7, 2026
View reviewed changes

@chrisnas chrisnas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gleocadie
gleocadie merged commit e2f79f8 into master May 7, 2026
75 of 79 checks passed
@gleocadie
gleocadie deleted the gleocadie/fix-potential-issue-in-profile-creation branch May 7, 2026 18:30
@github-actions github-actions Bot added this to the vNext-v3 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisnas chrisnas chrisnas approved these changes

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler type:reliability

Projects

None yet

Milestone

3.44.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gleocadie @chrisnas @andrewlock