Fix metrics for baggage extract#8561
Merged
Merged
Conversation
github-actions
Bot
added
the
area:tracer
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8561) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (75ms) : 70, 79
master - mean (75ms) : 70, 80
section Bailout
This PR (8561) - mean (77ms) : 75, 80
master - mean (78ms) : 75, 81
section CallTarget+Inlining+NGEN
This PR (8561) - mean (1,107ms) : 1046, 1168
master - mean (1,101ms) : 1050, 1152
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (117ms) : 111, 123
master - mean (115ms) : 108, 122
section Bailout
This PR (8561) - mean (117ms) : 111, 123
master - mean (114ms) : 111, 117
section CallTarget+Inlining+NGEN
This PR (8561) - mean (786ms) : 761, 811
master - mean (789ms) : 761, 818
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (102ms) : 97, 107
master - mean (105ms) : 97, 114
section Bailout
This PR (8561) - mean (102ms) : 99, 105
master - mean (103ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8561) - mean (943ms) : 902, 984
master - mean (944ms) : 899, 988
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (102ms) : 96, 109
master - mean (98ms) : 95, 102
section Bailout
This PR (8561) - mean (103ms) : 98, 107
master - mean (104ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8561) - mean (826ms) : 793, 860
master - mean (822ms) : 788, 855
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (200ms) : 195, 204
master - mean (200ms) : 194, 206
section Bailout
This PR (8561) - mean (203ms) : 199, 207
master - mean (204ms) : 199, 208
section CallTarget+Inlining+NGEN
This PR (8561) - mean (1,207ms) : 1161, 1253
master - mean (1,199ms) : 1155, 1242
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (290ms) : 283, 296
master - mean (287ms) : 279, 296
section Bailout
This PR (8561) - mean (289ms) : 283, 295
master - mean (288ms) : 281, 295
section CallTarget+Inlining+NGEN
This PR (8561) - mean (970ms) : 945, 994
master - mean (965ms) : 946, 984
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (281ms) : 275, 288
master - mean (278ms) : 271, 286
section Bailout
This PR (8561) - mean (281ms) : 273, 290
master - mean (279ms) : 273, 286
section CallTarget+Inlining+NGEN
This PR (8561) - mean (1,160ms) : 1122, 1199
master - mean (1,151ms) : 1109, 1193
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8561) - mean (277ms) : 266, 288
master - mean (276ms) : 268, 284
section Bailout
This PR (8561) - mean (279ms) : 273, 285
master - mean (276ms) : 265, 286
section CallTarget+Inlining+NGEN
This PR (8561) - mean (1,044ms) : 998, 1089
master - mean (1,036ms) : 1000, 1072
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-13 12:40:45 Comparing candidate commit 6af7a5d in PR branch Some scenarios are present only in baseline or only in candidate runs. If you didn't create or remove some scenarios in your branch, this maybe a sign of crashed benchmarks 💥💥💥 Scenarios present only in baseline:
Found 3 performance improvements and 4 performance regressions! Performance is the same for 46 metrics, 19 unstable metrics, 88 known flaky benchmarks, 38 flaky benchmarks without significant changes.
|
bouwkast
force-pushed
the
steven/fix-baggage-extract-metrics-telemetry
branch
from
May 13, 2026 11:42
b0bf56d to
6af7a5d
Compare
bouwkast
marked this pull request as ready for review
May 13, 2026 18:20
andrewlock
approved these changes
May 14, 2026
|
|
||
| /// <summary> | ||
| /// The number of times a context propagation header is truncated, tagged by the reason for truncation (`truncation_reason:baggage_item_count_exceeded`, `truncation_reason:baggage_byte_count_exceeded`) | ||
| /// The number of times a context propagation header is truncated, tagged by the reason for truncation (`truncation_reason:baggage_item_count_exceeded`, `truncation_reason:baggage_byte_count_exceeded`, `truncation_reason:baggage_extract_item_exceeded`, `truncation_reason:baggage_extract_byte_exceeded`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Swaps to use new metrics
Reason for change
Was re-using old metrics/telemetry that wasn't exactly correct
Implementation details
Copied what the other languages are using
Test coverage
I didn't see how we test this currently
Other details
Been a while since I've added new stuff like this so unsure exactly if everything looks right here.