Retry microbenchmarks on non-compliant CPUs#8558
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8558) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (73ms) : 70, 76
master - mean (74ms) : 70, 79
section Bailout
This PR (8558) - mean (77ms) : 74, 79
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (8558) - mean (1,084ms) : 1030, 1138
master - mean (1,080ms) : 1031, 1129
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (114ms) : 110, 119
master - mean (117ms) : 111, 123
section Bailout
This PR (8558) - mean (117ms) : 111, 124
master - mean (117ms) : 111, 123
section CallTarget+Inlining+NGEN
This PR (8558) - mean (779ms) : 756, 802
master - mean (782ms) : 748, 816
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (103ms) : 97, 109
master - mean (102ms) : 95, 109
section Bailout
This PR (8558) - mean (102ms) : 99, 104
master - mean (101ms) : 98, 105
section CallTarget+Inlining+NGEN
This PR (8558) - mean (946ms) : 909, 983
master - mean (945ms) : 907, 983
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (102ms) : 97, 107
master - mean (104ms) : 98, 111
section Bailout
This PR (8558) - mean (105ms) : 100, 110
master - mean (102ms) : 98, 107
section CallTarget+Inlining+NGEN
This PR (8558) - mean (825ms) : 789, 861
master - mean (825ms) : 790, 861
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (203ms) : 194, 212
master - mean (201ms) : 194, 207
section Bailout
This PR (8558) - mean (205ms) : 199, 212
master - mean (204ms) : 198, 211
section CallTarget+Inlining+NGEN
This PR (8558) - mean (1,185ms) : 1128, 1242
master - mean (1,194ms) : 1132, 1257
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (283ms) : 274, 293
master - mean (287ms) : 278, 296
section Bailout
This PR (8558) - mean (286ms) : 275, 296
master - mean (291ms) : 282, 300
section CallTarget+Inlining+NGEN
This PR (8558) - mean (939ms) : 906, 971
master - mean (943ms) : 916, 970
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (277ms) : 268, 287
master - mean (275ms) : 268, 282
section Bailout
This PR (8558) - mean (277ms) : 268, 286
master - mean (278ms) : 267, 288
section CallTarget+Inlining+NGEN
This PR (8558) - mean (1,150ms) : 1102, 1199
master - mean (1,146ms) : 1104, 1187
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8558) - mean (281ms) : 273, 290
master - mean (275ms) : 266, 284
section Bailout
This PR (8558) - mean (283ms) : 274, 292
master - mean (276ms) : 267, 286
section CallTarget+Inlining+NGEN
This PR (8558) - mean (1,042ms) : 1000, 1084
master - mean (1,037ms) : 981, 1092
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
13c59ea to
a1d8a1f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Replace manual check_cpu_model step with target_cpu field. bp-infra now handles CPU verification with automatic retry.
a1d8a1f to
37ab98f
Compare
BenchmarksBenchmark execution time: 2026-05-05 13:21:07 Comparing candidate commit cd19ee5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 61 known flaky benchmarks, 26 flaky benchmarks without significant changes.
|

Summary of changes
Use bp-infra
target_cpufield for CPU validation with automatic retry on mismatch.Reason for change
Fix flaky microbenchmarks CI caused by m5.metal CPU lottery (8259CL vs 8175M).
Implementation details
target_cpu: "8259CL"to provision filecheck_cpu_modelstep (bp-infra handles this internally now)Test coverage
Testing microbenchmarks: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/1656268778
Testing macrobenchmarks: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/1656650126
Other details
Depends on https://github.com/DataDog/benchmarking-platform-tools/pull/232