Apply baggage limits on extract#8555
Merged
Merged
Conversation
bouwkast
added
the
area:tracer
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67b48b50d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8555) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (73ms) : 71, 76
master - mean (73ms) : 70, 77
section Bailout
This PR (8555) - mean (78ms) : 76, 81
master - mean (78ms) : 75, 80
section CallTarget+Inlining+NGEN
This PR (8555) - mean (1,085ms) : 1036, 1134
master - mean (1,086ms) : 1021, 1151
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (115ms) : 111, 119
master - mean (114ms) : 110, 119
section Bailout
This PR (8555) - mean (118ms) : 112, 125
master - mean (117ms) : 111, 122
section CallTarget+Inlining+NGEN
This PR (8555) - mean (787ms) : 763, 810
master - mean (778ms) : 754, 801
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (102ms) : 97, 107
master - mean (105ms) : 100, 109
section Bailout
This PR (8555) - mean (102ms) : 99, 104
master - mean (103ms) : 99, 107
section CallTarget+Inlining+NGEN
This PR (8555) - mean (944ms) : 906, 982
master - mean (937ms) : 896, 977
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (103ms) : 98, 109
master - mean (100ms) : 96, 104
section Bailout
This PR (8555) - mean (105ms) : 98, 112
master - mean (104ms) : 98, 109
section CallTarget+Inlining+NGEN
This PR (8555) - mean (868ms) : 755, 982
master - mean (819ms) : 779, 860
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (199ms) : 193, 205
master - mean (199ms) : 193, 206
section Bailout
This PR (8555) - mean (201ms) : 196, 207
master - mean (203ms) : 196, 209
section CallTarget+Inlining+NGEN
This PR (8555) - mean (1,179ms) : 1133, 1225
master - mean (1,180ms) : 1128, 1233
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (284ms) : 274, 294
master - mean (283ms) : 275, 290
section Bailout
This PR (8555) - mean (286ms) : 279, 293
master - mean (283ms) : 275, 292
section CallTarget+Inlining+NGEN
This PR (8555) - mean (943ms) : 913, 974
master - mean (941ms) : 909, 972
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (278ms) : 269, 288
master - mean (278ms) : 268, 288
section Bailout
This PR (8555) - mean (277ms) : 271, 284
master - mean (278ms) : 268, 288
section CallTarget+Inlining+NGEN
This PR (8555) - mean (1,143ms) : 1091, 1196
master - mean (1,148ms) : 1103, 1192
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8555) - mean (276ms) : 268, 284
master - mean (277ms) : 269, 286
section Bailout
This PR (8555) - mean (277ms) : 268, 287
master - mean (279ms) : 267, 290
section CallTarget+Inlining+NGEN
This PR (8555) - mean (1,032ms) : 991, 1074
master - mean (1,033ms) : 987, 1079
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-04 13:21:26 Comparing candidate commit 67b48b5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 57 known flaky benchmarks, 30 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Honor
DD_TRACE_BAGGAGE_MAX_ITEMSandDD_TRACE_BAGGAGE_MAX_BYTESwhen parsing inbound baggage headersReason for change
Implementation details
Test coverage
Added unit tests for it.
Other details