Decrease warnings part 3#8546
Merged
Merged
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8546) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (73ms) : 70, 75
master - mean (75ms) : 71, 79
section Bailout
This PR (8546) - mean (79ms) : 75, 83
master - mean (78ms) : 74, 81
section CallTarget+Inlining+NGEN
This PR (8546) - mean (1,131ms) : 1085, 1176
master - mean (1,132ms) : 1068, 1196
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (119ms) : 112, 125
master - mean (114ms) : 109, 119
section Bailout
This PR (8546) - mean (117ms) : 112, 121
master - mean (116ms) : 111, 121
section CallTarget+Inlining+NGEN
This PR (8546) - mean (812ms) : 785, 839
master - mean (809ms) : 778, 840
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (105ms) : 99, 111
master - mean (101ms) : 98, 104
section Bailout
This PR (8546) - mean (104ms) : 98, 110
master - mean (102ms) : 99, 104
section CallTarget+Inlining+NGEN
This PR (8546) - mean (952ms) : 911, 993
master - mean (943ms) : 906, 980
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (101ms) : 97, 104
master - mean (104ms) : 98, 111
section Bailout
This PR (8546) - mean (106ms) : 99, 113
master - mean (102ms) : 98, 105
section CallTarget+Inlining+NGEN
This PR (8546) - mean (850ms) : 772, 927
master - mean (835ms) : 780, 890
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (202ms) : 194, 210
master - mean (203ms) : 194, 212
section Bailout
This PR (8546) - mean (206ms) : 197, 216
master - mean (207ms) : 199, 215
section CallTarget+Inlining+NGEN
This PR (8546) - mean (1,247ms) : 1198, 1295
master - mean (1,266ms) : 1213, 1320
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (293ms) : 276, 309
master - mean (298ms) : 284, 312
section Bailout
This PR (8546) - mean (295ms) : 284, 307
master - mean (298ms) : 281, 315
section CallTarget+Inlining+NGEN
This PR (8546) - mean (1,003ms) : 974, 1033
master - mean (1,007ms) : 985, 1028
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (290ms) : 276, 303
master - mean (289ms) : 277, 301
section Bailout
This PR (8546) - mean (292ms) : 278, 305
master - mean (290ms) : 278, 302
section CallTarget+Inlining+NGEN
This PR (8546) - mean (1,176ms) : 1130, 1222
master - mean (1,182ms) : 1137, 1226
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8546) - mean (291ms) : 280, 303
master - mean (290ms) : 277, 303
section Bailout
This PR (8546) - mean (290ms) : 277, 303
master - mean (293ms) : 277, 309
section CallTarget+Inlining+NGEN
This PR (8546) - mean (1,081ms) : 990, 1172
master - mean (1,064ms) : 991, 1137
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-07 10:52:05 Comparing candidate commit 0e240c9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 59 known flaky benchmarks, 28 flaky benchmarks without significant changes.
|
NachoEchevarria
added
the
area:builds
Restores the System.Net.*/System.IO.*/System.Threading.Channels
PackageReferences I had deleted for NU1510 in Samples.Elasticsearch,
Samples.Elasticsearch.V7, Samples.RabbitMQ, Samples.DataStreams.RabbitMQ,
and LogsInjection.Serilog. Their original comments ("avoid package
downgrade errors") were accurate: they resolve transitive NU1605
conflicts introduced by NEST 6.1.0 / Serilog.Sinks.File 2.2.0 /
RabbitMQ.Client < 5 via NETStandard.Library 1.6.0. dotnet restore is
lenient about these but nuget.exe restore (CI) fails hard with NU1605.
Adds <NoWarn>NU1510</NoWarn> per csproj with a comment explaining the
refs are retained for conflict resolution despite being flagged as
framework-provided.
NachoEchevarria
force-pushed
the
nacho/decreaseWarningsPart3
branch
from
May 5, 2026 08:45
d71ae14 to
0c43a68
Compare
NachoEchevarria
marked this pull request as ready for review
May 5, 2026 13:52
greghuels
removed their request for review
May 5, 2026 13:52
andrewlock
reviewed
May 5, 2026
…plicateTypeProxy.csproj Co-authored-by: Andrew Lock <[email protected]>
andrewlock
approved these changes
May 7, 2026
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Great, thanks for doing this!
…lict.2x/Samples.VersionConflict.2x.csproj Co-authored-by: Andrew Lock <[email protected]>
dudikeleti
approved these changes
May 7, 2026
e-n-0
approved these changes
May 7, 2026
Collaborator
Author
|
Thanks for the feedback and reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Part 3 of the warning-reduction series. ~25 warning sources eliminated across sample/regression projects and the runner tool.
Previous PRs:
#8534
#8519
Reason for change
CI emits ~17k warnings; chipping away at the batch surfaced after parts 1-2 merged.
Implementation details
PackageReferences (NU1510 — flagged framework-provided on the target TFM and not needed):Microsoft.AspNetCore.Mvc.RazorPages,Microsoft.Extensions.Logging.Debug,System.Runtime.InteropServices.RuntimeInformation,System.Data.Common,System.Net.Http 4.3.4,System.IO.FileSystem,System.Net.NameResolution.<NoWarn>(with comment explaining why the reference is load-bearing):System.Memory/System.Net.Httpon net4x targets — Probes, CallTargetNativeTest, VersionConflict.{1x,2x}, DuplicateTypeProxy.Datadog.Trace.Tools.Runner(third-party assemblies already rooted via<TrimmerRootAssembly>).SampleHelpers.TrySetServiceNameparameter widened tostring?with an early-return guard so we don't reflection-invoke the setter with null; redundantevaluation?.Errorremoved inSamples.FeatureFlags/Evaluator.cs(was de-narrowing the flow state and tripping CS8602 on net48);Samples.GrpcDotNet/Worker.cs[CallerMemberName]default fixed.Test coverage
No behavioral changes. CI verifies the warning count drops without breaking compilation.
Other details