Skip to content

[SymDB] DEBUG-5382 Add injectable line ranges to method scopes#8544

Merged
dudikeleti merged 1 commit into
masterfrom
dudik/symdb/injectable-lines
May 1, 2026
Merged

[SymDB] DEBUG-5382 Add injectable line ranges to method scopes#8544
dudikeleti merged 1 commit into
masterfrom
dudik/symdb/injectable-lines

Conversation

@dudikeleti

@dudikeleti dudikeleti commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Add has_injectible_lines and injectible_lines to SymDB method scopes.
  • Build injectable line ranges from PDB sequence points and merge contiguous executable spans before serializing them.
  • Resolve async kickoff methods through generated state machine sequence points so the outer method scope reflects the source lines users actually see.
  • Add targeted symbol extractor coverage for injectable-line range generation and exact async-method ranges.
  • Update the affected Verify snapshots for async and state-machine-backed samples.

Reason for change

  • Probe placement tooling needs executable source lines so it can avoid repeated trial-and-failure on non-injectable lines.
  • Async methods should expose injectable lines on the original method scope, not only on generated closure/state-machine scopes.

Implementation details

  • Keep the existing SymDB schema spelling and introduce a LineRange model for serialized ranges.
  • Default method scopes to has_injectible_lines = false, then populate ranges when PDB-backed sequence points are available.
  • Use async fallback when resolving method sequence points so kickoff methods inherit source information from generated MoveNext() sequence points.
  • Build ranges by sorting visible sequence points and merging adjacent spans; use pooled intermediate storage so the helper only allocates the final serialized array.
  • Snapshot changes are limited to async/state-machine scopes that now resolve to real source lines and columns instead of 0 or closure-only fallback.

Test coverage

SymbolsTests.SymbolExtractorTest

@dudikeleti
dudikeleti requested a review from a team as a code owner April 30, 2026 00:47
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8544) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.87 ± (73.01 - 73.56) ms73.68 ± (73.80 - 74.35) ms+1.1%✅⬆️
.NET Framework 4.8 - Bailout
duration77.27 ± (77.21 - 77.55) ms79.98 ± (79.62 - 80.19) ms+3.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1119.35 ± (1120.24 - 1127.31) ms1126.90 ± (1129.01 - 1138.67) ms+0.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.45 ± (22.41 - 22.50) ms23.13 ± (23.05 - 23.21) ms+3.0%✅⬆️
process.time_to_main_ms84.30 ± (84.10 - 84.50) ms88.53 ± (88.18 - 88.88) ms+5.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.90 ± (10.90 - 10.90) MB10.92 ± (10.91 - 10.92) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.84 ± (22.77 - 22.92) ms22.58 ± (22.54 - 22.62) ms-1.1%✅
process.time_to_main_ms89.38 ± (89.03 - 89.73) ms87.17 ± (86.91 - 87.43) ms-2.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.87 ± (10.86 - 10.87) MB10.95 ± (10.95 - 10.95) MB+0.8%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms204.16 ± (203.65 - 204.68) ms206.00 ± (205.33 - 206.66) ms+0.9%✅⬆️
process.time_to_main_ms564.44 ± (563.05 - 565.83) ms567.67 ± (566.13 - 569.20) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.73 ± (49.70 - 49.76) MB49.69 ± (49.66 - 49.71) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.9%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.57 ± (21.51 - 21.63) ms21.61 ± (21.54 - 21.67) ms+0.2%✅⬆️
process.time_to_main_ms75.37 ± (75.06 - 75.68) ms76.27 ± (76.00 - 76.55) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.60) MB10.64 ± (10.64 - 10.64) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.29 ± (21.24 - 21.33) ms21.22 ± (21.17 - 21.27) ms-0.3%✅
process.time_to_main_ms74.94 ± (74.69 - 75.19) ms75.80 ± (75.53 - 76.06) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.71 ± (10.71 - 10.72) MB10.76 ± (10.75 - 10.76) MB+0.4%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms350.48 ± (348.38 - 352.58) ms355.02 ± (352.72 - 357.32) ms+1.3%✅⬆️
process.time_to_main_ms560.92 ± (559.44 - 562.41) ms561.09 ± (559.68 - 562.49) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.81 ± (50.79 - 50.83) MB51.06 ± (51.04 - 51.08) MB+0.5%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.5%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.45 ± (19.41 - 19.49) ms19.50 ± (19.46 - 19.53) ms+0.2%✅⬆️
process.time_to_main_ms72.66 ± (72.47 - 72.85) ms73.44 ± (73.27 - 73.62) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.67 ± (7.66 - 7.67) MB-0.0%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.87 ± (19.81 - 19.93) ms20.03 ± (19.97 - 20.09) ms+0.8%✅⬆️
process.time_to_main_ms76.75 ± (76.44 - 77.06) ms77.20 ± (76.91 - 77.49) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.72 - 7.73) MB7.72 ± (7.71 - 7.72) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms280.71 ± (277.85 - 283.56) ms280.47 ± (278.14 - 282.81) ms-0.1%✅
process.time_to_main_ms519.92 ± (518.50 - 521.34) ms520.19 ± (518.87 - 521.50) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.80 ± (37.78 - 37.83) MB37.76 ± (37.73 - 37.79) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.2%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration201.20 ± (201.31 - 202.57) ms202.99 ± (203.22 - 204.65) ms+0.9%✅⬆️
.NET Framework 4.8 - Bailout
duration204.76 ± (205.18 - 206.36) ms206.04 ± (206.51 - 207.84) ms+0.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1238.63 ± (1239.33 - 1246.44) ms1246.50 ± (1243.77 - 1249.14) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms196.77 ± (196.13 - 197.40) ms197.04 ± (196.41 - 197.67) ms+0.1%✅⬆️
process.time_to_main_ms85.28 ± (85.01 - 85.55) ms85.37 ± (85.02 - 85.72) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.95 ± (15.93 - 15.97) MB16.03 ± (16.01 - 16.04) MB+0.5%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms195.84 ± (195.33 - 196.36) ms195.09 ± (194.47 - 195.72) ms-0.4%✅
process.time_to_main_ms86.55 ± (86.30 - 86.80) ms86.20 ± (85.91 - 86.49) ms-0.4%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.06 ± (16.04 - 16.08) MB16.09 ± (16.07 - 16.11) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.1%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms379.37 ± (377.78 - 380.97) ms377.63 ± (376.12 - 379.13) ms-0.5%✅
process.time_to_main_ms563.78 ± (562.21 - 565.34) ms572.91 ± (571.37 - 574.46) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.33 ± (58.26 - 58.41) MB58.35 ± (58.29 - 58.42) MB+0.0%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms201.70 ± (201.23 - 202.16) ms201.23 ± (200.50 - 201.95) ms-0.2%✅
process.time_to_main_ms74.29 ± (74.05 - 74.52) ms73.71 ± (73.43 - 73.98) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.29 ± (16.27 - 16.31) MB16.39 ± (16.37 - 16.41) MB+0.6%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.4%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms200.14 ± (199.68 - 200.60) ms200.43 ± (199.76 - 201.10) ms+0.1%✅⬆️
process.time_to_main_ms74.85 ± (74.61 - 75.10) ms75.02 ± (74.74 - 75.29) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.32 ± (16.29 - 16.34) MB16.36 ± (16.34 - 16.39) MB+0.3%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.5%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms571.66 ± (568.90 - 574.41) ms570.83 ± (568.51 - 573.16) ms-0.1%✅
process.time_to_main_ms560.29 ± (558.84 - 561.75) ms568.50 ± (567.12 - 569.88) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.76 ± (61.72 - 61.81) MB61.88 ± (61.84 - 61.91) MB+0.2%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.3%✅
.NET 8 - Baseline
process.internal_duration_ms199.11 ± (198.63 - 199.59) ms200.28 ± (199.63 - 200.93) ms+0.6%✅⬆️
process.time_to_main_ms73.26 ± (73.02 - 73.50) ms73.55 ± (73.24 - 73.86) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.66 ± (11.65 - 11.67) MB11.68 ± (11.67 - 11.70) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)18 ± (18 - 19)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms199.58 ± (199.11 - 200.05) ms198.17 ± (197.43 - 198.92) ms-0.7%✅
process.time_to_main_ms74.89 ± (74.67 - 75.11) ms74.51 ± (74.20 - 74.83) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.71 ± (11.70 - 11.72) MB11.74 ± (11.71 - 11.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)19 ± (19 - 20)-0.2%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms496.09 ± (492.68 - 499.50) ms496.18 ± (493.36 - 499.00) ms+0.0%✅⬆️
process.time_to_main_ms518.36 ± (517.21 - 519.51) ms523.90 ± (522.63 - 525.17) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed51.52 ± (51.49 - 51.55) MB51.49 ± (51.45 - 51.52) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 30)30 ± (30 - 30)+0.4%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (74ms)  : 70, 78
    master - mean (73ms)  : 69, 78

    section Bailout
    This PR (8544) - mean (80ms)  : 76, 84
    master - mean (77ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (1,134ms)  : 1061, 1207
    master - mean (1,124ms)  : 1074, 1174
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (119ms)  : 114, 125
    master - mean (114ms)  : 109, 118

    section Bailout
    This PR (8544) - mean (117ms)  : 112, 121
    master - mean (119ms)  : 112, 127

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (811ms)  : 787, 835
    master - mean (805ms)  : 780, 831
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (105ms)  : 98, 111
    master - mean (104ms)  : 97, 111

    section Bailout
    This PR (8544) - mean (104ms)  : 99, 108
    master - mean (103ms)  : 98, 108

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (944ms)  : 907, 981
    master - mean (942ms)  : 899, 985
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (101ms)  : 97, 104
    master - mean (100ms)  : 96, 103

    section Bailout
    This PR (8544) - mean (105ms)  : 100, 110
    master - mean (105ms)  : 98, 111

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (831ms)  : 790, 872
    master - mean (840ms)  : 766, 914
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (204ms)  : 194, 214
    master - mean (202ms)  : 192, 212

    section Bailout
    This PR (8544) - mean (207ms)  : 197, 217
    master - mean (206ms)  : 197, 215

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (1,246ms)  : 1212, 1281
    master - mean (1,243ms)  : 1191, 1294
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (293ms)  : 276, 309
    master - mean (292ms)  : 279, 305

    section Bailout
    This PR (8544) - mean (291ms)  : 276, 307
    master - mean (292ms)  : 281, 303

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (991ms)  : 970, 1013
    master - mean (985ms)  : 958, 1011
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (284ms)  : 268, 301
    master - mean (285ms)  : 274, 297

    section Bailout
    This PR (8544) - mean (285ms)  : 272, 298
    master - mean (284ms)  : 275, 293

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (1,168ms)  : 1135, 1202
    master - mean (1,162ms)  : 1124, 1200
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8544) - mean (286ms)  : 269, 302
    master - mean (283ms)  : 273, 294

    section Bailout
    This PR (8544) - mean (284ms)  : 272, 296
    master - mean (285ms)  : 274, 297

    section CallTarget+Inlining+NGEN
    This PR (8544) - mean (1,051ms)  : 1003, 1099
    master - mean (1,045ms)  : 992, 1099
Loading

@pr-commenter

pr-commenter Bot commented Apr 30, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-30 01:49:53

Comparing candidate commit 08b8599 in PR branch dudik/symdb/injectable-lines with baseline commit 26249cd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 59 known flaky benchmarks, 28 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟩 throughput [+10412.116op/s; +12670.419op/s] or [+8.752%; +10.650%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+306.690ms; +311.985ms] or [+152.191%; +154.818%]
  • 🟥 throughput [-47.320op/s; -43.267op/s] or [-8.514%; -7.785%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+382.376ms; +385.723ms] or [+302.101%; +304.745%]
  • 🟩 throughput [+83.856op/s; +91.753op/s] or [+11.056%; +12.097%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+394.237ms; +395.464ms] or [+348.885%; +349.971%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-15.950ms; -11.775ms] or [-7.449%; -5.499%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • 🟥 throughput [-269412.917op/s; -266358.115op/s] or [-27.508%; -27.196%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-25.545ms; -20.677ms] or [-11.392%; -9.221%]
  • 🟥 throughput [-70413.854op/s; -47729.962op/s] or [-7.522%; -5.099%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • 🟥 throughput [-131873.421op/s; -115361.805op/s] or [-18.948%; -16.575%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+9526.777op/s; +12508.512op/s] or [+6.062%; +7.959%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+389684.110op/s; +409185.913op/s] or [+12.994%; +13.644%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.909ms; -14.556ms] or [-8.716%; -6.710%]
  • 🟩 throughput [+202453.174op/s; +256255.650op/s] or [+8.036%; +10.171%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+299.490ms; +300.130ms] or [+149.645%; +149.965%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+300.965ms; +304.170ms] or [+151.777%; +153.394%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.774ms; +302.317ms] or [+151.003%; +152.284%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+297.072ms; +297.871ms] or [+145.910%; +146.303%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+293.996ms; +296.875ms] or [+143.724%; +145.131%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+301.068ms; +302.929ms] or [+150.473%; +151.403%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+22.987µs; +46.597µs] or [+7.339%; +14.876%]
  • 🟥 throughput [-433.220op/s; -234.550op/s] or [-13.505%; -7.312%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.809ms; +300.497ms] or [+149.636%; +149.979%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+324.433ms; +368.277ms] or [+352.510%; +400.148%]
  • 🟩 throughput [+1172.303op/s; +1303.399op/s] or [+9.633%; +10.710%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+253.275ms; +298.663ms] or [+192.309%; +226.772%]
  • 🟩 throughput [+628.779op/s; +831.101op/s] or [+6.087%; +8.046%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+339.427ms; +376.404ms] or [+156.065%; +173.067%]
  • 🟥 throughput [-527.444op/s; -490.681op/s] or [-47.792%; -44.461%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+180.725ms; +317.771ms] or [+77.018%; +135.421%]
  • 🟥 throughput [-674.451op/s; -590.985op/s] or [-44.986%; -39.419%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+324.660ms; +332.732ms] or [+194.184%; +199.012%]
  • 🟥 throughput [-400.912op/s; -366.351op/s] or [-27.915%; -25.508%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-168.399µs; -127.831µs] or [-8.530%; -6.475%]
  • 🟩 throughput [+37.296op/s; +47.903op/s] or [+7.363%; +9.456%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+303.670ms; +305.354ms] or [+152.922%; +153.770%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+301.023ms; +302.473ms] or [+150.843%; +151.570%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+302.040ms; +305.221ms] or [+151.732%; +153.330%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+302.707ms; +304.466ms] or [+152.009%; +152.893%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+298.994ms; +301.342ms] or [+147.839%; +149.000%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+304.339ms; +308.311ms] or [+154.252%; +156.265%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+302.596ms; +304.179ms] or [+151.876%; +152.670%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+298.696ms; +300.893ms] or [+148.873%; +149.968%]
  • 🟩 throughput [+43984.314op/s; +49710.319op/s] or [+8.734%; +9.871%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+299.325ms; +302.222ms] or [+148.912%; +150.353%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.575ms; -12.908ms] or [-7.708%; -6.002%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • unstable execution_time [+8.682µs; +49.452µs] or [+2.145%; +12.215%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-18.989KB; -18.969KB] or [-6.927%; -6.919%]
  • unstable execution_time [-51.203µs; -0.428µs] or [-10.120%; -0.085%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-15.608KB; -15.592KB] or [-5.690%; -5.684%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • unstable execution_time [+6.866µs; +11.437µs] or [+16.229%; +27.032%]
  • 🟥 throughput [-4919.798op/s; -3084.848op/s] or [-20.711%; -12.986%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.188µs; -7.068µs] or [-22.012%; -10.966%]
  • 🟩 throughput [+1811.590op/s; +3317.757op/s] or [+11.115%; +20.356%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.066ms; +303.519ms] or [+152.681%; +153.415%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.893ms; +306.117ms] or [+154.681%; +155.813%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.508ms; +301.348ms] or [+149.941%; +150.862%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+39428.548op/s; +43150.539op/s] or [+7.463%; +8.167%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.806ms; +302.626ms] or [+149.925%; +150.832%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.158ms; +303.464ms] or [+151.729%; +152.385%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+303.537ms; +305.858ms] or [+153.935%; +155.111%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.050ms; +300.845ms] or [+149.666%; +150.063%]
  • 🟩 throughput [+66198862.357op/s; +66482564.786op/s] or [+48.210%; +48.417%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+376.801ms; +412.783ms] or [+468.619%; +513.369%]
  • 🟩 throughput [+960.987op/s; +1130.046op/s] or [+7.429%; +8.736%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+298.801ms; +299.732ms] or [+149.035%; +149.499%]
  • 🟩 throughput [+18403641.957op/s; +19346181.179op/s] or [+8.152%; +8.569%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+88907.422op/s; +99090.472op/s] or [+8.301%; +9.252%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+50391.357op/s; +69738.083op/s] or [+5.833%; +8.072%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+89024.855op/s; +118574.771op/s] or [+6.891%; +9.178%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+87107.628op/s; +94296.246op/s] or [+8.651%; +9.365%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+56813.380op/s; +61188.711op/s] or [+10.316%; +11.111%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+32476.492op/s; +42139.733op/s] or [+7.269%; +9.432%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+88465.463op/s; +105253.444op/s] or [+9.884%; +11.759%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

jpbempel
jpbempel approved these changes Apr 30, 2026
View reviewed changes

@jpbempel jpbempel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from debugger POV

@dudikeleti
dudikeleti merged commit 040bff6 into master May 1, 2026
142 of 143 checks passed
@dudikeleti
dudikeleti deleted the dudik/symdb/injectable-lines branch May 1, 2026 09:22
@github-actions github-actions Bot added this to the vNext-v3 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbempel jpbempel jpbempel approved these changes

Assignees

No one assigned

Labels

area:debugger

Projects

None yet

Milestone

3.43.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dudikeleti @jpbempel @andrewlock