[Dynamic Instrumentation] DEBUG-5104 support case-insensitive line probe source paths#8542
Merged
Merged
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8542) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (74ms) : 69, 79
master - mean (73ms) : 70, 77
section Bailout
This PR (8542) - mean (78ms) : 74, 83
master - mean (79ms) : 75, 84
section CallTarget+Inlining+NGEN
This PR (8542) - mean (1,128ms) : 1069, 1187
master - mean (1,123ms) : 1080, 1166
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (118ms) : 112, 123
master - mean (117ms) : 111, 123
section Bailout
This PR (8542) - mean (115ms) : 112, 118
master - mean (118ms) : 113, 122
section CallTarget+Inlining+NGEN
This PR (8542) - mean (812ms) : 789, 835
master - mean (806ms) : 777, 836
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (102ms) : 97, 106
master - mean (101ms) : 97, 104
section Bailout
This PR (8542) - mean (106ms) : 100, 113
master - mean (103ms) : 98, 107
section CallTarget+Inlining+NGEN
This PR (8542) - mean (948ms) : 901, 994
master - mean (941ms) : 903, 980
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (100ms) : 97, 103
master - mean (101ms) : 96, 106
section Bailout
This PR (8542) - mean (103ms) : 97, 108
master - mean (101ms) : 98, 103
section CallTarget+Inlining+NGEN
This PR (8542) - mean (832ms) : 778, 886
master - mean (829ms) : 789, 868
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (198ms) : 193, 204
master - mean (198ms) : 192, 205
section Bailout
This PR (8542) - mean (201ms) : 195, 207
master - mean (204ms) : 199, 208
section CallTarget+Inlining+NGEN
This PR (8542) - mean (1,222ms) : 1169, 1275
master - mean (1,222ms) : 1177, 1268
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (282ms) : 273, 292
master - mean (285ms) : 276, 294
section Bailout
This PR (8542) - mean (282ms) : 276, 288
master - mean (287ms) : 278, 296
section CallTarget+Inlining+NGEN
This PR (8542) - mean (972ms) : 948, 997
master - mean (976ms) : 954, 999
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (276ms) : 268, 284
master - mean (278ms) : 268, 288
section Bailout
This PR (8542) - mean (278ms) : 267, 288
master - mean (276ms) : 270, 283
section CallTarget+Inlining+NGEN
This PR (8542) - mean (1,152ms) : 1119, 1185
master - mean (1,153ms) : 1109, 1198
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8542) - mean (275ms) : 266, 284
master - mean (276ms) : 268, 285
section Bailout
This PR (8542) - mean (275ms) : 265, 286
master - mean (283ms) : 268, 297
section CallTarget+Inlining+NGEN
This PR (8542) - mean (1,030ms) : 982, 1078
master - mean (1,037ms) : 997, 1077
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-05-01 13:12:49 Comparing candidate commit efc44a5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 62 known flaky benchmarks, 25 flaky benchmarks without significant changes.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds case-insensitive source path matching for Dynamic Instrumentation line probes while preserving the original PDB document path returned from resolution, reducing cases where valid probes remain unbound due to casing differences.
Changes:
- Extend
FilePathLookup.FindPathThatEndsWithwith a case-insensitive full-suffix fallback when the trie fast-path misses. - Make trailing-segment matching case-insensitive (
StringComparison.OrdinalIgnoreCase) and convertClosestPathBySuffixResultto a readonly struct. - Add/adjust integration tests covering case-insensitive matching, ambiguity handling, and segment-count mismatch behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tracer/src/Datadog.Trace/Debugger/LineProbeResolver.cs | Implements case-insensitive fallback suffix matching on trie miss and returns the original PDB path; switches suffix-segment comparisons to OrdinalIgnoreCase; refactors result carrier to a readonly struct. |
| tracer/test/Datadog.Trace.Debugger.IntegrationTests/LineProbeResolverTest.cs | Adds focused coverage for case-insensitive exact-suffix behavior, ambiguity rejection, and query/document segment-count mismatch; updates prior test expectation for case-only differences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dudikeleti
force-pushed
the
dudik/line-probe-support-case-insensitive
branch
from
May 1, 2026 09:49
c64a2df to
efc44a5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dudikeleti
enabled auto-merge (squash)
May 1, 2026 12:37
jpbempel
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Controllers/DebuggerController.csvscontrollers/debuggercontroller.cs.Implementation details
StringComparison.OrdinalIgnoreCase.ClosestPathBySuffixResultto a readonly struct to avoid adding allocation in this warm probe-resolution path.Test coverage
LineProbeResolverTest