Do not send DD_GIT_COMMIT_SHA error to telemetry#8537
Merged
Conversation
bouwkast
commented
Apr 28, 2026
bouwkast
enabled auto-merge (squash)
April 28, 2026 19:20
link04
approved these changes
Apr 28, 2026
link04
left a comment
link04
left a comment
Contributor
There was a problem hiding this comment.
Thank you for this good log fix Steven!
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8537) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (75ms) : 70, 80
master - mean (76ms) : 71, 80
section Bailout
This PR (8537) - mean (78ms) : 75, 81
master - mean (79ms) : 74, 83
section CallTarget+Inlining+NGEN
This PR (8537) - mean (1,083ms) : 1039, 1128
master - mean (1,078ms) : 1035, 1122
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (118ms) : 111, 124
master - mean (118ms) : 111, 124
section Bailout
This PR (8537) - mean (115ms) : 113, 117
master - mean (116ms) : 113, 118
section CallTarget+Inlining+NGEN
This PR (8537) - mean (787ms) : 759, 816
master - mean (781ms) : 755, 807
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (104ms) : 99, 108
master - mean (104ms) : 98, 110
section Bailout
This PR (8537) - mean (103ms) : 100, 105
master - mean (106ms) : 101, 111
section CallTarget+Inlining+NGEN
This PR (8537) - mean (943ms) : 903, 982
master - mean (942ms) : 897, 987
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (102ms) : 98, 107
master - mean (101ms) : 97, 104
section Bailout
This PR (8537) - mean (104ms) : 98, 111
master - mean (104ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8537) - mean (828ms) : 787, 868
master - mean (829ms) : 787, 870
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (204ms) : 196, 212
master - mean (203ms) : 196, 210
section Bailout
This PR (8537) - mean (208ms) : 201, 216
master - mean (207ms) : 200, 214
section CallTarget+Inlining+NGEN
This PR (8537) - mean (1,205ms) : 1163, 1246
master - mean (1,201ms) : 1158, 1245
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (288ms) : 278, 298
master - mean (292ms) : 282, 303
section Bailout
This PR (8537) - mean (290ms) : 279, 301
master - mean (297ms) : 282, 312
section CallTarget+Inlining+NGEN
This PR (8537) - mean (956ms) : 930, 982
master - mean (967ms) : 929, 1005
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (281ms) : 271, 292
master - mean (287ms) : 273, 301
section Bailout
This PR (8537) - mean (283ms) : 273, 293
master - mean (288ms) : 275, 302
section CallTarget+Inlining+NGEN
This PR (8537) - mean (1,153ms) : 1118, 1189
master - mean (1,162ms) : 1109, 1215
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8537) - mean (282ms) : 275, 288
master - mean (288ms) : 270, 306
section Bailout
This PR (8537) - mean (285ms) : 275, 294
master - mean (287ms) : 272, 301
section CallTarget+Inlining+NGEN
This PR (8537) - mean (1,047ms) : 1000, 1094
master - mean (1,048ms) : 997, 1099
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-28 20:31:06 Comparing candidate commit 0570cb5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 62 known flaky benchmarks, 25 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes Log.Error to Log.ErrorSkipTelemetry as it is not actionable by us.
Reason for change
We can't act on this so we don't need to see it.
Previously it was ignored, but the messaged changed so it is a new error now.
Implementation details
Log.Error -> Log.ErrorSkipTelemetry
Test coverage
None
Other details
https://app.datadoghq.com/error-tracking/issue/c6344748-427c-11f1-bd52-da7ad0900002