Use command-line args to configure benchmarks#853
Merged
Conversation
tonyredondo
requested changes
Aug 12, 2020
tonyredondo
approved these changes
Aug 12, 2020
lucaspimentel
approved these changes
Aug 12, 2020
lucaspimentel
added
the
area:benchmarks
zacharycmontoya
approved these changes
Aug 12, 2020
kevingosse
force-pushed
the
kevin/testbenchmark2
branch
from
August 13, 2020 09:32
85922c0 to
7a753f1
Compare
kevingosse
force-pushed
the
kevin/testbenchmark2
branch
from
August 13, 2020 15:09
7a753f1 to
1a6850d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since those benchmarks will be launched automatically in different environments, we need to be able to give the parameters through the command-line instead of hardcoding them with attributes.