Fix trace agent connection issues that emerge in Azure App Service environment#852
Merged
Merged
Conversation
- Rewrite SocketException logic to compare against innermost exception. By checking only Exception.InnerException we have been unable to detect the SocketException's since upgrading the .NET Tracer to 1.18.0
…lly changing the endpoint so retries can take advantage of updated ports in AAS - Modify the SubscribeToTraceAgentPortOverride callback to use this new mechanism
…start so failed Trace agent responses don't trigger concurrent resets.
zacharycmontoya
added
area:tracer
…tion is a SocketException
lucaspimentel
approved these changes
Aug 20, 2020
lucaspimentel
left a comment
lucaspimentel
left a comment
Member
There was a problem hiding this comment.
LGTM. Left 2 non-blocking rename suggestions.
colin-higgins
approved these changes
Aug 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DataDog/apm-dotnet