[Dynamic Instrumentation] DEBUG-2387 Sample evaluation error snapshots#8515
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e71944f06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+383
to
+385
| if (ProbeInfo.HasCondition && !sampler.Sample()) | ||
| { | ||
| shouldStopCapture = true; |
There was a problem hiding this comment.
For conditional probes where GetOrCreateEvaluator().Evaluate(...) itself throws, the catch above converts the exception into evaluationResult.Errors and returns immediately, so execution never reaches this new sampler check. Those evaluation-error snapshots still bypass rate limiting on every invocation; route the catch-created result through the same HasError sampling path before returning.
Useful? React with 👍 / 👎.
BenchmarksBenchmark execution time: 2026-04-28 13:07:51 Comparing candidate commit ddd8261 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 60 known flaky benchmarks, 27 flaky benchmarks without significant changes.
|
tylfin
approved these changes
Apr 27, 2026
tylfin
left a comment
tylfin
left a comment
Member
There was a problem hiding this comment.
🙌 thanks for addressing this one
dudikeleti
force-pushed
the
dudik/el/sample-el-errors
branch
from
April 28, 2026 11:59
3e71944 to
ddd8261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
messagefrom the first evaluation error when expression evaluation fails.Reason for change
Test coverage
ProbeProcessorTests.ConditionEvaluationErrorsAreDroppedWhenSamplerRejects|ProbeProcessorTests.ConditionEvaluationErrorsAreCapturedWhenSamplerKeeps|DebuggerSnapshotCreatorTests.Message_UsesFirstEvaluationError