Ensure we always run all smoke tests on Docker tag bump PRs#8514
Merged
andrewlock merged 2 commits intoMay 6, 2026
Conversation
andrewlock
added
area:builds
andrewlock
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2500b72394
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-04-24 09:58:30 Comparing candidate commit 5ce5f16 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 0 unstable metrics, 56 known flaky benchmarks, 31 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8514) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (74ms) : 70, 79
master - mean (73ms) : 70, 76
section Bailout
This PR (8514) - mean (80ms) : 75, 84
master - mean (78ms) : 74, 82
section CallTarget+Inlining+NGEN
This PR (8514) - mean (1,081ms) : 1029, 1132
master - mean (1,083ms) : 1033, 1133
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (116ms) : 109, 123
master - mean (114ms) : 109, 119
section Bailout
This PR (8514) - mean (116ms) : 110, 122
master - mean (119ms) : 113, 124
section CallTarget+Inlining+NGEN
This PR (8514) - mean (778ms) : 746, 810
master - mean (777ms) : 746, 808
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (104ms) : 99, 110
master - mean (104ms) : 97, 112
section Bailout
This PR (8514) - mean (102ms) : 100, 104
master - mean (103ms) : 99, 106
section CallTarget+Inlining+NGEN
This PR (8514) - mean (939ms) : 903, 976
master - mean (940ms) : 907, 974
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (100ms) : 97, 104
master - mean (101ms) : 97, 106
section Bailout
This PR (8514) - mean (106ms) : 101, 111
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8514) - mean (827ms) : 793, 861
master - mean (822ms) : 786, 858
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (201ms) : 195, 206
master - mean (199ms) : 193, 204
section Bailout
This PR (8514) - mean (203ms) : 196, 209
master - mean (202ms) : 197, 208
section CallTarget+Inlining+NGEN
This PR (8514) - mean (1,197ms) : 1131, 1263
master - mean (1,180ms) : 1122, 1238
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (287ms) : 278, 295
master - mean (289ms) : 278, 300
section Bailout
This PR (8514) - mean (289ms) : 281, 297
master - mean (290ms) : 281, 299
section CallTarget+Inlining+NGEN
This PR (8514) - mean (951ms) : 925, 977
master - mean (950ms) : 923, 977
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (282ms) : 271, 294
master - mean (283ms) : 271, 294
section Bailout
This PR (8514) - mean (283ms) : 273, 292
master - mean (283ms) : 271, 294
section CallTarget+Inlining+NGEN
This PR (8514) - mean (1,153ms) : 1110, 1197
master - mean (1,144ms) : 1094, 1194
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8514) - mean (281ms) : 273, 290
master - mean (279ms) : 269, 290
section Bailout
This PR (8514) - mean (281ms) : 272, 291
master - mean (281ms) : 273, 289
section CallTarget+Inlining+NGEN
This PR (8514) - mean (1,040ms) : 989, 1092
master - mean (1,036ms) : 988, 1085
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # would block queue-time overrides from the UI — YAML takes precedence and the | ||
| # "settable at queue time" UI value would be ignored. The branch name matches | ||
| # .github/workflows/auto_bump_smoke_test_docker_images.yml — keep both in sync. | ||
| isDockerImageBumpPr: $[eq(variables['System.PullRequest.SourceBranch'], 'bot/smoke-test-docker-image-bump')] |
Collaborator
There was a problem hiding this comment.
In previous lines, we are using the branch long names. Should we use refs/heads/bot/smoke... here? Alternatively, we could probbly use the short name with .SourceBranchName
Member
Author
There was a problem hiding this comment.
Unfortunately, I don't believe we can - the difference is that in PRs, the branch name is a "fake" merge branch, so we can't use the long names. And for non-PRs, this variable isn't set, so we can't use the short names either
NachoEchevarria
approved these changes
May 5, 2026
bouwkast
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ensure we always run all smoke tests when change the smoke test images
Reason for change
We want to make sure we actually test all the smoke test images when we bump the versions, otherwise we could break master if there's a genuine issue.
Implementation details
Adds a check to see if the PR was created by the tag version bump workflow, and if so, sets a variable to make sure all the smoke test jobs run
Test coverage
Can't easily test this without there being a PR, so will test in prod 😄