Run the docker-compose version tagging update manually instead of using Dependabot#8506
Merged
Conversation
andrewlock
added
the
area:builds
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36e0d25489
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "github_url": "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}", | ||
| } | ||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBOOK_URL_GENERATEPACKAGEVERSIONS }} |
Collaborator
There was a problem hiding this comment.
NIT: Typo, this is missing a H
Member
Author
There was a problem hiding this comment.
Yeah, so is the secret in GitHub though 🙈 😂
NachoEchevarria
approved these changes
Apr 23, 2026
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8506) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (75ms) : 70, 80
master - mean (75ms) : 71, 79
section Bailout
This PR (8506) - mean (78ms) : 75, 82
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (8506) - mean (1,076ms) : 1028, 1124
master - mean (1,077ms) : 1027, 1127
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (117ms) : 110, 124
master - mean (118ms) : 112, 123
section Bailout
This PR (8506) - mean (115ms) : 110, 119
master - mean (115ms) : 112, 119
section CallTarget+Inlining+NGEN
This PR (8506) - mean (775ms) : 743, 807
master - mean (776ms) : 751, 801
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (102ms) : 98, 105
master - mean (102ms) : 96, 108
section Bailout
This PR (8506) - mean (102ms) : 100, 105
master - mean (101ms) : 98, 104
section CallTarget+Inlining+NGEN
This PR (8506) - mean (944ms) : 900, 988
master - mean (941ms) : 899, 983
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (102ms) : 96, 108
master - mean (101ms) : 97, 105
section Bailout
This PR (8506) - mean (103ms) : 98, 109
master - mean (104ms) : 99, 109
section CallTarget+Inlining+NGEN
This PR (8506) - mean (823ms) : 788, 858
master - mean (822ms) : 778, 867
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (201ms) : 193, 209
master - mean (206ms) : 198, 215
section Bailout
This PR (8506) - mean (205ms) : 199, 212
master - mean (208ms) : 202, 214
section CallTarget+Inlining+NGEN
This PR (8506) - mean (1,194ms) : 1134, 1254
master - mean (1,202ms) : 1145, 1259
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (289ms) : 278, 300
master - mean (293ms) : 283, 302
section Bailout
This PR (8506) - mean (290ms) : 281, 299
master - mean (295ms) : 283, 307
section CallTarget+Inlining+NGEN
This PR (8506) - mean (945ms) : 922, 968
master - mean (961ms) : 930, 992
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (286ms) : 275, 297
master - mean (286ms) : 275, 296
section Bailout
This PR (8506) - mean (286ms) : 272, 300
master - mean (287ms) : 277, 297
section CallTarget+Inlining+NGEN
This PR (8506) - mean (1,151ms) : 1105, 1197
master - mean (1,156ms) : 1115, 1196
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8506) - mean (283ms) : 271, 294
master - mean (285ms) : 273, 297
section Bailout
This PR (8506) - mean (282ms) : 272, 292
master - mean (286ms) : 275, 297
section CallTarget+Inlining+NGEN
This PR (8506) - mean (1,050ms) : 978, 1122
master - mean (1,049ms) : 973, 1126
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bouwkast
approved these changes
Apr 23, 2026
BenchmarksBenchmark execution time: 2026-04-23 13:19:19 Comparing candidate commit d482578 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 58 known flaky benchmarks, 29 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
tl;dr; Dependabot continues to be terrible at its job
🤖 explanation
We could either remove the cool down (not acceptable) or we could try to fix the bug in dependabot (not worth the hassle), or we can just do it ourselves (what I settled on)
Implementation details
Told 🤖 to "implement it properly" and it did a good enough job 😄 It handles getting an anonymous token for the docker hub registry and managing the cool down, but there is a possibility that we could hit rate limits. For now I'm inclined to just "meh" over it, as these should be very rare, because most of the requests don't count towards it, and it shouldn't be an issue for mcr.
One slight issue is the way the tagging works we can't get "all the recent new images", so that we can update to the latest image outside the cooldown. We get the latest, see if it's in the cooldown, and if not, don't update. In the pathological case, we could end up never updating. In practice, that shouldn't be an issue for the images we're using
Test coverage
We can't actually test this properly until it's merged, but I ran a test locally, and it output the following (abbreviated)
And seems to work 🤞
Other details
I'd like to update the pipeline to always run all smoke tests for these PRs, but I'll move that to a separate PR so as not to block this, as might require some faffing
https://datadoghq.atlassian.net/browse/APMLP-1282