Remove agent check in client-side-stats#8503
Merged
Merged
Conversation
lucaspimentel
approved these changes
Apr 22, 2026
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8503) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (74ms) : 70, 79
master - mean (73ms) : 71, 75
section Bailout
This PR (8503) - mean (77ms) : 75, 79
master - mean (78ms) : 75, 81
section CallTarget+Inlining+NGEN
This PR (8503) - mean (1,078ms) : 1032, 1124
master - mean (1,090ms) : 1015, 1165
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (117ms) : 110, 123
master - mean (115ms) : 112, 118
section Bailout
This PR (8503) - mean (116ms) : 114, 118
master - mean (119ms) : 113, 126
section CallTarget+Inlining+NGEN
This PR (8503) - mean (780ms) : 748, 812
master - mean (779ms) : 750, 808
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (101ms) : 97, 105
master - mean (104ms) : 97, 111
section Bailout
This PR (8503) - mean (102ms) : 99, 105
master - mean (104ms) : 98, 110
section CallTarget+Inlining+NGEN
This PR (8503) - mean (941ms) : 893, 988
master - mean (941ms) : 902, 980
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (104ms) : 98, 111
master - mean (101ms) : 98, 104
section Bailout
This PR (8503) - mean (103ms) : 98, 108
master - mean (105ms) : 99, 111
section CallTarget+Inlining+NGEN
This PR (8503) - mean (824ms) : 789, 859
master - mean (825ms) : 789, 862
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (205ms) : 196, 214
master - mean (207ms) : 197, 217
section Bailout
This PR (8503) - mean (210ms) : 201, 218
master - mean (212ms) : 204, 220
section CallTarget+Inlining+NGEN
This PR (8503) - mean (1,220ms) : 1165, 1274
master - mean (1,207ms) : 1152, 1261
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (298ms) : 283, 312
master - mean (297ms) : 282, 313
section Bailout
This PR (8503) - mean (298ms) : 285, 312
master - mean (300ms) : 285, 314
section CallTarget+Inlining+NGEN
This PR (8503) - mean (984ms) : 939, 1029
master - mean (979ms) : 945, 1013
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (294ms) : 278, 310
master - mean (295ms) : 282, 308
section Bailout
This PR (8503) - mean (295ms) : 277, 314
master - mean (297ms) : 284, 310
section CallTarget+Inlining+NGEN
This PR (8503) - mean (1,175ms) : 1137, 1213
master - mean (1,169ms) : 1121, 1217
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8503) - mean (294ms) : 274, 314
master - mean (289ms) : 273, 305
section Bailout
This PR (8503) - mean (295ms) : 278, 312
master - mean (289ms) : 273, 306
section CallTarget+Inlining+NGEN
This PR (8503) - mean (1,103ms) : 975, 1231
master - mean (1,064ms) : 981, 1147
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
enabled auto-merge (squash)
April 23, 2026 09:33
BenchmarksBenchmark execution time: 2026-04-23 10:06:49 Comparing candidate commit a3376b7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 57 known flaky benchmarks, 30 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removes the minimum-agent version check from the client-side-stats check
Reason for change
We didn't have it before, which means people who previously had stats, suddenly won't have them. Also other agents (like bottlecap etc) don't have the version. And we haven't figured out how to handle that yet. While CSS is off by default, this seems like the best option to take.
Implementation details
Remove the code that is checking for CSS support.
Test coverage
Covered by existing (and removed a test for the behaviour)
Other details
Follows on from
charhelpers likeIsAsciiHexDigit#8417IpAddressObfuscationUtilfor use with client-side-stats #8418ContainsSpanIdtoSpanCollection#8435FnvHash64.GenerateHash()#8444