Skip to content

Update System.Text.Json to latest in source generators project#8497

Merged
andrewlock merged 1 commit into
masterfrom
andrew/update-system-text-json
Apr 29, 2026
Merged

Update System.Text.Json to latest in source generators project#8497
andrewlock merged 1 commit into
masterfrom
andrew/update-system-text-json

Conversation

@andrewlock

@andrewlock andrewlock commented Apr 22, 2026

Copy link
Copy Markdown
Member

Summary of changes

Update System.Text.Json to latest in source generators project

Reason for change

In #7944 we downgraded the version of System.Text.Json due to a bug in Rider, which caused the IDE doesn't index source generated files using the last version of the package properly, causing invalid missing values:

image

The issue is marked as fixed, and I can't reproduce it locally any more, so we should be safe to update

image

Implementation details

Bummp the System.Text.Json value to latest

Test coverage

Tested the impact locally, and everything else is covered by CI

Other details

Supersedes #7900

@andrewlock
andrewlock requested a review from a team as a code owner April 22, 2026 12:27
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 22, 2026
@andrewlock andrewlock mentioned this pull request Apr 22, 2026
Closed
@pr-commenter

pr-commenter Bot commented Apr 22, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-22 13:32:33

Comparing candidate commit 9857646 in PR branch andrew/update-system-text-json with baseline commit 3c003f8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 59 known flaky benchmarks, 28 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟩 throughput [+9783.579op/s; +12035.057op/s] or [+8.223%; +10.116%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+305.055ms; +307.039ms] or [+151.379%; +152.363%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+381.314ms; +384.544ms] or [+301.261%; +303.813%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+401.361ms; +402.831ms] or [+355.189%; +356.490%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-16.296ms; -12.120ms] or [-7.611%; -5.661%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • 🟥 throughput [-244884.116op/s; -242245.322op/s] or [-25.004%; -24.734%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.549ms; -21.678ms] or [-11.840%; -9.667%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • 🟥 throughput [-129508.730op/s; -113460.774op/s] or [-18.608%; -16.302%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+10694.421op/s; +13631.166op/s] or [+6.805%; +8.673%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • 🟩 throughput [+8006.916op/s; +10649.905op/s] or [+6.379%; +8.484%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+409175.000op/s; +445339.485op/s] or [+13.644%; +14.850%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-19.036ms; -14.662ms] or [-8.775%; -6.759%]
  • 🟩 throughput [+207347.390op/s; +261387.116op/s] or [+8.230%; +10.375%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+300.012ms; +300.553ms] or [+149.906%; +150.176%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+300.218ms; +303.543ms] or [+151.401%; +153.077%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+300.070ms; +302.708ms] or [+151.152%; +152.481%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.276ms; +297.014ms] or [+145.519%; +145.881%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+299.402ms; +302.490ms] or [+146.367%; +147.876%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+302.531ms; +304.061ms] or [+151.205%; +151.969%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟥 throughput [-195.186op/s; -114.622op/s] or [-9.010%; -5.291%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+24.036µs; +47.659µs] or [+7.674%; +15.215%]
  • 🟥 throughput [-441.873op/s; -243.111op/s] or [-13.774%; -7.578%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.789ms; +300.475ms] or [+149.625%; +149.968%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+372.921ms; +407.919ms] or [+405.194%; +443.220%]
  • 🟩 throughput [+1075.958op/s; +1203.095op/s] or [+8.841%; +9.886%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟥 execution_time [+364.880ms; +369.967ms] or [+277.050%; +280.912%]
  • 🟩 throughput [+717.971op/s; +915.454op/s] or [+6.950%; +8.862%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+305.420ms; +381.294ms] or [+140.429%; +175.315%]
  • 🟥 throughput [-546.832op/s; -477.727op/s] or [-49.548%; -43.287%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+181.239ms; +316.289ms] or [+77.236%; +134.789%]
  • 🟥 throughput [-747.723op/s; -664.215op/s] or [-49.873%; -44.303%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+336.782ms; +345.338ms] or [+201.435%; +206.552%]
  • 🟥 throughput [-398.217op/s; -363.198op/s] or [-27.727%; -25.289%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-143.366µs; -101.835µs] or [-7.262%; -5.159%]
  • 🟩 throughput [+29.582op/s; +40.688op/s] or [+5.840%; +8.032%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+302.975ms; +304.851ms] or [+152.572%; +153.517%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+299.001ms; +307.113ms] or [+149.830%; +153.895%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+300.259ms; +303.782ms] or [+150.837%; +152.607%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+301.792ms; +303.047ms] or [+151.550%; +152.180%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+297.306ms; +298.952ms] or [+147.004%; +147.818%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+301.886ms; +305.498ms] or [+153.009%; +154.840%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+301.513ms; +303.119ms] or [+151.332%; +152.138%]
  • 🟥 throughput [-31547.433op/s; -29277.635op/s] or [-8.184%; -7.595%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+301.464ms; +303.415ms] or [+150.252%; +151.225%]
  • 🟩 throughput [+63233.483op/s; +67114.610op/s] or [+12.556%; +13.327%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+300.832ms; +303.688ms] or [+149.661%; +151.082%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-15.462ms; -11.660ms] or [-7.190%; -5.422%]
  • 🟩 throughput [+24309.087op/s; +31538.622op/s] or [+6.669%; +8.652%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-20.757KB; -20.737KB] or [-7.572%; -7.564%]
  • unstable execution_time [-48.427µs; +3.396µs] or [-9.571%; +0.671%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+6.182µs; +10.410µs] or [+14.613%; +24.607%]
  • 🟥 throughput [-4653.557op/s; -2872.139op/s] or [-19.590%; -12.091%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-13.356µs; -6.170µs] or [-20.722%; -9.572%]
  • 🟩 throughput [+1523.720op/s; +3025.199op/s] or [+9.349%; +18.561%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+302.721ms; +303.971ms] or [+153.012%; +153.644%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.728ms; +306.006ms] or [+154.596%; +155.756%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.594ms; +301.463ms] or [+149.984%; +150.920%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+34862.280op/s; +37779.841op/s] or [+6.599%; +7.151%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+301.427ms; +303.004ms] or [+150.234%; +151.020%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+301.407ms; +302.505ms] or [+151.352%; +151.904%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+302.825ms; +305.133ms] or [+153.573%; +154.744%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+300.239ms; +300.893ms] or [+149.761%; +150.087%]
  • 🟩 throughput [+61081228.900op/s; +61334787.752op/s] or [+44.483%; +44.668%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+428.227ms; +432.757ms] or [+532.576%; +538.210%]
  • 🟩 throughput [+976.104op/s; +1144.049op/s] or [+7.546%; +8.844%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.295ms; +300.208ms] or [+149.282%; +149.737%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+90561.273op/s; +106565.372op/s] or [+8.455%; +9.950%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+48497.653op/s; +68090.785op/s] or [+5.614%; +7.881%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+92749.320op/s; +121981.470op/s] or [+7.179%; +9.442%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+77767.509op/s; +85921.575op/s] or [+7.724%; +8.533%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+47300.588op/s; +52531.310op/s] or [+8.589%; +9.539%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+25188.123op/s; +34904.465op/s] or [+5.638%; +7.813%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+58060.052op/s; +75357.493op/s] or [+6.487%; +8.419%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472
  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@andrewlock
andrewlock merged commit 94f75bc into master Apr 29, 2026
143 checks passed
@andrewlock
andrewlock deleted the andrew/update-system-text-json branch April 29, 2026 08:19
@github-actions github-actions Bot added this to the vNext-v3 milestone Apr 29, 2026
@andrewlock andrewlock added the dependencies Pull requests that update a dependency file label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes
@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

3.43.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @bouwkast @NachoEchevarria