fix(mstest): add 4.2.1 adapter signatures#8475
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8475) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (75ms) : 70, 80
master - mean (73ms) : 70, 77
section Bailout
This PR (8475) - mean (79ms) : 75, 83
master - mean (80ms) : 75, 84
section CallTarget+Inlining+NGEN
This PR (8475) - mean (1,077ms) : 1034, 1120
master - mean (1,081ms) : 1009, 1154
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (117ms) : 111, 123
master - mean (116ms) : 110, 122
section Bailout
This PR (8475) - mean (115ms) : 111, 119
master - mean (117ms) : 111, 123
section CallTarget+Inlining+NGEN
This PR (8475) - mean (793ms) : 765, 821
master - mean (798ms) : 771, 824
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (103ms) : 96, 110
master - mean (103ms) : 97, 109
section Bailout
This PR (8475) - mean (102ms) : 99, 104
master - mean (105ms) : 100, 110
section CallTarget+Inlining+NGEN
This PR (8475) - mean (941ms) : 900, 983
master - mean (940ms) : 907, 972
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (100ms) : 97, 102
master - mean (102ms) : 96, 108
section Bailout
This PR (8475) - mean (104ms) : 98, 110
master - mean (101ms) : 99, 103
section CallTarget+Inlining+NGEN
This PR (8475) - mean (829ms) : 792, 865
master - mean (827ms) : 782, 872
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (211ms) : 207, 215
master - mean (207ms) : 202, 212
section Bailout
This PR (8475) - mean (215ms) : 210, 219
master - mean (211ms) : 207, 215
section CallTarget+Inlining+NGEN
This PR (8475) - mean (1,231ms) : 1185, 1276
master - mean (1,215ms) : 1159, 1271
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (304ms) : 296, 311
master - mean (299ms) : 292, 306
section Bailout
This PR (8475) - mean (307ms) : 300, 314
master - mean (298ms) : 291, 305
section CallTarget+Inlining+NGEN
This PR (8475) - mean (1,010ms) : 979, 1042
master - mean (998ms) : 960, 1035
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (295ms) : 289, 301
master - mean (296ms) : 288, 304
section Bailout
This PR (8475) - mean (295ms) : 290, 299
master - mean (294ms) : 287, 301
section CallTarget+Inlining+NGEN
This PR (8475) - mean (1,181ms) : 1138, 1224
master - mean (1,175ms) : 1140, 1210
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8475) - mean (295ms) : 289, 302
master - mean (292ms) : 286, 299
section Bailout
This PR (8475) - mean (295ms) : 289, 301
master - mean (293ms) : 288, 298
section CallTarget+Inlining+NGEN
This PR (8475) - mean (1,082ms) : 980, 1185
master - mean (1,073ms) : 992, 1154
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-17 14:53:37 Comparing candidate commit 1e7ddef in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 25 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Summary of changes
TypeCache.GetTestMethodInfo(TestMethod)RunSingleTestandRunSingleTestAsyncsignatures that now takeUnitTestElement4.2.1, including the Windowsnet48rows4.2.1Reason for change
MSTest 4.2.1 changed adapter method signatures used by our CI Visibility instrumentation. The existing hooks no longer matched those methods, which caused missing MSTest spans.
Implementation details
TypeCacheGetTestMethodInfoIntegrationV4as a small proxy integration that reuses the existingTypeCachelogic for the new overload[InstrumentMethod]definitions for the 4.2.1+UnitTestRunnersignatures on the existing integrationsPackageVersionsLatestSpecific,PackageVersionsLatestMajors, andPackageVersionsLatestMinorsMSTest entries to include the missing4.2.1coverage, including the Windowsnet48rowsTest coverage