Skip to content

[SINT-5051] Update CI identities client version and Windows code signer to latest release#8474

Merged
andrewlock merged 1 commit into
masterfrom
sarra.barnoussi/sint-5051-update-ci-identities-client-version
May 7, 2026
Merged

[SINT-5051] Update CI identities client version and Windows code signer to latest release#8474
andrewlock merged 1 commit into
masterfrom
sarra.barnoussi/sint-5051-update-ci-identities-client-version

Conversation

@sarra-barnoussi

@sarra-barnoussi sarra-barnoussi commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

  • Update Windows code signing image to v0.7.0. This version uses the latest version of the CI Identities client
  • Forward the CI Job Name Env Variable for better observability.
  • Update the ci-identities client version to the latest one

Reason for change

Mostly for better observability
See changelog : link

@sarra-barnoussi
sarra-barnoussi requested a review from a team as a code owner April 17, 2026 12:28
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 17, 2026
andrewlock
andrewlock reviewed Apr 17, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, more changes are required to actually make these changes live though (see the comment at the top of the dockerfile)

I'll look at rebuilding and pushing this image soon, or better, maybe I'll try to update things so we can build directly in gitlab instead...

@pr-commenter

pr-commenter Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-06 13:45:44

Comparing candidate commit 05da2b0 in PR branch sarra.barnoussi/sint-5051-update-ci-identities-client-version with baseline commit 6ee0df9 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 58 known flaky benchmarks, 29 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • 🟥 throughput [-7790.557op/s; -7119.537op/s] or [-9.237%; -8.442%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-8268.601op/s; -7119.967op/s] or [-8.407%; -7.239%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+311.213ms; +316.614ms] or [+154.435%; +157.115%]
  • 🟥 throughput [-42.393op/s; -38.707op/s] or [-7.627%; -6.964%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+379.915ms; +381.888ms] or [+300.156%; +301.715%]
  • 🟩 throughput [+94.006op/s; +97.783op/s] or [+12.394%; +12.892%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+391.380ms; +393.084ms] or [+346.356%; +347.865%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-16.167ms; -11.998ms] or [-7.551%; -5.604%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • 🟥 throughput [-268815.975op/s; -265326.077op/s] or [-27.447%; -27.091%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.587ms; -21.734ms] or [-11.857%; -9.693%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • 🟥 throughput [-159472.444op/s; -143361.848op/s] or [-22.913%; -20.598%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 throughput [+9702.052op/s; +12652.321op/s] or [+6.173%; +8.050%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 throughput [+249841.089op/s; +280484.091op/s] or [+8.331%; +9.353%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-18.610ms; -14.266ms] or [-8.578%; -6.576%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • 🟥 execution_time [+298.459ms; +299.686ms] or [+149.130%; +149.743%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • 🟥 execution_time [+299.886ms; +303.021ms] or [+151.233%; +152.814%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • 🟥 execution_time [+299.997ms; +302.385ms] or [+151.115%; +152.318%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟥 execution_time [+296.492ms; +297.256ms] or [+145.625%; +146.000%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+297.731ms; +300.278ms] or [+145.550%; +146.795%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+299.923ms; +300.790ms] or [+149.901%; +150.335%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟥 execution_time [+22.496µs; +49.158µs] or [+5.159%; +11.274%]
  • 🟥 throughput [-240.316op/s; -120.362op/s] or [-10.448%; -5.233%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+27.214µs; +50.874µs] or [+8.688%; +16.241%]
  • 🟥 throughput [-467.751op/s; -268.748op/s] or [-14.581%; -8.378%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟥 execution_time [+299.543ms; +300.215ms] or [+149.503%; +149.838%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • unstable execution_time [+365.851ms; +402.472ms] or [+397.512%; +437.302%]
  • 🟩 throughput [+1250.057op/s; +1396.824op/s] or [+10.272%; +11.478%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • unstable execution_time [+331.438ms; +360.005ms] or [+251.658%; +273.349%]
  • 🟩 throughput [+658.672op/s; +861.702op/s] or [+6.376%; +8.342%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • unstable execution_time [+316.540ms; +355.909ms] or [+145.542%; +163.644%]
  • 🟥 throughput [-521.823op/s; -485.302op/s] or [-47.282%; -43.973%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • unstable execution_time [+210.958ms; +344.184ms] or [+89.901%; +146.677%]
  • 🟥 throughput [-672.551op/s; -588.973op/s] or [-44.859%; -39.285%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+330.007ms; +338.035ms] or [+197.383%; +202.184%]
  • 🟥 throughput [-380.161op/s; -345.635op/s] or [-26.470%; -24.066%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-171.394µs; -132.128µs] or [-8.682%; -6.693%]
  • 🟩 throughput [+38.453op/s; +48.759op/s] or [+7.591%; +9.626%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 execution_time [+303.253ms; +305.112ms] or [+152.713%; +153.649%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+302.296ms; +304.559ms] or [+151.481%; +152.615%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • 🟥 execution_time [+302.225ms; +305.264ms] or [+151.825%; +153.352%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟥 execution_time [+303.292ms; +304.881ms] or [+152.303%; +153.101%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • 🟥 execution_time [+297.056ms; +298.757ms] or [+146.881%; +147.722%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+302.562ms; +306.133ms] or [+153.352%; +155.162%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 execution_time [+300.651ms; +301.824ms] or [+150.900%; +151.488%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 execution_time [+300.375ms; +303.214ms] or [+149.709%; +151.124%]
  • 🟩 throughput [+52549.867op/s; +57273.594op/s] or [+10.435%; +11.373%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟥 execution_time [+299.852ms; +302.459ms] or [+149.174%; +150.470%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-19.583KB; -19.563KB] or [-7.144%; -7.136%]
  • unstable execution_time [-38.259µs; +13.668µs] or [-7.562%; +2.701%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟥 execution_time [+5.735µs; +9.857µs] or [+13.557%; +23.300%]
  • 🟥 throughput [-4471.474op/s; -2699.487op/s] or [-18.824%; -11.364%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • unstable execution_time [-14.476µs; -7.626µs] or [-22.460%; -11.831%]
  • 🟩 throughput [+1889.407op/s; +3320.018op/s] or [+11.592%; +20.369%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+303.192ms; +304.719ms] or [+153.250%; +154.022%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+303.038ms; +305.597ms] or [+154.245%; +155.548%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+299.611ms; +302.583ms] or [+149.992%; +151.480%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 throughput [+27546.342op/s; +31490.698op/s] or [+5.214%; +5.961%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 execution_time [+300.797ms; +302.435ms] or [+149.920%; +150.737%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 execution_time [+302.057ms; +303.576ms] or [+151.679%; +152.441%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+303.859ms; +306.091ms] or [+154.098%; +155.230%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • 🟥 execution_time [+299.875ms; +300.748ms] or [+149.579%; +150.015%]
  • 🟩 throughput [+61238775.264op/s; +61523291.466op/s] or [+44.598%; +44.805%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • unstable execution_time [+385.097ms; +416.613ms] or [+478.937%; +518.132%]
  • 🟩 throughput [+1066.213op/s; +1254.146op/s] or [+8.242%; +9.695%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 execution_time [+299.462ms; +300.363ms] or [+149.365%; +149.814%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 throughput [+107570.940op/s; +114587.886op/s] or [+10.044%; +10.699%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 throughput [+56692.285op/s; +75801.843op/s] or [+6.562%; +8.774%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 throughput [+97666.793op/s; +127768.779op/s] or [+7.560%; +9.890%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 throughput [+83179.845op/s; +91487.875op/s] or [+8.261%; +9.086%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 throughput [+55473.618op/s; +59814.958op/s] or [+10.073%; +10.861%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 throughput [+34007.359op/s; +43746.260op/s] or [+7.612%; +9.792%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟩 throughput [+89971.523op/s; +107305.260op/s] or [+10.052%; +11.989%]

Known flaky benchmarks without significant changes:

  • scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472
  • scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
  • scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
  • scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
  • scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
  • scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472
  • scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
  • scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

@andrewlock andrewlock mentioned this pull request Apr 23, 2026
Merged
andrewlock added a commit that referenced this pull request May 6, 2026
@andrewlock
Allow building the Gitlab docker image in Gitlab (#8507)
9818a29 
## Summary of changes

- Moves the building of GitLab image into GitLab
- Updates the build images/runners to use Windows 2022

## Reason for change

Today, updating the windows gitlab image involves
- building the image locally
- pushing it to dockerhub
- testing the image works
- making a PR to Datadog/images to mirror the image
- Updating the original PR to use the new image

That's a lot of faff. Instead, this PR changes it so that building the
docker image is just "click a button in GitLab"

## Implementation details

The crux of the implementation uses a hash of the contents of the gitlab
dockerimage folder. There's other ways we could do this, but this has
the nice behaviour of meaning your build will fail if you change
something there and _don't_ rebuild the image (e.g. see #8474).

The first time you change something in this folder, [the `Build` stage
will
fail](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/1621141095):

```
ERROR: Windows build image not found at registry.ddbuild.io/ci/dd-trace-dotnet/dd-trace-dotnet-docker-build:d8e89e5cffc8.
The Dockerfile or install scripts under tracer/build/_build/docker/gitlab/ have changed.
Manually trigger the 'build-windows-ci-image' job in this pipeline, wait for it to finish, then re-run this job.
```

You can then click on the pipeline, click
[build-windows-ci-image](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-dotnet/-/jobs/1621141094),
and go make a coffee ☕ After ~45 mins, the new image should have been
pushed, and you can re-run the build, with your new changes.

## Test coverage

I tested the workflow for this PR, and it works 🙌 

## Other details

One issue I had to deal with is the 2019/2022 issue. You can only run
docker images of the same base Windows version on the host, and the
`registry.ddbuild.io/ci-identities/ci-identities-gitlab-job-client:v0.2.0-windows-amd64`
image is apparently a 2022 host. Seeing as we really should be using
2022 anyway (and we use 2022 in azure devops), switched everything to be
2022 instead
@andrewlock
andrewlock force-pushed the sarra.barnoussi/sint-5051-update-ci-identities-client-version branch from da5772a to 05da2b0 Compare May 6, 2026 12:26
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented May 6, 2026

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8474) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.97 ± (73.04 - 73.39) ms72.85 ± (72.87 - 73.36) ms-0.2%✅
.NET Framework 4.8 - Bailout
duration77.18 ± (77.15 - 77.52) ms80.17 ± (79.95 - 80.44) ms+3.9%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1085.57 ± (1082.70 - 1089.95) ms1079.86 ± (1078.55 - 1084.14) ms-0.5%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.38 ± (22.34 - 22.42) ms22.90 ± (22.83 - 22.97) ms+2.3%✅⬆️
process.time_to_main_ms84.82 ± (84.59 - 85.04) ms86.84 ± (86.55 - 87.13) ms+2.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.93) MB10.92 ± (10.92 - 10.93) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.59 ± (22.54 - 22.65) ms22.57 ± (22.52 - 22.62) ms-0.1%✅
process.time_to_main_ms88.30 ± (87.97 - 88.64) ms87.42 ± (87.12 - 87.72) ms-1.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.90 ± (10.90 - 10.91) MB10.96 ± (10.96 - 10.97) MB+0.6%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms215.01 ± (214.26 - 215.75) ms212.65 ± (211.78 - 213.53) ms-1.1%✅
process.time_to_main_ms532.60 ± (531.12 - 534.08) ms530.57 ± (529.12 - 532.03) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.87 ± (47.84 - 47.91) MB48.03 ± (48.01 - 48.06) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.08 ± (21.04 - 21.12) ms21.50 ± (21.45 - 21.56) ms+2.0%✅⬆️
process.time_to_main_ms73.06 ± (72.88 - 73.24) ms75.46 ± (75.17 - 75.75) ms+3.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.62) MB10.65 ± (10.65 - 10.66) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.18 ± (21.14 - 21.23) ms21.38 ± (21.32 - 21.43) ms+0.9%✅⬆️
process.time_to_main_ms75.21 ± (74.97 - 75.45) ms76.50 ± (76.24 - 76.76) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.74 - 10.75) MB10.77 ± (10.77 - 10.77) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms381.92 ± (380.19 - 383.65) ms382.68 ± (380.76 - 384.59) ms+0.2%✅⬆️
process.time_to_main_ms527.76 ± (526.49 - 529.03) ms530.44 ± (529.10 - 531.77) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.29 ± (49.26 - 49.32) MB49.46 ± (49.44 - 49.49) MB+0.4%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms19.82 ± (19.76 - 19.89) ms19.51 ± (19.48 - 19.55) ms-1.6%✅
process.time_to_main_ms75.03 ± (74.69 - 75.37) ms72.64 ± (72.48 - 72.81) ms-3.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.66 ± (7.65 - 7.66) MB7.66 ± (7.66 - 7.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.51 ± (19.46 - 19.55) ms19.90 ± (19.85 - 19.95) ms+2.0%✅⬆️
process.time_to_main_ms74.05 ± (73.88 - 74.23) ms76.57 ± (76.29 - 76.86) ms+3.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.72 ± (7.71 - 7.72) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms297.76 ± (295.35 - 300.16) ms301.44 ± (298.98 - 303.90) ms+1.2%✅⬆️
process.time_to_main_ms495.88 ± (494.35 - 497.41) ms491.63 ± (490.51 - 492.75) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.56 ± (36.53 - 36.58) MB36.61 ± (36.58 - 36.63) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration204.68 ± (205.32 - 207.02) ms208.13 ± (208.42 - 210.17) ms+1.7%✅⬆️
.NET Framework 4.8 - Bailout
duration209.43 ± (209.34 - 210.79) ms212.69 ± (212.69 - 214.30) ms+1.6%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1221.20 ± (1220.43 - 1228.28) ms1234.42 ± (1234.87 - 1243.35) ms+1.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms198.77 ± (198.13 - 199.41) ms199.18 ± (198.38 - 199.98) ms+0.2%✅⬆️
process.time_to_main_ms86.46 ± (86.12 - 86.81) ms86.52 ± (86.12 - 86.92) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.00 ± (15.98 - 16.01) MB16.05 ± (16.03 - 16.07) MB+0.3%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.1%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms199.02 ± (198.33 - 199.70) ms199.74 ± (198.88 - 200.61) ms+0.4%✅⬆️
process.time_to_main_ms88.31 ± (87.95 - 88.66) ms87.82 ± (87.43 - 88.21) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.11 - 16.15) MB16.04 ± (16.02 - 16.06) MB-0.5%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.1%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.04 ± (398.40 - 401.67) ms423.63 ± (420.99 - 426.26) ms+5.9%✅⬆️
process.time_to_main_ms540.58 ± (539.25 - 541.92) ms534.24 ± (532.54 - 535.93) ms-1.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.54 ± (58.46 - 58.63) MB58.70 ± (58.64 - 58.77) MB+0.3%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.3%✅
.NET 6 - Baseline
process.internal_duration_ms210.72 ± (209.89 - 211.55) ms204.21 ± (203.36 - 205.06) ms-3.1%✅
process.time_to_main_ms78.20 ± (77.82 - 78.58) ms75.50 ± (75.12 - 75.88) ms-3.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.23 ± (16.21 - 16.25) MB16.31 ± (16.29 - 16.32) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (19 - 20)+0.1%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms207.37 ± (206.68 - 208.05) ms205.12 ± (204.21 - 206.04) ms-1.1%✅
process.time_to_main_ms78.36 ± (78.01 - 78.71) ms76.92 ± (76.53 - 77.30) ms-1.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.27 ± (16.25 - 16.28) MB16.34 ± (16.32 - 16.36) MB+0.4%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)20 ± (20 - 20)-1.8%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms598.52 ± (596.15 - 600.89) ms594.91 ± (592.59 - 597.23) ms-0.6%✅
process.time_to_main_ms546.47 ± (545.29 - 547.66) ms549.30 ± (547.87 - 550.73) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.20 ± (61.10 - 61.30) MB60.95 ± (60.85 - 61.05) MB-0.4%✅
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms206.12 ± (205.47 - 206.77) ms205.31 ± (204.53 - 206.10) ms-0.4%✅
process.time_to_main_ms76.19 ± (75.88 - 76.50) ms76.03 ± (75.67 - 76.38) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.51 ± (11.50 - 11.53) MB11.67 ± (11.65 - 11.68) MB+1.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.4%✅
.NET 8 - Bailout
process.internal_duration_ms206.12 ± (205.45 - 206.79) ms205.65 ± (204.90 - 206.39) ms-0.2%✅
process.time_to_main_ms77.58 ± (77.31 - 77.85) ms77.28 ± (76.94 - 77.63) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.59 ± (11.58 - 11.61) MB11.74 ± (11.73 - 11.76) MB+1.3%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-1.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms532.95 ± (526.12 - 539.78) ms524.72 ± (519.43 - 530.00) ms-1.5%✅
process.time_to_main_ms508.20 ± (507.12 - 509.28) ms505.81 ± (504.36 - 507.27) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.35 ± (50.27 - 50.42) MB50.40 ± (50.33 - 50.46) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (73ms)  : 69, 77
    master - mean (73ms)  : 71, 76

    section Bailout
    This PR (8474) - mean (80ms)  : 77, 84
    master - mean (77ms)  : 75, 80

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (1,081ms)  : 1042, 1121
    master - mean (1,086ms)  : 1035, 1138
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (117ms)  : 111, 123
    master - mean (114ms)  : 109, 119

    section Bailout
    This PR (8474) - mean (117ms)  : 111, 123
    master - mean (118ms)  : 111, 126

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (781ms)  : 756, 806
    master - mean (786ms)  : 762, 811
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (104ms)  : 98, 110
    master - mean (100ms)  : 97, 104

    section Bailout
    This PR (8474) - mean (105ms)  : 99, 110
    master - mean (103ms)  : 98, 107

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (941ms)  : 910, 973
    master - mean (940ms)  : 903, 977
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (100ms)  : 97, 102
    master - mean (103ms)  : 96, 109

    section Bailout
    This PR (8474) - mean (105ms)  : 98, 111
    master - mean (101ms)  : 99, 104

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (822ms)  : 783, 862
    master - mean (823ms)  : 776, 870
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (209ms)  : 197, 222
    master - mean (206ms)  : 193, 219

    section Bailout
    This PR (8474) - mean (213ms)  : 202, 225
    master - mean (210ms)  : 200, 220

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (1,239ms)  : 1178, 1300
    master - mean (1,224ms)  : 1168, 1281
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (297ms)  : 278, 316
    master - mean (296ms)  : 280, 311

    section Bailout
    This PR (8474) - mean (298ms)  : 279, 317
    master - mean (298ms)  : 280, 316

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (997ms)  : 973, 1021
    master - mean (981ms)  : 943, 1020
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (293ms)  : 268, 317
    master - mean (299ms)  : 279, 319

    section Bailout
    This PR (8474) - mean (292ms)  : 273, 311
    master - mean (296ms)  : 279, 312

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (1,176ms)  : 1126, 1226
    master - mean (1,175ms)  : 1129, 1222
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8474) - mean (294ms)  : 273, 315
    master - mean (295ms)  : 278, 313

    section Bailout
    This PR (8474) - mean (295ms)  : 277, 312
    master - mean (295ms)  : 280, 311

    section CallTarget+Inlining+NGEN
    This PR (8474) - mean (1,068ms)  : 990, 1146
    master - mean (1,074ms)  : 976, 1171
Loading

andrewlock
andrewlock approved these changes May 7, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay, I worked on #8507 to make actually shipping this change easier, and rebased. The resulting rebuild seems to have worked so 🤞 all looks good at your end!

@andrewlock
andrewlock merged commit 3825f10 into master May 7, 2026
140 checks passed
@andrewlock
andrewlock deleted the sarra.barnoussi/sint-5051-update-ci-identities-client-version branch May 7, 2026 08:56
@github-actions github-actions Bot added this to the vNext-v3 milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@cedricvanrompay-datadog cedricvanrompay-datadog cedricvanrompay-datadog approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.44.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sarra-barnoussi @andrewlock @cedricvanrompay-datadog