[Profiler] Fix bug in ManagedCodeCache#8467
Conversation
BenchmarksBenchmark execution time: 2026-04-17 09:42:13 Comparing candidate commit 2d71665 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 25 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8467) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (74ms) : 70, 78
master - mean (73ms) : 69, 76
section Bailout
This PR (8467) - mean (79ms) : 75, 83
master - mean (79ms) : 76, 83
section CallTarget+Inlining+NGEN
This PR (8467) - mean (1,072ms) : 1030, 1114
master - mean (1,076ms) : 1035, 1116
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (116ms) : 110, 122
master - mean (114ms) : 108, 120
section Bailout
This PR (8467) - mean (116ms) : 111, 122
master - mean (116ms) : 111, 122
section CallTarget+Inlining+NGEN
This PR (8467) - mean (797ms) : 771, 823
master - mean (794ms) : 763, 825
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (101ms) : 97, 104
master - mean (103ms) : 98, 109
section Bailout
This PR (8467) - mean (102ms) : 97, 107
master - mean (101ms) : 98, 104
section CallTarget+Inlining+NGEN
This PR (8467) - mean (942ms) : 903, 981
master - mean (941ms) : 906, 975
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (102ms) : 97, 107
master - mean (99ms) : 96, 103
section Bailout
This PR (8467) - mean (101ms) : 98, 104
master - mean (104ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8467) - mean (828ms) : 783, 874
master - mean (825ms) : 784, 866
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (201ms) : 196, 205
master - mean (200ms) : 196, 204
section Bailout
This PR (8467) - mean (205ms) : 201, 208
master - mean (205ms) : 199, 210
section CallTarget+Inlining+NGEN
This PR (8467) - mean (1,188ms) : 1146, 1230
master - mean (1,190ms) : 1130, 1249
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (291ms) : 284, 299
master - mean (289ms) : 283, 295
section Bailout
This PR (8467) - mean (291ms) : 285, 297
master - mean (290ms) : 284, 295
section CallTarget+Inlining+NGEN
This PR (8467) - mean (974ms) : 949, 999
master - mean (964ms) : 940, 988
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (286ms) : 279, 293
master - mean (280ms) : 274, 286
section Bailout
This PR (8467) - mean (284ms) : 279, 289
master - mean (282ms) : 276, 288
section CallTarget+Inlining+NGEN
This PR (8467) - mean (1,158ms) : 1116, 1200
master - mean (1,159ms) : 1115, 1204
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8467) - mean (284ms) : 277, 290
master - mean (280ms) : 275, 285
section Bailout
This PR (8467) - mean (285ms) : 276, 293
master - mean (281ms) : 275, 287
section CallTarget+Inlining+NGEN
This PR (8467) - mean (1,050ms) : 1006, 1094
master - mean (1,042ms) : 992, 1093
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
8270b74 to
2d71665
Compare
Summary of changes
Method
IsManagedhas a bug when the instruction pointer is in the R2R segments.Reason for change
Implementation details
Make it right :)
If we do not find the instruction pointers in JIT Code cache, we look into the module code cache.
Test coverage
New test added
Other details