add new set of benchmarks#8464
Merged
Merged
Conversation
github-actions
Bot
added
the
area:builds
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8464) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (73ms) : 70, 76
master - mean (74ms) : 70, 77
section Bailout
This PR (8464) - mean (77ms) : 74, 79
master - mean (77ms) : 74, 79
section CallTarget+Inlining+NGEN
This PR (8464) - mean (1,076ms) : 1029, 1123
master - mean (1,080ms) : 1022, 1139
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (114ms) : 109, 119
master - mean (116ms) : 108, 124
section Bailout
This PR (8464) - mean (115ms) : 112, 118
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8464) - mean (797ms) : 765, 828
master - mean (800ms) : 774, 826
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (101ms) : 96, 107
master - mean (100ms) : 95, 105
section Bailout
This PR (8464) - mean (101ms) : 99, 103
master - mean (105ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (8464) - mean (943ms) : 912, 974
master - mean (942ms) : 910, 974
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (102ms) : 96, 109
master - mean (101ms) : 97, 105
section Bailout
This PR (8464) - mean (103ms) : 99, 108
master - mean (101ms) : 99, 103
section CallTarget+Inlining+NGEN
This PR (8464) - mean (826ms) : 788, 863
master - mean (825ms) : 786, 863
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (210ms) : 205, 215
master - mean (204ms) : 199, 209
section Bailout
This PR (8464) - mean (213ms) : 209, 217
master - mean (207ms) : 204, 211
section CallTarget+Inlining+NGEN
This PR (8464) - mean (1,230ms) : 1173, 1287
master - mean (1,200ms) : 1158, 1241
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (303ms) : 293, 313
master - mean (294ms) : 288, 301
section Bailout
This PR (8464) - mean (304ms) : 298, 309
master - mean (295ms) : 291, 300
section CallTarget+Inlining+NGEN
This PR (8464) - mean (1,008ms) : 975, 1041
master - mean (991ms) : 966, 1017
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (298ms) : 290, 306
master - mean (288ms) : 282, 294
section Bailout
This PR (8464) - mean (297ms) : 291, 304
master - mean (289ms) : 283, 294
section CallTarget+Inlining+NGEN
This PR (8464) - mean (1,178ms) : 1140, 1216
master - mean (1,167ms) : 1133, 1202
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8464) - mean (296ms) : 288, 303
master - mean (288ms) : 281, 294
section Bailout
This PR (8464) - mean (296ms) : 289, 302
master - mean (288ms) : 283, 293
section CallTarget+Inlining+NGEN
This PR (8464) - mean (1,081ms) : 994, 1169
master - mean (1,063ms) : 980, 1145
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-17 13:36:37 Comparing candidate commit 7789f0c in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
faydef
marked this pull request as ready for review
April 17, 2026 12:43
andrewlock
approved these changes
Apr 17, 2026
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Sure, if it works, then LGTM 👍
Comment on lines
+9
to
+10
| - dotnet-aspnet-realworld-parallel | ||
| - dotnet-aspnet-realworld-parallel-slo |
Member
There was a problem hiding this comment.
"aspnet" not "aspnetcore"? You're killing me here 😂
Collaborator
There was a problem hiding this comment.
I'm sorry that's on me, I started out as a .NET Framework one but then had to swap to .NET 10
I didn't want to change the name as I got too attached to it
Collaborator
There was a problem hiding this comment.
I think the plan was to actually go and add in more Activity + DD examples (ideally with .NET Framework and .NET)
But we can change the name if needed, but unsure if that will cause any downstream issues 😛
Contributor
Author
There was a problem hiding this comment.
But we can change the name if needed, but unsure if that will cause any downstream issues 😛
It should be changed downstream too indeed 👍
I'm sorry that's on me, I started out as a .NET Framework one but then had to swap to .NET 10
I mean.. The naming convention for .NET is not helping out here either 😆
Member
There was a problem hiding this comment.
The naming convention for .NET is not helping out here either
It's very simple, ASP.NET runs on ASP.NET Core, ASP.NET Core, runs on .NET Framework and .NET Core and also .NET which is the same as .NET Core but different. Hope that clears it up 
andrewlock
added
the
area:benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Integrates new parallel macrobenchmarks from
DataDog/apm-sdks-benchmarksvia GitLabinclude: project:configuration in the CI pipeline.Reason for change
Centralizes macrobenchmark configurations in a single repository (
apm-sdks-benchmarks) for consistent and unified management across all APM SDKs.Implementation details
Both old and new benchmarks run in parallel during the transition period to validate results. All future macrobenchmark changes should be made in the
apm-sdks-benchmarksrepository.Test coverage
Existing benchmark validation ensures consistency between old and new benchmark runs during the parallel execution period.
Other details
These jobs are allowed to fail to avoid potentially impeding the workflow.