Fix benchmark reporting#8453
Conversation
BenchmarksBenchmark execution time: 2026-04-14 16:27:49 Comparing candidate commit 4fc437d in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 25 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8453) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (72ms) : 69, 74
master - mean (71ms) : 69, 73
section Bailout
This PR (8453) - mean (76ms) : 73, 78
master - mean (76ms) : 73, 78
section CallTarget+Inlining+NGEN
This PR (8453) - mean (1,071ms) : 1033, 1108
master - mean (1,072ms) : 1022, 1123
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (111ms) : 108, 115
master - mean (113ms) : 109, 116
section Bailout
This PR (8453) - mean (113ms) : 111, 116
master - mean (114ms) : 110, 117
section CallTarget+Inlining+NGEN
This PR (8453) - mean (778ms) : 754, 801
master - mean (789ms) : 769, 809
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (99ms) : 97, 102
master - mean (99ms) : 95, 103
section Bailout
This PR (8453) - mean (100ms) : 97, 104
master - mean (100ms) : 97, 103
section CallTarget+Inlining+NGEN
This PR (8453) - mean (935ms) : 896, 974
master - mean (929ms) : 896, 963
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (99ms) : 95, 103
master - mean (99ms) : 96, 101
section Bailout
This PR (8453) - mean (99ms) : 97, 101
master - mean (99ms) : 96, 102
section CallTarget+Inlining+NGEN
This PR (8453) - mean (813ms) : 776, 850
master - mean (811ms) : 778, 845
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (208ms) : 204, 212
master - mean (208ms) : 204, 213
section Bailout
This PR (8453) - mean (214ms) : 211, 217
master - mean (212ms) : 209, 215
section CallTarget+Inlining+NGEN
This PR (8453) - mean (1,221ms) : 1177, 1266
master - mean (1,218ms) : 1159, 1276
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (302ms) : 297, 308
master - mean (300ms) : 293, 307
section Bailout
This PR (8453) - mean (304ms) : 298, 309
master - mean (300ms) : 295, 305
section CallTarget+Inlining+NGEN
This PR (8453) - mean (996ms) : 965, 1026
master - mean (995ms) : 970, 1020
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (295ms) : 289, 301
master - mean (294ms) : 287, 300
section Bailout
This PR (8453) - mean (296ms) : 292, 299
master - mean (294ms) : 288, 300
section CallTarget+Inlining+NGEN
This PR (8453) - mean (1,180ms) : 1142, 1218
master - mean (1,176ms) : 1138, 1213
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8453) - mean (292ms) : 288, 297
master - mean (292ms) : 287, 297
section Bailout
This PR (8453) - mean (295ms) : 289, 300
master - mean (291ms) : 286, 296
section CallTarget+Inlining+NGEN
This PR (8453) - mean (1,060ms) : 991, 1129
master - mean (1,078ms) : 974, 1182
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Fix benchmark failures not being reported in CI
Reason for change
The wrong ordering of commands meant we were ignoring benchmarking failures
Implementation details
Make sure to check the
ERRORLOGbefore calling another commandTest coverage
This is the test I guess, let's see what happens
Other details
Spotted because @cbeauchesne noticed that #8367 regressed, but didn't fail the CI job