Make microbenchmark post-processing steps non-fatal#8452
Conversation
upload-to-bp-ui.sh and post-pr-comment.sh now log warnings on failure and always exit 0, so transient upload/comment errors do not fail the benchmark CI job when the actual benchmark run succeeded.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8452) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (72ms) : 69, 74
master - mean (72ms) : 70, 74
section Bailout
This PR (8452) - mean (76ms) : 74, 78
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8452) - mean (1,064ms) : 1027, 1102
master - mean (1,076ms) : 1010, 1141
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (112ms) : 109, 116
master - mean (114ms) : 110, 117
section Bailout
This PR (8452) - mean (113ms) : 109, 116
master - mean (115ms) : 112, 118
section CallTarget+Inlining+NGEN
This PR (8452) - mean (783ms) : 757, 809
master - mean (784ms) : 764, 805
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (99ms) : 96, 103
master - mean (100ms) : 96, 103
section Bailout
This PR (8452) - mean (99ms) : 97, 101
master - mean (101ms) : 98, 104
section CallTarget+Inlining+NGEN
This PR (8452) - mean (930ms) : 900, 959
master - mean (932ms) : 899, 964
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (98ms) : 94, 101
master - mean (98ms) : 94, 103
section Bailout
This PR (8452) - mean (99ms) : 97, 101
master - mean (99ms) : 97, 101
section CallTarget+Inlining+NGEN
This PR (8452) - mean (816ms) : 777, 854
master - mean (814ms) : 781, 848
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (190ms) : 187, 193
master - mean (191ms) : 187, 194
section Bailout
This PR (8452) - mean (194ms) : 191, 197
master - mean (194ms) : 192, 196
section CallTarget+Inlining+NGEN
This PR (8452) - mean (1,143ms) : 1088, 1197
master - mean (1,142ms) : 1100, 1184
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (273ms) : 269, 277
master - mean (273ms) : 269, 277
section Bailout
This PR (8452) - mean (273ms) : 270, 276
master - mean (273ms) : 270, 276
section CallTarget+Inlining+NGEN
This PR (8452) - mean (926ms) : 908, 944
master - mean (924ms) : 895, 953
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (266ms) : 262, 271
master - mean (267ms) : 262, 272
section Bailout
This PR (8452) - mean (267ms) : 264, 269
master - mean (266ms) : 264, 268
section CallTarget+Inlining+NGEN
This PR (8452) - mean (1,133ms) : 1078, 1188
master - mean (1,133ms) : 1090, 1176
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8452) - mean (265ms) : 261, 270
master - mean (264ms) : 261, 267
section Bailout
This PR (8452) - mean (265ms) : 263, 268
master - mean (265ms) : 261, 268
section CallTarget+Inlining+NGEN
This PR (8452) - mean (1,021ms) : 973, 1069
master - mean (1,019ms) : 980, 1058
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-14 10:32:56 Comparing candidate commit a86524b in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Summary of changes
upload-to-bp-ui.sh: curl and HTTP failures are non-fatal, logged as warnings, script always exits 0post-pr-comment.sh:pr-commenterfailure is non-fatal, logged as a warninganalyze-results.sh: fails fast if no candidate results are foundWARNING:casing normalized consistently across all scriptsReason for change
Transient upload or PR comment failures were marking
run-benchmarksas failed even when benchmarks succeeded, causing unnecessary reruns.Test coverage
Verified curl failure, HTTP 503, and HTTP 200 paths via shell tests.