Skip to content

Improve peer-tag calculation fast-path performance#8445

Merged
andrewlock merged 9 commits into
masterfrom
andrew/client-side-stats/peer-tag-improvements
Apr 21, 2026
Merged

Improve peer-tag calculation fast-path performance#8445
andrewlock merged 9 commits into
masterfrom
andrew/client-side-stats/peer-tag-improvements

Conversation

@andrewlock

@andrewlock andrewlock commented Apr 13, 2026

Copy link
Copy Markdown
Member

Summary of changes

Improves the performance of peer-tag hash calculation for "fast path" cases (where there's an existing bucket)

Reason for change

We have to calculate the hash of all peer tags as part of client-side-stats bucketing calculations, which involves encoding them as utf-8. Additionally, when we send the buckets, we have to send the tags as utf-8.

In the initial CSS 1.2.0 implementation, we encoded the tags every-time we ran a calculation, which would allocate for every span that had peer tags, generally quite expensive. In this PR, we switch to doing the encoding twice: once with a zero-allocation implementation (amortized 0 on .NET Framework) to calculate the hash, and then, if we need the "real" encoded tags, then we do that encoding again.

Implementation details

  • Split the peer tags work in two, once to calculate the peer tags hash, once to get the actual tags as key:value
  • In the hash-calculation stage, we can use stackalloc for .NET Core, and array pool implementation for .NET Framework etc
  • As additional optimizations, we also
    • Pre-encode the peer tag keys to utf-8, so that we only need to do those once for the hash calculation.
    • Pass key details from BuildKey to GetEncodedPeerTags (i.e. is this a "base service" only tag, if so, what's the tag value, otherwise how big does the peer tag list need to be)
    • If client-side stats is disabled, don't bother doing all the pre-calculation (or for trace filters)

There are some possible future optimizations, not implemented in this PR:

  • Track which tags require IP quantization to avoid re-doing it. (Maybe we should allow-list the quantization anyway, so that it only applies to specific tags? Or alternatively, block list?)
  • Instead of doing the encoding of tag:value, allow writing the pre-computed byte[] to MessagePackBinary and appending the value. This is doable, but requires updating the MessagePackBinary implementation to support it, so I considered it out of scope for now

Test coverage

Mostly covered by existing tests, but added some additional unit tests that directly compare the hashing to values used in Go agent tests.

Additionally did some benchmarking. The key thing is that the ClientSpanWithPeerTags path is zero-allocation (and it's nice that the slow-path is still lower allocation than before, even if it's slower over all)

Method Runtime Mean Error Allocated
BuildKey_SimpleSpan_Before .NET 10.0 44.34 ns 0.906 ns -
BuildKey_SimpleSpan_After .NET 10.0 39.17 ns 0.445 ns -
BuildKey_SimpleSpan_Before .NET 6.0 93.13 ns 1.837 ns -
BuildKey_SimpleSpan_After .NET 6.0 87.56 ns 0.839 ns -
BuildKey_SimpleSpan_Before .NET Core 3.1 192.53 ns 2.572 ns -
BuildKey_SimpleSpan_After .NET Core 3.1 217.32 ns 4.362 ns -
BuildKey_SimpleSpan_Before .NET Framework 4.8 131.98 ns 2.621 ns -
BuildKey_SimpleSpan_After .NET Framework 4.8 175.20 ns 7.647 ns -
BuildKey_ClientSpanNoPeerTags_Before .NET 10.0 160.62 ns 2.622 ns -
BuildKey_ClientSpanNoPeerTags_After .NET 10.0 151.27 ns 1.995 ns -
BuildKey_ClientSpanNoPeerTags_Before .NET 6.0 243.62 ns 3.199 ns -
BuildKey_ClientSpanNoPeerTags_After .NET 6.0 232.55 ns 2.975 ns -
BuildKey_ClientSpanNoPeerTags_Before .NET Core 3.1 550.47 ns 9.998 ns -
BuildKey_ClientSpanNoPeerTags_After .NET Core 3.1 680.42 ns 10.022 ns -
BuildKey_ClientSpanNoPeerTags_Before .NET Framework 4.8 442.88 ns 8.854 ns -
BuildKey_ClientSpanNoPeerTags_After .NET Framework 4.8 682.12 ns 13.468 ns -
BuildKey_ClientSpanWithPeerTags_Before .NET 10.0 800.82 ns 15.062 ns 840 B
BuildKey_ClientSpanWithPeerTags_After .NET 10.0 575.04 ns 5.604 ns -
BuildKey_ClientSpanWithPeerTags_Before .NET 6.0 1,076.07 ns 13.124 ns 840 B
BuildKey_ClientSpanWithPeerTags_After .NET 6.0 1,440.26 ns 28.755 ns -
BuildKey_ClientSpanWithPeerTags_Before .NET Core 3.1 1,531.27 ns 13.509 ns 840 B
BuildKey_ClientSpanWithPeerTags_After .NET Core 3.1 1,774.35 ns 89.601 ns -
BuildKey_ClientSpanWithPeerTags_Before .NET Framework 4.8 1,682.15 ns 17.082 ns 859 B
BuildKey_ClientSpanWithPeerTags_After .NET Framework 4.8 2,040.90 ns 162.895 ns -
BuildKey_ClientSpanWithPeerTags_GetEncodedPeerTags .NET 10.0 1,141.85 ns 9.980 ns 760 B
BuildKey_ClientSpanWithPeerTags_GetEncodedPeerTags .NET 6.0 2,720.55 ns 53.097 ns 760 B
BuildKey_ClientSpanWithPeerTags_GetEncodedPeerTags .NET Core 3.1 3,534.28 ns 141.234 ns 760 B
BuildKey_ClientSpanWithPeerTags_GetEncodedPeerTags .NET Framework 4.8 3,438.80 ns 84.352 ns 778 B
Details 

// <copyright file="StatsAggregatorBenchmark.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System;
using System.Collections.Generic;
using System.Threading.Tasks;
using BenchmarkDotNet.Attributes;
using Datadog.Trace;
using Datadog.Trace.Agent;
using Datadog.Trace.Agent.DiscoveryService;
using Datadog.Trace.Configuration;
using Datadog.Trace.Tagging;

namespace Benchmarks.Trace;

/// <summary>
/// StatsAggregator.BuildKey benchmarks
/// </summary>
[MemoryDiagnoser]
[BenchmarkCategory(Constants.TracerCategory)]
public class StatsAggregatorBenchmark
{
    private static readonly List<StatsAggregator.PeerTagKey> PeerTagKeys =
    [
        new("_dd.base_service"),
        new("aws.queue.name"),
        new("aws.queue.url"),
        new("aws.s3.bucket"),
        new("aws.stream.name"),
        new("bucketname"),
        new("db.couchbase.seed.nodes"),
        new("db.hostname"),
        new("db.instance"),
        new("db.system"),
        new("messaging.destination"),
        new("messaging.kafka.bootstrap.servers"),
        new("messaging.rabbitmq.exchange"),
        new("messaging.system"),
        new("network.destination.name"),
        new("peer.hostname"),
        new("peer.service"),
        new("server.address"),
        new("topic"),
    ];

    private StatsAggregator _aggregator;
    private Span _simpleSpan;
    private Span _clientSpanNoPeerTags;
    private Span _clientSpanWithPeerTags;
    private StatsAggregationKey _key;
    private List<byte[]> _encoded;

    [GlobalSetup]
    public void GlobalSetup()
    {
        _aggregator = new StatsAggregator(
            new NoOpApi(),
            new TracerSettings(),
            NullDiscoveryService.Instance,
            isOtlp: false);

        var now = DateTimeOffset.UtcNow;

        // Simple span: no span kind, no peer tags — exercises the "internal" fast path
        _simpleSpan = CreateSpan(now, "web-service", "web.request", "GET /api/users", "web");

        // Client span with SpanKind but no matching peer tags — iterates peer tag keys but finds nothing
        var clientTags = new HttpTags { HttpMethod = "GET", HttpStatusCode = "200" };
        _clientSpanNoPeerTags = CreateSpan(now, "web-service", "http.request", "GET /api/orders", "http", clientTags);

        // Client span with several peer tags set — the most expensive path
        var peerTags = new HttpTags { HttpMethod = "POST", HttpStatusCode = "200" };
        _clientSpanWithPeerTags = CreateSpan(now, "web-service", "http.request", "POST /api/data", "http", peerTags);
        _clientSpanWithPeerTags.Tags.SetTag("peer.service", "remote-service");
        _clientSpanWithPeerTags.Tags.SetTag("db.instance", "i-1234");
        _clientSpanWithPeerTags.Tags.SetTag("db.system", "postgres");
        _clientSpanWithPeerTags.Tags.SetTag("server.address", "db.example.com");
        _clientSpanWithPeerTags.Tags.SetTag("network.destination.name", "db.example.com");

    }

    [GlobalCleanup]
    public void GlobalCleanup()
    {
        _aggregator.DisposeAsync().GetAwaiter().GetResult();
        var value = _key;
        var encoded = _encoded;
    }

    /// <summary>
    /// BuildKey for a simple span with no span kind (internal fast-path, no peer tag iteration).
    /// </summary>
    [Benchmark]
    public void BuildKey_SimpleSpan()
    {
        _key = _aggregator.BuildKey(_simpleSpan, PeerTagKeys, out _);
    }

    /// <summary>
    /// BuildKey for a client span that has no matching peer tags (iterates all peer tag keys, finds none).
    /// </summary>
    [Benchmark]
    public void BuildKey_ClientSpanNoPeerTags()
    {
        _key = _aggregator.BuildKey(_clientSpanNoPeerTags, PeerTagKeys, out _);
    }

    /// <summary>
    /// BuildKey for a client span with several peer tags set (UTF-8 encoding + FNV hashing).
    /// </summary>
    [Benchmark]
    public void BuildKey_ClientSpanWithPeerTags()
    {
        _key = _aggregator.BuildKey(_clientSpanWithPeerTags, PeerTagKeys, out var results);
    }

    /// <summary>
    /// BuildKey for a client span with several peer tags set (UTF-8 encoding + FNV hashing).
    /// </summary>
    [Benchmark]
    public void BuildKey_ClientSpanWithPeerTags_GetEncodedPeerTags()
    {
        _key = _aggregator.BuildKey(_clientSpanWithPeerTags, PeerTagKeys, out var results);
        _encoded = StatsAggregator.GetEncodedPeerTags(_clientSpanWithPeerTags, PeerTagKeys, in results);
    }

    private static Span CreateSpan(DateTimeOffset start, string serviceName, string operationName, string resourceName, string type, ITags tags = null)
    {
        var tracer = Benchmarks.Trace.Asm.EmptyDatadogTracer.Instance;
        var traceContext = new TraceContext(tracer);
        var context = new SpanContext(null, traceContext, serviceName);
        var span = new Span(context, start, tags);
        span.OperationName = operationName;
        span.ResourceName = resourceName;
        span.Type = type;
        return span;
    }

    private sealed class NoOpApi : IApi
    {
        public TracesEncoding TracesEncoding => TracesEncoding.DatadogV0_4;

        public Task<bool> Ping() => Task.FromResult(true);

        public Task<bool> SendTracesAsync(ArraySegment<byte> traces, int numberOfTraces, bool statsComputationEnabled, long numberOfDroppedP0Traces, long numberOfDroppedP0Spans, bool apmTracingEnabled = true)
            => Task.FromResult(true);

        public Task<bool> SendStatsAsync(StatsBuffer stats, long bucketDuration, int tracerObfuscationVersion)
            => Task.FromResult(true);
    }
}

Other details

Part of a stack:

@andrewlock andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:performance Performance, speed, latency, resource usage (CPU, memory) labels Apr 13, 2026
@andrewlock
andrewlock requested a review from a team as a code owner April 13, 2026 12:34
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8445) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.04 ± (73.06 - 73.47) ms73.19 ± (73.08 - 73.53) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration79.43 ± (79.14 - 79.68) ms76.79 ± (76.59 - 76.94) ms-3.3%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1078.17 ± (1077.99 - 1085.09) ms1074.02 ± (1075.82 - 1084.44) ms-0.4%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.58 ± (22.53 - 22.64) ms22.49 ± (22.44 - 22.55) ms-0.4%✅
process.time_to_main_ms85.27 ± (84.93 - 85.61) ms84.08 ± (83.83 - 84.33) ms-1.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.91) MB10.91 ± (10.91 - 10.92) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.44 ± (22.39 - 22.49) ms22.24 ± (22.21 - 22.27) ms-0.9%✅
process.time_to_main_ms85.80 ± (85.52 - 86.08) ms85.33 ± (85.10 - 85.57) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.91 - 10.92) MB10.95 ± (10.94 - 10.95) MB+0.3%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms229.30 ± (228.30 - 230.31) ms230.98 ± (229.84 - 232.13) ms+0.7%✅⬆️
process.time_to_main_ms528.48 ± (527.17 - 529.79) ms528.99 ± (527.49 - 530.49) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.49 ± (48.46 - 48.52) MB48.49 ± (48.46 - 48.52) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.54 ± (21.48 - 21.59) ms21.18 ± (21.15 - 21.21) ms-1.7%✅
process.time_to_main_ms75.15 ± (74.86 - 75.45) ms72.30 ± (72.13 - 72.47) ms-3.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.62) MB10.62 ± (10.62 - 10.62) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.34 ± (21.29 - 21.39) ms21.40 ± (21.36 - 21.45) ms+0.3%✅⬆️
process.time_to_main_ms75.13 ± (74.90 - 75.36) ms75.82 ± (75.54 - 76.11) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.72 ± (10.72 - 10.73) MB10.74 ± (10.74 - 10.74) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms382.76 ± (380.81 - 384.70) ms385.18 ± (382.95 - 387.42) ms+0.6%✅⬆️
process.time_to_main_ms528.95 ± (527.68 - 530.21) ms527.58 ± (526.40 - 528.75) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.92 ± (49.89 - 49.95) MB50.09 ± (50.06 - 50.11) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.57 ± (19.54 - 19.61) ms19.48 ± (19.45 - 19.52) ms-0.5%✅
process.time_to_main_ms73.22 ± (73.05 - 73.39) ms73.24 ± (73.05 - 73.43) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.67 ± (7.67 - 7.68) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.84 ± (19.79 - 19.89) ms19.35 ± (19.31 - 19.38) ms-2.5%✅
process.time_to_main_ms76.26 ± (76.01 - 76.51) ms73.43 ± (73.31 - 73.54) ms-3.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.72) MB7.73 ± (7.73 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms306.60 ± (304.59 - 308.62) ms303.14 ± (301.06 - 305.22) ms-1.1%✅
process.time_to_main_ms488.18 ± (487.03 - 489.32) ms488.35 ± (487.19 - 489.51) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.82 ± (37.75 - 37.89) MB37.20 ± (37.15 - 37.25) MB-1.6%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.2%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration190.97 ± (190.90 - 191.72) ms191.26 ± (191.31 - 192.19) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration194.83 ± (194.74 - 195.32) ms194.81 ± (194.65 - 195.23) ms-0.0%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1154.22 ± (1155.63 - 1163.48) ms1150.40 ± (1150.13 - 1156.71) ms-0.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms185.22 ± (184.85 - 185.58) ms185.52 ± (185.21 - 185.83) ms+0.2%✅⬆️
process.time_to_main_ms80.36 ± (80.19 - 80.54) ms80.37 ± (80.20 - 80.55) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.04 - 16.16) MB16.13 ± (16.10 - 16.16) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms184.28 ± (184.05 - 184.51) ms185.14 ± (184.91 - 185.37) ms+0.5%✅⬆️
process.time_to_main_ms81.63 ± (81.51 - 81.74) ms81.92 ± (81.80 - 82.05) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.24 ± (16.21 - 16.27) MB16.07 ± (15.98 - 16.16) MB-1.0%✅
runtime.dotnet.threads.count21 ± (21 - 21)20 ± (20 - 20)-2.6%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms393.41 ± (392.07 - 394.75) ms393.63 ± (392.23 - 395.02) ms+0.1%✅⬆️
process.time_to_main_ms505.05 ± (503.89 - 506.20) ms506.08 ± (505.06 - 507.11) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.75 ± (58.56 - 58.94) MB58.87 ± (58.66 - 59.07) MB+0.2%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms189.21 ± (188.98 - 189.44) ms189.73 ± (189.49 - 189.97) ms+0.3%✅⬆️
process.time_to_main_ms70.43 ± (70.30 - 70.57) ms70.06 ± (69.90 - 70.22) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (15.94 - 16.25) MB15.93 ± (15.76 - 16.10) MB-1.0%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.4%✅
.NET 6 - Bailout
process.internal_duration_ms188.61 ± (188.42 - 188.79) ms188.71 ± (188.54 - 188.88) ms+0.1%✅⬆️
process.time_to_main_ms71.24 ± (71.14 - 71.33) ms71.05 ± (70.95 - 71.15) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (15.96 - 16.27) MB16.14 ± (15.99 - 16.28) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.7%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms595.94 ± (592.52 - 599.35) ms598.50 ± (595.84 - 601.16) ms+0.4%✅⬆️
process.time_to_main_ms508.12 ± (507.33 - 508.91) ms508.04 ± (507.20 - 508.88) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.39 ± (61.28 - 61.49) MB61.73 ± (61.63 - 61.82) MB+0.6%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.4%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms186.39 ± (186.12 - 186.65) ms186.55 ± (186.35 - 186.74) ms+0.1%✅⬆️
process.time_to_main_ms69.34 ± (69.16 - 69.51) ms69.30 ± (69.14 - 69.46) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.75 ± (11.72 - 11.77) MB11.84 ± (11.81 - 11.87) MB+0.8%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms186.02 ± (185.78 - 186.25) ms185.48 ± (185.27 - 185.69) ms-0.3%✅
process.time_to_main_ms70.62 ± (70.50 - 70.74) ms70.25 ± (70.16 - 70.35) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.79 ± (11.74 - 11.83) MB11.75 ± (11.66 - 11.84) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (18 - 19)-2.5%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms517.15 ± (514.91 - 519.39) ms517.16 ± (514.60 - 519.73) ms+0.0%✅⬆️
process.time_to_main_ms466.76 ± (466.14 - 467.39) ms468.80 ± (468.09 - 469.52) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.76 ± (50.73 - 50.80) MB50.76 ± (50.74 - 50.79) MB-0.0%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.2%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (73ms)  : 70, 77
    master - mean (73ms)  : 70, 76

    section Bailout
    This PR (8445) - mean (77ms)  : 75, 78
    master - mean (79ms)  : 75, 84

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (1,080ms)  : 1018, 1142
    master - mean (1,082ms)  : 1029, 1134
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (114ms)  : 107, 120
    master - mean (115ms)  : 108, 122

    section Bailout
    This PR (8445) - mean (114ms)  : 111, 117
    master - mean (115ms)  : 109, 122

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (797ms)  : 770, 823
    master - mean (795ms)  : 772, 818
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (99ms)  : 96, 103
    master - mean (103ms)  : 97, 110

    section Bailout
    This PR (8445) - mean (104ms)  : 99, 108
    master - mean (103ms)  : 98, 107

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (940ms)  : 905, 976
    master - mean (940ms)  : 906, 973
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (100ms)  : 97, 103
    master - mean (101ms)  : 98, 103

    section Bailout
    This PR (8445) - mean (100ms)  : 98, 102
    master - mean (104ms)  : 100, 109

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (824ms)  : 783, 866
    master - mean (826ms)  : 784, 869
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (192ms)  : 187, 196
    master - mean (191ms)  : 187, 195

    section Bailout
    This PR (8445) - mean (195ms)  : 192, 198
    master - mean (195ms)  : 192, 198

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (1,153ms)  : 1106, 1201
    master - mean (1,160ms)  : 1100, 1219
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (275ms)  : 271, 278
    master - mean (274ms)  : 269, 280

    section Bailout
    This PR (8445) - mean (275ms)  : 271, 280
    master - mean (274ms)  : 271, 277

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (930ms)  : 910, 951
    master - mean (927ms)  : 899, 956
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (268ms)  : 264, 272
    master - mean (268ms)  : 264, 272

    section Bailout
    This PR (8445) - mean (268ms)  : 265, 270
    master - mean (268ms)  : 265, 271

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (1,137ms)  : 1105, 1169
    master - mean (1,132ms)  : 1082, 1183
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8445) - mean (266ms)  : 262, 269
    master - mean (266ms)  : 262, 270

    section Bailout
    This PR (8445) - mean (266ms)  : 262, 269
    master - mean (266ms)  : 263, 269

    section CallTarget+Inlining+NGEN
    This PR (8445) - mean (1,020ms)  : 980, 1059
    master - mean (1,016ms)  : 981, 1051
Loading

@pr-commenter

pr-commenter Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-21 07:11:42

Comparing candidate commit 4ee6bae in PR branch andrew/client-side-stats/peer-tag-improvements with baseline commit 77b1fe6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.005%]
  • ignore execution_time [-817.574µs; +136.563µs] or [-0.406%; +0.068%]
  • ignore throughput [+14.823op/s; +528.694op/s] or [+0.018%; +0.627%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-2016.569µs; +1489.492µs] or [-1.006%; +0.743%]
  • 🟩 throughput [+8344.650op/s; +10593.359op/s] or [+7.014%; +8.904%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • ignore execution_time [+0.201ms; +2.404ms] or [+0.101%; +1.209%]
  • ignore throughput [-1356.857op/s; -84.266op/s] or [-1.380%; -0.086%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [-20 bytes; -19 bytes] or [-0.613%; -0.600%]
  • 🟥 execution_time [+306.043ms; +307.844ms] or [+151.869%; +152.763%]
  • ignore throughput [+8.751op/s; +12.518op/s] or [+1.575%; +2.252%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+380.696ms; +383.711ms] or [+300.773%; +303.156%]
  • ignore throughput [+10.798op/s; +13.133op/s] or [+1.424%; +1.731%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+395.664ms; +398.567ms] or [+350.148%; +352.717%]
  • ignore throughput [+2.222op/s; +5.758op/s] or [+0.314%; +0.813%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • 🟥 allocated_mem [+1.308KB; +1.308KB] or [+27.529%; +27.541%]
  • ignore execution_time [+69.810µs; +733.138µs] or [+0.035%; +0.366%]
  • ignore throughput [-5291.027op/s; -4720.661op/s] or [-4.117%; -3.673%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+9.977%; +9.987%]
  • 🟩 execution_time [-16.330ms; -12.130ms] or [-7.627%; -5.665%]
  • ignore throughput [+5996.812op/s; +8801.503op/s] or [+4.377%; +6.425%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+27.502%; +27.510%]
  • ignore execution_time [-12.377ms; -8.202ms] or [-5.894%; -3.906%]
  • ignore throughput [-1397.577op/s; +900.302op/s] or [-1.264%; +0.814%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • 🟥 allocated_mem [+1.307KB; +1.307KB] or [+105.746%; +105.759%]
  • ignore execution_time [-631.656µs; -20.635µs] or [-0.315%; -0.010%]
  • 🟥 throughput [-249592.397op/s; -246076.672op/s] or [-25.485%; -25.126%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 allocated_mem [+471 bytes; +472 bytes] or [+38.558%; +38.566%]
  • 🟩 execution_time [-26.379ms; -19.733ms] or [-11.764%; -8.800%]
  • ignore throughput [-58685.982op/s; -32476.074op/s] or [-6.270%; -3.469%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 allocated_mem [+1.272KB; +1.272KB] or [+105.292%; +105.304%]
  • ignore execution_time [-3.930ms; +0.385ms] or [-1.962%; +0.192%]
  • 🟥 throughput [-139114.673op/s; -122951.479op/s] or [-19.988%; -17.666%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [-1142.760µs; -125.359µs] or [-0.570%; -0.062%]
  • ignore throughput [-1368.744op/s; -158.540op/s] or [-0.921%; -0.107%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • ignore execution_time [-1993.718µs; +1538.155µs] or [-1.006%; +0.776%]
  • 🟩 throughput [+11400.281op/s; +14400.063op/s] or [+7.254%; +9.163%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+2.010ms; +6.030ms] or [+1.025%; +3.074%]
  • 🟩 throughput [+7054.303op/s; +9774.625op/s] or [+5.620%; +7.787%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • ignore execution_time [-335.079µs; -108.812µs] or [-0.167%; -0.054%]
  • ignore throughput [+55724.904op/s; +66609.414op/s] or [+1.695%; +2.026%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.008%]
  • ignore execution_time [-4551.641µs; +5364.633µs] or [-2.250%; +2.652%]
  • 🟩 throughput [+457634.267op/s; +535775.326op/s] or [+15.259%; +17.865%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • 🟩 execution_time [-19.213ms; -14.800ms] or [-8.857%; -6.822%]
  • 🟩 throughput [+216575.012op/s; +270707.922op/s] or [+8.596%; +10.745%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • ignore allocated_mem [+1 bytes; +4 bytes] or [+0.004%; +0.012%]
  • 🟥 execution_time [+299.804ms; +300.385ms] or [+149.802%; +150.092%]
  • ignore throughput [+172.342op/s; +188.262op/s] or [+1.903%; +2.079%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+301.166ms; +304.517ms] or [+151.879%; +153.569%]
  • ignore throughput [+266.524op/s; +481.606op/s] or [+2.039%; +3.684%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+300.022ms; +302.670ms] or [+151.128%; +152.462%]
  • ignore throughput [+40.536op/s; +177.826op/s] or [+0.391%; +1.717%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • ignore allocated_mem [+4 bytes; +5 bytes] or [+0.230%; +0.243%]
  • 🟥 execution_time [+296.733ms; +297.395ms] or [+145.743%; +146.068%]
  • ignore throughput [-10.874op/s; -4.071op/s] or [-0.288%; -0.108%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+297.345ms; +299.857ms] or [+145.361%; +146.589%]
  • ignore throughput [+61.706op/s; +129.218op/s] or [+0.896%; +1.877%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+301.725ms; +303.623ms] or [+150.802%; +151.751%]
  • ignore throughput [+65.539op/s; +87.700op/s] or [+1.301%; +1.741%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+6.849µs; +11.929µs] or [+1.406%; +2.449%]
  • ignore throughput [-47.887op/s; -28.168op/s] or [-2.332%; -1.372%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.010%]
  • ignore execution_time [+17.745µs; +44.458µs] or [+4.070%; +10.197%]
  • ignore throughput [-218.821op/s; -98.630op/s] or [-9.513%; -4.288%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [+7.208µs; +29.200µs] or [+1.544%; +6.256%]
  • ignore throughput [-144.347op/s; -63.449op/s] or [-6.663%; -2.929%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-3.458µs; +0.926µs] or [-0.934%; +0.250%]
  • ignore throughput [-5.543op/s; +25.701op/s] or [-0.205%; +0.952%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • 🟥 execution_time [+24.329µs; +47.954µs] or [+7.767%; +15.309%]
  • 🟥 throughput [-444.277op/s; -245.507op/s] or [-13.849%; -7.653%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [-12.749µs; +9.651µs] or [-3.488%; +2.640%]
  • ignore throughput [-105.675op/s; +28.082op/s] or [-3.792%; +1.008%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.772ms; +300.412ms] or [+149.617%; +149.937%]
  • ignore throughput [+3553127.675op/s; +4121738.281op/s] or [+1.780%; +2.065%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • ignore allocated_mem [+122 bytes; +124 bytes] or [+0.682%; +0.693%]
  • unstable execution_time [+360.139ms; +398.898ms] or [+391.306%; +433.419%]
  • 🟩 throughput [+1347.645op/s; +1494.893op/s] or [+11.074%; +12.284%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • ignore allocated_mem [+20 bytes; +22 bytes] or [+0.099%; +0.110%]
  • unstable execution_time [+286.492ms; +326.554ms] or [+217.531%; +247.949%]
  • 🟩 throughput [+644.950op/s; +845.548op/s] or [+6.244%; +8.185%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [+2.756KB; +2.760KB] or [+4.896%; +4.904%]
  • unstable execution_time [+324.371ms; +390.439ms] or [+149.143%; +179.520%]
  • 🟥 throughput [-483.554op/s; -431.883op/s] or [-43.815%; -39.133%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [-1.270KB; -1.268KB] or [-2.995%; -2.990%]
  • unstable execution_time [+204.730ms; +337.936ms] or [+87.247%; +144.014%]
  • 🟥 throughput [-753.581op/s; -670.106op/s] or [-50.264%; -44.696%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+198 bytes; +201 bytes] or [+0.468%; +0.475%]
  • 🟥 execution_time [+331.219ms; +338.643ms] or [+198.107%; +202.548%]
  • 🟥 throughput [-410.913op/s; -375.714op/s] or [-28.611%; -26.160%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-61.558µs; -41.673µs] or [-3.098%; -2.097%]
  • ignore throughput [+11.129op/s; +16.380op/s] or [+2.211%; +3.255%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-55.554µs; -35.847µs] or [-3.816%; -2.463%]
  • ignore throughput [+18.360op/s; +27.748op/s] or [+2.673%; +4.039%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-103.466µs; -89.304µs] or [-3.599%; -3.107%]
  • ignore throughput [+11.227op/s; +13.025op/s] or [+3.227%; +3.744%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-12.864µs; -8.544µs] or [-1.111%; -0.738%]
  • ignore throughput [+6.465op/s; +9.722op/s] or [+0.749%; +1.126%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-61.142µs; -43.009µs] or [-5.671%; -3.989%]
  • ignore throughput [+39.338op/s; +58.984op/s] or [+4.242%; +6.360%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-35.508µs; +60.277µs] or [-1.902%; +3.229%]
  • unstable throughput [-13.734op/s; +44.886op/s] or [-2.564%; +8.378%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

  • ignore allocated_mem [-43 bytes; +21 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+17.359µs; +34.312µs] or [+0.678%; +1.340%]
  • ignore throughput [-5.062op/s; -2.538op/s] or [-1.296%; -0.650%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • ignore allocated_mem [-38 bytes; +46 bytes] or [-0.006%; +0.007%]
  • 🟩 execution_time [-162.874µs; -128.579µs] or [-8.251%; -6.513%]
  • 🟩 throughput [+36.966op/s; +45.934op/s] or [+7.297%; +9.068%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • ignore allocated_mem [-42 bytes; +23 bytes] or [-0.007%; +0.004%]
  • ignore execution_time [-137.424µs; -98.990µs] or [-3.485%; -2.510%]
  • ignore throughput [+6.751op/s; +9.240op/s] or [+2.662%; +3.643%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • 🟥 execution_time [+301.322ms; +302.631ms] or [+151.740%; +152.399%]
  • ignore throughput [+11180.791op/s; +12783.688op/s] or [+3.598%; +4.113%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+300.781ms; +302.120ms] or [+150.722%; +151.393%]
  • ignore throughput [+15505.946op/s; +22446.633op/s] or [+2.445%; +3.539%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+301.831ms; +304.818ms] or [+151.627%; +153.128%]
  • ignore throughput [+9854.155op/s; +17474.032op/s] or [+2.076%; +3.681%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • 🟥 execution_time [+301.499ms; +302.578ms] or [+151.403%; +151.945%]
  • ignore throughput [+13832.010op/s; +15320.450op/s] or [+4.634%; +5.133%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.006%]
  • 🟥 execution_time [+298.739ms; +300.493ms] or [+147.713%; +148.580%]
  • ignore throughput [+23985.404op/s; +30432.980op/s] or [+3.865%; +4.903%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+303.754ms; +307.243ms] or [+153.956%; +155.724%]
  • ignore throughput [+1845.801op/s; +10154.111op/s] or [+0.399%; +2.193%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • ignore allocated_mem [+0 bytes; +1 bytes] or [+0.108%; +0.119%]
  • 🟥 execution_time [+298.816ms; +300.876ms] or [+149.979%; +151.013%]
  • ignore throughput [+444.860op/s; +3201.799op/s] or [+0.115%; +0.831%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+298.872ms; +301.169ms] or [+148.960%; +150.105%]
  • 🟩 throughput [+53008.645op/s; +57038.365op/s] or [+10.526%; +11.326%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+300.896ms; +303.833ms] or [+149.693%; +151.154%]
  • ignore throughput [-23629.232op/s; -17670.284op/s] or [-5.593%; -4.183%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [-314.979µs; +657.667µs] or [-0.157%; +0.327%]
  • ignore throughput [-7213.592op/s; -5816.873op/s] or [-2.901%; -2.339%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.003%]
  • 🟩 execution_time [-16.147ms; -12.469ms] or [-7.508%; -5.798%]
  • ignore throughput [+15053.098op/s; +21717.171op/s] or [+4.129%; +5.958%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.008%]
  • ignore execution_time [-0.359ms; +3.579ms] or [-0.180%; +1.796%]
  • ignore throughput [+3146.803op/s; +9023.620op/s] or [+1.149%; +3.294%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • ignore allocated_mem [-4.459KB; -4.431KB] or [-1.623%; -1.613%]
  • ignore execution_time [+8.890µs; +49.327µs] or [+2.196%; +12.184%]
  • ignore throughput [-259.294op/s; -55.396op/s] or [-10.434%; -2.229%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-25.855KB; -25.834KB] or [-9.431%; -9.424%]
  • unstable execution_time [-45.344µs; +6.932µs] or [-8.962%; +1.370%]
  • ignore throughput [-16.030op/s; +167.795op/s] or [-0.800%; +8.373%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-16.460KB; -16.443KB] or [-6.000%; -5.994%]
  • ignore execution_time [-48.778µs; +8.171µs] or [-8.453%; +1.416%]
  • ignore throughput [-11.275op/s; +143.756op/s] or [-0.644%; +8.213%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472

  • ignore allocated_mem [-2 bytes; +2 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [+0.517µs; +1.916µs] or [+0.896%; +3.318%]
  • ignore throughput [-546.591op/s; -152.660op/s] or [-3.154%; -0.881%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • ignore allocated_mem [-4 bytes; +0 bytes] or [-0.010%; -0.001%]
  • unstable execution_time [+7.449µs; +11.970µs] or [+17.607%; +28.293%]
  • 🟥 throughput [-5136.210op/s; -3301.301op/s] or [-21.622%; -13.897%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +1 bytes] or [-0.002%; +0.002%]
  • unstable execution_time [-14.984µs; -8.142µs] or [-23.247%; -12.632%]
  • 🟩 throughput [+2067.709op/s; +3486.475op/s] or [+12.686%; +21.391%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • ignore allocated_mem [+2 bytes; +3 bytes] or [+0.061%; +0.072%]
  • 🟥 execution_time [+302.900ms; +305.774ms] or [+153.102%; +154.555%]
  • ignore throughput [-173.022op/s; -134.246op/s] or [-2.891%; -2.243%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [-1 bytes; +0 bytes] or [-0.027%; -0.017%]
  • 🟥 execution_time [+302.488ms; +305.691ms] or [+153.966%; +155.596%]
  • ignore throughput [-131.055op/s; -48.272op/s] or [-1.625%; -0.599%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • 🟥 execution_time [+300.992ms; +303.603ms] or [+150.684%; +151.991%]
  • ignore throughput [-213.101op/s; -142.584op/s] or [-2.715%; -1.816%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [+247.996µs; +1284.913µs] or [+0.124%; +0.641%]
  • ignore throughput [+527.428op/s; +2602.549op/s] or [+0.146%; +0.720%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.007%]
  • ignore execution_time [+124.592µs; +966.760µs] or [+0.062%; +0.483%]
  • 🟩 throughput [+38979.538op/s; +44667.258op/s] or [+7.378%; +8.455%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.006%]
  • ignore execution_time [+1.391ms; +5.024ms] or [+0.705%; +2.547%]
  • ignore throughput [+1295.669op/s; +9654.170op/s] or [+0.307%; +2.285%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • 🟥 execution_time [+298.907ms; +300.538ms] or [+148.978%; +149.791%]
  • ignore throughput [-2672.237op/s; -1634.050op/s] or [-1.765%; -1.079%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+0.000%; +0.009%]
  • 🟥 execution_time [+302.371ms; +303.793ms] or [+151.836%; +152.550%]
  • ignore throughput [+5466.376op/s; +6926.537op/s] or [+2.377%; +3.012%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • 🟥 execution_time [+302.573ms; +304.673ms] or [+153.445%; +154.511%]
  • ignore throughput [+672.642op/s; +2605.119op/s] or [+0.379%; +1.467%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+300.063ms; +300.697ms] or [+149.673%; +149.989%]
  • 🟩 throughput [+65941621.185op/s; +66210914.837op/s] or [+48.023%; +48.219%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • ignore allocated_mem [+53 bytes; +55 bytes] or [+0.313%; +0.323%]
  • unstable execution_time [+337.621ms; +379.522ms] or [+419.892%; +472.003%]
  • 🟩 throughput [+1033.440op/s; +1206.466op/s] or [+7.989%; +9.327%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.685ms; +300.646ms] or [+149.476%; +149.955%]
  • 🟩 throughput [+18173581.440op/s; +19116080.951op/s] or [+8.050%; +8.467%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [+0.981ms; +2.343ms] or [+0.491%; +1.172%]
  • ignore throughput [-5507.269op/s; +203.226op/s] or [-0.615%; +0.023%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-4.582ms; -3.438ms] or [-2.244%; -1.684%]
  • 🟩 throughput [+88840.776op/s; +95419.708op/s] or [+8.295%; +8.909%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [+0.368ms; +4.467ms] or [+0.186%; +2.261%]
  • 🟩 throughput [+43304.912op/s; +63549.519op/s] or [+5.012%; +7.356%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.009%]
  • ignore execution_time [+309.921µs; +797.040µs] or [+0.155%; +0.398%]
  • ignore throughput [-2271.899op/s; +3383.290op/s] or [-0.208%; +0.310%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • ignore execution_time [+5.490ms; +9.604ms] or [+2.860%; +5.004%]
  • 🟩 throughput [+75595.544op/s; +105878.539op/s] or [+5.851%; +8.195%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • ignore execution_time [-3.638ms; -1.994ms] or [-1.787%; -0.980%]
  • 🟩 throughput [+69515.860op/s; +79337.787op/s] or [+6.904%; +7.880%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.002%]
  • ignore execution_time [-1.809ms; -0.375ms] or [-0.900%; -0.187%]
  • ignore throughput [+3319.191op/s; +6554.502op/s] or [+0.740%; +1.460%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • ignore execution_time [-867.095µs; +593.697µs] or [-0.433%; +0.296%]
  • 🟩 throughput [+60403.457op/s; +64835.860op/s] or [+10.968%; +11.773%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • ignore execution_time [-0.540ms; +3.557ms] or [-0.271%; +1.787%]
  • ignore throughput [+19906.415op/s; +29691.104op/s] or [+4.456%; +6.646%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-1399.651µs; -380.911µs] or [-0.698%; -0.190%]
  • ignore throughput [-20123.102op/s; -16733.035op/s] or [-2.945%; -2.449%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-1178.898µs; +2323.854µs] or [-0.590%; +1.162%]
  • 🟩 throughput [+82299.795op/s; +99242.844op/s] or [+9.195%; +11.088%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [+1.102ms; +4.992ms] or [+0.560%; +2.536%]
  • ignore throughput [+21613.314op/s; +36572.520op/s] or [+3.018%; +5.106%]

lucaspimentel
lucaspimentel reviewed Apr 13, 2026
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Agent/StatsAggregator.cs Outdated
lucaspimentel
lucaspimentel reviewed Apr 13, 2026
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Agent/StatsAggregator.cs
else
{
Interlocked.Exchange(ref _peerTagKeys, config.PeerTags);
Log.Warning("Stats computation disabled because the detected agent does not support this feature.");

@lucaspimentel lucaspimentel Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost certainly going to need an override for this when using the Rust agents, but that's a separate issue...

@andrewlock andrewlock Apr 14, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that whole question of how we identify the rust agent is a whole open question...

lucaspimentel
lucaspimentel reviewed Apr 13, 2026
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Agent/DiscoveryService/DiscoveryService.cs
var spanMetaStructs = jObject["span_meta_structs"]?.Value<bool>() ?? false;
var spanEvents = jObject["span_events"]?.Value<bool>() ?? false;
var peerTags = (jObject["peer_tags"] as JArray)?.Values<string>().Where(x => !string.IsNullOrEmpty(x)).Distinct().OrderBy(x => x).ToList();
var peerTags = (jObject["peer_tags"] as JArray)?.Values<string>().ToList();

@lucaspimentel lucaspimentel Apr 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:tears-of-joy:

@andrewlock
andrewlock force-pushed the andrew/client-side-stats/peer-tag-improvements branch from 58d4473 to 9daade0 Compare April 14, 2026 10:08
@andrewlock
andrewlock requested review from a team as code owners April 14, 2026 10:08
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/fnvhash branch from e94c3c9 to 9b41576 Compare April 14, 2026 10:08
zacharycmontoya
zacharycmontoya approved these changes Apr 15, 2026
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewlock andrewlock mentioned this pull request Apr 16, 2026
Merged
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/peer-tag-improvements branch from 9daade0 to 7817c48 Compare April 16, 2026 07:59
@andrewlock
andrewlock requested review from a team as code owners April 16, 2026 07:59
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/fnvhash branch from 9b41576 to 25dabec Compare April 16, 2026 07:59
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/fnvhash branch from 25dabec to 00ff8c1 Compare April 21, 2026 06:02
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/peer-tag-improvements branch from 7817c48 to 105b79a Compare April 21, 2026 06:02
@andrewlock
andrewlock changed the base branch from andrew/client-side-stats/fnvhash to master April 21, 2026 06:02
@andrewlock
andrewlock enabled auto-merge (squash) April 21, 2026 06:03
@andrewlock
andrewlock force-pushed the andrew/client-side-stats/peer-tag-improvements branch from 105b79a to 4ee6bae Compare April 21, 2026 06:04
@andrewlock
andrewlock merged commit 269954c into master Apr 21, 2026
139 checks passed
@andrewlock
andrewlock deleted the andrew/client-side-stats/peer-tag-improvements branch April 21, 2026 07:59
@github-actions github-actions Bot added this to the vNext-v3 milestone Apr 21, 2026
This was referenced Apr 21, 2026
Closed
Merged
andrewlock added a commit that referenced this pull request Apr 23, 2026
@andrewlock
Remove agent check in client-side-stats (#8503)
7c74848 
## Summary of changes

Removes the minimum-agent version check from the client-side-stats check

## Reason for change

We didn't have it before, which means people who previously had stats,
suddenly won't have them. Also other agents (like bottlecap etc) don't
have the version. And we haven't figured out how to handle that yet.
While CSS is off by default, this seems like the best option to take.

## Implementation details

Remove the code that is checking for CSS support.

## Test coverage

Covered by existing (and removed a test for the behaviour)

## Other details

Follows on from 
- #8417
- #8418
- #8420
- #8435
- #8436
- #8444
- #8445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

No one assigned

Labels

area:client-side-stats area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:performance Performance, speed, latency, resource usage (CPU, memory)

Projects

None yet

Milestone

3.43.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @zacharycmontoya