Skip to content

Set resource name after exception in OnEndRequest method#8439

Merged
NachoEchevarria merged 7 commits into
masterfrom
fix/aspnet-resource-name-on-incomplete-request
Apr 16, 2026
Merged

Set resource name after exception in OnEndRequest method#8439
NachoEchevarria merged 7 commits into
masterfrom
fix/aspnet-resource-name-on-incomplete-request

Conversation

@anna-git

@anna-git anna-git commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

When no resource-based sampling rules are configured, the resource name was only set in OnEndRequest. If OnEndRequest doesn't complete (e.g., client disconnect), the resource name remained null and defaulted to the operation name aspnet.request in Span.Finish(). This fix ensures the resource name is always set early in OnBeginRequest. Fixes APMS-19184

Made-with: Cursor

Summary of changes

Reason for change

https://datadoghq.atlassian.net/browse/APMS-19184

Implementation details

Test coverage

Other details

@anna-git anna-git added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Apr 10, 2026
@github-actions github-actions Bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Apr 10, 2026
@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8439) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration70.89 ± (70.89 - 71.19) ms71.31 ± (71.44 - 71.91) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration75.97 ± (75.83 - 76.24) ms75.86 ± (75.83 - 76.17) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1057.73 ± (1058.79 - 1064.77) ms1060.03 ± (1058.91 - 1064.72) ms+0.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.30 ± (22.26 - 22.33) ms22.16 ± (22.13 - 22.19) ms-0.6%✅
process.time_to_main_ms83.51 ± (83.30 - 83.71) ms82.91 ± (82.71 - 83.12) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.93) MB10.89 ± (10.89 - 10.90) MB-0.3%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.33 ± (22.29 - 22.37) ms22.32 ± (22.27 - 22.36) ms-0.1%✅
process.time_to_main_ms85.37 ± (85.15 - 85.59) ms85.40 ± (85.18 - 85.61) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.93 ± (10.92 - 10.93) MB-0.2%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms228.23 ± (226.93 - 229.53) ms224.85 ± (223.73 - 225.97) ms-1.5%✅
process.time_to_main_ms520.02 ± (518.74 - 521.29) ms521.18 ± (520.02 - 522.34) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.47 ± (48.43 - 48.50) MB48.40 ± (48.37 - 48.42) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.00 ± (20.96 - 21.03) ms21.09 ± (21.06 - 21.13) ms+0.4%✅⬆️
process.time_to_main_ms72.47 ± (72.32 - 72.62) ms72.49 ± (72.32 - 72.66) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.59 ± (10.59 - 10.60) MB10.62 ± (10.61 - 10.62) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.88 ± (20.85 - 20.92) ms21.07 ± (21.04 - 21.11) ms+0.9%✅⬆️
process.time_to_main_ms73.03 ± (72.86 - 73.20) ms73.85 ± (73.68 - 74.02) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.71 ± (10.70 - 10.71) MB10.72 ± (10.72 - 10.72) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms382.96 ± (380.32 - 385.60) ms388.54 ± (386.38 - 390.70) ms+1.5%✅⬆️
process.time_to_main_ms519.27 ± (518.28 - 520.26) ms518.73 ± (517.76 - 519.69) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.02 ± (49.99 - 50.04) MB49.98 ± (49.96 - 50.01) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms19.30 ± (19.25 - 19.34) ms19.18 ± (19.15 - 19.21) ms-0.6%✅
process.time_to_main_ms71.33 ± (71.13 - 71.53) ms71.58 ± (71.42 - 71.75) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.65 ± (7.64 - 7.66) MB-0.3%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.28 ± (19.25 - 19.31) ms19.24 ± (19.21 - 19.27) ms-0.2%✅
process.time_to_main_ms72.59 ± (72.42 - 72.76) ms72.96 ± (72.80 - 73.12) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.72) MB7.69 ± (7.69 - 7.70) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms308.38 ± (305.68 - 311.07) ms304.50 ± (302.20 - 306.81) ms-1.3%✅
process.time_to_main_ms480.19 ± (479.41 - 480.98) ms479.81 ± (479.07 - 480.54) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed37.09 ± (37.07 - 37.11) MB37.05 ± (37.03 - 37.08) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.4%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration205.88 ± (205.69 - 206.64) ms207.88 ± (207.71 - 208.61) ms+1.0%✅⬆️
.NET Framework 4.8 - Bailout
duration209.45 ± (209.20 - 209.82) ms210.23 ± (210.02 - 210.72) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1205.92 ± (1204.43 - 1210.16) ms1212.26 ± (1211.38 - 1220.82) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms200.48 ± (200.06 - 200.89) ms199.40 ± (199.02 - 199.77) ms-0.5%✅
process.time_to_main_ms87.38 ± (87.10 - 87.65) ms87.35 ± (87.00 - 87.69) ms-0.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.04 ± (16.02 - 16.06) MB15.98 ± (15.96 - 16.00) MB-0.4%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms201.23 ± (200.81 - 201.65) ms199.82 ± (199.42 - 200.21) ms-0.7%✅
process.time_to_main_ms89.20 ± (88.98 - 89.41) ms88.36 ± (88.09 - 88.62) ms-0.9%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed15.96 ± (15.93 - 15.98) MB15.94 ± (15.92 - 15.96) MB-0.1%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.3%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms414.12 ± (413.03 - 415.20) ms409.56 ± (408.33 - 410.79) ms-1.1%✅
process.time_to_main_ms544.49 ± (542.86 - 546.12) ms532.34 ± (531.37 - 533.32) ms-2.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed59.36 ± (59.32 - 59.40) MB59.21 ± (59.17 - 59.25) MB-0.2%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms206.31 ± (205.93 - 206.69) ms204.79 ± (204.30 - 205.28) ms-0.7%✅
process.time_to_main_ms76.22 ± (75.96 - 76.48) ms75.34 ± (75.10 - 75.58) ms-1.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.23 ± (16.20 - 16.25) MB16.26 ± (16.24 - 16.28) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)19 ± (19 - 19)-1.0%✅
.NET 6 - Bailout
process.internal_duration_ms206.20 ± (205.87 - 206.54) ms203.85 ± (203.44 - 204.26) ms-1.1%✅
process.time_to_main_ms77.72 ± (77.48 - 77.96) ms76.14 ± (75.91 - 76.37) ms-2.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.24 ± (16.21 - 16.26) MB16.33 ± (16.31 - 16.36) MB+0.6%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.3%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms595.92 ± (593.29 - 598.54) ms603.24 ± (600.32 - 606.16) ms+1.2%✅⬆️
process.time_to_main_ms539.98 ± (538.87 - 541.09) ms535.40 ± (534.44 - 536.37) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed61.52 ± (61.41 - 61.63) MB61.74 ± (61.65 - 61.83) MB+0.4%✅⬆️
runtime.dotnet.threads.count31 ± (31 - 31)31 ± (31 - 31)-0.3%✅
.NET 8 - Baseline
process.internal_duration_ms203.23 ± (202.75 - 203.70) ms202.45 ± (202.08 - 202.82) ms-0.4%✅
process.time_to_main_ms75.43 ± (75.17 - 75.69) ms74.58 ± (74.32 - 74.83) ms-1.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.62 ± (11.60 - 11.64) MB11.68 ± (11.67 - 11.70) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms203.09 ± (202.69 - 203.49) ms202.41 ± (201.92 - 202.90) ms-0.3%✅
process.time_to_main_ms76.37 ± (76.13 - 76.60) ms76.22 ± (76.02 - 76.42) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.68 ± (11.66 - 11.70) MB11.69 ± (11.67 - 11.71) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.1%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms525.68 ± (520.62 - 530.73) ms520.04 ± (516.16 - 523.92) ms-1.1%✅
process.time_to_main_ms501.21 ± (500.34 - 502.09) ms498.87 ± (497.98 - 499.75) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.70 ± (50.64 - 50.75) MB50.59 ± (50.55 - 50.63) MB-0.2%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.2%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (72ms)  : 68, 75
    master - mean (71ms)  : 69, 73

    section Bailout
    This PR (8439) - mean (76ms)  : 74, 78
    master - mean (76ms)  : 73, 79

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (1,062ms)  : 1021, 1103
    master - mean (1,062ms)  : 1019, 1105
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (112ms)  : 108, 115
    master - mean (112ms)  : 109, 116

    section Bailout
    This PR (8439) - mean (114ms)  : 111, 118
    master - mean (114ms)  : 112, 117

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (784ms)  : 763, 804
    master - mean (784ms)  : 761, 807
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (100ms)  : 96, 103
    master - mean (100ms)  : 96, 103

    section Bailout
    This PR (8439) - mean (101ms)  : 98, 105
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (937ms)  : 906, 969
    master - mean (930ms)  : 890, 971
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (98ms)  : 95, 102
    master - mean (98ms)  : 94, 102

    section Bailout
    This PR (8439) - mean (100ms)  : 96, 103
    master - mean (99ms)  : 96, 103

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (815ms)  : 777, 853
    master - mean (819ms)  : 780, 859
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (208ms)  : 203, 214
    master - mean (206ms)  : 201, 211

    section Bailout
    This PR (8439) - mean (210ms)  : 207, 214
    master - mean (210ms)  : 206, 213

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (1,216ms)  : 1159, 1273
    master - mean (1,207ms)  : 1169, 1246
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (296ms)  : 289, 303
    master - mean (297ms)  : 289, 305

    section Bailout
    This PR (8439) - mean (297ms)  : 290, 304
    master - mean (299ms)  : 293, 306

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (976ms)  : 945, 1006
    master - mean (1,002ms)  : 964, 1040
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (289ms)  : 282, 296
    master - mean (292ms)  : 286, 297

    section Bailout
    This PR (8439) - mean (289ms)  : 283, 295
    master - mean (293ms)  : 288, 297

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (1,169ms)  : 1133, 1204
    master - mean (1,167ms)  : 1124, 1210
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8439) - mean (288ms)  : 282, 295
    master - mean (289ms)  : 283, 296

    section Bailout
    This PR (8439) - mean (289ms)  : 283, 295
    master - mean (290ms)  : 284, 296

    section CallTarget+Inlining+NGEN
    This PR (8439) - mean (1,053ms)  : 994, 1113
    master - mean (1,067ms)  : 971, 1162
Loading

@pr-commenter

pr-commenter Bot commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-04-15 11:22:05

Comparing candidate commit c5672d7 in PR branch fix/aspnet-resource-name-on-incomplete-request with baseline commit 6963bde in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.005%]
  • ignore execution_time [-1.758ms; -0.802ms] or [-0.873%; -0.398%]
  • ignore throughput [-682.101op/s; -284.993op/s] or [-0.809%; -0.338%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-1626.524µs; +1876.819µs] or [-0.811%; +0.936%]
  • 🟩 throughput [+8465.894op/s; +10629.842op/s] or [+7.116%; +8.935%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • ignore execution_time [-15.498ms; -2.316ms] or [-7.795%; -1.165%]
  • ignore throughput [-869.594op/s; +437.846op/s] or [-0.884%; +0.445%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [-20 bytes; -19 bytes] or [-0.613%; -0.600%]
  • 🟥 execution_time [+310.762ms; +312.620ms] or [+154.211%; +155.133%]
  • ignore throughput [+3.504op/s; +7.291op/s] or [+0.630%; +1.312%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.009%; +0.002%]
  • 🟥 execution_time [+385.451ms; +387.278ms] or [+304.530%; +305.973%]
  • ignore throughput [+17.033op/s; +19.450op/s] or [+2.246%; +2.564%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+1 bytes; +2 bytes] or [+0.065%; +0.075%]
  • 🟥 execution_time [+398.442ms; +401.431ms] or [+352.606%; +355.251%]
  • ignore throughput [+1.847op/s; +4.575op/s] or [+0.261%; +0.646%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.005%]
  • ignore execution_time [-357.567µs; +191.683µs] or [-0.179%; +0.096%]
  • ignore throughput [+3269.744op/s; +3662.292op/s] or [+2.544%; +2.849%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.005%]
  • 🟩 execution_time [-16.458ms; -12.287ms] or [-7.686%; -5.738%]
  • 🟩 throughput [+8573.372op/s; +11353.760op/s] or [+6.258%; +8.288%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.002%]
  • ignore execution_time [-13.481ms; -9.350ms] or [-6.420%; -4.452%]
  • 🟩 throughput [+8049.018op/s; +10331.397op/s] or [+7.277%; +9.341%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.002%; +0.008%]
  • ignore execution_time [-881.263µs; -112.926µs] or [-0.439%; -0.056%]
  • ignore throughput [+6907.997op/s; +11170.420op/s] or [+0.705%; +1.141%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.002%; +0.005%]
  • 🟩 execution_time [-26.348ms; -21.490ms] or [-11.750%; -9.584%]
  • 🟩 throughput [+107607.847op/s; +130366.491op/s] or [+11.496%; +13.927%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • ignore execution_time [-3.470ms; +0.864ms] or [-1.732%; +0.431%]
  • 🟩 throughput [+107638.779op/s; +124337.591op/s] or [+15.466%; +17.865%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [-1154.210µs; -121.664µs] or [-0.575%; -0.061%]
  • ignore throughput [+629.873op/s; +1400.029op/s] or [+0.424%; +0.942%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • ignore execution_time [-1853.642µs; +1668.209µs] or [-0.935%; +0.842%]
  • 🟩 throughput [+10908.553op/s; +13853.943op/s] or [+6.941%; +8.815%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+2.401ms; +6.415ms] or [+1.224%; +3.271%]
  • 🟩 throughput [+6961.177op/s; +9634.173op/s] or [+5.545%; +7.675%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • ignore execution_time [-304.103µs; -103.738µs] or [-0.152%; -0.052%]
  • ignore throughput [-3611.291op/s; +4858.579op/s] or [-0.110%; +0.148%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.008%]
  • ignore execution_time [-3.010ms; -2.069ms] or [-1.488%; -1.023%]
  • 🟩 throughput [+361037.296op/s; +375413.506op/s] or [+12.039%; +12.518%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • 🟩 execution_time [-19.559ms; -15.200ms] or [-9.016%; -7.007%]
  • 🟩 throughput [+221996.807op/s; +275845.612op/s] or [+8.812%; +10.949%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net472

  • ignore allocated_mem [+1 bytes; +4 bytes] or [+0.004%; +0.012%]
  • 🟥 execution_time [+299.667ms; +300.212ms] or [+149.733%; +150.006%]
  • ignore throughput [+64.258op/s; +116.396op/s] or [+0.710%; +1.286%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs net6.0

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+298.863ms; +302.260ms] or [+150.717%; +152.430%]
  • ignore throughput [+329.505op/s; +541.560op/s] or [+2.520%; +4.142%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeArgs netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +2 bytes] or [-0.004%; +0.008%]
  • 🟥 execution_time [+299.551ms; +302.378ms] or [+150.890%; +152.314%]
  • ignore throughput [+135.789op/s; +265.950op/s] or [+1.311%; +2.568%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • ignore allocated_mem [+3 bytes; +4 bytes] or [+0.186%; +0.199%]
  • 🟥 execution_time [+298.135ms; +298.918ms] or [+146.432%; +146.817%]
  • ignore throughput [-10.762op/s; -0.681op/s] or [-0.285%; -0.018%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+299.888ms; +301.778ms] or [+146.604%; +147.528%]
  • ignore throughput [+22.587op/s; +59.850op/s] or [+0.328%; +0.870%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • 🟥 execution_time [+300.024ms; +302.108ms] or [+149.951%; +150.993%]
  • ignore throughput [+24.677op/s; +46.420op/s] or [+0.490%; +0.921%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+2.188µs; +5.862µs] or [+0.449%; +1.204%]
  • ignore throughput [-24.182op/s; -9.010op/s] or [-1.178%; -0.439%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.010%]
  • ignore execution_time [+14.177µs; +41.745µs] or [+3.251%; +9.574%]
  • ignore throughput [-203.226op/s; -81.120op/s] or [-8.835%; -3.527%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [+7.759µs; +29.819µs] or [+1.662%; +6.389%]
  • ignore throughput [-146.821op/s; -65.634op/s] or [-6.778%; -3.030%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-7.624µs; -3.750µs] or [-2.058%; -1.013%]
  • ignore throughput [+28.417op/s; +56.447op/s] or [+1.052%; +2.091%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.007%]
  • 🟥 execution_time [+23.001µs; +46.715µs] or [+7.343%; +14.914%]
  • 🟥 throughput [-433.430op/s; -233.993op/s] or [-13.511%; -7.294%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.003%]
  • ignore execution_time [-16.473µs; +5.879µs] or [-4.506%; +1.608%]
  • ignore throughput [-77.155op/s; +56.169op/s] or [-2.769%; +2.016%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.844ms; +300.453ms] or [+149.653%; +149.957%]
  • ignore throughput [-1261873.493op/s; -702601.612op/s] or [-0.632%; -0.352%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • ignore allocated_mem [+94 bytes; +96 bytes] or [+0.526%; +0.537%]
  • unstable execution_time [+377.110ms; +408.907ms] or [+409.746%; +444.294%]
  • 🟩 throughput [+1192.648op/s; +1338.348op/s] or [+9.800%; +10.997%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • ignore allocated_mem [-3 bytes; +0 bytes] or [-0.015%; -0.004%]
  • unstable execution_time [+262.106ms; +306.266ms] or [+199.014%; +232.545%]
  • 🟩 throughput [+697.081op/s; +900.939op/s] or [+6.748%; +8.722%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • ignore allocated_mem [+2.772KB; +2.777KB] or [+4.925%; +4.933%]
  • unstable execution_time [+339.703ms; +398.820ms] or [+156.192%; +183.373%]
  • 🟥 throughput [-513.581op/s; -458.187op/s] or [-46.535%; -41.516%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • ignore allocated_mem [-1.270KB; -1.268KB] or [-2.995%; -2.990%]
  • unstable execution_time [+184.599ms; +319.919ms] or [+78.668%; +136.336%]
  • 🟥 throughput [-746.346op/s; -662.869op/s] or [-49.781%; -44.214%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • ignore allocated_mem [+230 bytes; +234 bytes] or [+0.545%; +0.553%]
  • 🟥 execution_time [+346.977ms; +354.928ms] or [+207.532%; +212.288%]
  • 🟥 throughput [-430.941op/s; -396.082op/s] or [-30.006%; -27.579%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-49.264µs; -31.154µs] or [-2.479%; -1.568%]
  • ignore throughput [+8.298op/s; +13.029op/s] or [+1.649%; +2.589%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+56.971µs; +83.910µs] or [+3.914%; +5.764%]
  • ignore throughput [-36.248op/s; -24.640op/s] or [-5.276%; -3.587%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-184.424µs; -82.392µs] or [-6.416%; -2.866%]
  • ignore throughput [+11.401op/s; +32.555op/s] or [+3.277%; +9.358%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [-19.887µs; -8.370µs] or [-1.718%; -0.723%]
  • ignore throughput [+7.123op/s; +15.171op/s] or [+0.825%; +1.756%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟩 execution_time [-70.512µs; -55.637µs] or [-6.540%; -5.160%]
  • 🟩 throughput [+50.585op/s; +67.603op/s] or [+5.454%; +7.289%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • ignore execution_time [+7.428µs; +17.907µs] or [+0.398%; +0.959%]
  • ignore throughput [-5.044op/s; -2.072op/s] or [-0.941%; -0.387%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

  • ignore allocated_mem [-43 bytes; +21 bytes] or [-0.007%; +0.003%]
  • ignore execution_time [+58.145µs; +74.842µs] or [+2.271%; +2.923%]
  • ignore throughput [-11.002op/s; -8.584op/s] or [-2.817%; -2.198%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • ignore allocated_mem [-38 bytes; +46 bytes] or [-0.006%; +0.007%]
  • ignore execution_time [-58.583µs; -17.987µs] or [-2.968%; -0.911%]
  • ignore throughput [+6.323op/s; +16.409op/s] or [+1.248%; +3.239%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • ignore allocated_mem [-42 bytes; +23 bytes] or [-0.007%; +0.004%]
  • ignore execution_time [-154.988µs; -123.026µs] or [-3.930%; -3.120%]
  • ignore throughput [+8.341op/s; +10.410op/s] or [+3.289%; +4.105%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • 🟥 execution_time [+302.343ms; +303.678ms] or [+152.254%; +152.926%]
  • ignore throughput [+9965.795op/s; +11628.500op/s] or [+3.207%; +3.742%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+300.300ms; +305.984ms] or [+150.481%; +153.329%]
  • 🟩 throughput [+36310.286op/s; +45336.121op/s] or [+5.725%; +7.148%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+299.586ms; +311.000ms] or [+150.499%; +156.233%]
  • ignore throughput [+10302.632op/s; +21021.118op/s] or [+2.170%; +4.428%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.004%]
  • 🟥 execution_time [+300.920ms; +302.300ms] or [+151.112%; +151.805%]
  • ignore throughput [+13569.184op/s; +15078.965op/s] or [+4.546%; +5.052%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.007%; +0.006%]
  • 🟥 execution_time [+297.668ms; +299.964ms] or [+147.183%; +148.319%]
  • ignore throughput [+19009.262op/s; +25261.411op/s] or [+3.063%; +4.070%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • 🟥 execution_time [+302.996ms; +306.533ms] or [+153.572%; +155.365%]
  • ignore throughput [+12826.248op/s; +20876.625op/s] or [+2.770%; +4.508%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • ignore allocated_mem [+0 bytes; +1 bytes] or [+0.108%; +0.119%]
  • 🟥 execution_time [+301.381ms; +302.640ms] or [+151.266%; +151.898%]
  • ignore throughput [-5325.761op/s; -3366.524op/s] or [-1.382%; -0.873%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+297.736ms; +300.227ms] or [+148.394%; +149.636%]
  • 🟩 throughput [+59872.787op/s; +64955.595op/s] or [+11.889%; +12.898%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.006%]
  • 🟥 execution_time [+298.969ms; +301.447ms] or [+148.735%; +149.967%]
  • ignore throughput [-3386.221op/s; +1779.086op/s] or [-0.802%; +0.421%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [-982.539µs; -62.769µs] or [-0.489%; -0.031%]
  • ignore throughput [-4086.252op/s; -2900.815op/s] or [-1.643%; -1.166%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.003%]
  • 🟩 execution_time [-16.458ms; -12.810ms] or [-7.653%; -5.957%]
  • ignore throughput [+16054.370op/s; +22965.974op/s] or [+4.404%; +6.300%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.008%]
  • ignore execution_time [-986.799µs; +2944.939µs] or [-0.495%; +1.477%]
  • ignore throughput [+7602.723op/s; +13291.276op/s] or [+2.775%; +4.852%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net472

  • ignore allocated_mem [-4.459KB; -4.431KB] or [-1.623%; -1.613%]
  • unstable execution_time [+5.797µs; +47.146µs] or [+1.432%; +11.645%]
  • ignore throughput [-241.960op/s; -34.459op/s] or [-9.737%; -1.387%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟩 allocated_mem [-25.565KB; -25.545KB] or [-9.326%; -9.318%]
  • unstable execution_time [-41.995µs; +10.953µs] or [-8.300%; +2.165%]
  • ignore throughput [-29.870op/s; +154.826op/s] or [-1.491%; +7.726%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • ignore allocated_mem [-1.453KB; -1.435KB] or [-0.530%; -0.523%]
  • unstable execution_time [+72.040µs; +226.945µs] or [+12.484%; +39.328%]
  • unstable throughput [-245.894op/s; -7.615op/s] or [-14.048%; -0.435%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net472

  • ignore allocated_mem [-2 bytes; +2 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-385.360ns; +1144.027ns] or [-0.668%; +1.982%]
  • ignore throughput [-308.912op/s; +123.143op/s] or [-1.783%; +0.711%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • ignore allocated_mem [-4 bytes; +0 bytes] or [-0.010%; -0.001%]
  • 🟥 execution_time [+3.796µs; +7.597µs] or [+8.973%; +17.956%]
  • 🟥 throughput [-3653.590op/s; -1927.051op/s] or [-15.380%; -8.112%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • ignore allocated_mem [-1 bytes; +1 bytes] or [-0.002%; +0.002%]
  • unstable execution_time [-14.864µs; -7.512µs] or [-23.061%; -11.655%]
  • 🟩 throughput [+2067.683op/s; +3619.415op/s] or [+12.686%; +22.206%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • ignore allocated_mem [+2 bytes; +3 bytes] or [+0.061%; +0.072%]
  • 🟥 execution_time [+302.164ms; +303.322ms] or [+152.730%; +153.316%]
  • ignore throughput [-95.104op/s; -74.193op/s] or [-1.589%; -1.240%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • 🟥 execution_time [+302.268ms; +304.592ms] or [+153.854%; +155.036%]
  • ignore throughput [+9.268op/s; +85.020op/s] or [+0.115%; +1.054%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • 🟥 execution_time [+298.255ms; +300.507ms] or [+149.313%; +150.441%]
  • ignore throughput [-61.770op/s; +2.779op/s] or [-0.787%; +0.035%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [-2.027ms; -1.232ms] or [-1.011%; -0.614%]
  • ignore throughput [-15067.544op/s; -13718.575op/s] or [-4.171%; -3.798%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.007%]
  • ignore execution_time [-101.568µs; +525.536µs] or [-0.051%; +0.263%]
  • 🟩 throughput [+34171.259op/s; +37975.071op/s] or [+6.468%; +7.188%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.006%]
  • ignore execution_time [+1.938ms; +5.681ms] or [+0.983%; +2.879%]
  • ignore throughput [-2852.379op/s; +5735.664op/s] or [-0.675%; +1.357%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • 🟥 execution_time [+301.869ms; +303.823ms] or [+150.454%; +151.429%]
  • ignore throughput [+1173.509op/s; +2223.561op/s] or [+0.775%; +1.468%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+0.000%; +0.009%]
  • 🟥 execution_time [+302.354ms; +303.493ms] or [+151.828%; +152.400%]
  • ignore throughput [+967.583op/s; +2923.922op/s] or [+0.421%; +1.272%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.003%]
  • 🟥 execution_time [+302.496ms; +304.777ms] or [+153.407%; +154.563%]
  • ignore throughput [-783.727op/s; +1103.315op/s] or [-0.441%; +0.621%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+300.104ms; +300.753ms] or [+149.693%; +150.017%]
  • 🟩 throughput [+61278399.641op/s; +61510892.278op/s] or [+44.627%; +44.796%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • ignore allocated_mem [+38 bytes; +40 bytes] or [+0.226%; +0.236%]
  • unstable execution_time [+370.389ms; +405.176ms] or [+460.645%; +503.908%]
  • 🟩 throughput [+1029.665op/s; +1207.724op/s] or [+7.960%; +9.336%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [+nan%; +nan%]
  • 🟥 execution_time [+299.425ms; +300.335ms] or [+149.347%; +149.800%]
  • ignore throughput [+1788146.688op/s; +2727955.708op/s] or [+0.792%; +1.208%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-282.430µs; +332.566µs] or [-0.141%; +0.166%]
  • ignore throughput [+20437.087op/s; +23958.026op/s] or [+2.281%; +2.674%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-4.713ms; -3.615ms] or [-2.309%; -1.770%]
  • 🟩 throughput [+74703.219op/s; +82358.857op/s] or [+6.975%; +7.690%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.003%; +0.006%]
  • ignore execution_time [+1.929ms; +6.083ms] or [+0.976%; +3.078%]
  • 🟩 throughput [+43574.330op/s; +62756.027op/s] or [+5.044%; +7.264%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.000%; +0.009%]
  • ignore execution_time [-307.918µs; -22.676µs] or [-0.154%; -0.011%]
  • ignore throughput [+20.504op/s; +7858.397op/s] or [+0.002%; +0.719%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.004%]
  • ignore execution_time [+4.718ms; +8.869ms] or [+2.458%; +4.621%]
  • 🟩 throughput [+65906.467op/s; +95310.674op/s] or [+5.101%; +7.377%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.001%; +0.008%]
  • ignore execution_time [-3.065ms; -1.615ms] or [-1.506%; -0.793%]
  • 🟩 throughput [+86246.657op/s; +95879.676op/s] or [+8.566%; +9.522%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.008%; +0.002%]
  • ignore execution_time [-2.578ms; -1.038ms] or [-1.283%; -0.517%]
  • ignore throughput [-22543.955op/s; -19022.046op/s] or [-5.023%; -4.238%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.004%; +0.009%]
  • ignore execution_time [-1017.259µs; +411.633µs] or [-0.508%; +0.206%]
  • 🟩 throughput [+49395.426op/s; +54306.683op/s] or [+8.969%; +9.861%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.006%; +0.004%]
  • ignore execution_time [+0.610ms; +4.721ms] or [+0.307%; +2.372%]
  • 🟩 throughput [+28066.463op/s; +37590.620op/s] or [+6.282%; +8.414%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.006%]
  • ignore execution_time [-1215.728µs; -323.433µs] or [-0.606%; -0.161%]
  • ignore throughput [-9658.084op/s; -6281.284op/s] or [-1.414%; -0.919%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.007%]
  • ignore execution_time [-1094.837µs; +2395.598µs] or [-0.548%; +1.198%]
  • 🟩 throughput [+77933.670op/s; +95578.695op/s] or [+8.707%; +10.679%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • ignore allocated_mem [+0 bytes; +0 bytes] or [-0.005%; +0.005%]
  • ignore execution_time [+1.731ms; +5.638ms] or [+0.879%; +2.863%]
  • ignore throughput [+19021.993op/s; +33838.540op/s] or [+2.656%; +4.725%]

andrewlock
andrewlock reviewed Apr 13, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can avoid it, I'd really rather we didn't do this, as it increases allocations bunch 🙁 Is there really no way to detect the disconnection? Given that we presumably still close the span (otherwise you wouldn't see them returned), I'm assuming OnEndRequest() still runs? Or is it catching an error in the Exception handler here (and if so, could we move the pre-emptive resource name calculation here instead?)

@NachoEchevarria

NachoEchevarria commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

If we can avoid it, I'd really rather we didn't do this, as it increases allocations bunch 🙁 Is there really no way to detect the disconnection? Given that we presumably still close the span (otherwise you wouldn't see them returned), I'm assuming OnEndRequest() still runs? Or is it catching an error in the Exception handler here (and if so, could we move the pre-emptive resource name calculation here instead?)

Maybe we can move the logic to OnEndRequest by adding a finally block? Something like:

Line 415:
currentSpan.ResourceName = BuildResourceName(tracer, app.Request);
}
}
finally
{
// If an exception prevented the normal resource name logic from running,
// set a fallback resource name before disposing to avoid defaulting to the operation name
if (scope.Span.ResourceName is null)
{
scope.Span.ResourceName = BuildResourceName(tracer, app.Request);
}

@NachoEchevarria @anna-git
fix(aspnet): Set fallback resource name in OnEndRequest finally block
1227ccf 
When no resource-based sampling rules are configured, the resource name
is only set in OnEndRequest. If an exception occurs before the resource
name logic runs (e.g. in security/IAST processing), the resource name
remains null and defaults to the operation name "aspnet.request" in
Span.Finish(). This fix adds a fallback in the OnEndRequest finally
block to set the resource name before scope disposal.

Fixes APMS-19184

Co-authored-by: Anna <[email protected]>
@NachoEchevarria
NachoEchevarria force-pushed the fix/aspnet-resource-name-on-incomplete-request branch from 3a84935 to 1227ccf Compare April 14, 2026 13:35
@NachoEchevarria
NachoEchevarria marked this pull request as ready for review April 14, 2026 14:00
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner April 14, 2026 14:00
andrewlock
andrewlock reviewed Apr 14, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NachoEchevarria, I think this is a good solution, but you may also need to do it on line 266 too?

We also need to make sure this works with "inferred proxy scopes" too - I haven't looked into it to see if that would be affected 🙂

@NachoEchevarria

NachoEchevarria commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks @NachoEchevarria, I think this is a good solution, but you may also need to do it on line 266 too?

We also need to make sure this works with "inferred proxy scopes" too - I haven't looked into it to see if that would be affected 🙂

Good catch! Done!

About proxies, AzureApiManagementSpanFactory and AwsApiGatewaySpanFactory set ResourceName at creation time (lines 41 and 40 respectively). So proxy spans already have their resource name set before they reach
TracingHttpModule.

andrewlock
andrewlock approved these changes Apr 14, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but you have some build errors! Approving assuming that you apply these changes one way or another 🙂

Comment thread tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs Outdated
Comment thread tracer/src/Datadog.Trace/AspNet/TracingHttpModule.cs Outdated
@NachoEchevarria NachoEchevarria changed the title fix(aspnet): Always set resource name in OnBeginRequest Set resource name after exception in OnEndRequest method Apr 16, 2026
@NachoEchevarria
NachoEchevarria merged commit 9863b8b into master Apr 16, 2026
140 checks passed
@NachoEchevarria
NachoEchevarria deleted the fix/aspnet-resource-name-on-incomplete-request branch April 16, 2026 09:45
@github-actions github-actions Bot added this to the vNext-v3 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:reliability

Projects

None yet

Milestone

3.42.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anna-git @NachoEchevarria @andrewlock