Update base image used in download stages#8437
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8437) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (72ms) : 70, 74
master - mean (72ms) : 69, 75
section Bailout
This PR (8437) - mean (76ms) : 74, 78
master - mean (76ms) : 74, 78
section CallTarget+Inlining+NGEN
This PR (8437) - mean (1,064ms) : 1019, 1108
master - mean (1,071ms) : 1008, 1134
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (112ms) : 108, 116
master - mean (112ms) : 109, 115
section Bailout
This PR (8437) - mean (113ms) : 110, 117
master - mean (114ms) : 112, 117
section CallTarget+Inlining+NGEN
This PR (8437) - mean (777ms) : 758, 796
master - mean (776ms) : 756, 796
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (99ms) : 96, 102
master - mean (99ms) : 95, 103
section Bailout
This PR (8437) - mean (100ms) : 97, 103
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8437) - mean (933ms) : 895, 971
master - mean (927ms) : 893, 961
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (98ms) : 96, 101
master - mean (97ms) : 94, 100
section Bailout
This PR (8437) - mean (99ms) : 97, 101
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8437) - mean (813ms) : 784, 842
master - mean (811ms) : 783, 840
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (192ms) : 189, 196
master - mean (194ms) : 191, 197
section Bailout
This PR (8437) - mean (195ms) : 193, 197
master - mean (198ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (8437) - mean (1,142ms) : 1103, 1182
master - mean (1,155ms) : 1094, 1216
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (276ms) : 272, 280
master - mean (279ms) : 275, 283
section Bailout
This PR (8437) - mean (277ms) : 274, 280
master - mean (279ms) : 276, 282
section CallTarget+Inlining+NGEN
This PR (8437) - mean (927ms) : 906, 947
master - mean (927ms) : 905, 949
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (269ms) : 266, 272
master - mean (271ms) : 267, 275
section Bailout
This PR (8437) - mean (270ms) : 266, 273
master - mean (271ms) : 268, 273
section CallTarget+Inlining+NGEN
This PR (8437) - mean (1,136ms) : 1093, 1179
master - mean (1,142ms) : 1097, 1186
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8437) - mean (268ms) : 264, 272
master - mean (269ms) : 266, 273
section Bailout
This PR (8437) - mean (267ms) : 264, 270
master - mean (269ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8437) - mean (1,022ms) : 990, 1054
master - mean (1,024ms) : 982, 1066
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
0254013 to
2b89d0d
Compare
2b89d0d to
1898888
Compare
BenchmarksBenchmark execution time: 2026-04-10 10:10:34 Comparing candidate commit 1898888 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 0 unstable metrics, 87 known flaky benchmarks.
|
Summary of changes
Updates the base image used in download stages in GitLab
Reason for change
It's old and needs updating
Implementation details
Try just updating the image. I chose a somewhat arbitrary image from the registry - we couldn't use
[gbi-ubuntu_2404](https://github.com/DataDog/images/tree/master/base/gbi-ubuntu_2404)directly, because it doesn't havejqinstalled, so this one seemed as good as any. Really didn't seem worth building our own image just for that, but we could consider it if necessary.Test coverage
If the build works, we're fine
Other details
https://datadoghq.atlassian.net/browse/CONTSEC-2034