Add benchmark for the AgentWriter#842
Merged
Merged
Conversation
tonyredondo
approved these changes
Aug 7, 2020
| public class SpanBenchmark | ||
| { | ||
| private static Tracer _tracer; | ||
| private static readonly Tracer Tracer; |
Member
There was a problem hiding this comment.
Is there a performance reason for this change?
Contributor
Author
There was a problem hiding this comment.
None whatsoever. It was just to please Resharper 😛
kevingosse
force-pushed
the
kevin/benchmarks
branch
from
August 13, 2020 15:37
9516076 to
8263644
Compare
lucaspimentel
approved these changes
Aug 14, 2020
zacharycmontoya
added
the
area:benchmarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a benchmark for flushing traces for the agent, and disabled some background stuff for the span benchmarks.
Also added a way to disable the background task from the AgentWriter, to have more predictable results.
I had to mock the API requests and not actually send them, because I was getting throttled by the trace agent.