Add managed-by:bp-infra tag and skip PR comments on master on benchmarking jobs#8416
Conversation
andrewlock
left a comment
There was a problem hiding this comment.
I'll take your word for it 🙈
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8416) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (72ms) : 69, 75
master - mean (72ms) : 68, 75
section Bailout
This PR (8416) - mean (76ms) : 74, 78
master - mean (75ms) : 74, 77
section CallTarget+Inlining+NGEN
This PR (8416) - mean (1,067ms) : 1015, 1119
master - mean (1,061ms) : 1019, 1103
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (111ms) : 108, 115
master - mean (111ms) : 107, 115
section Bailout
This PR (8416) - mean (113ms) : 111, 116
master - mean (114ms) : 111, 117
section CallTarget+Inlining+NGEN
This PR (8416) - mean (777ms) : 759, 795
master - mean (780ms) : 756, 803
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (99ms) : 96, 101
master - mean (99ms) : 96, 102
section Bailout
This PR (8416) - mean (99ms) : 96, 103
master - mean (101ms) : 98, 104
section CallTarget+Inlining+NGEN
This PR (8416) - mean (935ms) : 886, 984
master - mean (930ms) : 895, 965
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (98ms) : 96, 101
master - mean (97ms) : 94, 100
section Bailout
This PR (8416) - mean (99ms) : 97, 102
master - mean (99ms) : 96, 101
section CallTarget+Inlining+NGEN
This PR (8416) - mean (815ms) : 778, 852
master - mean (812ms) : 779, 844
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (189ms) : 185, 194
master - mean (190ms) : 185, 194
section Bailout
This PR (8416) - mean (193ms) : 190, 195
master - mean (193ms) : 191, 194
section CallTarget+Inlining+NGEN
This PR (8416) - mean (1,133ms) : 1093, 1174
master - mean (1,136ms) : 1076, 1197
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (271ms) : 267, 276
master - mean (272ms) : 267, 276
section Bailout
This PR (8416) - mean (272ms) : 269, 275
master - mean (272ms) : 268, 276
section CallTarget+Inlining+NGEN
This PR (8416) - mean (917ms) : 898, 937
master - mean (917ms) : 894, 941
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (265ms) : 262, 268
master - mean (266ms) : 262, 270
section Bailout
This PR (8416) - mean (265ms) : 263, 268
master - mean (265ms) : 263, 268
section CallTarget+Inlining+NGEN
This PR (8416) - mean (1,128ms) : 1074, 1181
master - mean (1,131ms) : 1086, 1176
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8416) - mean (265ms) : 261, 268
master - mean (264ms) : 260, 268
section Bailout
This PR (8416) - mean (264ms) : 261, 267
master - mean (264ms) : 261, 266
section CallTarget+Inlining+NGEN
This PR (8416) - mean (1,014ms) : 969, 1060
master - mean (1,012ms) : 979, 1045
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-04-08 07:52:32 Comparing candidate commit 553baab in PR branch Found 30 performance improvements and 37 performance regressions! Performance is the same for 216 metrics, 5 unstable metrics.
|
d28e3f1 to
f0cdd7a
Compare
f0cdd7a to
d5d94dd
Compare
Summary of changes
managed-by:bp-infratoDD_METRICS_TAGSon benchmark CI jobs that use bp-infra.master, since there's no PR.Reason for change
Necessary to filter these CI jobs and monitor their duration in our benchmarking platform dashboard.
See https://datadoghq.atlassian.net/wiki/spaces/DEVX/pages/2889355451/Gitlab+Runner+fork#Metrics
Set up monitoring for the Windows benchmarking infrastructure
Implementation details
DD_METRICS_TAGS: "managed-by:bp-infra"to thevariablesblock of jobs that invoke bp-infra.masteron.gitlab/benchmarks/microbenchmarks/scripts/post-pr-comment.sh.Test coverage
No test changes — this only adds a CI variable for metric tagging.
Other details