Skip DNS resolution when agent is bound to localhost#841
Merged
Conversation
lucaspimentel
approved these changes
Aug 7, 2020
tonyredondo
approved these changes
Aug 14, 2020
zacharycmontoya
added a commit
that referenced
this pull request
Aug 17, 2020
This reverts commit 7839843.
zacharycmontoya
added a commit
that referenced
this pull request
Aug 18, 2020
This reverts commit 7839843.
zacharycmontoya
added a commit
that referenced
this pull request
Aug 18, 2020
kevingosse
added a commit
that referenced
this pull request
Aug 19, 2020
* Skip DNS resolution when agent is bound to localhost
kevingosse
added a commit
that referenced
this pull request
Aug 24, 2020
* Skip DNS resolution when agent is bound to localhost
kevingosse
added a commit
that referenced
this pull request
Aug 25, 2020
* Skip DNS resolution when agent is bound to localhost
zacharycmontoya
added
the
area:tracer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On .net core, when resolving localhost on a machine with ipv6 enabled, ::1 is considered first. Unfortunately, the agent is bound only to ipv4, so the initial connection timeouts and adds a 2 seconds delay.
Changing localhost to 127.0.0.1 should fix this in the most common case.