Remove unnecessary System.Collections.NonGeneric NuGet package#839
Merged
zacharycmontoya merged 3 commits intoAug 7, 2020
Merged
Conversation
zacharycmontoya
added
the
dependencies
lucaspimentel
approved these changes
Aug 6, 2020
kevingosse
approved these changes
Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary System.Collections.NonGeneric NuGet package that was originally added to vendor Serilog. This was defined in the original Serilog.csproj when compiling for netstandard2.0, but the final assembly only has one assembly reference, which is netstandard.dll, so this NuGet package is unnecessary and can be removed without affecting the compilation.
This saves space by not publishing the System.Collections.NonGeneric.dll for the netstandard2.0 framework in the Windows MSI and it saves potential confusion about the dependency tree of Datadog.Trace.dll
@DataDog/apm-dotnet