Skip to content

Add OTEL_RESOURCE_ATTRIBUTES to claude settings#8378

Merged
bouwkast merged 1 commit into
masterfrom
steven/add-some-telemetry-for-llm
Mar 26, 2026
Merged

Add OTEL_RESOURCE_ATTRIBUTES to claude settings#8378
bouwkast merged 1 commit into
masterfrom
steven/add-some-telemetry-for-llm

Conversation

@bouwkast

@bouwkast bouwkast commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Summary of changes

This adds "OTEL_RESOURCE_ATTRIBUTES": "repo.owner=DataDog,repo.name=dd-trace-dotnet" to our claude settings

Reason for change

This will make it so that our telemetry marks that if we are working on the repo with Claude that it will report our repository.

I don't think there is any functional change here besides the fact that I want to make my telemetry go from N/A to dd-trace-dotnet

Implementation details

Followed https://datadoghq.atlassian.net/wiki/spaces/AIDEVX/pages/5689508824/Repo+Config#Repo-Tags-in-Telemetry

Test coverage

Other details

@bouwkast
bouwkast requested a review from a team as a code owner March 26, 2026 16:19
@pr-commenter

pr-commenter Bot commented Mar 26, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-26 17:01:32

Comparing candidate commit 166b5d1 in PR branch steven/add-some-telemetry-for-llm with baseline commit 6087ef6 in branch master.

Found 8 performance improvements and 11 performance regressions! Performance is the same for 251 metrics, 18 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 execution_time [-29.715ms; -27.467ms] or [-13.147%; -12.152%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+90.060ms; +90.178ms] or [+81.075%; +81.181%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟥 execution_time [+25.554ms; +29.627ms] or [+12.893%; +14.948%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 execution_time [+11.261ms; +15.106ms] or [+5.659%; +7.591%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟥 throughput [-300719.418op/s; -185619.422op/s] or [-9.088%; -5.610%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+15.325ms; +20.720ms] or [+7.714%; +10.429%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-19.814ms; -19.297ms] or [-9.891%; -9.633%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 throughput [+155.106op/s; +338.406op/s] or [+5.293%; +11.547%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 throughput [+77.888op/s; +122.757op/s] or [+5.429%; +8.557%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 throughput [-192.848op/s; -89.578op/s] or [-12.502%; -5.807%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-192.621µs; -185.912µs] or [-11.748%; -11.339%]
  • 🟩 throughput [+78.211op/s; +80.980op/s] or [+12.823%; +13.277%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟥 allocated_mem [+18.573KB; +18.604KB] or [+7.270%; +7.283%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 allocated_mem [-19.931KB; -19.898KB] or [-7.227%; -7.214%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 execution_time [+10.962ms; +15.531ms] or [+5.586%; +7.915%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+95.128ms; +96.740ms] or [+98.038%; +99.699%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟩 throughput [+15584607.960op/s; +16731623.240op/s] or [+6.927%; +7.437%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟥 execution_time [+10.430ms; +14.028ms] or [+5.213%; +7.011%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟥 execution_time [+16.738ms; +21.817ms] or [+8.592%; +11.198%]

@bouwkast bouwkast added the for-ai-agents 🤖 files used by AI agents, not humans label Mar 26, 2026
@bouwkast
bouwkast merged commit 1e350b3 into master Mar 26, 2026
101 of 105 checks passed
@bouwkast
bouwkast deleted the steven/add-some-telemetry-for-llm branch March 26, 2026 19:39
@github-actions github-actions Bot added this to the vNext-v3 milestone Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

for-ai-agents 🤖 files used by AI agents, not humans

Projects

None yet

Milestone

3.41.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bouwkast @zacharycmontoya @andrewlock