Fix swapped SpanKinds and missing tags in IbmMqHelper by NachoEchevarria · Pull Request #8369 · DataDog/dd-trace-dotnet

NachoEchevarria · 2026-03-25T14:15:53Z

Summary of changes

Fix three pre-existing bugs in IbmMqHelper:

Swapped SpanKinds: CreateProducerScope passed SpanKinds.Consumer and CreateConsumerScope passed SpanKinds.Producer to CreateIbmMqTags — now corrected.
Missing tags in producer scope: CreateProducerScope created and populated IbmMqTags but never passed them to StartActiveInternal, so tags (including TopicName) were silently discarded.

Reason for change

Producer spans were tagged as consumers and vice versa, and producer spans were missing messaging-specific tags entirely.

Implementation details

Swap SpanKinds.Consumer → SpanKinds.Producer in CreateProducerScope (line 71)
Swap SpanKinds.Producer → SpanKinds.Consumer in CreateConsumerScope (line 138)
Add tags: tags parameter to StartActiveInternal in CreateProducerScope

Test coverage

Existing integration tests cover IBM MQ span creation. No new tests required — this is a straightforward value correction.

Other details

Pre-existing bugs, not introduced by any recent PR.

pr-commenter · 2026-03-25T14:58:21Z

Benchmarks

Benchmark execution time: 2026-03-26 07:57:40

Comparing candidate commit 1f189a1 in PR branch nacho/IbmMqHelperIntegrationFix with baseline commit da0f277 in branch master.

Found 7 performance improvements and 8 performance regressions! Performance is the same for 256 metrics, 17 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟥 execution_time [+88.608ms; +88.739ms] or [+78.247%; +78.362%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

🟩 execution_time [-20.530ms; -14.700ms] or [-9.548%; -6.837%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

🟥 execution_time [+17.363ms; +17.974ms] or [+8.678%; +8.983%]
🟥 throughput [-244584.910op/s; -235949.596op/s] or [-7.446%; -7.183%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

🟩 execution_time [-23.247ms; -17.318ms] or [-10.754%; -8.011%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

🟩 execution_time [-10.685ms; -8.231ms] or [-10.605%; -8.170%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

🟥 execution_time [+159.459µs; +164.514µs] or [+7.890%; +8.140%]
🟥 throughput [-37.291op/s; -36.145op/s] or [-7.536%; -7.305%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

🟩 throughput [+16818.226op/s; +19015.512op/s] or [+5.038%; +5.696%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

🟥 throughput [-18056.937op/s; -15700.612op/s] or [-5.797%; -5.040%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

🟩 throughput [+31421.897op/s; +35982.504op/s] or [+6.247%; +7.154%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

🟩 throughput [+26872.814op/s; +37267.126op/s] or [+6.799%; +9.429%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

🟩 throughput [+20675.157op/s; +31743.026op/s] or [+5.812%; +8.923%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

🟥 allocated_mem [+20.180KB; +20.208KB] or [+7.894%; +7.905%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

🟥 execution_time [+10.526ms; +15.687ms] or [+5.347%; +7.969%]

andrewlock

Oops 🤦‍♂️

Do we have tests though, because surely this should change some snapshot tests? 😅

dd-trace-dotnet-ci-bot · 2026-03-25T17:46:47Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8369) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	72.18 ± (72.21 - 72.55) ms	71.99 ± (72.06 - 72.40) ms	-0.3%	✅
.NET Framework 4.8 - Bailout
duration	76.06 ± (75.98 - 76.23) ms	76.33 ± (76.19 - 76.58) ms	+0.4%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1074.17 ± (1074.02 - 1080.94) ms	1075.11 ± (1076.76 - 1083.59) ms	+0.1%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.27 ± (22.23 - 22.32) ms	22.37 ± (22.34 - 22.40) ms	+0.4%	✅⬆️
process.time_to_main_ms	83.84 ± (83.65 - 84.04) ms	83.40 ± (83.23 - 83.57) ms	-0.5%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.91 ± (10.90 - 10.91) MB	10.90 ± (10.90 - 10.91) MB	-0.0%	✅
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.20 ± (22.16 - 22.23) ms	22.32 ± (22.28 - 22.35) ms	+0.5%	✅⬆️
process.time_to_main_ms	84.99 ± (84.80 - 85.17) ms	84.98 ± (84.78 - 85.18) ms	-0.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.95 ± (10.95 - 10.95) MB	10.94 ± (10.94 - 10.95) MB	-0.1%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	224.19 ± (223.03 - 225.36) ms	223.87 ± (222.57 - 225.18) ms	-0.1%	✅
process.time_to_main_ms	533.18 ± (532.04 - 534.32) ms	533.82 ± (532.64 - 535.01) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.17 ± (48.14 - 48.20) MB	48.24 ± (48.21 - 48.28) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.1%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	20.99 ± (20.95 - 21.03) ms	20.99 ± (20.96 - 21.02) ms	+0.0%	✅⬆️
process.time_to_main_ms	72.11 ± (71.93 - 72.30) ms	71.88 ± (71.73 - 72.04) ms	-0.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.62 ± (10.62 - 10.62) MB	10.64 ± (10.64 - 10.64) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.87 ± (20.83 - 20.92) ms	20.91 ± (20.88 - 20.94) ms	+0.2%	✅⬆️
process.time_to_main_ms	72.72 ± (72.56 - 72.88) ms	73.10 ± (72.94 - 73.27) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.68 ± (10.68 - 10.69) MB	10.75 ± (10.74 - 10.75) MB	+0.6%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	213.74 ± (212.59 - 214.90) ms	215.63 ± (214.19 - 217.07) ms	+0.9%	✅⬆️
process.time_to_main_ms	532.98 ± (531.77 - 534.18) ms	533.67 ± (532.19 - 535.15) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	50.07 ± (50.04 - 50.09) MB	50.11 ± (50.08 - 50.14) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	+0.3%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	19.30 ± (19.26 - 19.34) ms	19.30 ± (19.27 - 19.33) ms	-0.0%	✅
process.time_to_main_ms	71.83 ± (71.63 - 72.02) ms	71.82 ± (71.67 - 71.96) ms	-0.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.68 ± (7.67 - 7.68) MB	7.69 ± (7.68 - 7.70) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.16 ± (19.12 - 19.20) ms	19.38 ± (19.33 - 19.42) ms	+1.1%	✅⬆️
process.time_to_main_ms	72.23 ± (72.13 - 72.34) ms	72.90 ± (72.73 - 73.07) ms	+0.9%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.74 ± (7.73 - 7.74) MB	7.77 ± (7.76 - 7.78) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	160.92 ± (159.91 - 161.94) ms	159.22 ± (158.47 - 159.97) ms	-1.1%	✅
process.time_to_main_ms	487.92 ± (486.95 - 488.90) ms	491.98 ± (491.19 - 492.76) ms	+0.8%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	36.85 ± (36.82 - 36.88) MB	36.93 ± (36.91 - 36.95) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	193.86 ± (193.81 - 194.68) ms	193.36 ± (193.25 - 194.21) ms	-0.3%	✅
.NET Framework 4.8 - Bailout
duration	197.09 ± (197.00 - 197.47) ms	197.49 ± (197.24 - 197.83) ms	+0.2%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1154.11 ± (1155.88 - 1163.35) ms	1157.33 ± (1156.68 - 1163.65) ms	+0.3%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	187.87 ± (187.56 - 188.18) ms	189.37 ± (188.86 - 189.88) ms	+0.8%	✅⬆️
process.time_to_main_ms	80.99 ± (80.74 - 81.23) ms	81.14 ± (80.89 - 81.39) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.09 ± (16.06 - 16.12) MB	16.09 ± (16.06 - 16.12) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (20 - 20)	+0.0%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	187.67 ± (187.29 - 188.06) ms	188.61 ± (188.17 - 189.04) ms	+0.5%	✅⬆️
process.time_to_main_ms	82.43 ± (82.24 - 82.63) ms	82.13 ± (81.96 - 82.30) ms	-0.4%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	16.16 ± (16.13 - 16.19) MB	16.13 ± (16.10 - 16.16) MB	-0.2%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (20 - 21)	-0.3%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	394.51 ± (393.01 - 396.01) ms	395.65 ± (394.36 - 396.94) ms	+0.3%	✅⬆️
process.time_to_main_ms	522.77 ± (521.68 - 523.87) ms	523.36 ± (522.33 - 524.40) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	58.67 ± (58.49 - 58.85) MB	58.82 ± (58.66 - 58.98) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	193.11 ± (192.81 - 193.42) ms	193.93 ± (193.49 - 194.36) ms	+0.4%	✅⬆️
process.time_to_main_ms	70.53 ± (70.36 - 70.70) ms	70.82 ± (70.64 - 70.99) ms	+0.4%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.37 ± (16.34 - 16.40) MB	16.38 ± (16.29 - 16.47) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.2%	✅
.NET 6 - Bailout
process.internal_duration_ms	192.40 ± (192.03 - 192.78) ms	192.18 ± (191.86 - 192.49) ms	-0.1%	✅
process.time_to_main_ms	71.36 ± (71.22 - 71.51) ms	71.32 ± (71.20 - 71.44) ms	-0.1%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.25 ± (16.13 - 16.38) MB	16.37 ± (16.26 - 16.48) MB	+0.7%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 20)	20 ± (20 - 20)	+1.6%	✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	419.18 ± (417.71 - 420.64) ms	419.59 ± (418.26 - 420.91) ms	+0.1%	✅⬆️
process.time_to_main_ms	524.80 ± (523.65 - 525.96) ms	527.85 ± (526.59 - 529.10) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	60.91 ± (60.86 - 60.96) MB	60.98 ± (60.95 - 61.01) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 31)	+0.2%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	191.15 ± (190.81 - 191.49) ms	191.02 ± (190.63 - 191.41) ms	-0.1%	✅
process.time_to_main_ms	70.04 ± (69.82 - 70.26) ms	70.11 ± (69.90 - 70.32) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.71 ± (11.68 - 11.74) MB	11.70 ± (11.68 - 11.72) MB	-0.1%	✅
runtime.dotnet.threads.count	18 ± (18 - 18)	18 ± (18 - 18)	-0.3%	✅
.NET 8 - Bailout
process.internal_duration_ms	189.51 ± (189.18 - 189.85) ms	189.90 ± (189.54 - 190.26) ms	+0.2%	✅⬆️
process.time_to_main_ms	70.53 ± (70.40 - 70.66) ms	70.75 ± (70.64 - 70.87) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.82 ± (11.79 - 11.86) MB	11.82 ± (11.79 - 11.85) MB	-0.1%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.3%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	342.54 ± (341.61 - 343.47) ms	341.61 ± (340.40 - 342.81) ms	-0.3%	✅
process.time_to_main_ms	482.13 ± (481.22 - 483.04) ms	482.86 ± (482.01 - 483.71) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	48.88 ± (48.85 - 48.91) MB	48.82 ± (48.78 - 48.86) MB	-0.1%	✅
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.1%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (72ms)  : 70, 75
    master - mean (72ms)  : 70, 75

    section Bailout
    This PR (8369) - mean (76ms)  : 74, 78
    master - mean (76ms)  : 75, 77

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (1,080ms)  : 1031, 1129
    master - mean (1,077ms)  : 1028, 1127

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (113ms)  : 109, 117
    master - mean (113ms)  : 108, 117

    section Bailout
    This PR (8369) - mean (114ms)  : 111, 117
    master - mean (114ms)  : 111, 117

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (794ms)  : 773, 816
    master - mean (796ms)  : 778, 813

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (99ms)  : 96, 102
    master - mean (99ms)  : 95, 103

    section Bailout
    This PR (8369) - mean (100ms)  : 97, 103
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (787ms)  : 768, 806
    master - mean (786ms)  : 764, 808

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (99ms)  : 96, 101
    master - mean (99ms)  : 94, 103

    section Bailout
    This PR (8369) - mean (100ms)  : 97, 103
    master - mean (99ms)  : 97, 101

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (691ms)  : 666, 716
    master - mean (690ms)  : 670, 710

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (194ms)  : 189, 198
    master - mean (194ms)  : 190, 198

    section Bailout
    This PR (8369) - mean (198ms)  : 195, 200
    master - mean (197ms)  : 195, 199

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (1,160ms)  : 1113, 1207
    master - mean (1,160ms)  : 1104, 1215

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (279ms)  : 273, 284
    master - mean (277ms)  : 272, 281

    section Bailout
    This PR (8369) - mean (279ms)  : 273, 284
    master - mean (278ms)  : 273, 283

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (950ms)  : 926, 975
    master - mean (949ms)  : 924, 975

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (273ms)  : 267, 279
    master - mean (272ms)  : 267, 277

    section Bailout
    This PR (8369) - mean (271ms)  : 267, 276
    master - mean (272ms)  : 267, 277

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (975ms)  : 944, 1006
    master - mean (973ms)  : 949, 996

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8369) - mean (270ms)  : 265, 276
    master - mean (271ms)  : 266, 276

    section Bailout
    This PR (8369) - mean (271ms)  : 266, 275
    master - mean (269ms)  : 265, 274

    section CallTarget+Inlining+NGEN
    This PR (8369) - mean (856ms)  : 828, 884
    master - mean (856ms)  : 824, 887

bouwkast

We don't have sample / tests for this, would probably be nice to revisit that again to see if we could do that without having to manually create them each time

Co-authored-by: Steven Bouwkamp <[email protected]>

NachoEchevarria · 2026-03-26T08:56:42Z

Oops 🤦‍♂️

Do we have tests though, because surely this should change some snapshot tests? 😅

We dont have them. I checked. There are some unit tests though in tracer\test\Datadog.Trace.Tests\ClrProfiler\AutoInstrumentation\IbmMq\IbmMqHelperTests.cs

Would be worth to add them?

Just noticed that we should not according to the slack comments.

Fix Ibm mq helper

c62075a

NachoEchevarria changed the title ~~Fix Ibm mq helper~~ Fix swapped SpanKinds and missing tags in IbmMqHelper Mar 25, 2026

github-actions Bot added the area:integrations label Mar 25, 2026

NachoEchevarria marked this pull request as ready for review March 25, 2026 16:34

NachoEchevarria requested review from a team as code owners March 25, 2026 16:34

andrewlock approved these changes Mar 25, 2026

View reviewed changes

bouwkast approved these changes Mar 25, 2026

View reviewed changes

Comment thread tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/IbmMq/IbmMqHelper.cs Outdated

Comment thread tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/IbmMq/IbmMqHelper.cs Outdated

Apply suggestions from code review

1f189a1

Co-authored-by: Steven Bouwkamp <[email protected]>

NachoEchevarria merged commit 6087ef6 into master Mar 26, 2026
139 checks passed

NachoEchevarria deleted the nacho/IbmMqHelperIntegrationFix branch March 26, 2026 15:52

github-actions Bot added this to the vNext-v3 milestone Mar 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix swapped SpanKinds and missing tags in IbmMqHelper#8369

Fix swapped SpanKinds and missing tags in IbmMqHelper#8369
NachoEchevarria merged 2 commits into
masterfrom
nacho/IbmMqHelperIntegrationFix

NachoEchevarria commented Mar 25, 2026 •

edited

Loading

Uh oh!

pr-commenter Bot commented Mar 25, 2026 •

edited

Loading

Explanation

More details about the CI and significant changes

Uh oh!

andrewlock left a comment •

edited

Loading

Uh oh!

dd-trace-dotnet-ci-bot Bot commented Mar 25, 2026 •

edited

Loading

FakeDbCommand

HttpMessageHandler

Uh oh!

bouwkast left a comment

Uh oh!

Uh oh!

Uh oh!

NachoEchevarria commented Mar 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

NachoEchevarria commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

pr-commenter Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

Uh oh!

andrewlock left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dd-trace-dotnet-ci-bot Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

NachoEchevarria commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NachoEchevarria commented Mar 25, 2026 •

edited

Loading

pr-commenter Bot commented Mar 25, 2026 •

edited

Loading

andrewlock left a comment •

edited

Loading

dd-trace-dotnet-ci-bot Bot commented Mar 25, 2026 •

edited

Loading

NachoEchevarria commented Mar 26, 2026 •

edited

Loading