Stabilize test-agent readiness in smoke tests#8368
Conversation
Co-authored-by: NachoEchevarria <[email protected]>
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8368) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (69ms) : 67, 71
master - mean (69ms) : 66, 72
section Bailout
This PR (8368) - mean (72ms) : 71, 73
master - mean (80ms) : 69, 91
section CallTarget+Inlining+NGEN
This PR (8368) - mean (1,055ms) : 994, 1115
master - mean (1,054ms) : 999, 1109
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (108ms) : 105, 111
master - mean (107ms) : 104, 110
section Bailout
This PR (8368) - mean (108ms) : 106, 110
master - mean (108ms) : 106, 110
section CallTarget+Inlining+NGEN
This PR (8368) - mean (771ms) : 753, 790
master - mean (777ms) : 751, 802
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (95ms) : 92, 97
master - mean (95ms) : 92, 97
section Bailout
This PR (8368) - mean (96ms) : 94, 98
master - mean (95ms) : 93, 98
section CallTarget+Inlining+NGEN
This PR (8368) - mean (761ms) : 741, 780
master - mean (760ms) : 736, 784
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (94ms) : 91, 96
master - mean (93ms) : 90, 96
section Bailout
This PR (8368) - mean (95ms) : 93, 98
master - mean (94ms) : 93, 96
section CallTarget+Inlining+NGEN
This PR (8368) - mean (666ms) : 645, 688
master - mean (661ms) : 645, 677
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (193ms) : 188, 198
master - mean (193ms) : 189, 197
section Bailout
This PR (8368) - mean (196ms) : 193, 199
master - mean (196ms) : 193, 200
section CallTarget+Inlining+NGEN
This PR (8368) - mean (1,162ms) : 1103, 1221
master - mean (1,164ms) : 1107, 1222
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (277ms) : 270, 284
master - mean (276ms) : 270, 282
section Bailout
This PR (8368) - mean (277ms) : 273, 281
master - mean (277ms) : 272, 282
section CallTarget+Inlining+NGEN
This PR (8368) - mean (948ms) : 926, 970
master - mean (942ms) : 923, 961
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (270ms) : 266, 275
master - mean (270ms) : 266, 274
section Bailout
This PR (8368) - mean (270ms) : 266, 274
master - mean (269ms) : 265, 274
section CallTarget+Inlining+NGEN
This PR (8368) - mean (967ms) : 943, 991
master - mean (965ms) : 943, 988
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8368) - mean (269ms) : 265, 272
master - mean (269ms) : 263, 275
section Bailout
This PR (8368) - mean (269ms) : 264, 274
master - mean (269ms) : 262, 276
section CallTarget+Inlining+NGEN
This PR (8368) - mean (854ms) : 831, 877
master - mean (850ms) : 829, 871
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
andrewlock
left a comment
There was a problem hiding this comment.
I'd be fine going even higher tbh, as long as they're "real" delays!
BenchmarksBenchmark execution time: 2026-03-25 14:16:22 Comparing candidate commit 89e4efb in PR branch Found 5 performance improvements and 16 performance regressions! Performance is the same for 251 metrics, 16 unstable metrics.
|
Summary of changes
Increased test-agent readiness timeout from 30s to 60s and added retry-attempt logging.
Reason for change
Smoke tests were intermittently failing in CI when the test-agent container startup was delayed on busy runners.
Implementation details
WaitForTestAgentAsyncinSmokeTestRunner.cs