Skip to content

Fix dd_dotnet.ArtifactTests.CreatedumpTests.DisableTelemetry flakiness#8354

Merged
NachoEchevarria merged 2 commits into
masterfrom
nacho/FixDumpFlakinessArm64
Mar 24, 2026
Merged

Fix dd_dotnet.ArtifactTests.CreatedumpTests.DisableTelemetry flakiness#8354
NachoEchevarria merged 2 commits into
masterfrom
nacho/FixDumpFlakinessArm64

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary of changes

Fixes intermittent CreatedumpTests failures on arm64 Linux by relaxing the createdump output assertion when the .NET runtime's createdump tool fails due to a known ptrace race condition.

Reason for change

On arm64 Linux, createdump intermittently fails with ptrace(ATTACH, <tid>) FAILED No such process — a race condition where threads exit before createdump can attach to them. When this happens, createdump aborts without writing "Writing minidump with heap to file /dev/null", causing the test assertion to fail even though our crash tracking code correctly invoked createdump.

This is a known .NET runtime limitation tracked in multiple issues:

Flaky test identified via CI Test Management.

Implementation details

  • Added AssertCreatedumpWasInvoked() helper that, only on arm64 Linux, also accepts "[createdump] Gathering state for process" as evidence that createdump was invoked (even if it failed due to the ptrace race). On all other platforms, the strict assertion is preserved.
  • Updated all 4 assertion sites: Passthrough, BashScript, DoNothingIfNotEnabled, and DisableTelemetry.
  • Tightened negative assertions (the "should NOT call createdump" branches) to check for both strings.

Test coverage

Other details

The test's purpose is to verify that our crash tracking code correctly invokes createdump, not that createdump itself succeeds. The relaxed assertion still validates that createdump was started by our code.

@NachoEchevarria NachoEchevarria added the area:tests unit tests, integration tests label Mar 23, 2026
@NachoEchevarria
NachoEchevarria marked this pull request as ready for review March 23, 2026 11:52
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner March 23, 2026 11:52
@pr-commenter

pr-commenter Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-24 10:31:47

Comparing candidate commit 367f679 in PR branch nacho/FixDumpFlakinessArm64 with baseline commit 4e38cdd in branch master.

Found 7 performance improvements and 3 performance regressions! Performance is the same for 260 metrics, 18 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟩 execution_time [-104.272ms; -101.850ms] or [-52.281%; -51.067%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-88.198ms; -88.114ms] or [-44.290%; -44.248%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 throughput [+35318.837op/s; +58637.226op/s] or [+5.142%; +8.537%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-14.528ms; -13.158ms] or [-6.795%; -6.154%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+97.828ms; +99.345ms] or [+98.170%; +99.693%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 throughput [-133.148op/s; -98.428op/s] or [-8.082%; -5.975%]
  • 🟩 execution_time [-59.990ms; -55.609ms] or [-29.399%; -27.252%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟩 execution_time [-17.202ms; -14.868ms] or [-16.399%; -14.174%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟩 execution_time [-20.347ms; -15.253ms] or [-9.453%; -7.087%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟥 execution_time [+11.619ms; +15.070ms] or [+5.829%; +7.561%]

@dd-trace-dotnet-ci-bot

dd-trace-dotnet-ci-bot Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8354) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.50 ± (68.59 - 68.92) ms68.54 ± (68.53 - 68.81) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration72.75 ± (72.61 - 72.94) ms72.65 ± (72.58 - 72.94) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1035.76 ± (1041.41 - 1050.85) ms1035.04 ± (1035.30 - 1040.50) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms21.88 ± (21.85 - 21.91) ms21.82 ± (21.79 - 21.85) ms-0.3%✅
process.time_to_main_ms79.43 ± (79.28 - 79.57) ms79.44 ± (79.27 - 79.61) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.90 ± (10.90 - 10.91) MB10.90 ± (10.89 - 10.90) MB-0.0%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.83 ± (21.81 - 21.86) ms21.69 ± (21.66 - 21.71) ms-0.7%✅
process.time_to_main_ms80.74 ± (80.59 - 80.89) ms80.43 ± (80.30 - 80.57) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.93 ± (10.93 - 10.93) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms218.36 ± (217.14 - 219.59) ms218.47 ± (217.14 - 219.81) ms+0.1%✅⬆️
process.time_to_main_ms514.75 ± (513.73 - 515.77) ms514.89 ± (513.76 - 516.03) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.24 ± (48.21 - 48.28) MB48.22 ± (48.19 - 48.26) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.61 ± (20.59 - 20.63) ms20.50 ± (20.48 - 20.53) ms-0.5%✅
process.time_to_main_ms68.55 ± (68.42 - 68.69) ms68.72 ± (68.58 - 68.85) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.64) MB10.63 ± (10.62 - 10.63) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.57 ± (20.55 - 20.60) ms20.51 ± (20.48 - 20.53) ms-0.3%✅
process.time_to_main_ms69.89 ± (69.78 - 70.00) ms69.90 ± (69.78 - 70.01) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.75 ± (10.74 - 10.75) MB10.74 ± (10.73 - 10.74) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms206.58 ± (205.40 - 207.75) ms205.37 ± (204.21 - 206.53) ms-0.6%✅
process.time_to_main_ms515.07 ± (513.91 - 516.22) ms513.92 ± (512.88 - 514.95) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed50.06 ± (50.02 - 50.10) MB50.03 ± (49.98 - 50.07) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms18.76 ± (18.74 - 18.79) ms18.82 ± (18.80 - 18.85) ms+0.3%✅⬆️
process.time_to_main_ms68.02 ± (67.91 - 68.14) ms68.11 ± (67.98 - 68.24) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.68) MB7.66 ± (7.65 - 7.66) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.81 ± (18.78 - 18.83) ms18.78 ± (18.76 - 18.81) ms-0.1%✅
process.time_to_main_ms69.23 ± (69.12 - 69.33) ms69.14 ± (69.03 - 69.26) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.74) MB7.71 ± (7.71 - 7.72) MB-0.2%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms152.44 ± (151.69 - 153.18) ms153.29 ± (152.47 - 154.11) ms+0.6%✅⬆️
process.time_to_main_ms472.25 ± (471.36 - 473.15) ms473.98 ± (473.14 - 474.83) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.92 ± (36.90 - 36.95) MB36.91 ± (36.89 - 36.93) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.85 ± (193.73 - 194.56) ms192.34 ± (192.35 - 193.18) ms-0.8%✅
.NET Framework 4.8 - Bailout
duration195.92 ± (195.63 - 196.29) ms195.51 ± (195.38 - 195.98) ms-0.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1145.83 ± (1148.73 - 1156.95) ms1147.62 ± (1152.45 - 1161.37) ms+0.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.04 ± (186.74 - 187.33) ms186.73 ± (186.41 - 187.05) ms-0.2%✅
process.time_to_main_ms80.59 ± (80.40 - 80.78) ms80.57 ± (80.34 - 80.80) ms-0.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.12 - 16.18) MB16.09 ± (16.06 - 16.12) MB-0.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)+0.1%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms186.04 ± (185.73 - 186.35) ms186.95 ± (186.60 - 187.29) ms+0.5%✅⬆️
process.time_to_main_ms81.63 ± (81.49 - 81.77) ms81.69 ± (81.52 - 81.87) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.14 - 16.19) MB16.14 ± (16.11 - 16.16) MB-0.2%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms389.07 ± (387.54 - 390.59) ms389.74 ± (388.47 - 391.00) ms+0.2%✅⬆️
process.time_to_main_ms516.72 ± (515.74 - 517.70) ms517.16 ± (516.08 - 518.23) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.33 ± (58.12 - 58.54) MB58.61 ± (58.40 - 58.83) MB+0.5%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms191.37 ± (191.04 - 191.71) ms191.94 ± (191.63 - 192.25) ms+0.3%✅⬆️
process.time_to_main_ms69.86 ± (69.68 - 70.04) ms69.98 ± (69.80 - 70.16) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.34 ± (16.27 - 16.42) MB16.34 ± (16.26 - 16.42) MB-0.0%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.7%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms192.30 ± (191.83 - 192.78) ms191.80 ± (191.35 - 192.26) ms-0.3%✅
process.time_to_main_ms71.32 ± (71.16 - 71.48) ms71.01 ± (70.85 - 71.16) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.15 ± (16.04 - 16.25) MB16.34 ± (16.25 - 16.43) MB+1.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms412.06 ± (410.95 - 413.18) ms412.70 ± (411.35 - 414.05) ms+0.2%✅⬆️
process.time_to_main_ms524.25 ± (522.68 - 525.82) ms520.54 ± (519.13 - 521.96) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed60.96 ± (60.92 - 61.00) MB60.89 ± (60.84 - 60.94) MB-0.1%✅
runtime.dotnet.threads.count30 ± (30 - 31)31 ± (30 - 31)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms188.52 ± (188.16 - 188.87) ms189.75 ± (189.30 - 190.19) ms+0.7%✅⬆️
process.time_to_main_ms69.26 ± (69.04 - 69.48) ms70.08 ± (69.87 - 70.29) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.78 - 11.85) MB11.80 ± (11.77 - 11.82) MB-0.2%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.0%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms187.85 ± (187.57 - 188.13) ms188.45 ± (188.20 - 188.70) ms+0.3%✅⬆️
process.time_to_main_ms70.18 ± (70.09 - 70.27) ms70.63 ± (70.53 - 70.73) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.90 ± (11.86 - 11.93) MB11.82 ± (11.79 - 11.84) MB-0.7%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.5%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms339.73 ± (338.29 - 341.17) ms338.42 ± (336.98 - 339.87) ms-0.4%✅
process.time_to_main_ms477.22 ± (476.29 - 478.14) ms477.26 ± (476.33 - 478.20) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed48.67 ± (48.63 - 48.71) MB48.76 ± (48.72 - 48.79) MB+0.2%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (69ms)  : 67, 71
    master - mean (69ms)  : 66, 71

    section Bailout
    This PR (8354) - mean (73ms)  : 71, 75
    master - mean (73ms)  : 71, 74

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (1,038ms)  : 1001, 1075
    master - mean (1,046ms)  : 977, 1115
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (107ms)  : 104, 110
    master - mean (107ms)  : 104, 110

    section Bailout
    This PR (8354) - mean (108ms)  : 106, 109
    master - mean (108ms)  : 106, 110

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (772ms)  : 753, 790
    master - mean (769ms)  : 751, 788
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (94ms)  : 92, 97
    master - mean (94ms)  : 92, 97

    section Bailout
    This PR (8354) - mean (96ms)  : 94, 98
    master - mean (96ms)  : 94, 97

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (750ms)  : 731, 770
    master - mean (751ms)  : 730, 771
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (94ms)  : 91, 97
    master - mean (93ms)  : 91, 95

    section Bailout
    This PR (8354) - mean (95ms)  : 92, 97
    master - mean (95ms)  : 93, 96

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (657ms)  : 639, 675
    master - mean (655ms)  : 636, 674
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (193ms)  : 189, 197
    master - mean (194ms)  : 190, 198

    section Bailout
    This PR (8354) - mean (196ms)  : 193, 199
    master - mean (196ms)  : 193, 199

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (1,157ms)  : 1090, 1224
    master - mean (1,153ms)  : 1094, 1212
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (276ms)  : 270, 281
    master - mean (276ms)  : 271, 280

    section Bailout
    This PR (8354) - mean (277ms)  : 272, 281
    master - mean (276ms)  : 271, 281

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (939ms)  : 919, 959
    master - mean (937ms)  : 913, 961
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 264, 276

    section Bailout
    This PR (8354) - mean (271ms)  : 266, 276
    master - mean (272ms)  : 263, 280

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (962ms)  : 940, 983
    master - mean (966ms)  : 936, 995
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8354) - mean (269ms)  : 263, 275
    master - mean (268ms)  : 262, 273

    section Bailout
    This PR (8354) - mean (269ms)  : 265, 272
    master - mean (268ms)  : 264, 271

    section CallTarget+Inlining+NGEN
    This PR (8354) - mean (845ms)  : 825, 865
    master - mean (848ms)  : 825, 870
Loading

gleocadie
gleocadie approved these changes Mar 23, 2026
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrewlock
andrewlock approved these changes Mar 23, 2026
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For future us:

when dd-dotnet is spawned, we go over the threads to capture the crash information, but we do no stop all the threads. For each thread, we suspend them, collect info, detach and resume.
When attaching to a process, we could instruct to stop all the threads, and resume them when done

@NachoEchevarria
NachoEchevarria merged commit fe2cdea into master Mar 24, 2026
141 checks passed
@NachoEchevarria
NachoEchevarria deleted the nacho/FixDumpFlakinessArm64 branch March 24, 2026 11:53
@github-actions github-actions Bot added this to the vNext-v3 milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.41.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @gleocadie @andrewlock